summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHenigan <rheniga1@MGC12Z921DLVCG.fbpld77.ford.com>2021-09-07 10:13:14 -0400
committerHenigan <rheniga1@MGC12Z921DLVCG.fbpld77.ford.com>2021-09-07 10:13:14 -0400
commit0c711c849ec7e67bd235391afc1a63e325e9f985 (patch)
tree03e669fdff6bc33f59d5791e7319968dd97d263e
parentcd00bb13000aadb673b192758fcd6015b1bee615 (diff)
downloadsdl_android-bugfix/issue_1720.tar.gz
Cleanup error messaging around queryid and typebugfix/issue_1720
-rw-r--r--base/src/main/java/com/smartdevicelink/session/BaseSdlSession.java8
1 files changed, 6 insertions, 2 deletions
diff --git a/base/src/main/java/com/smartdevicelink/session/BaseSdlSession.java b/base/src/main/java/com/smartdevicelink/session/BaseSdlSession.java
index 42459dfd5..55df1f683 100644
--- a/base/src/main/java/com/smartdevicelink/session/BaseSdlSession.java
+++ b/base/src/main/java/com/smartdevicelink/session/BaseSdlSession.java
@@ -222,12 +222,16 @@ public abstract class BaseSdlSession implements ISdlProtocol, ISecurityInitializ
return;
}
- if (receivedHeader.getQueryID() != SecurityQueryID.SEND_HANDSHAKE_DATA
- || !(receivedHeader.getQueryType() == SecurityQueryType.REQUEST || receivedHeader.getQueryType() == SecurityQueryType.NOTIFICATION)) {
+ if (receivedHeader.getQueryID() != SecurityQueryID.SEND_HANDSHAKE_DATA) {
DebugTool.logError(TAG, "Security Query module error: Message is not a SEND_HANDSHAKE_DATA REQUEST");
return;
}
+ if (receivedHeader.getQueryType() == SecurityQueryType.RESPONSE) {
+ DebugTool.logError(TAG, "Security Query module error: Message is a response, which is not supported");
+ return;
+ }
+
iNumBytes = sdlSecurity.runHandshake(data, dataToRead);
// Assemble a security query payload header for our response