summaryrefslogtreecommitdiff
path: root/source4
Commit message (Collapse)AuthorAgeFilesLines
* auth auth_log: csbuild unused parm unix_usernameGary Lockyer2019-06-136-8/+3
| | | | | | | | | | | | | | | | | | Fixes csbuild errors Error: COMPILER_WARNING: auth/auth_log.c: scope_hint: In function ‘log_authentication_event_json’ auth/auth_log.c:146:14: warning: unused parameter ‘unix_username’ [-Wunused-parameter] Error: COMPILER_WARNING: auth/auth_log.c: scope_hint: In function ‘log_authentication_event_human_readable’ auth/auth_log.c:586:14: warning: unused parameter ‘unix_username’ [-Wunused-parameter] Signed-off-by: Gary Lockyer <gary@catalyst.net.nz> Reviewed-by: Andreas Schneider <asn@samba.org>
* torture: Use two connections in SMB2 sharemode testsChristof Schmitt2019-06-121-14/+16
| | | | | | | | | | | This allows using the unclist option to specify multiple targets, e.g. for testing against multiple nodes in a clustered Samba environment. Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Jun 12 20:02:26 UTC 2019 on sn-devel-184
* libcli/smb: s/smbXcli_session_copy/smbXcli_session_shallow_copyStefan Metzmacher2019-06-121-3/+3
| | | | | | | | We should make clear that this is a function for testing only, with possible strange side effects. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s4:torture: force signing in the smb2.session.bind1 testStefan Metzmacher2019-06-121-1/+9
| | | | | | | | | This test is supposed to test which signing keys are used on each of the channels, so it's important to require signing. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s4/torture/rpc: cppcheck: Fix ctunullpointer errorNoel Power2019-06-111-1/+7
| | | | | | | | | Fixes source4/torture/rpc/netlogon.c:307: error: ctunullpointer: Null pointer dereference: p <--[cppcheck] Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Gary Lockyer gary@catalyst.net.nz
* winsrepl.idl: remove unused decode functionsGary Lockyer2019-06-061-5/+0
| | | | | | | | Remove the decode_* functions as they are no longer needed, and this will reduce the amount of untested automatically generated code. Signed-off-by: Gary Lockyer <gary@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* sasl_helpers.idl: remove unused decode functionsGary Lockyer2019-06-061-4/+0
| | | | | | | | Remove the decode_* functions as they are no longer needed, and this will reduce the amount of untested automatically generated code. Signed-off-by: Gary Lockyer <gary@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* ntp_signd.idl: remove unused decode functionsGary Lockyer2019-06-061-6/+0
| | | | | | | | Remove the decode_* functions as they are no longer needed, and this will reduce the amount of untested automatically generated code. Signed-off-by: Gary Lockyer <gary@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4/torture/unix: cppcheck: Fix shiftTooManyBitsSigned errorNoel Power2019-06-041-1/+1
| | | | | | | | | Fixes source4/torture/unix/unix_info2.c:300: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Andreas Schneider <asn@samba.org>
* s4/torture/smb2: cppcheck: Fix shiftTooManyBitsSigned errorNoel Power2019-06-041-2/+2
| | | | | | | | | | | | | | | | | | | | Fixes source4/torture/smb2/notify.c:974: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] source4/torture/smb2/notify.c:994: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] source4/torture/smb2/notify.c:1002: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] source4/torture/smb2/notify.c:1011: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] source4/torture/smb2/notify.c:1025: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] source4/torture/smb2/notify.c:1040: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] source4/torture/smb2/notify.c:1048: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] source4/torture/smb2/notify.c:1062: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] source4/torture/smb2/notify.c:1081: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] source4/torture/smb2/notify.c:1096: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] source4/torture/smb2/notify.c:1112: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] source4/torture/smb2/notify.c:1125: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Andreas Schneider <asn@samba.org>
* s4/torture/smb2: cppcheck: Fix shiftTooManyBitsSigned errorNoel Power2019-06-041-3/+3
| | | | | | | | | | | Fixes source4/torture/smb2/create.c:197: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] source4/torture/smb2/create.c:234: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] source4/torture/smb2/create.c:265: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Andreas Schneider <asn@samba.org>
* s4/torture/raw: cppcheck: Fix shiftTooManyBitsSigned errorNoel Power2019-06-041-2/+3
| | | | | | | | | | Fix source4/torture/raw/open.c:1009: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] source4/torture/raw/open.c:1048: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Andreas Schneider <asn@samba.org>
* s4/torture/raw: cppcheck: Fix shiftTooManyBitsSigned errorNoel Power2019-06-041-2/+2
| | | | | | | | | | | | | | | | | | | | | | | Fix source4/torture/raw/notify.c:831: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] source4/torture/raw/notify.c:838: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] source4/torture/raw/notify.c:849: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] source4/torture/raw/notify.c:861: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] source4/torture/raw/notify.c:869: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] source4/torture/raw/notify.c:882: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] source4/torture/raw/notify.c:892: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] source4/torture/raw/notify.c:903: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] source4/torture/raw/notify.c:914: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] source4/torture/raw/notify.c:929: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] source4/torture/raw/notify.c:941: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] source4/torture/raw/notify.c:951: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] source4/torture/raw/notify.c:961: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] source4/torture/raw/notify.c:972: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] source4/torture/raw/notify.c:982: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck] Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Andreas Schneider <asn@samba.org>
* s4/smdb: cppcheck: fix nullPointer: Possible null pointer dereference warning.Noel Power2019-06-041-2/+69
| | | | | | | | | | | | | | | Insert unreachable return to satisfy the following warnings source4/smbd/server.c:692: warning: nullPointer: Possible null pointer dereference: state <--[cppcheck] source4/smbd/server.c:694: warning: nullPointer: Possible null pointer dereference: state <--[cppcheck] source4/smbd/server.c:699: warning: nullPointer: Possible null pointer dereference: state <--[cppcheck] source4/smbd/server.c:758: warning: nullPointer: Possible null pointer dereference: state <--[cppcheck] source4/smbd/server.c:789: warning: nullPointer: Possible null pointer dereference: state <--[cppcheck] source4/smbd/server.c:849: warning: nullPointer: Possible null pointer dereference: state <--[cppcheck] source4/smbd/server.c:866: warning: nullPointer: Possible null pointer dereference: state <--[cppcheck] Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Andreas Schneider <asn@samba.org>
* s4/smb_server/smb: cppcheck: Fix uninitvar & uninitStructMember errorsNoel Power2019-06-041-1/+1
| | | | | | | | | | | | | | | Fixes the following errors (note: existing code is safe the way it is currently all accesses to the structure are 'after' it is assigned) source4/smb_server/smb/negprot.c:447: error: uninitvar: Uninitialized variable: blob <--[cppcheck] source4/smb_server/smb/negprot.c:453: error: uninitStructMember: Uninitialized struct member: blob.data <--[cppcheck] source4/smb_server/smb/negprot.c:447: error: uninitStructMember: Uninitialized struct member: blob.length <--[cppcheck] source4/smb_server/smb/negprot.c:453: error: uninitStructMember: Uninitialized struct member: blob.length <--[cppcheck] source4/smb_server/smb/negprot.c:454: error: uninitStructMember: Uninitialized struct member: blob.length <--[cppcheck] source4/smb_server/smb/negprot.c:455: error: uninitStructMember: Uninitialized struct member: blob.length <--[cppcheck] Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Andreas Schneider <asn@samba.org>
* s4/rpc_server/dnsserver: clang: fix Value stored to 'status' is never readNoel Power2019-06-041-0/+8
| | | | | | | | | | | | | | Fix the following warnings source4/rpc_server/dnsserver/dcerpc_dnsserver.c:1021: error: uninitvar: Uninitialized variable: answer_integer <--[cppcheck] source4/rpc_server/dnsserver/dcerpc_dnsserver.c:1723:4: warning: Value stored to 'status' is never read <--[clang] status = dns_fill_records_array(tmp_ctx, NULL, DNS_TYPE_A, ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ source4/rpc_server/dnsserver/dcerpc_dnsserver.c:1881:4: warning: Value stored to 'status' is never read <--[clang] status = dns_fill_records_array(tmp_ctx, NULL, DNS_TYPE_A, Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Andreas Schneider <asn@samba.org>
* s4/rpc_server/dnsserver: cppcheck: Fix Uninitialized variable error.Noel Power2019-06-041-1/+2
| | | | | | | | | | | source4/rpc_server/dnsserver/dcerpc_dnsserver.c:715: error: uninitvar: Uninitialized variable: answer_integer <--[cppcheck] This error is benign and somewhat false because the code pointed to does not run (due to a different check) if answer_integer is not actually initialsed. It is easy to squash it though by just initialising the var. Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Andreas Schneider <asn@samba.org>
* s4/ntvfs/cifs: cppcheck: squash nullPointer: Possible null pointer dereferenceNoel Power2019-06-041-0/+9
| | | | | | | | | | | | Fix the following cppcheck warnings /home/samba/samba-pidl/source4/ntvfs/cifs/vfs_cifs.c:604: warning: nullPointer: Possible null pointer dereference: file <--[cppcheck] /home/samba/samba-pidl/source4/ntvfs/cifs/vfs_cifs.c:605: warning: nullPointer: Possible null pointer dereference: file <--[cppcheck] /home/samba/samba-pidl/source4/ntvfs/cifs/vfs_cifs.c:648: warning: nullPointer: Possible null pointer dereference: file <--[cppcheck] /home/samba/samba-pidl/source4/ntvfs/cifs/vfs_cifs.c:649: warning: nullPointer: Possible null pointer dereference: file <--[cppcheck] Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Andreas Schneider <asn@samba.org>
* s4:rpc_server:netlogon: don't require NEG_AUTHENTICATED_RPC in ↵Stefan Metzmacher2019-06-041-15/+0
| | | | | | | | | | | | | | netr_ServerAuthenticate*() The domain join with VMWare Horizon Quickprep seems to use netr_ServerAuthenticate3() with just the NEG_STRONG_KEYS (and in addition the NEG_SUPPORTS_AES) just to verify a password. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13464 (maybe) BUG: https://bugzilla.samba.org/show_bug.cgi?id=13949 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s4:torture:fsmo.py: remove unused 'net_cmd' variableBjörn Baumbach2019-05-301-2/+0
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13973 Signed-off-by: Björn Baumbach <bbaumbach@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:fsmo.py: test role transfers of dns partitionsBjörn Baumbach2019-05-301-0/+10
| | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13973 Pair-Programmed-With: Stefan Metzmacher <metze@samba.org> Signed-off-by: Björn Baumbach <bbaumbach@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4 lib rpc pyrpc: Fix error messageGary Lockyer2019-05-301-1/+2
| | | | | | | | | Fix the error message returned when unable to initialise an event context. Signed-off-by: Gary Lockyer <gary@catalyst.net.nz> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* downgradedatabase: adding special case for MDBAaron Haslett2019-05-291-2/+27
| | | | | | | | | | | | | Though this script was initially written for undoing GUID indexing on TDB databases, we're repurposing it to do a full downgrade of any database. MDB databases can't be DN indexed, but they can have pack format version 2 and ORDERED_INTEGER data types, which must be removed during a downgrade. Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz> Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
* dsdb: disable ORDERED_INTEGER with MDB pack format v1Aaron Haslett2019-05-291-9/+63
| | | | | | | | | | | | | | | | | | | | For TDB databases, the new ORDERED_INTEGER type is disabled along with repacking at format version 1 if GUID indexing is disabled, so all the new database features are toggled together. This scheme doesn't work with MDB because GUID indexing is mandatory when using MDB. However, a downgrade path is still required so in a previous commit we added a pack_format_override option which allows a downgrade script to force the database to use an earlier packing format. But, the new ORDERED_INTEGER type would still be present in MDB databases so this patch reads the pack_format_override opaque and converts ORDERED_INTEGER types in @ATTRIBUTES to INTEGER and doesn't write any indexes of that type to @INDEXLIST. The @INDEXLIST will be refreshed later, on the first transaction. Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz> Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
* ldb: binding ordered indexes to GUID indexingAaron Haslett2019-05-291-6/+29
| | | | | | | | | | | | | | To reduce the number of potential combinations of database features in ldb, we want to link all new database features since 4.7. GUID indexing, ordered integers, and pack format changes will all upgrade together. This patch makes ordered integers only function if GUID indexing is enabled. If GUID indexing is disabled, ORDERED_INTEGER will not be written to @ATTRIBUTES and a syntax's index_format_fn will never be used. Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* downgradedatabase: blackbox testAaron Haslett2019-05-291-0/+2
| | | | | | | | | This test confirms that running downgradedatabase causes all GUID keys to be replaced with DN keys at the KV level Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* sambadowngradedatabase: Add "or later" to warning about using tools from ↵Andrew Bartlett2019-05-291-1/+1
| | | | | | | Samba 4.8 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* sambaundoguididx: renamed to downgradedatabaseAaron Haslett2019-05-291-0/+0
| | | | | | | | | | In forthcoming commits we're going to repurpose this script to do an entire downgrade of a database, disabling all new database features. downgradedatabase is a more appropriate name. Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* sambaundoguididx: fix for -sAndrew Bartlett2019-05-291-2/+4
| | | | | | | | | Quick fix running this script with -s instead of -H. samdb_url() returns a url with a protocol prefix, which causes issues further down in the script. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* smbtorture: Fix a typoVolker Lendecke2019-05-281-1/+1
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* dsdb:audit_log: avoid printing "... remote host [Unknown] SID [(NULL SID)] ..."Stefan Metzmacher2019-05-281-1/+3
| | | | | | | | | | | We better print "... remote host [Unknown] SID [S-1-5-18] ..." in 'dsdb_audit' message, this matches what we print for 'dsdb_json_audit'. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13916 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* Fix ubsan null pointer passed as argument 2Gary Lockyer2019-05-276-27/+58
| | | | | | | | | | | | Fix ubsan warning null pointer passed as argument 2 when the source pointer is NULL. The calls to memcpy are now guarded by an if (len > 0) Signed-off-by: Gary Lockyer <gary@catalyst.net.nz> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Gary Lockyer <gary@samba.org> Autobuild-Date(master): Mon May 27 01:29:48 UTC 2019 on sn-devel-184
* ldap server: generate correct referral schemesGary Lockyer2019-05-244-5/+36
| | | | | | | | | | | | | | Ensure that the referrals returned in a search request use the same scheme as the request, i.e. referrals recieved via ldap are prefixed with "ldap://" and those over ldaps are prefixed with "ldaps://" BUG: https://bugzilla.samba.org/show_bug.cgi?id=12478 Signed-off-by: Gary Lockyer <gary@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Fri May 24 05:12:14 UTC 2019 on sn-devel-184
* ldap tests: test scheme for referralsGary Lockyer2019-05-241-0/+8
| | | | | | | | | | | Ensure that the referrals returned in a search request use the same scheme as the request, i.e. referrals recieved via ldap are prefixed with "ldap://" and those over ldaps are prefixed with "ldaps://" BUG: https://bugzilla.samba.org/show_bug.cgi?id=12478 Signed-off-by: Gary Lockyer <gary@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* selftest: Remove infinite client/server loop in srvsvc_NetNameValidate testAndrew Bartlett2019-05-241-0/+7
| | | | | Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
* s4:torture/vfs/fruit: ensure test_adouble_conversion_wo_xattr() uses a ↵Ralph Boehme2019-05-231-6/+9
| | | | | | | | | | | | | | | | non-emtpy resourcefork This ensures the resource fork is not deleted as part of the AppleDouble file conversion for the option fruit:wipe_intentionally_left_blank_rfork=yes. This is currently not a problem in selftest, as we don't enable the option, but a subsequent commit will run all vfs.fruit tests against a share with this option enabled. Bug: https://bugzilla.samba.org/show_bug.cgi?id=13958 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s4:torture/vfs/fruit: ensure test_adouble_conversion() uses a non-emtpy ↵Ralph Boehme2019-05-231-3/+668
| | | | | | | | | | | | | | | | resourcefork This ensures the resource fork is not deleted as part of the AppleDouble file conversion for the option fruit:wipe_intentionally_left_blank_rfork=yes. This is currently not a problem in selftest, as we don't enable the option, but a subsequent commit will run all vfs.fruit tests against a share with this option enabled. Bug: https://bugzilla.samba.org/show_bug.cgi?id=13958 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* sambaundoguididx: Add flags=ldb.FLG_DONT_CREATE_DB and port to Python3Andrew Bartlett2019-05-231-6/+10
| | | | | | | | | | | In py3 we need to add an extra str() around the returned ldb value to enable .split() to be used. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed By: Noel Power <npower@samba.org> Autobuild-User(master): Noel Power <npower@samba.org> Autobuild-Date(master): Thu May 23 14:25:52 UTC 2019 on sn-devel-184
* smbtorture: Add a test to make smbd panicVolker Lendecke2019-05-221-0/+75
| | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=13957 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s4-ntvfs: Remove untested ntvfs_cifsposix backendAndrew Bartlett2019-05-225-1366/+0
| | | | | | | | | | | | | It had a note: WARNING: All file access is done as user root!!! Only use this module for testing, with only test data!!! Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz> Autobuild-User(master): Gary Lockyer <gary@samba.org> Autobuild-Date(master): Wed May 22 07:15:43 UTC 2019 on sn-devel-184
* s4-ntvfs: Remove untested stub vfs_print backendAndrew Bartlett2019-05-223-143/+0
| | | | | Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
* ntvfs: Remove unused and untested SMB1 -> SMB2 proxy moduleAndrew Bartlett2019-05-222-912/+0
| | | | | | | | | | While this could have been a very interesting idea (particularly if it allowed our main SMB server to disable SMB1), it has never been enabled in our testsuite so relying on it would be quite brave. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
* ntvfs: Remove unused nbench vfs moduleAndrew Bartlett2019-05-223-1005/+0
| | | | | | | | | | A pass-though NTVFS module to write nbench files is a cute idea, but this is untested and almost certainly unused. Found by looking at the LCOV results. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
* libcli/ldap: Remove unsued ldap_transaction()Andrew Bartlett2019-05-221-23/+0
| | | | | | | | This is unsued since a87dea2a0894015cf4a3140995791f5468c40038 in 2007 when we moved to using LDB for LDAP in this area of the code. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
* s4-rpc_server: Remove unused dnsserver_find_partition()Andrew Bartlett2019-05-222-16/+0
| | | | | | | | | | This has been unused since it was introduced by 5673e2cec946502da84956f866658718e7632a3e in 2011. Found by callcatcher Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
* dsdb: Remove unsued dsdb_class_by_cn()Andrew Bartlett2019-05-221-10/+0
| | | | | | | | | | The callers moved to dsdb_class_by_cn_ldb_val() with 43aa546ecc3f05845793b1a7354685d50a77c170 in 2009. Found by callcatcher Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
* Remove unused auth_get_challenge_not_implementedAndrew Bartlett2019-05-221-9/+0
| | | | | | | | | This became unused after eba87995145b0e14672c1f6993f7aa3422d62541 in 2012 Found by callcatcher Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
* ldb: pack function for new pack formatAaron Haslett2019-05-221-5/+148
| | | | | | | | | | | | | | | | | Pack function for new pack format with values separated from other data so that while unpacking, the value section (which is probably large) doesn't have to be loaded into cache/memory. The new format is disabled for now. Two tests are added that operate on a detailed binary breakdown of the new format. NOTE: Configure with --abi-check-disable to build this commit. This patch is part of a set of LDB ABI changes, and the version update is done on the last commit. Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
* ldb: unpack function for new pack formatAaron Haslett2019-05-221-17/+261
| | | | | | | | | | | | | | | | | | | Unpack function for new pack format with values separated from other data so that while unpacking, the value section (which is probably large) doesn't have to be loaded into cache/memory. Additionally, width of length field can now vary per-element to save space. The old unpack routine is still present and is called if the old pack format version number is found. LDB torture suite is modified to run relevant tests on both old and new pack format. NOTE: Configure with --abi-check-disable to build this commit. This patch is part of a set of LDB ABI changes, and the version update is done on the last commit. Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
* s4 librpc rpc pyrpc: Fix flapping dcerpc.bare testsGary Lockyer2019-05-221-5/+2
| | | | | | | | | | | | | Commit d65b7641c84976c543ded8f0de5ab2da3c19b407 had the parameters to talloc_reparent reversed. This caused the dcerpc.bare tests to flap. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13932 Signed-off-by: Gary Lockyer <gary@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Gary Lockyer <gary@samba.org> Autobuild-Date(master): Wed May 22 03:03:43 UTC 2019 on sn-devel-184
View Lorry Controller Status