summaryrefslogtreecommitdiff
path: root/source4/torture/basic
Commit message (Collapse)AuthorAgeFilesLines
* s4/torture: Add new test for DELETE_ON_CLOSE on non-empty directoriesAnoop C S2018-08-231-0/+87
| | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13204 Signed-off-by: Anoop C S <anoopcs@redhat.com> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> (cherry picked from commit 6a7f11746c9cc3cdc5307e540bdd1f3f10fed05b)
* s4:torture: Use strlcpy() in gen_name()Andreas Schneider2018-06-201-1/+1
| | | | | | | | | | | | | | | ../source4/torture/basic/mangle_test.c: In function ‘gen_name’: ../source4/torture/basic/mangle_test.c:148:3: error: ‘strncpy’ output truncated before terminating nul copying 5 bytes from a string of the same length [-Werror=stringop-truncation] strncpy(p, "ABCDE", 5); ^~~~~~~~~~~~~~~~~~~~~~ BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org> (cherry picked from commit 7a00d90d668f53914ffe035c41a5e79e60b51521)
* s4: torture: Test all combinations of directory open with existing directory ↵Jeremy Allison2018-04-061-0/+66
| | | | | | | | | | | | | | | | | to ensure behavior is the same. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13358 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <Volker.Lendecke@SerNet.DE> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Mar 29 23:13:42 CEST 2018 on sn-devel-144 (cherry picked from commit c98cd0f25edaae7558f18fd331e2fef3aabb61f2) Autobuild-User(v4-8-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-8-test): Fri Apr 6 13:50:18 CEST 2018 on sn-devel-144
* s4: torture: Test all combinations of directory create to ensure behavior is ↵Jeremy Allison2018-04-061-0/+65
| | | | | | | | | | the same. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13358 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <Volker.Lendecke@SerNet.DE> (cherry picked from commit fd9084336e7e86ccec83141d880fd7c336c23b6c)
* s4: torture: Test all combinations of file open with existing file to ensure ↵Jeremy Allison2018-04-061-0/+68
| | | | | | | | | | behavior is the same. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13358 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <Volker.Lendecke@SerNet.DE> (cherry picked from commit 820b35bb1ceb445eb3659b67eedfb0a2f5b2f976)
* s4: torture: Test all combinations of file create to ensure behavior is the ↵Jeremy Allison2018-04-061-24/+33
| | | | | | | | | | same. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13358 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <Volker.Lendecke@SerNet.DE> (cherry picked from commit 22fe8dcb77565495886244e88bb0433363d1f80a)
* s4: torture: Ensure a failed file create doesn't create the file.Jeremy Allison2018-04-061-0/+27
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13358 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <Volker.Lendecke@SerNet.DE> (cherry picked from commit 53cdf7a9a18ed547eade4c3cdd80d286058e440d)
* s4-torture: fix truncation warningsUri Simchoni2017-11-241-3/+3
| | | | | | | | Fix various places where there is potential truncation while doing time / size calculations. Signed-off-by: Uri Simchoni <uri@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* Add a test for unsetting Delete-on-Close before the close by DoC opener.Richard Sharpe2017-07-281-0/+56
| | | | | | | | | | | | Windows semantics says that any unset of Delete-on-Close before the client that opened for Delete-on-Close closes the file is silently ignored and the file is still deleted on the last close. This test tests that in a single open case. Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Fri Jul 28 11:47:06 CEST 2017 on sn-devel-144
* Fix incorrect error messages:unsetting not setting.Richard Sharpe2017-07-281-2/+2
| | | | | | | The error messages are wrong and could give testers the wrong idea. Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com> Reviewed-by: Volker Lendecke <vl@samba.org>
* delete duplicate testHerb Lewis2017-07-081-1/+0
| | | | | | | | Signed-off-by: Herb Lewis <herb@samba.org> Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com> Autobuild-User(master): Herb Lewis <herb@samba.org> Autobuild-Date(master): Sat Jul 8 05:57:55 CEST 2017 on sn-devel-144
* s4: popt: Global replace of cmdline_credentials -> ↵Jeremy Allison2017-05-111-3/+2
| | | | | | | | | | | popt_get_cmdline_credentials(). Add one use of popt_set_cmdline_credentials(). Fix 80 column limits when cmdline_credentials changes to popt_get_cmdline_credentials(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s4: torture: Add a TALLOC_CTX * to torture_test_delete().Jeremy Allison2017-05-052-3/+3
| | | | | Reviewed-by: Ralph Böhme <slow@samba.org> Signed-off-by: Jeremy Allison <jra@samba.org>
* s4: torture: Pass TALLOC_CTX * to torture_delay_write().Jeremy Allison2017-05-052-3/+3
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s4: torture: Change torture_register_suite() to add a TALLOC_CTX *.Jeremy Allison2017-05-051-2/+2
| | | | | | | | Change callers to use the passed in TALLOC_CTX * instead of talloc_autofree_context(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* lib: modules: Change XXX_init interface from XXX_init(void) to ↵Jeremy Allison2017-04-221-1/+1
| | | | | | | | | | | | | | | | | | | | XXX_init(TALLOC_CTX *) Not currently used - no logic changes inside. This will make it possible to pass down a long-lived talloc context from the loading function for modules to use instead of having them internally all use talloc_autofree_context() which is a hidden global. Updated all known module interface numbers, and added a WHATSNEW. Signed-off-by: Jeremy Allison <jra@samba.org> Signed-off-by: Ralph Böhme <slow@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Sat Apr 22 01:17:00 CEST 2017 on sn-devel-144
* Correct "existence" typos.Chris Lamb2017-02-221-3/+3
| | | | | | Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* Correct "occured" typos.Chris Lamb2017-02-221-1/+1
| | | | | | Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* s4:torture:basic:delete: fix O3 error unused result of asprintfMichael Adam2016-05-131-2/+5
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Christian Ambach <ambi@samba.org>
* s4:torture:basic:dir: fix O3 error unused result of asprintfMichael Adam2016-05-131-4/+10
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Christian Ambach <ambi@samba.org>
* s4:torture:basic: fix O3 error unused result of writeMichael Adam2016-05-131-1/+2
| | | | | | | in test_utable Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Christian Ambach <ambi@samba.org>
* s4:torture:basic:misc: fix O3 error unused result of asprintfMichael Adam2016-05-131-4/+11
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Christian Ambach <ambi@samba.org>
* s4:torture:basic: fix O3 error unused result of asprintfMichael Adam2016-05-131-2/+4
| | | | | | | | | in run_opentest() While fixing this, also convert to using talloc_asprintf instead. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Christian Ambach <ambi@samba.org>
* s4:torture:basic: fix 'Conditional jump or move ' valgrind errorNoel Power2016-04-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | running smbtorture test base.bench-holdopen.bench-holdopen yields the following valgrind trace. ==29953== Conditional jump or move depends on uninitialised value(s) ==29953== at 0xF4634F0: _talloc_zero_array (in /usr/lib64/libtalloc.so.2.1.5) ==29953== by 0x5AE257E: smbcli_request_setup_transport (rawrequest.c:101) ==29953== by 0x5AE04AF: smb_raw_echo_send (clitransport.c:554) ==29953== by 0x5AE0774: smb_raw_echo (clitransport.c:609) ==29953== by 0x4183D3: torture_holdopen (misc.c:288) ==29953== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==29953== by 0x955368F: internal_torture_run_test (torture.c:442) ==29953== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==29953== by 0x2600A4: run_matching (smbtorture.c:110) ==29953== by 0x25FF66: run_matching (smbtorture.c:95) ==29953== by 0x2601C5: torture_run_named_tests (smbtorture.c:143) ==29953== by 0x261E44: main (smbtorture.c:665) ==29953== ==29953== Conditional jump or move depends on uninitialised value(s) ==29953== at 0xF4630E3: _talloc_zero (in /usr/lib64/libtalloc.so.2.1.5) ==29953== by 0x5AE257E: smbcli_request_setup_transport (rawrequest.c:101) ==29953== by 0x5AE04AF: smb_raw_echo_send (clitransport.c:554) ==29953== by 0x5AE0774: smb_raw_echo (clitransport.c:609) ==29953== by 0x4183D3: torture_holdopen (misc.c:288) ==29953== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==29953== by 0x955368F: internal_torture_run_test (torture.c:442) ==29953== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==29953== by 0x2600A4: run_matching (smbtorture.c:110) ==29953== by 0x25FF66: run_matching (smbtorture.c:95) ==29953== by 0x2601C5: torture_run_named_tests (smbtorture.c:143) ==29953== by 0x261E44: main (smbtorture.c:665) ==29953== Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s4:torture:basic: fix 'Syscall param writev(vector[...])' valgrind errorNoel Power2016-04-251-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | smbtorture test base.winattr.winattr yields the following trace ==25514== Syscall param writev(vector[...]) points to uninitialised byte(s) ==25514== at 0xFBA2C87: writev (in /lib64/libc-2.19.so) ==25514== by 0x106CB033: writev_handler (async_sock.c:340) ==25514== by 0xF67812A: ??? (in /usr/lib64/libtevent.so.0.9.26) ==25514== by 0xF6765F6: ??? (in /usr/lib64/libtevent.so.0.9.26) ==25514== by 0xF6727FC: _tevent_loop_once (in /usr/lib64/libtevent.so.0.9.26) ==25514== by 0x5AE3400: smbcli_request_receive (rawrequest.c:416) ==25514== by 0x5AEEC7E: smb_raw_nttrans_recv (rawtrans.c:408) ==25514== by 0x5AF6543: smb_raw_query_secdesc_recv (rawacl.c:67) ==25514== by 0x5AF580F: smb_raw_fileinfo_recv (rawfileinfo.c:699) ==25514== by 0x5AF58BE: smb_raw_fileinfo (rawfileinfo.c:721) ==25514== by 0x454AC3: torture_winattrtest (attr.c:217) ==25514== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==25514== by 0x955368F: internal_torture_run_test (torture.c:442) ==25514== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==25514== by 0x2600A4: run_matching (smbtorture.c:110) ==25514== by 0x25FF66: run_matching (smbtorture.c:95) ==25514== by 0x2601C5: torture_run_named_tests (smbtorture.c:143) ==25514== by 0x261E44: main (smbtorture.c:665) ==25514== Address 0x187d69c6 is 598 bytes inside a block of size 1,325 alloc'd ==25514== at 0x4C29110: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==25514== by 0xF464A73: _talloc_pooled_object (in /usr/lib64/libtalloc.so.2.1.5) ==25514== by 0xF67366D: _tevent_req_create (in /usr/lib64/libtevent.so.0.9.26) ==25514== by 0xB0D49FF: smb1cli_req_create (smbXcli_base.c:1322) ==25514== by 0xB0E1E6D: smb1cli_trans_send (smb1cli_trans.c:512) ==25514== by 0x5AEE9B2: smb_raw_nttrans_send (rawtrans.c:310) ==25514== by 0x5AF64F0: smb_raw_query_secdesc_send (rawacl.c:51) ==25514== by 0x5AF56E5: smb_raw_fileinfo_send (rawfileinfo.c:658) ==25514== by 0x5AF58A3: smb_raw_fileinfo (rawfileinfo.c:720) ==25514== by 0x454AC3: torture_winattrtest (attr.c:217) ==25514== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==25514== by 0x955368F: internal_torture_run_test (torture.c:442) ==25514== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==25514== by 0x2600A4: run_matching (smbtorture.c:110) ==25514== by 0x25FF66: run_matching (smbtorture.c:95) ==25514== by 0x2601C5: torture_run_named_tests (smbtorture.c:143) ==25514== by 0x261E44: main (smbtorture.c:665) Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s4:torture:basic: fix valgrind 'Syscall param writev(vector[...])' error.Noel Power2016-04-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | smbtorture test base.aliases.setpathinfo_aliases.setpathinfo_aliases results in the following valgrind trace ==23067== Syscall param writev(vector[...]) points to uninitialised byte(s) ==23067== at 0xFBA2C87: writev (in /lib64/libc-2.19.so) ==23067== by 0x106CB033: writev_handler (async_sock.c:340) ==23067== by 0xF67812A: ??? (in /usr/lib64/libtevent.so.0.9.26) ==23067== by 0xF6765F6: ??? (in /usr/lib64/libtevent.so.0.9.26) ==23067== by 0xF6727FC: _tevent_loop_once (in /usr/lib64/libtevent.so.0.9.26) ==23067== by 0x5AE3400: smbcli_request_receive (rawrequest.c:416) ==23067== by 0x5AE6019: smb_raw_write_recv (rawreadwrite.c:303) ==23067== by 0x5AE63FD: smb_raw_write (rawreadwrite.c:344) ==23067== by 0x9BE50CA: smbcli_write (clireadwrite.c:118) ==23067== by 0x423EB4: setpathinfo_aliases (aliases.c:367) ==23067== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==23067== by 0x955368F: internal_torture_run_test (torture.c:442) ==23067== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==23067== by 0x2600A4: run_matching (smbtorture.c:110) ==23067== by 0x25FF66: run_matching (smbtorture.c:95) ==23067== by 0x25FF66: run_matching (smbtorture.c:95) ==23067== by 0x2601C5: torture_run_named_tests (smbtorture.c:143) ==23067== by 0x261E44: main (smbtorture.c:665) ==23067== Address 0x187e0096 is 598 bytes inside a block of size 1,325 alloc'd ==23067== at 0x4C29110: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==23067== by 0xF464A73: _talloc_pooled_object (in /usr/lib64/libtalloc.so.2.1.5) ==23067== by 0xF67366D: _tevent_req_create (in /usr/lib64/libtevent.so.0.9.26) ==23067== by 0xB0D49FF: smb1cli_req_create (smbXcli_base.c:1322) ==23067== by 0x5ADFAB7: smbcli_transport_setup_subreq (clitransport.c:254) ==23067== by 0x5ADFC37: smbcli_transport_send (clitransport.c:326) ==23067== by 0x5AE33C3: smbcli_request_send (rawrequest.c:400) ==23067== by 0x5AE5FDD: smb_raw_write_send (rawreadwrite.c:289) ==23067== by 0x5AE63E6: smb_raw_write (rawreadwrite.c:343) ==23067== by 0x9BE50CA: smbcli_write (clireadwrite.c:118) ==23067== by 0x423EB4: setpathinfo_aliases (aliases.c:367) ==23067== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==23067== by 0x955368F: internal_torture_run_test (torture.c:442) ==23067== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==23067== by 0x2600A4: run_matching (smbtorture.c:110) ==23067== by 0x25FF66: run_matching (smbtorture.c:95) ==23067== by 0x25FF66: run_matching (smbtorture.c:95) ==23067== by 0x2601C5: torture_run_named_tests (smbtorture.c:143) ==23067== by 0x261E44: main (smbtorture.c:665) ==23067== Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s4:torture:basic: fix valgrind 'Syscall param writev(vector[...])' errorNoel Power2016-04-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | smbtorture test base.aliases.setfileinfo_aliases.setfileinfo_aliases results in the following valgrind trace ==22757== Syscall param writev(vector[...]) points to uninitialised byte(s) ==22757== at 0xFBA2C87: writev (in /lib64/libc-2.19.so) ==22757== by 0x106CB033: writev_handler (async_sock.c:340) ==22757== by 0xF67812A: ??? (in /usr/lib64/libtevent.so.0.9.26) ==22757== by 0xF6765F6: ??? (in /usr/lib64/libtevent.so.0.9.26) ==22757== by 0xF6727FC: _tevent_loop_once (in /usr/lib64/libtevent.so.0.9.26) ==22757== by 0x5AE3400: smbcli_request_receive (rawrequest.c:416) ==22757== by 0x5AE6019: smb_raw_write_recv (rawreadwrite.c:303) ==22757== by 0x5AE63FD: smb_raw_write (rawreadwrite.c:344) ==22757== by 0x9BE50CA: smbcli_write (clireadwrite.c:118) ==22757== by 0x423C91: setfileinfo_aliases (aliases.c:327) ==22757== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==22757== by 0x955368F: internal_torture_run_test (torture.c:442) ==22757== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==22757== by 0x2600A4: run_matching (smbtorture.c:110) ==22757== by 0x25FF66: run_matching (smbtorture.c:95) ==22757== by 0x25FF66: run_matching (smbtorture.c:95) ==22757== by 0x2601C5: torture_run_named_tests (smbtorture.c:143) ==22757== by 0x261E44: main (smbtorture.c:665) ==22757== Address 0x187dfee6 is 598 bytes inside a block of size 1,325 alloc'd ==22757== at 0x4C29110: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==22757== by 0xF464A73: _talloc_pooled_object (in /usr/lib64/libtalloc.so.2.1.5) ==22757== by 0xF67366D: _tevent_req_create (in /usr/lib64/libtevent.so.0.9.26) ==22757== by 0xB0D49FF: smb1cli_req_create (smbXcli_base.c:1322) ==22757== by 0x5ADFAB7: smbcli_transport_setup_subreq (clitransport.c:254) ==22757== by 0x5ADFC37: smbcli_transport_send (clitransport.c:326) ==22757== by 0x5AE33C3: smbcli_request_send (rawrequest.c:400) ==22757== by 0x5AE5FDD: smb_raw_write_send (rawreadwrite.c:289) ==22757== by 0x5AE63E6: smb_raw_write (rawreadwrite.c:343) ==22757== by 0x9BE50CA: smbcli_write (clireadwrite.c:118) ==22757== by 0x423C91: setfileinfo_aliases (aliases.c:327) ==22757== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==22757== by 0x955368F: internal_torture_run_test (torture.c:442) ==22757== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==22757== by 0x2600A4: run_matching (smbtorture.c:110) ==22757== by 0x25FF66: run_matching (smbtorture.c:95) ==22757== by 0x25FF66: run_matching (smbtorture.c:95) ==22757== by 0x2601C5: torture_run_named_tests (smbtorture.c:143) ==22757== by 0x261E44: main (smbtorture.c:665) Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s4:torture:basic: fix valgrind 'Syscall param writev(vector[...])' errorNoel Power2016-04-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | running smbtorture test base.aliases.FINDFIRST aliases.FINDFIRST aliases results in the following valgrind trace ==22639== Syscall param writev(vector[...]) points to uninitialised byte(s) ==22639== at 0xFBA2C87: writev (in /lib64/libc-2.19.so) ==22639== by 0x106CB033: writev_handler (async_sock.c:340) ==22639== by 0xF67812A: ??? (in /usr/lib64/libtevent.so.0.9.26) ==22639== by 0xF6765F6: ??? (in /usr/lib64/libtevent.so.0.9.26) ==22639== by 0xF6727FC: _tevent_loop_once (in /usr/lib64/libtevent.so.0.9.26) ==22639== by 0x5AE3400: smbcli_request_receive (rawrequest.c:416) ==22639== by 0x5AE6019: smb_raw_write_recv (rawreadwrite.c:303) ==22639== by 0x5AE63FD: smb_raw_write (rawreadwrite.c:344) ==22639== by 0x9BE50CA: smbcli_write (clireadwrite.c:118) ==22639== by 0x423672: findfirst_aliases (aliases.c:213) ==22639== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==22639== by 0x955368F: internal_torture_run_test (torture.c:442) ==22639== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==22639== by 0x2600A4: run_matching (smbtorture.c:110) ==22639== by 0x25FF66: run_matching (smbtorture.c:95) ==22639== by 0x25FF66: run_matching (smbtorture.c:95) ==22639== by 0x2601C5: torture_run_named_tests (smbtorture.c:143) ==22639== by 0x261E44: main (smbtorture.c:665) ==22639== Address 0x187dfd26 is 598 bytes inside a block of size 1,325 alloc'd ==22639== at 0x4C29110: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==22639== by 0xF464A73: _talloc_pooled_object (in /usr/lib64/libtalloc.so.2.1.5) ==22639== by 0xF67366D: _tevent_req_create (in /usr/lib64/libtevent.so.0.9.26) ==22639== by 0xB0D49FF: smb1cli_req_create (smbXcli_base.c:1322) ==22639== by 0x5ADFAB7: smbcli_transport_setup_subreq (clitransport.c:254) ==22639== by 0x5ADFC37: smbcli_transport_send (clitransport.c:326) ==22639== by 0x5AE33C3: smbcli_request_send (rawrequest.c:400) ==22639== by 0x5AE5FDD: smb_raw_write_send (rawreadwrite.c:289) ==22639== by 0x5AE63E6: smb_raw_write (rawreadwrite.c:343) ==22639== by 0x9BE50CA: smbcli_write (clireadwrite.c:118) ==22639== by 0x423672: findfirst_aliases (aliases.c:213) ==22639== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==22639== by 0x955368F: internal_torture_run_test (torture.c:442) ==22639== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==22639== by 0x2600A4: run_matching (smbtorture.c:110) ==22639== by 0x25FF66: run_matching (smbtorture.c:95) ==22639== by 0x25FF66: run_matching (smbtorture.c:95) ==22639== by 0x2601C5: torture_run_named_tests (smbtorture.c:143) ==22639== by 0x261E44: main (smbtorture.c:665) Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s4:torture:basic fix 'Syscall param writev(vector[...])' valgrind errorNoel Power2016-04-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | smbtorture 'base.aliases.QPATHINFO aliases.QPATHINFO aliases' results in following valgrind trace ==22469== Syscall param writev(vector[...]) points to uninitialised byte(s) ==22469== at 0xFBA2C87: writev (in /lib64/libc-2.19.so) ==22469== by 0x106CB033: writev_handler (async_sock.c:340) ==22469== by 0xF67812A: ??? (in /usr/lib64/libtevent.so.0.9.26) ==22469== by 0xF6765F6: ??? (in /usr/lib64/libtevent.so.0.9.26) ==22469== by 0xF6727FC: _tevent_loop_once (in /usr/lib64/libtevent.so.0.9.26) ==22469== by 0x5AE3400: smbcli_request_receive (rawrequest.c:416) ==22469== by 0x5AE6019: smb_raw_write_recv (rawreadwrite.c:303) ==22469== by 0x5AE63FD: smb_raw_write (rawreadwrite.c:344) ==22469== by 0x9BE50CA: smbcli_write (clireadwrite.c:118) ==22469== by 0x423431: qpathinfo_aliases (aliases.c:171) ==22469== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==22469== by 0x955368F: internal_torture_run_test (torture.c:442) ==22469== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==22469== by 0x2600A4: run_matching (smbtorture.c:110) ==22469== by 0x25FF66: run_matching (smbtorture.c:95) ==22469== by 0x25FF66: run_matching (smbtorture.c:95) ==22469== by 0x2601C5: torture_run_named_tests (smbtorture.c:143) ==22469== by 0x261E44: main (smbtorture.c:665) ==22469== Address 0x187dfb86 is 598 bytes inside a block of size 1,325 alloc'd ==22469== at 0x4C29110: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==22469== by 0xF464A73: _talloc_pooled_object (in /usr/lib64/libtalloc.so.2.1.5) ==22469== by 0xF67366D: _tevent_req_create (in /usr/lib64/libtevent.so.0.9.26) ==22469== by 0xB0D49FF: smb1cli_req_create (smbXcli_base.c:1322) ==22469== by 0x5ADFAB7: smbcli_transport_setup_subreq (clitransport.c:254) ==22469== by 0x5ADFC37: smbcli_transport_send (clitransport.c:326) ==22469== by 0x5AE33C3: smbcli_request_send (rawrequest.c:400) ==22469== by 0x5AE5FDD: smb_raw_write_send (rawreadwrite.c:289) ==22469== by 0x5AE63E6: smb_raw_write (rawreadwrite.c:343) ==22469== by 0x9BE50CA: smbcli_write (clireadwrite.c:118) ==22469== by 0x423431: qpathinfo_aliases (aliases.c:171) ==22469== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==22469== by 0x955368F: internal_torture_run_test (torture.c:442) ==22469== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==22469== by 0x2600A4: run_matching (smbtorture.c:110) ==22469== by 0x25FF66: run_matching (smbtorture.c:95) ==22469== by 0x25FF66: run_matching (smbtorture.c:95) ==22469== by 0x2601C5: torture_run_named_tests (smbtorture.c:143) ==22469== by 0x261E44: main (smbtorture.c:665) Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* CVE-2016-2115: s4:libcli/raw: pass the minprotocol to smb_raw_negotiate*()Stefan Metzmacher2016-04-121-0/+1
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=11756 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* CVE-2016-2111: s4:torture/base: don't use ntlmv2 for dos connection in ↵Stefan Metzmacher2016-04-121-2/+17
| | | | | | | | | base.samba3error BUG: https://bugzilla.samba.org/show_bug.cgi?id=11749 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org>
* s3,s4 torture/denytest: fix possible infinite loopAurelien Aptel2016-03-041-1/+1
| | | | | | | | | Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Alexander Bokovoy <ab@samba.org> Reviewed-by: David Disseldorf <ddis@suse.de> Autobuild-User(master): Alexander Bokovoy <ab@samba.org> Autobuild-Date(master): Fri Mar 4 21:23:45 CET 2016 on sn-devel-144
* s4:torture/basic: Fix misleading test case names in aliases testAnoop C S2015-12-011-2/+2
| | | | | | | | | | | | | Previously, "QFILEINFO aliases" was running qfsinfo_aliases and "QFSINFO aliases" was running qfileinfo_aliases. This change is to make sure that each of them point towards correct test cases. Signed-off-by: Anoop C S <anoopcs@redhat.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Tue Dec 1 20:44:54 CET 2015 on sn-devel-104
* Fix various spelling errorsMathieu Parent2015-11-061-1/+1
| | | | | | | | Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Fri Nov 6 13:43:45 CET 2015 on sn-devel-104
* s4:torture: fix a comment typo.Michael Adam2015-10-291-1/+1
| | | | | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Thu Oct 29 00:42:49 CET 2015 on sn-devel-104
* s4: torture: Fix double-free on error.Herb Lewis2015-09-221-1/+0
| | | | | Signed-off-by: Herb Lewis <hlewis@panasas.com> Reviewed-by: Jeremy Allison <jra@samba.org>
* lib: Remove tdb_compatVolker Lendecke2015-03-171-1/+1
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* lib: Remove tdb_open_compatVolker Lendecke2015-03-171-1/+1
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* s4:torture:basic: eliminate potential for false failures in ↵Michael Adam2014-10-031-18/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | delayed_write_update1c We want to test that the write did update the write time immediately. We check this by getting the file info in a loop for a few seconds. There are several result cases: - the server updated the write time immediately - success - the server updated the write time, but not immediately - failure - the server did not update the write time - failure The loop is only there to be able to discern between the two failure cases. The check for success is whether the first getinfo has reportet the updated write time. The potential for false failures was the additional timing check. So if the first fileinfo call just took too long (e.g. due to a busy system), this was reported as failure. This patch should eliminate interemittent autobuild failures. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: use assert in the second loop in delayed_write_update1bMichael Adam2014-10-031-11/+10
| | | | | | | We can hence replace the assert after the loop by a success torture_comment. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: add check for size after initial write in ↵Michael Adam2014-10-031-0/+3
| | | | | | | delayed_write_update1c Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: add update into past as error condition in ↵Michael Adam2014-10-031-3/+4
| | | | | | | delayed_write_update1c Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: make use of torture_assert macros in delayed_write_update1cMichael Adam2014-10-031-42/+23
| | | | | | | | This does not change the logic except for adding early returns in failure cases. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: whitespace cleanup in delayed_write_update1cMichael Adam2014-10-031-7/+7
| | | | | | | no diff with git diff -w Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: eliminate potential for false failures in ↵Michael Adam2014-10-031-19/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | delayed_write_update1b We want to test that the write did update the write time immediately. We check this by getting the file info in a loop for a few seconds. There are several result cases: - the server updated the write time immediately - success - the server updated the write time, but not immediately - failure - the server did not update the write time - failure The loop is only there to be able to discern between the two failure cases. The check for success is whether the first getinfo has reportet the updated write time. The potential for false failures was the additional timing check. So if the first fileinfo call just took too long (e.g. due to a busy system), this was reported as failure. This patch should eliminate interemittent autobuild failures. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: use assert in the second loop in delayed_write_update1bMichael Adam2014-10-031-11/+10
| | | | | | | We can hence replace the assert after the loop by a success torture_comment. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: add check for size after initial write in ↵Michael Adam2014-10-031-0/+3
| | | | | | | delayed_write_update1b Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: add update into past as error condition in ↵Michael Adam2014-10-031-3/+6
| | | | | | | delayed_write_update1b Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: make use of torture_assert macros in delayed_write_update1bMichael Adam2014-10-031-41/+24
| | | | | | | | This does not change the logic except for adding early returns in failure cases. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: whitespace cleanup in delayed_write_update1bMichael Adam2014-10-031-5/+5
| | | | | | | no diff with git diff -w Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>