summaryrefslogtreecommitdiff
path: root/source4/libnet
Commit message (Collapse)AuthorAgeFilesLines
* libnet: Add NULL checks to py_net_finddcVolker Lendecke2018-01-091-0/+10
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* schema: Make writing indices flag an enum for a new stateGarming Sam2017-11-241-2/+2
| | | | | | | | | | In schema_load_init, we find that the writing of indices is not locked in any way. This leads to race conditions. To resolve this, we need to have a new state (SCHEMA_COMPARE) which can report to the caller that we need to open a transaction to write the indices. Signed-off-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* debug: Add new debug class "drs_repl" for DRS replication processingAndrew Bartlett2017-09-071-0/+3
| | | | | | | This is used in the client and in the server Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
* replmd: Don't fail cycle if we get link for deleted object with GET_TGTTim Beale2017-08-181-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are going to end up supporting 2 different server schemes: A. the old/default behaviour of sending all the linked attributes last, at the end of the replication cycle. B. the new/Microsoft way of sending the linked attributes interleaved with the source/target objects. Normally if we're talking to a server using the old scheme-A, we won't ever use the GET_TGT flag. However, there are a couple of cases where it can happen: - A link to a new object was added during the replication cycle. - An object was deleted while the replication was in progress (and the linked attribute got queued before the object was deleted). Talking to an Samba DC running the old scheme will just cause it to start the replication cycle from scratch again, which is fairly harmless. However, there is a chance that the same thing can happen again, in which case the replication cycle will fail (because GET_TGT was already set). Even if we're using the new scheme (B), we could still potentially hit this case, as we can still queue up linked attributes between requests (group memberships can be larger than what can fit into a single replication chunk). If GET_TGT is set in the GetNcChanges request, then the local copy of the target object should always be up-to-date when we process the linked attribute. So if we still think the target object is deleted/recycled at this point, then it's safe to ignore the linked attribute (because we know our local copy is up-to-date). This logic matches the MS spec logic in ProcessLinkValue(). Not failing the replication cycle may be beneficial if we're trying to do a full-sync of a large database. Otherwise it might be time-consuming and frustrating to repeat the sync unnecessarily. Signed-off-by: Tim Beale <timbeale@catalyst.net.nz> Reviewed-by: Garming Sam <garming@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=12972
* drs: Fail replication transaction instead of dropping linksTim Beale2017-08-181-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the DRS client received a linked attribute that it couldn't resolve the target for, then it would just ignore that link and keep going. That link would then be lost forever (although a full-sync would resolve this). Instead of silently ignoring the link, fail the transaction. This *can* happen on Samba, but it is unusual. The target object and linked-attribute would need to be added while a replication is still in progress. It can also happen fairly easily when talking to a Windows DC. There are two import exceptions to this: 1). Linked attributes that span partitions. We can never guarantee that we will have received the target object, because it may be in a partition we haven't replicated yet. Samba doesn't have a great way of handling this currently, but we shouldn't fail the replication (because that breaks basic join tests). Just skip that linked attribute and hope that a subsequent full-sync will fix it. (I queried Microsoft and they said resolving cross-partition linked attributes is a implementation-specific problem to solve. GET_TGT won't resolve it) 2). When the replication involves a subset of objects, e.g. critical-only. In these cases, we don't increase the highwater-mark, so it is probably not such a dire problem if we don't add the link. In the case of critical-only, we will do a subsequent full sync which will then add the links. Signed-off-by: Tim Beale <timbeale@catalyst.net.nz> Reviewed-by: Garming Sam <garming@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=12972
* libnet: Initialize req_level in become_dc testsTim Beale2017-07-281-1/+1
| | | | | | | | | | | | | | | The net.api.become.dc tests would always pass the request into libnet_vampire_cb_store_chunk() with req_level=0, which meant that storing the chunk didn't use the correct replica_flags/exop. I noticed this problem when working on client-side support for GET_TGT. My changes relied on the critical-only request flag being passed down into replmd, but because the request flags weren't passed correctly, my changes caused the become_dc tests to fail. Signed-off-by: Tim Beale <timbeale@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* py3: Make sure to specify METH_VARARGS together with METH_KEYWORDSAlexander Bokovoy2017-07-141-1/+1
| | | | | | | | | | | | | A Python 3 bug https://bugs.python.org/issue15657 explains that one should always use METH_VARARGS|METH_KEYWORDS when defining a function rather than a lonely METH_KEYWORDS. We had only one definition like this in Samba and it was the one that affects FreeIPA when running in Python 3 mode. BUG: https://bugzilla.samba.org/show_bug.cgi?id=12905 Signed-off-by: Alexander Bokovoy <ab@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* libnet join: Fix error handling on provision_store_self_join failureGary Lockyer2017-05-251-1/+8
| | | | | | | | | | | This avoids leaving the error string NULL. Signed-off-by: Gary Lockyer <gary@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Thu May 25 06:28:02 CEST 2017 on sn-devel-144
* pynet: Add a hook to decrypt one attributeAndrew Bartlett2017-05-251-0/+74
| | | | | | | This will help with testing GetNCChanges and supplementalCredentials against Windows in Python Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* dsdb: Do not write the @INDEXLIST or @ATTRIBUTES records during schema refreshAndrew Bartlett2017-05-231-1/+1
| | | | | | | | Instead, write it once in the module init, if required, and after a modify to the schema partition is detected Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* python net: add username, oldpassword and domain to change_passwordGary Lockyer2017-03-291-7/+19
| | | | Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
* waf: disable-python - don't build samba-netIan Stakenvicius2017-03-101-1/+2
| | | | | | | | samba-net requires PROVISION, which is disabled when python isn't available. Signed-off-by: Ian Stakenvicius <axs@gentoo.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
* python: Port the samba.net module to Python 3Petr Viktorin2017-03-102-17/+27
| | | | | | Signed-off-by: Petr Viktorin <pviktori@redhat.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
* py_net: make use of pytalloc_GenericObject_steal()Stefan Metzmacher2017-02-251-3/+2
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12601 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* samba-tool drs replicate: Add --single-objectAndrew Bartlett2017-02-231-3/+3
| | | | | | | | | This may help when an object has been incorrectly locally removed from the NC or there is an urgent need to replicate a specific object (say when full replication is inoperable). Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* s4:libnet: make use of generate_random_machine_password()Stefan Metzmacher2017-02-211-1/+1
| | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12262 Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s4:libnet: s/highestCommitedUSN/highestCommittedUSNStefan Metzmacher2017-02-081-1/+1
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* python-libnet: Use new NTSTATUSError, WERRORError and DsExtendedError exceptionsAndrew Bartlett2016-11-041-14/+102
| | | | | | | | | | | This will allow callers to catch specific errors rather than RuntimeException As this slightly changes the exception, the timecmd test must be updated. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> BUG: https://bugzilla.samba.org/show_bug.cgi?id=12398
* dsdb: Catch errors in extended operations (like allocating a RID Set)Andrew Bartlett2016-11-041-2/+19
| | | | | | | | There are cases where allocating a RID Set can reasonably fail. Catch those nicely. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> BUG: https://bugzilla.samba.org/show_bug.cgi?id=12398
* dsdb: Rework DSDB code to use WERRORAndrew Bartlett2016-11-044-70/+89
| | | | | | | | | | The WERROR codes are more descriptive for DSDB issues, and almost all the code was converting from WERROR to NTSTATUS. This will allow us to better catch specific errors like WERR_DS_DRA_MISSING_PARENT Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> BUG: https://bugzilla.samba.org/show_bug.cgi?id=12398
* krb5_wrap: Rename smb_krb5_open_keytab_relative()Andreas Schneider2016-08-311-4/+4
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:dsdb/repl: set working_schema->resolving_in_progress during schema creationStefan Metzmacher2016-08-111-0/+5
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12128 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s4:dsdb/repl: Improve memory handling in replicated schema codeAndrew Bartlett2016-08-111-1/+1
| | | | | | | | | This attempts to make it clear what memory is short term and what memory is long term BUG: https://bugzilla.samba.org/show_bug.cgi?id=12115 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* valgrind: Avoid a warning about uninitialized memoryGarming Sam2016-07-281-1/+1
| | | | | Signed-off-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* libnet: Fix CID 1362934: CHECKED_RETURNVolker Lendecke2016-06-281-1/+6
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* samba-tool domain join: Set drsuapi.DRSUAPI_DRS_GET_ANC during initial replAndrew Bartlett2016-06-061-4/+7
| | | | | | | | | | This is needed so that we get parents before children. We need this to ensure that we always know the correct parent for a new child object, rather than just trusting the DN string Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* repl: Pass in the full partition DN to dsdb_replicated_objects_convert()Andrew Bartlett2016-06-061-2/+26
| | | | | | | | When we were processing an EXOP, we would pass in a DN specific to that operation, but this stopped repl_meta_data from finding the parent object Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* s4:libnet: fix 'Syscall param writev(vector[...])' valgrind errorNoel Power2016-04-251-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | running smbtorture rpc.dfs.netdfs.StdRoot yields the following valgrind trace ==18861== Syscall param writev(vector[...]) points to uninitialised byte(s) ==18861== at 0xFBA2C87: writev (in /lib64/libc-2.19.so) ==18861== by 0x106CB033: writev_handler (async_sock.c:340) ==18861== by 0xF67812A: ??? (in /usr/lib64/libtevent.so.0.9.26) ==18861== by 0xF6765F6: ??? (in /usr/lib64/libtevent.so.0.9.26) ==18861== by 0xF6727FC: _tevent_loop_once (in /usr/lib64/libtevent.so.0.9.26) ==18861== by 0xF673ACE: tevent_req_poll (in /usr/lib64/libtevent.so.0.9.26) ==18861== by 0x5D19325: tevent_req_poll_ntstatus (tevent_ntstatus.c:109) ==18861== by 0x88B2E0D: dcerpc_binding_handle_call (binding_handle.c:556) ==18861== by 0xBC6D0D2: dcerpc_srvsvc_NetShareDel_r (ndr_srvsvc_c.c:4272) ==18861== by 0x9786C0C: libnet_DelShare (libnet_share.c:195) ==18861== by 0x2E0174: test_NetShareDel (dfs.c:103) ==18861== by 0x2E126F: test_cleanup_stdroot (dfs.c:488) ==18861== Address 0x18869b46 is 598 bytes inside a block of size 1,325 alloc'd ==18861== at 0x4C29110: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==18861== by 0xF464A73: _talloc_pooled_object (in /usr/lib64/libtalloc.so.2.1.5) ==18861== by 0xF67366D: _tevent_req_create (in /usr/lib64/libtevent.so.0.9.26) ==18861== by 0xB0D49FF: smb1cli_req_create (smbXcli_base.c:1322) ==18861== by 0xB0E1E6D: smb1cli_trans_send (smb1cli_trans.c:512) ==18861== by 0xB0ED47D: tstream_smbXcli_np_readv_trans_start (tstream_smbXcli_np.c:901) ==18861== by 0xB0EC847: tstream_smbXcli_np_writev_write_next (tstream_smbXcli_np.c:578) ==18861== by 0xB0EC4D7: tstream_smbXcli_np_writev_send (tstream_smbXcli_np.c:505) ==18861== by 0xC259DFA: tstream_writev_send (tsocket.c:695) ==18861== by 0xC25AD64: tstream_writev_queue_trigger (tsocket_helpers.c:513) ==18861== by 0xF673023: tevent_common_loop_immediate (in /usr/lib64/libtevent.so.0.9.26) ==18861== by 0xF677EED: ??? (in /usr/lib64/libtevent.so.0.9.26) ==18861== Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s4/libnet: fix exporting to keytab by SPNRalph Boehme2016-04-251-16/+23
| | | | | | | | | | | | | | Fix a regression introduced by 5c5d586d3ebd40 that broke exporting service principals by their spn with samba-tool exportkeytab --principal=<SPN>. Iterating with samba_kdc_nextkey() only returns UPNs, so this can't work with SPNs. If we want to search for a specific SPN, we have to use samba_kdc_fetch(). Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s4-libnet: Link dckeytab.so correctly when is AD DC enabledAndreas Schneider2016-03-242-3/+2
| | | | | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Thu Mar 24 15:12:21 CET 2016 on sn-devel-144
* s4-libnet: only build python-dckeytab module for Heimdal in AD DC modeAlexander Bokovoy2016-03-231-1/+1
| | | | | | | | Signed-off-by: Alexander Bokovoy <ab@samba.org> Reviewed-by: Uri Simchoni <uri@samba.org> Autobuild-User(master): Uri Simchoni <uri@samba.org> Autobuild-Date(master): Wed Mar 23 23:43:51 CET 2016 on sn-devel-144
* build: mark explicit dependencies on pytalloc-utilGarming Sam2016-03-151-1/+1
| | | | | | | | | | | | | All subsystems that include pytalloc.h need to link against pytalloc-util. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11789 Signed-off-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Garming Sam <garming@samba.org> Autobuild-Date(master): Tue Mar 15 07:08:16 CET 2016 on sn-devel-144
* s4-libnet: Implement export_keytab without HDBAndreas Schneider2016-03-101-33/+159
| | | | | | | | | | This is used by 'samba-tool domain exportkeytab'. This loads the HDB Samba backend thus needs access to samdb. To avoid using heimdal specific code here, we could talk to samdb directly and write a keytab file. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* repl: Use DSDB_REPL_FLAG_PRIORITISE_INCOMING in samba-tool drs replicate --localAndrew Bartlett2015-10-261-0/+4
| | | | | | | Previously this would only be set when we did server-to-server replication Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* repl: Give an error if we get a secret when not expecting oneAndrew Bartlett2015-10-261-1/+6
| | | | | | | | | We should never get a secret from a server when we specify DRSUAPI_DRS_SPECIAL_SECRET_PROCESSING This asserts that this is the case. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* samba-tool: Remove vampire subcommand and now unused libnet_Vampire()Andrew Bartlett2015-10-262-341/+0
| | | | | | | This has been deprecated for a long time now Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* s4:libnet: make use of dcerpc_secondary_auth_connection_send/recv()Stefan Metzmacher2015-07-072-13/+7
| | | | | | | This avoid the bogus usage of dcerpc_pipe_auth(). Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4-libnet: only build python_dckeytab when heimdal is available.Günther Deschner2015-03-201-1/+1
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s4:py_net: make domain and address fully optional to py_net_finddcStefan Metzmacher2015-03-121-1/+1
| | | | | | | E.g. address=None is now also possible. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* Fix the O3 developer buildVolker Lendecke2015-03-031-1/+1
| | | | | | | | | | Different gcc versions complain at different places Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Tue Mar 3 13:14:53 CET 2015 on sn-devel-104
* s4-libnet: make it possible to join "off-site".Günther Deschner2014-10-241-1/+2
| | | | | | | | | | Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Günther Deschner <gd@samba.org> Autobuild-Date(master): Fri Oct 24 13:50:30 CEST 2014 on sn-devel-104
* py_net: Fix typo in change_password docstring, and indentation inJelmer Vernooij2014-10-141-4/+2
| | | | | | | | set_password docstring. Change-Id: I93e9ed79ee43233fc3c1bb69d8eb0a5c6e0e3940 Signed-off-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:librpc: use authenticated epmapping for ncacn_httpStefan Metzmacher2014-09-231-2/+8
| | | | | | | | | | | | We need to authenticate against the RpcProxy. In future we could have a way to specify alternative credentials for the RpcProxy and HttpProxy. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Tue Sep 23 01:34:05 CEST 2014 on sn-devel-104
* Order switch statementsSamuel Cabrero2014-07-072-18/+18
| | | | | | | | | Signed-off-by: Samuel Cabrero <scabrero@zentyal.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Kamen Mazdrashki <kamenim@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Mon Jul 7 07:47:44 CEST 2014 on sn-devel-104
* idl:drsuapi: Manage all possible lengths of drsuapi_DsBindInfoSamuel Cabrero2014-07-072-2/+48
| | | | | | | Signed-off-by: Samuel Cabrero <scabrero@zentyal.com> Reviewed-by: Kamen Mazdrashki <kamenim@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Kamen Mazdrashki <kamenim@samba.org>
* dsdb: Do not store a struct ldb_dn in struct schema_dataAndrew Bartlett2014-06-111-5/+0
| | | | | | | | | | | | The issue is that the DN contains a pointer to the ldb it belongs to, and if this is not kept around long enough, we might reference memory after it is de-allocated. Andrew Bartlett Change-Id: I040a6c37a3164b3309f370e32e598dd56b1a1bbb Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* Fix an empty if statement.Jose A. Rivera2014-05-051-1/+1
| | | | | | | | | | Primarily following the precedent set by other uses of composite_is_ok(), but also making sure nothing tries to use c after this point if it is in fact not ok. Signed-off-by: Jose A. Rivera <jarrpa@redhat.com> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* kerberos: Remove un-used event context argument from smb_krb5_init_context()Andrew Bartlett2014-04-281-1/+1
| | | | | | | | | | | | | | | | | The event context here was only specified in the server or admin-tool context, which does not do network communication, so this only caused a talloc_reference() and never any useful result. The actual network communication code sets an event context directly before making the network call. Andrew Bartlett Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Mon Apr 28 02:24:57 CEST 2014 on sn-devel-104
* Remove a number of NT_STATUS_HAVE_NO_MEMORY_AND_FREE macros from the codebase.Garming Sam2014-03-051-3/+12
| | | | | | | | | | | Following the current coding guidelines, it is considered bad practice to return from within a macro and change control flow as they look like normal function calls. Change-Id: I133eb5a699757ae57b87d3bd3ebbcf5b556b0268 Signed-off-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s4:libnet: add const to libnet_JoinDomain->out.samr_bindingStefan Metzmacher2014-02-132-2/+1
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>