summaryrefslogtreecommitdiff
path: root/source4/client
Commit message (Collapse)AuthorAgeFilesLines
* s4/cifsdd: don't ignore unknown optionsRalph Boehme2021-09-101-1/+7
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14828 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s4/smbclient: don't ignore unknown optionsRalph Boehme2021-09-101-0/+5
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14828 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s4:client: Migrate cifsdd to new cmdline option parserAndreas Schneider2021-06-162-13/+42
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* testprogs: Use new kerberos options for smbclient(4) testsAndreas Schneider2021-06-161-1/+1
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:client: Migrate smbclient4 to new cmdline option parserAndreas Schneider2021-06-161-18/+42
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:client: Use a creds helper variableAndreas Schneider2021-06-161-5/+10
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:client:tests: create temporary files under $PREFIX/SELFTEST_TMPDIRStefan Metzmacher2021-04-132-23/+25
| | | | | | | Tests should not create files in the build nor the source directory! Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* lib: Remove init_names()Volker Lendecke2021-03-161-2/+0
| | | | | | | | is_myname() looks at lp_* directly, nmbd maintains its own list: We don't need the baroque loadparm handler anymore. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* lib/util: remove extra safe_string.h fileMatthew DeVore2020-08-281-0/+2
| | | | | | | | | | | | | | | | | | lib/util/safe_string.h is similar to source3/include/safe_string.h, but the former has fewer checks. It is missing bcopy, strcasecmp, and strncasecmp. Add the missing elements to lib/util/safe_string.h remove the other safe_string.h which is in the source3-specific path. To accomodate existing uses of str(n?)casecmp, add #undef lines to source files where they are used. Signed-off-by: Matthew DeVore <matvore@google.com> Reviewed-by: David Mulder <dmulder@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri Aug 28 02:18:40 UTC 2020 on sn-devel-184
* s4:client: Remove code inside #ifdef NEXT2Christof Schmitt2020-07-161-5/+0
| | | | | | | This is dead code, the define is never set. Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* Fix clang 9 missing-field-initializer warningsGary Lockyer2020-05-081-1/+1
| | | | Signed-off-by: Gary Lockyer <gary@catalyst.net.nz> Reviewed-by: Andreas Schneider <asn@samba.org>
* smbclient4: Remove unused codeVolker Lendecke2020-02-101-809/+0
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Mon Feb 10 19:26:37 UTC 2020 on sn-devel-184
* s4: free popt context in clientSwen Schillig2019-08-221-0/+2
| | | | | | | | If done with popt context it should be free'd. Signed-off-by: Swen Schillig <swen@linux.ibm.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s4:cifsdd: Use C99 initializers for cifsdd argdefAndreas Schneider2019-01-281-11/+55
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
* s4:client: Use C99 initializer for poptOption in cifsddAndreas Schneider2019-01-281-5/+21
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
* s4:client: Use C99 initializer for poptOption in clientAndreas Schneider2019-01-281-9/+71
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
* s4:client: Fix size types and loopAndreas Schneider2018-04-031-5/+3
| | | | | | | This fixes compilation with -Wstrict-overflow=2. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s4:client: Fix size typesAndreas Schneider2018-03-201-4/+4
| | | | | | | This fixes compilation with -Wstrict-overflow=2 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4: cifsdd: Allocate the event context off NULL, not talloc_autofree_context().Jeremy Allison2017-05-131-2/+8
| | | | | | | Ensure it's freed on exit paths. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s4: client: Allocate event context off struct smbclient_context *, not ↵Jeremy Allison2017-05-131-1/+1
| | | | | | | talloc_autofree_context(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s4: popt: Global replace of cmdline_credentials -> ↵Jeremy Allison2017-05-112-10/+17
| | | | | | | | | | | popt_get_cmdline_credentials(). Add one use of popt_set_cmdline_credentials(). Fix 80 column limits when cmdline_credentials changes to popt_get_cmdline_credentials(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* lib: Fix "is_case_sensitive" in "ms_fnmatch_protocol"' callersVolker Lendecke2017-02-151-16/+6
| | | | | | | | | | | | | In the optimization in f969be54417 I got the boolean flag "is_case_sensitive" wrong. The behaviour was case *insensitive*, so all the flags should have been "false", keeping the old behaviour. While there, simplify "mask_match" in source4 client.c Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Wed Feb 15 11:40:32 CET 2017 on sn-devel-144
* lib: Add "is_case_sensitive" to ms_fnmatch_protocolVolker Lendecke2017-01-221-3/+5
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* smbclient4: xfile->stdioVolker Lendecke2016-12-111-15/+15
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* smbclient: fix string formatting in print commandDouglas Bagnall2016-12-011-6/+17
| | | | | | | | | | | | At one time, the variables lname and rname were char arrays, but now they are pointers. When they were arrays, sizeof(rname) was the length of the array, but now it gives the size of the pointer which is not what we want. In the case where the filename is -, rname was alloced as size 1, which could never fit the name it wanted to have contain ("stdin-<pid>"). Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Jeremy Allison <jra@samba.org>
* s4:client: fix O3 error unused result of of chdir and systemMichael Adam2016-05-131-5/+27
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Christian Ambach <ambi@samba.org>
* s4/client/cifsdd.c: typoAurelien Aptel2016-03-101-1/+1
| | | | | | Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Uri Simchoni <uri@samba.org>
* s4-client: Fix cifsdd arg parsing for skipAndreas Schneider2016-02-181-1/+1
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=11730 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4/client: add FS_SECTOR_SIZE_INFORMATION query supportDavid Disseldorp2015-03-181-0/+17
| | | | | Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s4:client: fix some compiler warningsStefan Metzmacher2014-02-131-7/+10
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* Make sure to set umask() before calling mkstemp().Andreas Schneider2013-03-061-0/+3
| | | | | | | Reviewed-by: David Disseldorp <ddiss@samba.org> Autobuild-User(master): David Disseldorp <ddiss@samba.org> Autobuild-Date(master): Wed Mar 6 01:16:34 CET 2013 on sn-devel-104
* s4-client: Make sure entry is a valid string.Andreas Schneider2013-03-051-2/+8
| | | | Reviewed-by: David Disseldorp <ddiss@samba.org>
* s4-cifsdd: Don't leak memory.Andreas Schneider2013-02-221-0/+6
| | | | Reviewed-by: Alexander Bokovoy <ab@samba.org>
* s4-client: Don't leak memory.Andreas Schneider2013-02-221-0/+2
| | | | Reviewed-by: Alexander Bokovoy <ab@samba.org>
* s4-client: Don't leak file descriptor.Andreas Schneider2013-02-221-0/+7
| | | | Reviewed-by: Alexander Bokovoy <ab@samba.org>
* s4-client: Don't leak resource handle.Andreas Schneider2013-02-221-0/+2
| | | | Reviewed-by: Alexander Bokovoy <ab@samba.org>
* s4-client: Check return codes in do_connect().Andreas Schneider2012-12-211-2/+18
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s4-client: Make sure we have a valid count if we goto cleanup.Andreas Schneider2012-12-121-1/+2
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s4:selftest: change the blackbox.smbclient test to use binary mapping for ↵Michael Adam2012-05-311-5/+3
| | | | smbclient
* selftest: Remove unused support for --exeextAndrew Bartlett2012-02-012-2/+2
|
* s4:libcli: move smbcli_transport_establish() logic into smbcli_socket_connect()Stefan Metzmacher2011-11-301-8/+10
| | | | metze
* s4: add some missing header dependencies.Günther Deschner2011-11-031-0/+2
| | | | Guenther
* s4-client: added close command in smbclientAndrew Tridgell2011-09-191-4/+62
| | | | | | | | | | this matches the existing open command, and also gives you error codes on both open and close useful for testing share mode locking Autobuild-User: Andrew Tridgell <tridge@samba.org> Autobuild-Date: Mon Sep 19 23:59:28 CEST 2011 on sn-devel-104
* waf: restore libsmbclient handling.Günther Deschner2011-09-151-13/+0
| | | | | | | | | | | | This is a temporary solution to get libsmbclient installed properly as a library (including symlinks and proper symbols). I was not able to make the old internal library name 'libsmb/smbclient' work together with "realname" and/or "link_name". Maybe one of the waf gurus has more ideas here. Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Thu Sep 15 15:31:59 CEST 2011 on sn-devel-104
* cli-raw: Add public libsmbclient-raw library.Jelmer Vernooij2011-08-181-1/+1
|
* cli_raw: Make name lowercase.Jelmer Vernooij2011-07-231-1/+1
| | | | | Autobuild-User: Jelmer Vernooij <jelmer@samba.org> Autobuild-Date: Sat Jul 23 23:20:51 CEST 2011 on sn-devel-104
* s4-modules Remove lp_ctx from init functions that no longer need itAndrew Bartlett2011-06-062-2/+2
| | | | | | | | Now that we don't allow the smb.conf to change the modules dir, many functions that simply load modules or initialise a subsytem that may load modules no longer need an lp_ctx. Andrew Bartlett
* lib/util Rename ms_fnmatch() to ms_fnmatch_protocol() to avoid dup symbolAndrew Bartlett2011-05-061-2/+2
| | | | | | | This verison of the function takes a protcol as argument to determine matching rules. Andrew Bartlett
* Fix simple uses of safe_strcpy -> strlcpy. Easy ones where we just remove -1.Jeremy Allison2011-05-041-2/+2
|
* Remove strlower_m() and strupper_m() from source4 and common code.Andrew Bartlett2011-05-031-6/+8
| | | | | | | | | This function is problematic because a string may expand in size when changed into upper or lower case. This will then push characters off the end of the string in the s3 implementation, or panic in the former s4 implementation. Andrew Bartlett