summaryrefslogtreecommitdiff
path: root/source3
Commit message (Collapse)AuthorAgeFilesLines
* selftest: s3: add a test for spnego downgrade from krb5 to ntlmIsaac Boukris2019-10-122-0/+50
| | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106 Signed-off-by: Isaac Boukris <iboukris@redhat.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:libsmb: Do not check the SPNEGO neg token for KRB5Andreas Schneider2019-10-121-50/+0
| | | | | | | | | | | | | The list is not protected and this could be a downgrade attack. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106 Pair-Programmed-With: Isaac Boukris <iboukris@redhat.com> Reviewed-by: Andreas Schneider <asn@samba.org> Signed-off-by: Andreas Schneider <asn@samba.org> Signed-off-by: Isaac Boukris <iboukris@redhat.com> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* wscript: split function check to one per line and sort alphabeticallyRalph Boehme2019-10-101-15/+62
| | | | | | | | Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Thu Oct 10 20:13:25 UTC 2019 on sn-devel-184
* wscript: remove all checks for _FUNC and __FUNCRalph Boehme2019-10-101-21/+18
| | | | | | | Those where historic artifacts not needed anymore. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s3: VFS: Complete the removal of SMB_VFS_RMDIR()Jeremy Allison2019-10-106-39/+2
| | | | | | | | | | All users now use SMB_VFS_UNLINKAT(..., AT_REMOVEDIR). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Thu Oct 10 07:26:43 UTC 2019 on sn-devel-184
* s3: VFS: vfs_time_audit: Remove rmdir_fn(). No longer used.Jeremy Allison2019-10-101-19/+0
| | | | | | | | NB, this will now fail smb_vfs_assert_all_fns() until we remove the rmdir_fn() from the VFS definitions. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_time_audit: Remove rmdir_fn(). No longer used.Jeremy Allison2019-10-101-22/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_syncops: Remove rmdir_fn(). No longer used.Jeremy Allison2019-10-101-7/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_streams_depot: Remove rmdir_fn(). No longer used.Jeremy Allison2019-10-101-9/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_snapper: Remove rmdir_fn(). No longer used.Jeremy Allison2019-10-101-17/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_shadow_copy2: Remove rmdir_fn(). No longer used.Jeremy Allison2019-10-101-20/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_posix_eadb: Remove rmdir_fn(). No longer used.Jeremy Allison2019-10-101-12/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_media_harmony: Remove rmdir_fn(). No longer used.Jeremy Allison2019-10-101-36/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_glusterfs: Remove rmdir_fn(). No longer used.Jeremy Allison2019-10-101-14/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_extd_audit: Remove rmdir_fn(). No longer used.Jeremy Allison2019-10-101-22/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_ceph_snapshots: Remove rmdir_fn(). No longer used.Jeremy Allison2019-10-101-21/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_ceph: Remove rmdir_fn(). No longer used.Jeremy Allison2019-10-101-12/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_catia: Remove rmdir_fn(). No longer used.Jeremy Allison2019-10-101-35/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_cap: Remove rmdir_fn(). No longer used.Jeremy Allison2019-10-101-26/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_audit: Remove rmdir_fn(). No longer used.Jeremy Allison2019-10-101-16/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_acl_xattr: Remove rmdir_fn(). No longer used.Jeremy Allison2019-10-101-9/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_acl_tdb: Remove rmdir_fn(). No longer used.Jeremy Allison2019-10-101-29/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_fruit: Remove rmdir_fn. No longer used.Jeremy Allison2019-10-101-9/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_unityed_media: Remove rmdir_fn. No longer used.Jeremy Allison2019-10-101-29/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_xattr_tdb: Remove rmdir_fn. No longer used.Jeremy Allison2019-10-101-41/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: smbd: Change rmdir_internals() to call SMB_VFS_UNLINKAT() in rmdir cases.Jeremy Allison2019-10-101-4/+14
| | | | | | | | | Use conn->cwd_fsp as current fsp. No logic change for now. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: smbd: Change recursive_rmdir() to call SMB_VFS_UNLINKAT() in rmdir case.Jeremy Allison2019-10-101-1/+5
| | | | | | | | | Use conn->cwd_fsp as current fsp. No logic change for now. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: cmd_vfs: Change cmd_pathfunc() to call SMB_VFS_UNLINKAT() in rmdir case.Jeremy Allison2019-10-101-1/+4
| | | | | | | | | Use conn->cwd_fsp as current fsp. No logic change for now. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_fruit: Change fruit_rmdir_internal() to call UNLINKAT instead ↵Jeremy Allison2019-10-101-1/+4
| | | | | | | of RMDIR. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_streams_depot: Change RMDIR -> UNLINKAT inside ↵Jeremy Allison2019-10-101-1/+4
| | | | | | | | | streams_depot_unlink_internal(). No logic change. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_streams_depot: Change RMDIR -> UNLINKAT inside stream_dir().Jeremy Allison2019-10-101-1/+4
| | | | | | | No logic change. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_streams_depot: Add a dirfsp parameter to ↵Jeremy Allison2019-10-101-2/+6
| | | | | | | | | streams_depot_rmdir_internal(). Not yet used. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_streams_depot: Rename streams_depot_rmdir() to ↵Jeremy Allison2019-10-101-4/+10
| | | | | | | | | | | | streams_depot_rmdir_internal(). Make rmdir_fn() a wrapper function. This will allow us to add the dirfsp parameter. Fix DEBUG statement so it doesn't print the wrong function name. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_posix_eadb: Convert streams_depot_rmdir_internal() to call ↵Jeremy Allison2019-10-101-2/+8
| | | | | | | UNLINKAT() instead of RMDIR(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_posix_eadb: Convert posix_eadb_rmdir_internal() to call ↵Jeremy Allison2019-10-101-1/+4
| | | | | | | UNLINKAT() instead of RMDIR(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_posix_eadb: Add a dirfsp parameter to posix_eadb_rmdir_internal().Jeremy Allison2019-10-101-1/+5
| | | | | | | Not yet used. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_posix_eadb: Rename posix_eadb_rmdir() to ↵Jeremy Allison2019-10-101-2/+12
| | | | | | | | | | posix_eadb_rmdir_internal(). Make rmdir_fn() a wrapper function. This will allow us to add the dirfsp parameter. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_acl_common: Convert rmdir_acl_common() to use UNLINKAT instead ↵Jeremy Allison2019-10-101-1/+4
| | | | | | | of RMDIR. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: Change rmdir_acl_common() to take a files_struct *dirfsp pointer.Jeremy Allison2019-10-104-6/+16
| | | | | | | | | Pass in the passed dirfsp if available, else handle->conn->cwd_fsp. No logic changes. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_acl_common: Change acl_common_remove_object() to use UNLINKAT ↵Jeremy Allison2019-10-101-1/+4
| | | | | | | instead of RMDIR. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_acl_xattr. Wrap rmdir_acl_common() by acl_xattr_rmdir() so we ↵Jeremy Allison2019-10-101-1/+7
| | | | | | | | | | don't call it directly. This will allow adding the extra dirfsp parameter to rmdir_acl_common(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* smbd: Fix an uninitalized variableVolker Lendecke2019-10-101-2/+1
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Oct 10 01:04:33 UTC 2019 on sn-devel-184
* mdssvc.idl: pass policy_handle as pointerRalph Boehme2019-10-093-18/+18
| | | | | | | | | | | | No change in behaviour, this just changes all functions to take the policy_handle argument as pointer instead of passing it by value. This is how all other IDLs pass it. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Noel Power <noel.power@suse.com> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Wed Oct 9 15:52:55 UTC 2019 on sn-devel-184
* s3:mdssvc: fix service startup in deamon modeRalph Boehme2019-10-092-6/+7
| | | | | | | | | | | | | | | | | | | | | Changes: * Don't initialize the RPC service by calling setup_rpc_module() in the parent mdssd. This is not needed in the parent, only in the worker childs. * In the worker childs call setup_rpc_module() instead of init_rpc_module() which ensures rpc_mdssvc_init() is called with the mdssvc callback which is needed to initialize mdssvc via mdssvc_init_cb() -> init_service_mdssvc() * Finally rpc_setup_mdssvc() is adjusted to be a noop if mdssvc is configured to as external and when called by the main parent smbd via dcesrv_ep_setup() -> setup_rpc_modules() I've manually tested all 4 combinations of external=yes|no X module=yes|no with the new mdfind command. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Noel Power <noel.power@suse.com>
* s3:mdssvc: use a helper variable for the service typeRalph Boehme2019-10-091-2/+3
| | | | | | | No change in behaviour. Simplifies a subsequent logical change. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Noel Power <noel.power@suse.com>
* mdssd: fix a debug messageRalph Boehme2019-10-091-1/+1
| | | | | Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Noel Power <noel.power@suse.com>
* s3: rpc_server: enable mdssvc by defaultRalph Boehme2019-10-091-1/+1
| | | | | | | | Now that mdssvc is built by default and also tested in CI, enable it by default, running as embedded service. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Noel Power <noel.power@suse.com>
* s3:utils: add mdfindRalph Boehme2019-10-092-0/+304
| | | | | | | | A small command line tool to run macOS Spotlight searches against an SMB server that runs the Spotlight mdssvc RPC service, including macOS and Samba. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Noel Power <noel.power@suse.com>
* s3:mdssvc: add unit tests for the Spotlight to Elasticsearch parserRalph Boehme2019-10-092-0/+251
| | | | | Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Noel Power <noel.power@suse.com>
* s3:mdssvc: add Elasticsearch backendRalph Boehme2019-10-0912-2/+2258
| | | | | Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Noel Power <noel.power@suse.com>