summaryrefslogtreecommitdiff
path: root/source3
Commit message (Collapse)AuthorAgeFilesLines
* smbd: fix build with FAM supportRalph Boehme2016-02-141-0/+1
| | | | | | | | | | | | Add missing define of HAVE_FAM when FAM is detected. Bug: https://bugzilla.samba.org/show_bug.cgi?id=11733 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Sun Feb 14 13:50:56 CET 2016 on sn-devel-144
* smbd: fix build with FAM supportRalph Boehme2016-02-142-2/+2
| | | | | | | | | | | Rename _fam_watch() to fam_watch(). I don't see a reason why this should be prefixed with an underscore. It's also inline with the corresponding inotify function inotify_watch(). Bug: https://bugzilla.samba.org/show_bug.cgi?id=11733 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* smbd: Simplify chroot option in smbdAndreas Schneider2016-02-131-8/+15
| | | | | | | | | | | | | | | | rpmlint has a check for this and prefers to call chdir() before chroot(). If not it will complain with missing-call-to-chdir-with-chroot. The old code equivalent secure. See http://unixwiz.net/techtips/chroot-practices.html This removes several unneeded talloc_tos() calls. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Sat Feb 13 03:50:54 CET 2016 on sn-devel-144
* s3-waf: Install smbspool_krb5_wrapper in LIBEXECDIRAndreas Schneider2016-02-131-0/+1
| | | | | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Martin Schwenke <martin@meltin.net> Autobuild-User(master): Martin Schwenke <martins@samba.org> Autobuild-Date(master): Sat Feb 13 00:41:33 CET 2016 on sn-devel-144
* s3:winbindd/idmap_autorid_tdb fix a compiler warningChristian Ambach2016-02-121-1/+1
| | | | | | | | | | about a potentially uninitialized variable Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Fri Feb 12 12:07:07 CET 2016 on sn-devel-144
* s3:vfs_fruit fix a compiler warningChristian Ambach2016-02-121-1/+1
| | | | | | | about a potentially uninitialized variable Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3: smbd: posix_acls: Fix check for setting u:g:o entry on a filesystem with ↵Jeremy Allison2016-02-111-1/+38
| | | | | | | | | | | | | | | | | | | | no ACL support. Since 4.0.x we add 2 additional ACE entries, one SMB_ACL_USER and SMB_ACL_GROUP to match the existing SMB_ACL_USER_OBJ and SMB_ACL_GROUP_OBJ entries. The two additional entries break the simple "must have 3 entries" check done inside convert_canon_ace_to_posix_perms(). Replace this with a more complete test. Problem and initial fix provided by <tcleamy@ucdavis.edu> BUG: https://bugzilla.samba.org/show_bug.cgi?id=10489 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Uri Simchoni <uri@samba.org> Autobuild-User(master): Uri Simchoni <uri@samba.org> Autobuild-Date(master): Thu Feb 11 11:14:53 CET 2016 on sn-devel-144
* s3:dbwrap: add dbwrap_tdb_require_mutexes:*= optionStefan Metzmacher2016-02-081-0/+10
| | | | | | | | This is similar to dbwrap_tdb_mutexes:*= (which is autodetected by default), but dbwrap_tdb_require_mutexes is off by default. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* tldap: Add a missing TALLOC_FREE(frame)Volker Lendecke2016-02-081-1/+1
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* dlist: remove unneeded argument from DLIST_DEMOTE()Michael Adam2016-02-062-5/+5
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* dlist: remove unneeded type argument from DLIST_ADD_END()Michael Adam2016-02-0626-46/+43
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* pdb: Fix segfault in pdb_ldap for missing gecosLuca Olivetti2016-02-051-3/+3
| | | | | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=11530 Signed-off-by: Luca Olivetti <luca@wetron.es> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Fri Feb 5 16:47:00 CET 2016 on sn-devel-144
* s3:utils/smbget set default blocksizeChristian Ambach2016-02-051-1/+1
| | | | | | | | | | | this got lost in the recent refactorings and causes problems when smbget attempts to use a zero byte read buffer Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Fri Feb 5 12:10:16 CET 2016 on sn-devel-144
* s3:utils/smbget add a error message on allocation errorChristian Ambach2016-02-051-0/+2
| | | | | Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* s3:smbd:open: Skip redundant call to file_set_dosmode when creating a new file.Jose A. Rivera2016-02-051-2/+2
| | | | | | | | | Signed-off-by: Jose A. Rivera <jarrpa@samba.org> Pair-programmed-with: Ira Cooper <ira@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri Feb 5 04:37:43 CET 2016 on sn-devel-144
* loadparm: Fix memory leak issue.Hemanth Thummala2016-02-041-1/+1
| | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=11708 Signed-off-by: Hemanth Thummala <hemanth.thummala@nutanix.com> Reviewed-by: Alexander Bokovoy <ab@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Thu Feb 4 12:39:14 CET 2016 on sn-devel-144
* samba3.blackbox.smbclient.forceuser_validusers: Add new test for force user ↵Robin Hack2016-02-042-0/+60
| | | | | | | | | | | | | | | | | | | | | | | | option. Test covers commit cf0934caf282f4ade8c8a701b0e40b68a2f17ace BUG: https://bugzilla.samba.org/show_bug.cgi?id=9878 RH BUG: https://bugzilla.redhat.com/show_bug.cgi?id=1077651 How to test: $ make -j test TESTS="samba3.blackbox.smbclient.forceuser_validusers" RESULD: Should PASS $ git revert cf0934caf282f4ade8c8a701b0e40b68a2f17ace $ make -j test TESTS="samba3.blackbox.smbclient.forceuser_validusers" RESULT: Should FAIL Signed-off-by: Robin Hack <rhack@redhat.com> Reviewed-by: Uri Simchoni <uri@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Uri Simchoni <uri@samba.org> Autobuild-Date(master): Thu Feb 4 03:44:42 CET 2016 on sn-devel-144
* gencache: Remove unused definesChristof Schmitt2016-02-031-4/+0
| | | | | Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* tldap: Parse a search entry only if it is oneVolker Lendecke2016-02-031-1/+6
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org> Autobuild-User(master): Günther Deschner <gd@samba.org> Autobuild-Date(master): Wed Feb 3 18:12:44 CET 2016 on sn-devel-144
* tldap: Make tldap_search use tldap_search_allVolker Lendecke2016-02-034-99/+30
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* tldap: Add tldap_pending_reqs()Volker Lendecke2016-02-031-2/+7
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* tldap: Add tldap_search_allVolker Lendecke2016-02-032-0/+105
| | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> TLDAPRC Reviewed-by: Guenther Deschner <gd@samba.org>
* tldap: Avoid a "ret == false"Volker Lendecke2016-02-031-3/+3
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* spnego: Correctly check asn1_tag_remaining retvalVolker Lendecke2016-02-031-4/+4
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* libads: Factor out ldap_schema_oids.hVolker Lendecke2016-02-033-25/+50
| | | | | | | Make the oids accessible without having to include ADS_STRUCT&friends Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* smbtorture3: Convert the tldap caller to TLDAPRCVolker Lendecke2016-02-031-6/+7
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* lib: Introduce TLDAPRCVolker Lendecke2016-02-034-490/+433
| | | | | | | Make ldap return codes type safe Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* tldap: Parse the sasl output blobVolker Lendecke2016-02-032-17/+75
| | | | Reviewed-by: Guenther Deschner <gd@samba.org>
* tldap: Slightly simplify tldap_search_cbVolker Lendecke2016-02-031-4/+3
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* tldap: Mark server down if read failedVolker Lendecke2016-02-031-0/+1
| | | | | | | This matches tldap_msg_sent Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* tldap: Add some required includesVolker Lendecke2016-02-031-0/+1
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* smbd: Fix CID 1351215 Improper use of negative valueVolker Lendecke2016-02-031-3/+9
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Wed Feb 3 15:03:09 CET 2016 on sn-devel-144
* smbd: Fix CID 1351216 Dereference null return valueVolker Lendecke2016-02-031-0/+3
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* libsmb/pysmb: add pytalloc-util dependency to fix the build.Günther Deschner2016-02-021-1/+1
| | | | | | | | | | Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Günther Deschner <gd@samba.org> Autobuild-Date(master): Tue Feb 2 15:49:14 CET 2016 on sn-devel-144
* idl: Rename "principle" to "principal_name"Volker Lendecke2016-02-021-4/+4
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s3:vfs:glusterfs: fix build after quota changes.Michael Adam2016-02-011-0/+1
| | | | | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Uri Simchoni <uri@samba.org> Autobuild-User(master): Uri Simchoni <uri@samba.org> Autobuild-Date(master): Mon Feb 1 22:09:18 CET 2016 on sn-devel-144
* s3:libads: we always have arcfour-hmac-md5 supportStefan Metzmacher2016-02-011-4/+0
| | | | | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Mon Feb 1 13:02:32 CET 2016 on sn-devel-144
* s3:clispnego: fix confusing warning in spnego_gen_krb5_wrap()Stefan Metzmacher2016-02-011-5/+10
| | | | | | | | | | | | | asn1_extract_blob() stops further asn1 processing by setting has_error. Don't call asn1_has_error() after asn1_extract_blob() has been successful otherwise we get an "Failed to build krb5 wrapper at" message on success. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11702 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* s3: smbd: Fix timestamp rounding inside SMB2 create.Jeremy Allison2016-01-291-0/+8
| | | | | | | | | | | | | | | Setting "dos filetime resolution = yes" should round to 2 second increments. Fix missing path inside smbd. Fix confirmed by reporter Hubert Gilch <hg@sepag.de>. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11703 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Fri Jan 29 10:41:01 CET 2016 on sn-devel-144
* s3-utils/smbget: Fix user-/name password reading from rcfileChristian Ambach2016-01-281-0/+10
| | | | | | | | As the password option is gone, code needs to be able to read password from user parameter when user%password syntax is used. Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3-utils/smbget: Fix reading the rcfileChristian Ambach2016-01-281-1/+1
| | | | | | | | shortName in POPT_AUTOHELP is null, so the loop always stopped at this item. Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3-utils/smbget: Fix option parsing and apply samba defaultsAndreas Schneider2016-01-281-69/+104
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Christian Ambach <ambi@samba.org>
* selftest: fix test_dfree_quota.shUri Simchoni2016-01-271-2/+2
| | | | | | | | | | Eliminate backslashes from smbcquotas output so that we don't have to deal with them correctly when parsing the output. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11697 Signed-off-by: Uri Simchoni <uri@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* selftest: add test case for different quote/dfree block sizeUri Simchoni2016-01-271-0/+5
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=11681 Signed-off-by: Uri Simchoni <uri@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* smbd: show correct disk size for different quota and dfree block sizesUri Simchoni2016-01-271-1/+8
| | | | | | | | | | When file system stats (VFS disk_free_fn) and quota (VFS get_quota_fn) return different block sizes, normalize values before comparing. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11681 Signed-off-by: Uri Simchoni <uri@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* smbd quotas: avoid stat of foreign file systemsUri Simchoni2016-01-271-10/+61
| | | | | | | | | | | | | | | | | When determining the block device of our file system, avoid stat'ing paths which are definitely not the mount point of our file system. This is done to avoid stalling smbd due to unresponsive network file systems (e.g. NFS) which are not related to the SMB shares. See discussion in samba-technical for vfs_fileid: https://lists.samba.org/archive/samba-technical/2016-January/111553.html Signed-off-by: Uri Simchoni <uri@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Jan 27 03:35:48 CET 2016 on sn-devel-144
* s3-lib: introduce sys_realpath()Uri Simchoni2016-01-273-14/+27
| | | | | | | | Add sys_realpath() function that captures the OS variations on realpath(). Signed-off-by: Uri Simchoni <uri@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* waf: Only build smb_krb5_wrapper if we have CUPSAndreas Schneider2016-01-261-1/+2
| | | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* disk_quotas: style fixUri Simchoni2016-01-261-2/+4
| | | | | Signed-off-by: Uri Simchoni <uri@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* vfs_gpfs: make sure get_quota does not return bogus valuesUri Simchoni2016-01-261-0/+25
| | | | | | | | | | | | | add implementation of get_quota_fn to vfs_gpfs. The implemetation returns ENOSYS for the case of user and group quota, to make sure the default VFS does not accidentally succeed (and return wrong values which would alter the disk-free calculation) For other quota types the function calls the underlying VFS as before. Signed-off-by: Uri Simchoni <uri@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
View Lorry Controller Status