summaryrefslogtreecommitdiff
path: root/source3
Commit message (Collapse)AuthorAgeFilesLines
* s3: smbd: Ensure get_real_filename() copes with empty pathnames.Jeremy Allison2018-08-281-0/+5
| | | | | | | | | | | | | | | | | | | Needed for vfs_glusterfs, as Gluster requires "." not '\0'. Based on a fix from Anoop C S <anoopcs@redhat.com> BUG: https://bugzilla.samba.org/show_bug.cgi?id=13585 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ira Cooper <ira@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Aug 22 21:50:41 CEST 2018 on sn-devel-144 (cherry picked from commit 9c71f61ed8a31d287d343d4f2e68cb40c57a2b89) Autobuild-User(v4-8-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-8-test): Tue Aug 28 16:05:05 CEST 2018 on sn-devel-144
* vfs_fruit: Fix a leak of "br_lck"Volker Lendecke2018-08-231-8/+16
| | | | | | | | | | | | | | Fix a panic if fruit_access_check detects a locking conflict. do_lock() returns a valid br_lck even in case of a locking conflict. Not free'ing it leads to a invalid lock order panic later, because "br_lck" corresponds to a dbwrap lock on brlock.tdb. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13584 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 51d57073798f76ec4f1261945e0ba779b2530009)
* s3:winbind: Do not lookup local system accounts in ADAndreas Schneider2018-08-231-0/+2
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13503 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> (cherry picked from commit 9f28d30633af721efec02d8816a9fa48f795a01c)
* s3: vfs: time_audit: fix handling of token_blob in ↵Ralph Wuerthner2018-08-231-9/+3
| | | | | | | | | | | smb_time_audit_offload_read_recv() BUG: https://bugzilla.samba.org/show_bug.cgi?id=13568 Signed-off-by: Ralph Wuerthner <ralph.wuerthner@de.ibm.com> Reviewed-by: Christof Schmitt <cs@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 4909b966050c921b0a6a32285fee55f5f14dc3ff)
* libsmb: Fix CID 1438243 Unchecked return valueVolker Lendecke2018-08-231-1/+8
| | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Aug 8 23:10:22 CEST 2018 on sn-devel-144
* libsmb: Fix CID 1438244 Unsigned compared against 0Volker Lendecke2018-08-231-4/+0
| | | | | | | | | | | | ndr_size_dom_sid returns a size_t, so that can't be <0. Also, the only case that ndr_size_dom_sid returns 0 is a NULL sid pointer. ndr_size_dom_sid can reasonably be assumed to not overflow, the number of sub-auths is a uint8. That times 4 plus 8 always fits into a size_t. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* smbd: Fix CID 1438245 Dereference before null checkVolker Lendecke2018-08-231-1/+1
| | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* smbd: Fix CID 1438246 Unchecked return valueVolker Lendecke2018-08-231-1/+10
| | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* smbd: Align integer typesVolker Lendecke2018-08-231-1/+1
| | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3: tests: smbclient. Regression test to ensure we get ↵Jeremy Allison2018-08-231-0/+42
| | | | | | | | | | | | | | NT_STATUS_DIRECTORY_NOT_EMPTY on rmdir. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13204 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri Aug 10 21:08:14 CEST 2018 on sn-devel-144 (cherry picked from commit bca400847f2fcc3dd1398e166c1964cb88822071)
* s3/libsmb: Explicitly set delete_on_close token for rmdirAnoop C S2018-08-231-1/+8
| | | | | | | | | | | | | | | | | | | | | The current implementation of `rmdir` hopes to get the directory deleted on closing last open handle when FILE_DELETE_ON_CLOSE is set on it. But for non-empty directories Windows doesn't error out during an open call. Following that we internally refuse to set initial delete_on_close while opening a non-empty directory. This prevents us from trying to delete the directory when last open handle is closed. Instead of relying on FILE_DELETE_ON_CLOSE during an open we explicitly set delete_on_close token on directory handle once it is available. This ensures that NT_STATUS_DIRECTORY_NOT_EMPTY is returned for `rmdir` on non-empty directories while closing open directory handle. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13204 Signed-off-by: Anoop C S <anoopcs@redhat.com> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> (cherry picked from commit 6b68e3eca631c04d6d57c489daf60f64732fc86d)
* Merge tag 'samba-4.8.4' into v4-8-testKarolin Seeger2018-08-144-12/+62
|\ | | | | | | samba: tag release samba-4.8.4
| * CVE-2018-1139 selftest: verify whether ntlmv1 can be used via SMB1 when it ↵Günther Deschner2018-08-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | is disabled. Right now, this test will succeed. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13360 CVE-2018-1139: Weak authentication protocol allowed. Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
| * CVE-2018-1139 s3-utils: use enum ntlm_auth_level in ntlm_password_check().Günther Deschner2018-08-111-2/+4
| | | | | | | | | | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13360 CVE-2018-1139: Weak authentication protocol allowed. Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
| * CVE-2018-10858: libsmb: Harden smbc_readdir_internal() against returns from ↵Jeremy Allison2018-08-112-8/+51
| | | | | | | | | | | | | | | | | | | | | | | | malicious servers. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13453 CVE-2018-10858: Insufficient input validation on client directory listing in libsmbclient. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
| * CVE-2018-10858: libsmb: Ensure smbc_urlencode() can't overwrite passed in ↵Jeremy Allison2018-08-111-2/+7
| | | | | | | | | | | | | | | | | | | | | | | | buffer. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13453 CVE-2018-10858: Insufficient input validation on client directory listing in libsmbclient. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* | s3/smbd: Ensure quota code is only called when quota support detectedNoel Power2018-08-132-0/+10
| | | | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13563 Signed-off-by: Noel Power <noel.power@suse.com> Autobuild-User(v4-8-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-8-test): Mon Aug 13 17:25:23 CEST 2018 on sn-devel-144
* | s3/utils: fix regression where specifying -Unetbios/root worksNoel Power2018-08-131-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Usually you need to be root on a linux server to modify quotas. Even with a linux server joined to a windows AD you could always log in as local root with smbcquotas. However in recent builds this has changed. This patch fixes this BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553 Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Noel Power <npower@samba.org> Autobuild-Date(master): Tue Jul 31 19:45:59 CEST 2018 on sn-devel-144
* | s3/smbd: allow set quota for non root user (when built with --enable-selftest)Noel Power2018-08-131-1/+1
| | | | | | | | | | | | | | | | | | | | Currently it appears you need to be root to set quotas, for test purposes this requirement needs to be relaxed. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553 Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Jeremy Allison <jra@samba.org>
* | s3/script/tests: Add simple (smb1 & smb2) get/set/list tests for smbcquotasNoel Power2018-08-134-0/+445
| | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553 Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Jeremy Allison <jra@samba.org>
* | s3/script/test: modify existing smbcquota test to use SMB2 in addition to SMB1.Noel Power2018-08-131-2/+12
| | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553 Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Jeremy Allison <jra@samba.org>
* | s3/smbd: smb2 server implementation for query get/set info.Noel Power2018-08-133-3/+120
| | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553 Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Jeremy Allison <jra@samba.org>
* | s3/smbd: adjust smb1 server to use idl structs and generated ndr push/pull funcsNoel Power2018-08-133-290/+402
| | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553 Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Jeremy Allison <jra@samba.org>
* | s3/libsmb: adjust smb2 code for new idl structs & generated ndr push/pull funcs.Noel Power2018-08-131-28/+58
| | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553 Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Jeremy Allison <jra@samba.org>
* | s3/libsmb: adjust smb1 cli code to use idl structs and ndr push/pull funcs.Noel Power2018-08-133-180/+224
| | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553 Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Jeremy Allison <jra@samba.org>
* | s3/smbd: Don't stat when doing a quota operation (as it's a fake file)Noel Power2018-08-131-1/+2
| | | | | | | | | | | | | | | | | | | | | | calling SMB_VFS_STAT on the quota fake file fails and caused FS_INFO/FileFsControlInfo request to error out early, in turn stopped a Win8.1 client from proceeding with quota queries. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553 Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Jeremy Allison <jra@samba.org>
* | s3/libsmb: Avoid potential smbpanic calling parse_user_quota_list.Noel Power2018-08-131-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | Calling parse_user_quota_list with a NULL buffer can cause a panic, while this shouldn't happen, I managed to trigger this with an early implementation of SMB2 quota support in smbd which didn't pass back NT_STATUS_NO_MORE_ENTRIES when handling a SMB2_0_INFO_QUOTA GETINFO message. OTHOH the Windows client handled the same situation gracefully. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553 Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Jeremy Allison <jra@samba.org>
* | s3/lib: Fix misleading typo in debug messageNoel Power2018-08-131-1/+1
| | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553 Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Jeremy Allison <jra@samba.org>
* | s3: smbd: Fix AIX sendfile() for SMB2. Ensure we don't spin on EAGAIN.Jeremy Allison2018-08-131-5/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For SMB2 the socket is set non-blocking. Ensure sendfile() calls complete if they return EAGAIN by saving the socket state, setting it blocking, doing the sendfile until completion and then restoring the socket state. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13537 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Fri Jul 20 15:14:24 CEST 2018 on sn-devel-144 (cherry picked from commit 582ce5d6b599516d6d8d619529a2aa809139a175)
* | s3: smbd: Fix FreeBSD sendfile() for SMB2. Ensure we don't spin on EAGAIN.Jeremy Allison2018-08-131-4/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | For SMB2 the socket is set non-blocking. Ensure sendfile() calls complete if they return EAGAIN by saving the socket state, setting it blocking, doing the sendfile until completion and then restoring the socket state. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13537 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> (cherry picked from commit 456e520a3be7e4b54f1f144324c3671b8f6e35ea)
* | s3: smbd: Fix HPUX sendfile() for SMB2. Ensure we don't spin on EAGAIN.Jeremy Allison2018-08-131-6/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | For SMB2 the socket is set non-blocking. Ensure sendfile() calls complete if they return EAGAIN by saving the socket state, setting it blocking, doing the sendfile until completion and then restoring the socket state. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13537 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> (cherry picked from commit d222caa449d9c00bb2dd9da6c79ea509960d47c6)
* | s3: smbd: Fix Solaris sendfile() for SMB2. Ensure we don't spin on EAGAIN.Jeremy Allison2018-08-131-6/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | For SMB2 the socket is set non-blocking. Ensure sendfile() calls complete if they return EAGAIN by saving the socket state, setting it blocking, doing the sendfile until completion and then restoring the socket state. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13537 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> (cherry picked from commit 16a587075c8c62c1160869358ca56a133e90247a)
* | s3: smbd: Fix Linux sendfile() for SMB2. Ensure we don't spin on EAGAIN.Jeremy Allison2018-08-131-7/+77
| | | | | | | | | | | | | | | | | | | | | | | | | | For SMB2 the socket is set non-blocking. Ensure sendfile() calls complete if they return EAGAIN by saving the socket state, setting it blocking, doing the sendfile until completion and then restoring the socket state. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13537 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> (cherry picked from commit 809967b3eab7a1b48c186517701538ca93536246)
* | s3: smbd: fix path check in smbd_smb2_create_durable_lease_check()Ralph Boehme2018-08-131-1/+15
| | | | | | | | | | | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=13535 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit e60e9368cb3cb512e2506620d814187a692108e0)
* | s3: libsmbclient: Fix cli_splice() fallback when reading less than a ↵Jeremy Allison2018-08-131-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | complete file. We were always asking for SPLICE_BLOCK_SIZE even when the remaining bytes we wanted were smaller than that. This works when using cli_splice() on a complete file, as the cli_read() terminated the read at the right place. We always have the space to read SPLICE_BLOCK_SIZE bytes so this isn't an overflow. Found by Bailey Berro <baileyberro@google.com> BUG: https://bugzilla.samba.org/show_bug.cgi?id=13527 Signed-off-by: Bailey Berro <baileyberro@google.com> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> Autobuild-User(master): David Disseldorp <ddiss@samba.org> Autobuild-Date(master): Fri Jul 13 14:57:14 CEST 2018 on sn-devel-144 (cherry picked from commit c9656fd2977557ab20ec4e3d87c385a9b2f1bf43)
* | s3: torture: Test SMB1 cli_splice() fallback path when doing a non-full file ↵Jeremy Allison2018-08-132-1/+157
| | | | | | | | | | | | | | | | | | | | | | | | | | | | splice. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13527 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> (cherry picked from commit 1c8d1cceff852acaca4a0ec0da37b053ed03fe4a) (cherry picked from commit 49d6c3f061284aac31c3ef21f88f9d69bdd86bd8) Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Sat Jul 14 00:14:13 CEST 2018 on sn-devel-144
* | vfs_ceph: don't lie about flock supportDavid Disseldorp2018-08-131-6/+5
| | | | | | | | | | | | | | | | | | | | | | Instead, match vfs_gluster behaviour and require that users explicitly disable "kernel share modes". Bug: https://bugzilla.samba.org/show_bug.cgi?id=13506 Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 926ae50627d536735cee9b3931ee35bc19060261)
* | s3:selftest: run rpc.lsa.lookupsids also with explicit [smb1] and [smb2]Stefan Metzmacher2018-08-131-1/+1
| | | | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13308 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org> (cherry picked from commit 6800077c5c57c257326573537d1f2bb7a8066149)
* | s3: smbd: always set vuid in check_user_ok()Ralph Boehme2018-08-131-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A SMB session reauth will have invalidated conn->vuid via conn_clear_vuid_caches(). Ensure conn->vuid always has the vuid of the current user in check_user_ok(). Bug: https://bugzilla.samba.org/show_bug.cgi?id=13351 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Thu Mar 22 18:26:04 CET 2018 on sn-devel-144 (cherry picked from commit 42d6dd2f30b6c3b3176bd1f378422a2eb62b1008)
* | s3: smbd/durable: remove dev and inode check from ↵Ralph Boehme2018-07-121-24/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | vfs_default_durable_reconnect_check_stat() On a cluster filesystem the device numbers may differ on the cluster nodes. We already verify the file_id in vfs_default_durable_reconnect(), so we can safely remove the dev/inode checks. Bug: https://bugzilla.samba.org/show_bug.cgi?id=13318 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 0a91ade5272698c094137fa28d2ad4723b5963cf) Autobuild-User(v4-8-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-8-test): Thu Jul 12 17:42:50 CEST 2018 on sn-devel-144
* | libsmbclient: Initialize written in cli_splice_fallback()Bailey Berro2018-07-121-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13511 Signed-off-by: Bailey Berro <baileyberro@chromium.org> Reviewed-by: David Mulder <dmulder@suse.com> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> Autobuild-User(master): David Disseldorp <ddiss@samba.org> Autobuild-Date(master): Mon Jul 9 21:29:48 CEST 2018 on sn-devel-144 (cherry picked from commit fe25bc793d30a64f06b19f737c652b0c7389ca92)
* | libsmbclient: Initialize written value before use.Jeremy Allison2018-07-121-1/+1
| | | | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13511 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> (cherry picked from commit 2e4878a69a62fb59d843ee53a1a9469b987e3a59)
* | python: pysmbd: Additional error path leak fix.Jeremy Allison2018-07-121-0/+1
| | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13474 Signed-off-by: Jeremy Allison <jra@samba.org>
* | s3:smbd: don't allow renaming basefile if streams are openRalph Boehme2018-07-121-0/+4
| | | | | | | | | | | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=13451 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 465b7d07e5db787c3d6330371e5e42ecbb1b57b9)
* | s3:locking: add file_has_open_streams()Ralph Boehme2018-07-122-0/+32
| | | | | | | | | | | | | | | | | | | | This can be used to check if a file opened by fsp also has stream opens. Bug: https://bugzilla.samba.org/show_bug.cgi?id=13451 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit dd8cf54c79fe8536e34cde15801d60931cd47b8b)
* | s3:smbd: add private option NTCREATEX_OPTIONS_PRIVATE_STREAM_BASEOPENRalph Boehme2018-07-122-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | This will be used to mark basefile opens of streams opens. This is needed to later implement a function that can determine if a file has stream opens. Bug: https://bugzilla.samba.org/show_bug.cgi?id=13451 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 37e7ff05ab9443c0330e68f5c701ffecedf2d738)
* | selftest: run smb2.streams tests against a share with vfs_streams_xattrRalph Boehme2018-07-121-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | The tests are currently only run against streams_depot, where stream IO is handle based, compared to streams_xattr which is path based. vfs_streams_xattr is also used much more in real world setups, so we should run our tests against it. Bug: https://bugzilla.samba.org/show_bug.cgi?id=13451 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (backported from commit aa096ab70a466388a9947f73a525b2dcbb9821e5)
* | vfs_fruit: delete 0 byte size streams if AAPL is enabledRalph Boehme2018-07-121-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | macOS SMB server uses xattrs as storage backend for streams, directly exposing xattr get/set characteristics. Setting EOF on a stream to 0 just deletes the xattr as macOS doesn't support 0-byte sized xattrs. Note that this does not apply to the AFP_AfpInfo and AFP_Resource streams, they have even stranger semantics and we have other tests for those. Bug: https://bugzilla.samba.org/show_bug.cgi?id=13441 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed May 30 02:34:29 CEST 2018 on sn-devel-144 (cherry picked from commit 46d127865f3fb14041797d395db3b3234ed3bd6c)
* | s3:tests: Add test for smbclient --quietJustin Stephenson2018-07-101-0/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13485 Signed-off-by: Justin Stephenson <jstephen@redhat.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Björn Baumbach <bb@sernet.de> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Tue Jun 26 20:29:19 CEST 2018 on sn-devel-144 (cherry picked from commit f90f434e041461fbea2e101066c79ec8caf35cce)
* | s3:client: Add --quiet option to smbclientJustin Stephenson2018-07-101-1/+8
|/ | | | | | | | | | | | Add quiet command-line argument to allow suppressing the help log message printed automatically after establishing a smbclient connection BUG: https://bugzilla.samba.org/show_bug.cgi?id=13485 Signed-off-by: Justin Stephenson <jstephen@redhat.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Björn Baumbach <bb@sernet.de> (cherry picked from commit 89a8b3ecd47b6d9a33e66f22d2786f0ae3b4cb72)
View Lorry Controller Status