summaryrefslogtreecommitdiff
path: root/source3
Commit message (Collapse)AuthorAgeFilesLines
* s3-lib: Get the real initial uid for selftestAndreas Schneider2015-11-051-0/+14
| | | | | | | | We need this that if we connect as the user who started smbd, we are able to perform privileged operation like creating a user. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* vfs_offline: add a blackbox testUri Simchoni2015-11-042-0/+34
| | | | | Signed-off-by: Uri Simchoni <uri@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* vfs_offline: add vfs_offline moduleUri Simchoni2015-11-043-1/+55
| | | | | | | | | | | | | | | | | | This module marks all file in the share as offline. It can be useful for shares mounted on top of a remote file system (either through a samba VFS module or via FUSE). Offline files change the behavior of Windows explorer, and prevent it from peeking inside folders just for the sake of drawing a nice icon of them. This greatly reduces the number of requests Windows Explorer makes, and improves user experience when dealing with remote file systems. The offline bit also has an effect on the behavior of Windows redirector. Signed-off-by: Uri Simchoni <uri@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3: rpcclient: Prevent null ptr access by returning error if no creds availableNoel Power2015-11-041-0/+5
| | | | | | | | | | Prevent rpccli_netlogon_password_logon being called with 'NULL' credentials. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11569 Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3: winbind: Prevent null ptr access by returning error if no creds availableNoel Power2015-11-041-2/+5
| | | | | | | | | | | Prevent rpccli_netlogon_network_logon/rpccli_netlogon_password_logon being called with 'NULL' credentials BUG: https://bugzilla.samba.org/show_bug.cgi?id=11569 Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3: smbd: If EA's are turned off on a share don't allow an SMB2 create ↵Jeremy Allison2015-11-041-0/+6
| | | | | | | | | | | | | | | | | containing them. Otherwise a create that should have failed may succeed. Based on an original patch from John Mulligan <phlogistonjohn@asynchrono.us> and comments from Uri Simchoni <uri@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=11589 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Uri Simchoni <uri@samba.org> Autobuild-User(master): Uri Simchoni <uri@samba.org> Autobuild-Date(master): Wed Nov 4 22:14:22 CET 2015 on sn-devel-104
* ctdb-daemon: Rename struct ctdb_control_tcp_addr to ctdb_connectionAmitay Isaacs2015-11-041-3/+3
| | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
* ctdb-daemon: Remove struct ctdb_client_notify_deregisterAmitay Isaacs2015-11-041-4/+2
| | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
* ctdb-daemon: Rename struct ctdb_client_notify_register to ctdb_notify_data_oldAmitay Isaacs2015-11-041-2/+2
| | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
* ctdb-daemon: Rename struct ctdb_rec_data to ctdb_rec_data_oldAmitay Isaacs2015-11-042-14/+14
| | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
* ctdb-daemon: Rename struct ctdb_node_map to ctdb_node_map_oldAmitay Isaacs2015-11-041-2/+2
| | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
* ctdb-daemon: Rename struct ctdb_reply_control to ctdb_reply_control_oldAmitay Isaacs2015-11-041-4/+4
| | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
* ctdb-daemon: Rename struct ctdb_req_control to ctdb_req_control_oldAmitay Isaacs2015-11-041-6/+6
| | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
* ctdb-daemon: Rename struct ctdb_req_message to ctdb_req_message_oldAmitay Isaacs2015-11-042-12/+12
| | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
* ctdb-daemon: Rename struct ctdb_reply_call to ctdb_reply_call_oldAmitay Isaacs2015-11-041-2/+2
| | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
* ctdb-daemon: Rename struct ctdb_req_call to ctdb_req_call_oldAmitay Isaacs2015-11-041-6/+6
| | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
* Changing log level of two entries to DBG_NOTICEMarc Muehlfeld2015-11-042-4/+4
| | | | | | | | | | | | | | | | | | | On domain members using RFC2307, machine acccounts without an uidNumber attribute are not retrieved via idmap_ad. This leads to many of the following two error messages: Username DOMAIN\machineaccountname$ is invalid on this system and Failed to map kerberos principal to system user (NT_STATUS_LOGON_FAILURE) Machine accounts don't have an uidNumber attribute, if not set manually. To avoid flooding the logs, setting message from debug level 1 to DBG_NOTICE. Bugreport: https://bugzilla.samba.org/show_bug.cgi?id=9912 Signed-off-by: Marc Muehlfeld <mmuehlfeld@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Nov 4 00:46:15 CET 2015 on sn-devel-104
* notifyd: Do not include CTDB headers without CLUSTER_SUPPORT enabledAmitay Isaacs2015-11-031-3/+35
| | | | | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Tue Nov 3 15:15:56 CET 2015 on sn-devel-104
* smbd: Do not include CTDB headers without CLUSTER_SUPPORT enabledAmitay Isaacs2015-11-031-1/+8
| | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Volker Lendecke <vl@samba.org>
* s3:smb2_server: make the logic of SMB2_CANCEL DLIST_REMOVE() clearerStefan Metzmacher2015-11-031-1/+11
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=11581 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3: Remove unnecessary __P() macroFelix Janda2015-10-311-1/+1
| | | | | | | | | | | | | __P() is used for compatibility with old K&R C compilers. With ANSI C this macro has no effect. Since we are assuming ANSI C in the rest of the code, the macro is not necessary. This fixes a compilation error with musl libc because of undeclared __P(). Signed-off-by: Felix Janda <felix.janda@posteo.de> Reviewed-by: Ralph Boehme <slow@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* smbd: Fix/simplify scavenger routinesVolker Lendecke2015-10-301-27/+20
| | | | | | | | | | Use read_data/write_data, "ofs" was not incremented Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri Oct 30 22:53:56 CET 2015 on sn-devel-104
* s3-smbd: Fix use after issue in smbd_smb2_request_dispatch()Andreas Schneider2015-10-301-7/+8
| | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=11581 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Fri Oct 30 19:49:47 CET 2015 on sn-devel-104
* messages: messages.h needs data_blob.hVolker Lendecke2015-10-281-0/+1
| | | | | | | | Normally it somehow comes via includes.h, but if you want to directly include messages.h you need this Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* lib: Remove a includes.h referenceVolker Lendecke2015-10-281-1/+1
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* lib: Include samba_util.h in server_id_db.hVolker Lendecke2015-10-281-0/+1
| | | | | | | Usually this came in via server_id.h's includes.h. This will go. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* smbd: Fix a commentVolker Lendecke2015-10-281-2/+3
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* ctdb-include: Remove unused header file include/ctdb.hAmitay Isaacs2015-10-282-2/+0
| | | | | | | | This was part of libctdb which has been removed. Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Michael Adam <obnox@samba.org> Reviewed-by: Martin Schwenke <martin@meltin.net>
* repl: Give an error if we get a secret when not expecting oneAndrew Bartlett2015-10-261-0/+1
| | | | | | | | | We should never get a secret from a server when we specify DRSUAPI_DRS_SPECIAL_SECRET_PROCESSING This asserts that this is the case. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* smbd: Send SMB2 oplock breaks unencryptedVolker Lendecke2015-10-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | This is not what Windows server does, but it seems that Windows clients expect. Windows->Windows never runs into this issue, because an encryption-enabled SMB3 connection will always use leases, and lease breaks *are* unencrypted... You can reproduce the issue Windows->Windows by disabling leases on the Windows server. Disable leases using the registry key: HKLM\SYSTEM\CurrentControlSet\Services\LanmanServer\DisableLeasing Dochelp confirmed that this is a valid workaround for Windows clients dropping encrypted oplock breaks. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11570 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Sat Oct 24 05:01:32 CEST 2015 on sn-devel-104
* smbd/quotas: Remove invalid quota status switch caseAnoop C S2015-10-241-10/+7
| | | | | | | | | | | | | | getquota_rslt structure from rquota.h defines the enum named status whose values start from 1. But in quotas.c we have an invalid check for status 0. This change is to remove that particular switch case. Signed-off-by: Anoop C S <anoopcs@redhat.com> Reviewed-by: Michael Adam <obnox@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Sat Oct 24 01:31:21 CEST 2015 on sn-devel-104
* messaging: Fix creating the dgm lockfileVolker Lendecke2015-10-221-0/+20
| | | | | | | | | | | | | | There might be situations where the lock directory moves to a location where a previous installation left the datagram sockets (Yes, I just came across this). We can't really deal with it except by just removing the socket without properly checking. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Oct 22 02:14:29 CEST 2015 on sn-devel-104
* Remove function name from callers of DBG_*Christof Schmitt2015-10-215-16/+14
| | | | | | | It is now added automatically. Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3-torture: Add WILDDELETE test to smbtorture3 to test old wildcard delete ↵Jeremy Allison2015-10-212-1/+68
| | | | | | | | | with zero attribute BUG: https://bugzilla.samba.org/show_bug.cgi?id=11452 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3-smbd: Fix old DOS client doing wildcard delete - gives a attribute type ↵Jeremy Allison2015-10-211-0/+3
| | | | | | | | | | | | of zero In the wildcard delete path we forgot to map 0 -> FILE_ATTRIBUTE_NORMAL as we do in the non-wildcard delete path. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11452 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* net: print file path in serverid wipedbs --verboseRalph Boehme2015-10-211-1/+15
| | | | | | | | Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Oct 21 03:10:28 CEST 2015 on sn-devel-104
* selftest: add a test for async_connect_send()Ralph Boehme2015-10-202-0/+14
| | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=11564 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* lib: Remove unused serverid_get_random_unique_idVolker Lendecke2015-10-192-18/+0
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Mon Oct 19 15:12:22 CEST 2015 on sn-devel-104
* lib: Add some debug to dgm_refVolker Lendecke2015-10-191-0/+8
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* lib: Push down unique generation one levelVolker Lendecke2015-10-196-11/+34
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* lib: Remove unused global my_unique_idVolker Lendecke2015-10-194-24/+0
| | | | | | | The unique_id is now always attached to a messaging_context. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* lib: Remove unused procid_is_me()Volker Lendecke2015-10-192-12/+0
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* lib: Remove unused procid_self()Volker Lendecke2015-10-192-6/+0
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* lib: Remove procid_self() from messages.cVolker Lendecke2015-10-191-2/+9
| | | | | | | | This together with the removal of procid_self obsoletes the global my_unique. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* lib: Fix pid_to_procid()Volker Lendecke2015-10-191-6/+12
| | | | | | | | | Putting in my_unique_id is just wrong. Now that we have a cheap way to read everyone's unique ids out of the lockfile, we can fix it. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* winbindd: Remove reference to procid_self()Volker Lendecke2015-10-191-1/+10
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* fssd: Remove reference to procid_self()Volker Lendecke2015-10-191-1/+1
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* auth: Remove procid_self() from auth_samba4Volker Lendecke2015-10-191-1/+8
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* smbd: Fix file name buflen and padding in notify repsonseJeremy Allison2015-10-181-1/+13
| | | | | | | | | | | | | | | | | The array is uint16, doubling the file name length consumes twice the space required. As we're hand assembling this as a series of concatinated individual data_blobs, we must take care to ensure the correct 4 byte alignment that was being masked by the previous doubling of the filename length. Bug: https://bugzilla.samba.org/show_bug.cgi?id=10634 Signed-off-by: Jeremy Allison <jra@samba.org> Signed-off-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Sun Oct 18 01:56:41 CEST 2015 on sn-devel-104
* vfs_streams_xattr: fix and simplify streams_xattr_get_name()Ralph Boehme2015-10-161-20/+19
| | | | | | | | | | | | | | | | | | streams_xattr_get_name() fails to chop off the stream type in case config->store_stream_type is false and the passed stream name contains a stream type. Eg when the passed in stream name is ":mystream:$DATA", but config->store_stream_type is false, we must generate a xattr name of "mystream" or "user.mystream". Bug: https://bugzilla.samba.org/show_bug.cgi?id=11466 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri Oct 16 23:27:01 CEST 2015 on sn-devel-104