summaryrefslogtreecommitdiff
path: root/source3/smbd/filename.c
Commit message (Collapse)AuthorAgeFilesLines
...
* s3: Add a new VFS op called SMB_VFS_TRANSLATE_NAMEAravind Srinivasan2009-08-281-1/+5
| | | | | | | | | | | This vop is designed to work in tandem with SMB_VFS_READDIR to allow vfs modules to make modifications to arbitrary filenames before they're consumed by callers. Subsequently the core directory enumeration code in smbd is now changed to free the memory that may be allocated in a module. This vop enables the new version of catia in the following patch. Signed-off-by: Tim Prouty <tprouty@samba.org>
* s3:smbd: teach filename_convert() about fake files (2nd fix for bug #6642)Stefan Metzmacher2009-08-271-0/+11
| | | | metze
* s3: Convert a few callers of unix_convert() over to filename_convert()Tim Prouty2009-07-241-10/+12
| | | | | | This patch also changes the unix convert flags to make sure the correct semantics are preservered for allowing/disallowing wildcards in the last component of the path.
* s3: Allow filename_convert() to pass through unix_convert_flags and let the ↵Tim Prouty2009-07-241-7/+34
| | | | | | caller know if the path has a wildcard This also eliminates the need for resolve_dfspath().
* s3: Change unix_convert to use an smb_filename struct internallyTim Prouty2009-07-221-137/+154
| | | | | | | | | | | | This allows SMB_VFS_[L]STAT to be called directly. Additionally, I changed NTSTATUS result to be named status for consistency. I also removed the stat_cache_add() from build_stream_path() because stat_cache_lookup() is never actually called on a file with a stream. There is no reason why the stat cache couldn't be consulted for streams in the future. Jeremy/Volker, please take a look at this one when you get a chance.
* s3: Remove the now unused fname parameter from filename_convert()Tim Prouty2009-07-211-12/+4
|
* s3: Separate out a new file: filename_utils.cTim Prouty2009-07-201-219/+0
| | | | This is to ease the linking pain of everything that links LOCKING_OBJ
* s3: Move is_ntfs_stream*() to filename.cTim Prouty2009-07-201-0/+24
|
* s3: Add ability to pass NULL to filename_convert for the char *fnameTim Prouty2009-07-061-7/+11
| | | | | The goal is to eventually remove the need for the char **fname argument once all callers have standardized on smb_filename.
* s3: Plumb smb_filename through SMB_VFS_STAT and SMB_VFS_LSTATTim Prouty2009-06-241-30/+81
| | | | | | | | | | | | | This patch introduces two new temporary helper functions vfs_stat_smb_fname and vfs_lstat_smb_fname. They basically allowed me to call the new smb_filename version of stat, while avoiding plumbing it through callers that are still too inconvenient. As the conversion moves along, I will be able to remove callers of this, with the goal being to remove all callers. There was also a bug in create_synthetic_smb_fname_split (also a temporary utility function) that caused it to incorrectly handle filenames with ':'s in them when in posix mode. This is now fixed.
* Fix Coverity IDs 922 and 933Volker Lendecke2009-06-191-2/+5
| | | | | | | | | | | In copy_internals(), if the !CAN_WRITE(conn) kicks in, we end up dereferencing a NULL smb_filename. This adds a simple protection around it. Tim, please check! Volker
* Replace the boilerplate calls to :Jeremy Allison2009-06-181-0/+52
| | | | | | | | | | | | resolve_dfspath() -> unix_convert() -> get_full_smb_filename() -> check_name() with a new function filename_convert(). This restores the check_name() calls that had gone missing since the default create_file was changed. All "standard" pathname processing now goes through filename_convert(). I'll take a look at the non-standard pathname processing next. As a benefit, fixed a missing resolve_dfspath() in the trans2 mkdir call. Jeremy.
* s3: Change SMB_VFS_OPEN to take an smb_filename structTim Prouty2009-06-171-3/+2
| | | | | | | | | | | | This was a little messy because of all of the vfs modules I had to touch. Most of them were pretty straight forward, but the streams modules required a little attention to handle smb_filename. Since the use of smb_filename enables the vfs modules to access the raw, over-the-wire stream, a little bit of the handling that was being done by split_ntfs_stream_name has now been shifted into the individual stream modules. It may be a little more code, but overall it gives more flexibility to the streams modules, while also allowing correct stream handling.
* s3: Add smb_filename utility functions and fix a bug in copy_smb_filenameTim Prouty2009-06-121-5/+85
|
* s3: Add utility function for copying an smb_filename structTim Prouty2009-06-101-0/+39
|
* Simplify the dropbox patchJeremy Allison2009-05-301-5/+10
|
* Re-Add the "dropbox" functionality with -wx rights on a directoryVolker Lendecke2009-05-291-3/+3
|
* Introduce "struct stat_ex" as a replacement for SMB_STRUCT_STATVolker Lendecke2009-05-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch introduces struct stat_ex { dev_t st_ex_dev; ino_t st_ex_ino; mode_t st_ex_mode; nlink_t st_ex_nlink; uid_t st_ex_uid; gid_t st_ex_gid; dev_t st_ex_rdev; off_t st_ex_size; struct timespec st_ex_atime; struct timespec st_ex_mtime; struct timespec st_ex_ctime; struct timespec st_ex_btime; /* birthtime */ blksize_t st_ex_blksize; blkcnt_t st_ex_blocks; }; typedef struct stat_ex SMB_STRUCT_STAT; It is really large because due to the friendly libc headers playing macro tricks with fields like st_ino, so I renamed them to st_ex_xxx. Why this change? To support birthtime, we already have quite a few #ifdef's at places where it does not really belong. With a stat struct that we control, we can consolidate the nanosecond timestamps and the birthtime deep in the VFS stat calls. At this moment it is triggered by a request to support the birthtime field for GPFS. GPFS does not extend the system level struct stat, but instead has a separate call that gets us the additional information beyond posix. Without being able to do that within the VFS stat calls, that support would have to be scattered around the main smbd code. It will very likely break all the onefs modules, but I think the changes will be reasonably easy to do.
* s3: Change unix_convert (and its callers) to use struct smb_filenameTim Prouty2009-05-201-77/+98
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is the first of a series of patches that change path based operations to operate on a struct smb_filename instead of a char *. This same concept already exists in source4. My goals for this series of patches are to eventually: 1) Solve the stream vs. posix filename that contains a colon ambiguity that currently exists. 2) Make unix_convert the only function that parses the stream name. 3) Clean up the unix_convert API. 4) Change all path based vfs operation to take a struct smb_filename. 5) Make is_ntfs_stream_name() a constant operation that can simply check the state of struct smb_filename rather than re-parse the filename. 6) Eliminate the need for split_ntfs_stream_name() to exist. My strategy is to start from the inside at unix_convert() and work my way out through the vfs layer, call by call. This first patch does just that, by changing unix_convert and all of its callers to operate on struct smb_filename. Since this is such a large change, I plan on pushing the patches in phases, where each phase keeps full compatibility and passes make test. The API of unix_convert has been simplified from: NTSTATUS unix_convert(TALLOC_CTX *ctx, connection_struct *conn, const char *orig_path, bool allow_wcard_last_component, char **pp_conv_path, char **pp_saved_last_component, SMB_STRUCT_STAT *pst) to: NTSTATUS unix_convert(TALLOC_CTX *ctx, connection_struct *conn, const char *orig_path, struct smb_filename *smb_fname, uint32_t ucf_flags) Currently the smb_filename struct looks like: struct smb_filename { char *base_name; char *stream_name; char *original_lcomp; SMB_STRUCT_STAT st; }; One key point here is the decision to break up the base_name and stream_name. I have introduced a helper function called get_full_smb_filename() that takes an smb_filename struct and allocates the full_name. I changed the callers of unix_convert() to subsequently call get_full_smb_filename() for the time being, but I plan to eventually eliminate get_full_smb_filename().
* Do not call SMB_VFS_GET_REAL_FILENAME if the name is mangledVolker Lendecke2009-05-091-6/+11
| | | | | | | | | The GPFS get_real_file name does not know about mangled names. Tim, if onefs does not either, you need this bugfix :-) In case onefs does 8.3 names, we need to pass the mangled flag down to SMB_VFS_GET_REAL_FILENAME to give GPFS a chance say ENOTSUPP and do the fallback.
* s3: Fix trans2 path to use case-insensitive stat optimizationtprouty2009-05-051-6/+34
| | | | | | | | | | | | | | | | | | | | Often times before creating a file, a client will first query to see if it already exists. Since some systems have a case-insensitive stat that is called from unix_convert, we can definitively return STATUS_NO_SUCH_FILE to the client without scanning the whole directory. This code path is taken from trans2querypathinfo, but trans2findfirst still does a full directory scan even though the get_real_filename (the case-insensitive stat vfs call) can prevent this. This patch adds the get_real_filename call to the trans2find* path, and also changes the vfs_default behavior for SMB_VFS_GET_REAL_FILENAME. Previously, in the absence of a get_real_filename implementation, we would fallback to the full directory scan. The default behavior now returns -1 and sets errno to EOPNOTSUPP. This allows SMB_VFS_GET_REALFILENAME to be called from trans2* and unix_convert.
* Revert "Do not use the file system GET_REAL_FILENAME for mangled names"Volker Lendecke2009-04-231-23/+7
| | | | This reverts commit b5b6ecb58aeba196c28370cde21a0826f81d8da6.
* Do not use the file system GET_REAL_FILENAME for mangled namesVolker Lendecke2009-04-201-7/+23
|
* Pass stat buffer down through all levels of VFS_READDIR wrappersSteven Danneman2009-02-091-1/+1
| | | | | | | | | * VFS_OP_READDIR can now provide stat information, take advantage of it if it's available * is_visible_file(): optimistically expect the provided stat buffer is already valid * dptr_ReadDirName(): refactor code for easier readability, functionality is the same
* Fix bug #Bug 6090 renaming or deleting a "not matching/resolving" symlink is ↵Jeremy Allison2009-02-041-4/+26
| | | | | | | | | | failing. Reported by Kukks. Make sure we correctly use LSTAT in all cases where POSIX pathnames are being used. This matters when dealing with symlinks pointing to invalid paths being renamed or deleted not all deletes and renames are done via an nt_create open. Jeremy.
* Pass the get_real_filename operation through the VFSVolker Lendecke2008-12-101-4/+1
| | | | | | | | | | | | | | This is done to help file systems that can tell us about the real upper/lower case combination given a case-insensitive file name. The sample I will soon push is the gpfs module (recent gpfs has a get_real_filename function), others might have a similar function to help alleviate the 1million files in a single directory problem. Jeremy, please comment! Thanks, Volker
* Change get_real_filename() to unix syscall conventions, make it non-staticVolker Lendecke2008-12-101-13/+14
| | | | It sets errno, so it might as well return 0/-1.
* Apply some constVolker Lendecke2008-12-101-2/+2
|
* Rename "scan_directory" to "get_real_filename"Volker Lendecke2008-12-101-12/+12
|
* Re-structure Volker's patch to "Fix trans2findfirst for the large directory ↵Jeremy Allison2008-11-181-26/+21
| | | | | | optimization". Makes the change clearer. Jeremy.
* Fix trans2findfirst for the large directory optimizationVolker Lendecke2008-11-181-0/+5
| | | | | | | | | | | | | | | | With case sensitive = yes preserve case = no short preserve case = no default case = upper a "dir FOO.txt" would not find "FOO.TXT" because FOO.txt ends up unconverted in the mask for mask_match. Jeremy, please check! Volker
* Fix bug #5783 FindFirst fails where search pattern == mangled filename.Jeremy Allison2008-09-231-2/+1
| | | | | That was an old and subtle bug. Jeremy.
* Fix unix_convert() for "*" after changing map_nt_error_from_unix().Michael Adam2008-08-121-1/+1
| | | | | | | | | | | | | | | | | | | | map_nt_error_from_unix() now assumes that it is called in an error path and returns an error even for a given errno == 0. The original behaviour of unix_convert() used the mapping of errno == 0 ==> NT_STATUS_OK to return success through an error path. I think this must have been an oversight, and unix_convert() worked only by coincidence (or because explicitly using the knowledge of the conceptually wrong working of map_nt_error_from_unix(). This patch puts this straight by not interpreting errno == 0 as an error condition and proceeding in that case. Jeremy - please check! Michael (This used to be commit ec5956ab0df1b3f567470b2481b73da9c3c67371)
* locking: combine get_delete_on_close_flag() and get_write_time() into ↵Stefan Metzmacher2008-04-071-5/+13
| | | | | | | | | get_file_infos() This means we need to fetch the record only once. metze (This used to be commit 4130b873291d39e363184fe4e38dc1f24ebe5056)
* Couple of minor fixes for POSIX pathname processing in theJeremy Allison2008-01-191-8/+10
| | | | | | | | | | | new stream code. (1) In smbd/filename, don't split the name at ':' if we know it's a posix path (this should be parameterized....). (2). When calling posix_mkdir, we get the flag FILE_FLAG_POSIX_SEMANTICS passed to open_directory(). I know for a posix client lp_posix_pathnames should be true (which is checked for in is_ntfs_stream_name() but we have an explicit flag here, so let's use it. Jeremy. (This used to be commit 7bb7a0def6518784befa75e5303289d2b4d36dd4)
* Add streams supportVolker Lendecke2008-01-191-0/+121
| | | | | | | | | | | This is the core of the streams support. The main change is that in files_struct there is now a base_fsp pointer that holds the main file open while a stream is open. This is necessary to get the rather strange delete semantics right: You can't delete the main file while a stream is open without FILE_SHARE_DELETE, and while a stream is open a successful unlink of the main file leads to DELETE_PENDING for all further access on the main file or any stream. (This used to be commit 6022873cc155bdbbd3fb620689715f07a24d6ed1)
* Convert OpenDir to talloc, use talloc_tos()Volker Lendecke2008-01-121-3/+3
| | | | | This cuts some mallocs on NtCreate&X (This used to be commit 8e64107b7846d8f9cce71aabc95b28b7488d01ce)
* If we detect a case insensitive filesystem makeJeremy Allison2007-12-221-4/+11
| | | | | | | sure we don't search directories on name misses for non-mangled names. Jeremy (This used to be commit 120048d2f40cf1a0ace2ecde205cbc694d263d69)
* Use filesystem capabilities to support case-insensitive filesystems.James Peach2007-12-221-0/+9
| | | | | | | | | If we know the underlying filesystem is case-insensitive, then we know that it won't help to search for case variations of the requested name. Jeremy, please review (and revert if you disagree). (This used to be commit 9e8b8f8c16612d8a08b55802f4fd9afca5498a7c)
* RIP BOOL. Convert BOOL -> bool. I found a few interestingJeremy Allison2007-10-181-10/+10
| | | | | | | | bugs in various places whilst doing this (places that assumed BOOL == int). I also need to fix the Samba4 pidl generation (next checkin). Jeremy. (This used to be commit f35a266b3cbb3e5fa6a86be60f34fe340a3ca71f)
* r25167: Fix breakage from mangling rewrite. Use theJeremy Allison2007-10-101-1/+2
| | | | | | | | new name if unmangling succeeded, not if it failed. Jerry - please re-test, this should fix your bug. Jeremy. (This used to be commit c215d6e84929b70e4472e19f32ec4f1db7449d90)
* r25138: More pstring elimination. Add a TALLOC_CTX parameterJeremy Allison2007-10-101-2/+2
| | | | | | to unix_convert(). Jeremy. (This used to be commit 39c211a702e91c34c1a5a689e1b0c4530ea8a1ac)
* r25111: Move to talloced pathnames on most code paths.Jeremy Allison2007-10-101-2/+1
| | | | | | | | | | There are now ony 17 pstrings left in reply.c, and these will be easy to remove (and I'll be doing that shortly). Had to fix an interesting bug in pull_ucs2_base_talloc() when a source string is not null terminated :-). Jeremy. (This used to be commit 0c9a8c4dff10974dbffd2a302ae982896122fcc0)
* r25009: Large patch discussed with Volker. Move unix_convert to a talloc-basedJeremy Allison2007-10-101-77/+112
| | | | | | | interface. More development will come on top of this. Remove the "mangled map" parameter. Jeremy. (This used to be commit dee8beba7a92b8a3f68bbcc59fd0a827f68c7736)
* r24811: Simple reformatting to fit the 80 columns rule.Jeremy Allison2007-10-101-63/+96
| | | | | Jeremy. (This used to be commit 0cdf046dae8ba0741bb7786aa4e85c34fc35dade)
* r24595: Fix Coverity ID 393Volker Lendecke2007-10-101-2/+1
| | | | | In this error case we would have used "start" not having it initialized (This used to be commit 751834fff92e85a424152c1642b238daa3060dbd)
* r24549: Fix unix_convert to return the already converted partVolker Lendecke2007-10-101-4/+10
| | | | | | | | | | | This API will change anyway when moving away from pstrings. It took so long to fix, because that rename bug I just fixed gave make test failures that had nothing to do with this one. I have samba4 tests for both bugs, will check them in when the build farm has caught up (This used to be commit d4f442ed9b145990af4db26859663954ddd70926)
* r24497: Revert r24485 -- this needs more thoughtVolker Lendecke2007-10-101-1/+1
| | | | (This used to be commit 01f701ba1ea9859b090aaf8f4ae9722c5502316c)
* r24485: Even in the failure case unix_convert must pass the already convertedVolker Lendecke2007-10-101-1/+1
| | | | | part of the string to the caller. (This used to be commit 301ae3d68bc64c9526eb7d4458584a5ebb151137)
* r24120: add a file_id_create() hook into the VFS layerStefan Metzmacher2007-10-101-1/+2
| | | | | | | | it's needed for some cluster filesystems to overload this function. metze (This used to be commit cdaa24e8047399002e4b287a31a8340a665e580f)
View Lorry Controller Status