summaryrefslogtreecommitdiff
path: root/source3/rpc_client
Commit message (Collapse)AuthorAgeFilesLines
* s3: rpc_client: Allocate struct db_context * off the local frame, as all ↵Jeremy Allison2017-08-171-1/+1
| | | | | | | | | | | | other variables in this function. On success, netlogon_creds_cli_set_global_db() reparents it to a long-lived context. BUG: https://bugzilla.samba.org/show_bug.cgi?id=12932 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 1fb46b76dbcf28d8c71ff1096c402953a90bcf5f)
* libcli/auth: pass an array of nt_hashes to netlogon_creds_cli_auth*()Stefan Metzmacher2017-06-271-2/+13
| | | | | | | | | | | | This way the caller can pass more than 2 hashes and can only know which hash was used for a successful connection. We allow up to 4 hashes (next, current, old, older). BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3:cli_pipe: ask for GENSEC_FEATURE_SIGN_PKT_HEADER after the ↵Stefan Metzmacher2017-05-211-7/+13
| | | | | | | | | | | gensec_update() dance Most features should be added before the update() dance, while GENSEC_FEATURE_SIGN_PKT_HEADER needs to be after the dance on the client side. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s3-rpc_cli: add winreg_del_driver_package()Günther Deschner2017-05-092-0/+121
| | | | | | | Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3-rpc_cli: add winreg_get_driver_package()Günther Deschner2017-05-092-0/+157
| | | | | | | Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3-rpc_cli: add winreg_add_driver_package()Günther Deschner2017-05-092-0/+115
| | | | | | | Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3-rpc_cli: add winreg_add_core_driver()Günther Deschner2017-05-092-0/+264
| | | | | | | Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3-rpc_cli: add winreg_get_core_driver()Günther Deschner2017-05-092-0/+185
| | | | | | | Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3/rpc_client: lookupsids error handling of NT_STATUS_NONE_MAPPEDRalph Boehme2017-04-071-1/+2
| | | | | | | | | | NT_STATUS_NONE_MAPPED is not a fatal error, it just means we must return all lsa_TranslatedName's as type SID_NAME_UNKNOWN. Bug: https://bugzilla.samba.org/show_bug.cgi?id=12728 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3/rpc_client: use NT_STATUS_LOOKUP_ERRRalph Boehme2017-04-071-4/+1
| | | | | | | | | No change in behaviour. Bug: https://bugzilla.samba.org/show_bug.cgi?id=12728 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* rpc: Always supply both the remote and local address to the auth subsystemGary Lockyer2017-03-291-0/+1
| | | | | | | | | | | This ensures that gensec, and then the NTLM auth subsystem under it, always gets the remote and local address pointers for potential logging. The local address allows us to know which interface an authentication is on Signed-off-by: Andrew Bartlett <abartlet@samba.org> Pair-Programmed-by: Gary Lockyer <gary@catalyst.net.nz> Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
* cli_netlogon: Add return parms to rpccli_netlogon_password_logonVolker Lendecke2017-03-072-4/+6
| | | | | | | Just for symmetry with rpccli_netlogon_network_logon() Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* cli_netlogon: Remove a fallback for flags=NULLVolker Lendecke2017-03-071-5/+0
| | | | | | | The two callers of rpccli_netlogon_network_logon have flags set !=NULL Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* cli_netlogon: Remove a fallback for authoritative=NULLVolker Lendecke2017-03-071-4/+0
| | | | | | | | The two callers of rpccli_netlogon_network_logon have authoritative set !=NULL Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* Correct "occured" typos.Chris Lamb2017-02-221-2/+2
| | | | | | Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* spoolss: allow truncated driver version in spoolss_driver_version_to_qword()Günther Deschner2017-01-121-2/+4
| | | | | | | | | This has been seen in real life Konica driver defintions. Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3-rpc_client: Pass NULL as no passwordAndreas Schneider2016-12-201-1/+1
| | | | | | | | | | GENSEC expects NULL as no password. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Tue Dec 20 17:37:56 CET 2016 on sn-devel-144
* s3-rpc_cli: Support the use of the object_uuid in rpc_cli interfacesGünther Deschner2016-11-241-1/+10
| | | | | | | Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* spoolss: Use correct values for secdesc and devmode pointersGünther Deschner2016-11-111-2/+2
| | | | | | | | | | | | | | ULONG_PTR needs to be decoded as a uint3264 and not as a 'uint32 *'. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11197 Guenther Pair-Programmed-With: Andreas Schneider <asn@samba.org> Signed-off-by: Guenther Deschner <gd@samba.org> Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3:cli_pipe: add support for DCERPC_AUTH_LEVEL_PACKETGünther Deschner2016-10-261-3/+3
| | | | | | | | Pair-Programmed-With: Stefan Metzmacher <metze@samba.org> Signed-off-by: Guenther Deschner <gd@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3:librpc: move NDR_PRINT_DEBUG() into the caller of dcerpc_pull_ncacn_packet()Stefan Metzmacher2016-10-261-0/+4
| | | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3:librpc: remove bigendian argument from dcerpc_pull_ncacn_packet()Stefan Metzmacher2016-10-261-2/+1
| | | | | | | | We should get this from the packet itself. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* werror: replace WERR_INVALID_PARAM with WERR_INVALID_PARAMETER in ↵Günther Deschner2016-09-283-6/+6
| | | | | | | | | source3/rpc_client/ Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* werror: replace WERR_GENERAL_FAILURE with WERR_GEN_FAILURE in ↵Günther Deschner2016-09-281-2/+2
| | | | | | | | | source3/rpc_client/init_spoolss.c Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* werror: removed WERR_NOMEMGünther Deschner2016-09-281-2/+2
| | | | | | | Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* werror: replace WERR_NOMEM with WERR_NOT_ENOUGH_MEMORY in source3/rpc_client/Günther Deschner2016-09-284-77/+77
| | | | | | | Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* werror: replace WERR_BADFILE with WERR_FILE_NOT_FOUND in source3/rpc_client/Günther Deschner2016-09-281-8/+8
| | | | | | | Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3-rpc_client: use spoolss_driver_version_to_qword in ↵Günther Deschner2016-09-271-7/+3
| | | | | | | | | | | | winreg_printer_ver_to_qword Guenter Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Uri Simchoni <uri@samba.org> Autobuild-User(master): Uri Simchoni <uri@samba.org> Autobuild-Date(master): Tue Sep 27 00:09:18 CEST 2016 on sn-devel-144
* s3-rpc_client: use spoolss_timestr_to_NTTIME in winreg_printer_date_to_NTTIMEGünther Deschner2016-09-261-17/+3
| | | | | | | Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Uri Simchoni <uri@samba.org>
* s3-rpc_client: add spoolss_driver_version_to_qword()Günther Deschner2016-09-262-0/+22
| | | | | | | Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Uri Simchoni <uri@samba.org>
* s3-rpc_client: add spoolss_timestr_to_NTTIME()Günther Deschner2016-09-262-0/+32
| | | | | | | Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Uri Simchoni <uri@samba.org>
* s3-rpc_client: add winreg_set_printserver_secdesc.Günther Deschner2016-09-222-16/+59
| | | | | | | Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3-rpc_client: add winreg_get_printserver_secdesc.Günther Deschner2016-09-222-13/+56
| | | | | | | Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* spoolss: rename spoolss_EnumPrintProcDataTypes to ↵Günther Deschner2016-09-221-21/+21
| | | | | | | | | | | spoolss_EnumPrintProcessorDataTypes This change makes automatic mapping for PAR->RPRN opcodes easier. Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3-spoolss: fix winreg_printer_ver_to_qwordGünther Deschner2016-09-151-3/+4
| | | | | | | | | | We were reporting the OS minor number as the driver version number in all GetDriver/EnumDriver calls. Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3-rpc_client: make it more clear printer driver version is a QWORD not a DWORD.Günther Deschner2016-09-111-3/+3
| | | | | | | Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3:rpc_client: remove unused rpc_pipe_client->max_recv_fragStefan Metzmacher2016-06-242-5/+0
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* CVE-2015-5370: s3:rpc_client: disconnect connection on protocol errorsStefan Metzmacher2016-04-121-3/+64
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=11344 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* CVE-2015-5370: s3:rpc_client: verify auth_context_id in ↵Stefan Metzmacher2016-04-121-0/+8
| | | | | | | | | rpc_pipe_bind_step_one_done() BUG: https://bugzilla.samba.org/show_bug.cgi?id=11344 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* CVE-2015-5370: s3:rpc_client: make use of pipe_auth_data->auth_context_idStefan Metzmacher2016-04-121-3/+6
| | | | | | | | | | | | This is better than using hardcoded values. We need to use auth_context_id = 1 for authenticated connections, as old Samba server (before this patchset) will use a hardcoded value of 1. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11344 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* CVE-2015-5370: s3:rpc_client: pass struct pipe_auth_data to ↵Stefan Metzmacher2016-04-121-14/+8
| | | | | | | | | create_rpc_{bind_auth3,alter_context}() BUG: https://bugzilla.samba.org/show_bug.cgi?id=11344 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* CVE-2015-5370: s3:rpc_client: verify auth_{type,level} in ↵Stefan Metzmacher2016-04-121-0/+15
| | | | | | | | | rpc_pipe_bind_step_one_done() BUG: https://bugzilla.samba.org/show_bug.cgi?id=11344 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* CVE-2015-5370: s3:rpc_client: protect rpc_api_pipe_got_pdu() against too ↵Stefan Metzmacher2016-04-121-0/+5
| | | | | | | | | large payloads BUG: https://bugzilla.samba.org/show_bug.cgi?id=11344 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* CVE-2015-5370: s3:rpc_client: make use of ↵Stefan Metzmacher2016-04-121-15/+96
| | | | | | | | | dcerpc_verify_ncacn_packet_header() in cli_pipe_validate_current_pdu() BUG: https://bugzilla.samba.org/show_bug.cgi?id=11344 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* CVE-2015-5370: s3:rpc_client: make use of dcerpc_pull_auth_trailer()Stefan Metzmacher2016-04-121-8/+6
| | | | | | | | | The does much more validation than dcerpc_pull_dcerpc_auth(). BUG: https://bugzilla.samba.org/show_bug.cgi?id=11344 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* CVE-2015-5370: s3:librpc/rpc: remove auth trailer and possible padding ↵Stefan Metzmacher2016-04-121-23/+10
| | | | | | | | | | | within dcerpc_check_auth() This simplifies the callers a lot. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11344 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* CVE-2015-5370: s3:rpc_client: remove useless frag_length check in ↵Stefan Metzmacher2016-04-121-8/+0
| | | | | | | | | | | rpc_api_pipe_got_pdu() dcerpc_pull_ncacn_packet() already verifies this. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11344 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* CVE-2015-5370: s3:rpc_client: move AS/U hack to the top of ↵Stefan Metzmacher2016-04-121-11/+13
| | | | | | | | | cli_pipe_validate_current_pdu() BUG: https://bugzilla.samba.org/show_bug.cgi?id=11344 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* source3/rpc_client: Fix CID 1273041 Condition is redundantAnoop C S2015-08-071-1/+2
| | | | | | | | | Signed-off-by: Anoop C S <anoopcs@redhat.com> Reviewed-by: Michael Adam <obnox@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Fri Aug 7 01:31:23 CEST 2015 on sn-devel-104
* s3:librpc/rpc: fix padding calculation in dcerpc_guess_sizes()Stefan Metzmacher2015-06-231-1/+0
| | | | | | | | | | | | The padding needs to be relative to the payload start not to the pdu start. We also need align the padding to DCERPC_AUTH_PAD_ALIGNMENT (16 bytes). BUG: https://bugzilla.samba.org/show_bug.cgi?id=11061 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
View Lorry Controller Status