summaryrefslogtreecommitdiff
path: root/source3/rpc_client
Commit message (Collapse)AuthorAgeFilesLines
* s3:librpc/rpc: fix padding calculation in dcerpc_guess_sizes()Stefan Metzmacher2015-07-111-1/+0
| | | | | | | | | | | | | The padding needs to be relative to the payload start not to the pdu start. We also need align the padding to DCERPC_AUTH_PAD_ALIGNMENT (16 bytes). BUG: https://bugzilla.samba.org/show_bug.cgi?id=11061 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (similar to commit b2e042ad9652e2dfb39640de43e09030efc41d3d)
* libcli/auth: also set secure channel type in netlogon_creds_client_init().Günther Deschner2014-08-071-0/+1
| | | | | | | Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> (cherry picked from commit a9d5b2fdf03a25e7669258de6c83288be3335cef)
* rpc_client: retry open on STATUS_PIPE_NOT_AVAILABLEDavid Disseldorp2014-03-101-7/+50
| | | | | | | | | | | | | | | | | | | Windows Server starts some named pipe services on demand, and responds to initial open requests with STATUS_PIPE_NOT_AVAILABLE. The FssagentRpc named pipe on Windows Server 2012 exhibits this behaviour. This change sees rpcclient retry named pipe open requests when the server responds with STATUS_PIPE_NOT_AVAILABLE. The retry logic is contained in an asynchronous tevent_timer callback, to allow for non-blocking callers. Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit ebe6627c1f0e6b488a0c456860a055fd5701e84d) [ddiss@samba.org: rebasead for 4.1 without 46d29d46bc065d51e3f7ca6892] Bug: https://bugzilla.samba.org/show_bug.cgi?id=10484 Initial FSRVP rpcclient requests fail with NT_STATUS_PIPE_NOT_AVAILABLE
* CVE-2013-4408:s3:Ensure LookupNames replies arrays are range checked.Jeremy Allison2013-12-051-0/+18
| | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185 Signed-off-by: Stefan Metzmacher <metze@samba.org> Signed-off-by: Jeremy Allison <jra@samba.org>
* CVE-2013-4408:s3:Ensure LookupSids replies arrays are range checked.Jeremy Allison2013-12-051-1/+16
| | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185 Signed-off-by: Stefan Metzmacher <metze@samba.org> Signed-off-by: Jeremy Allison <jra@samba.org>
* CVE-2013-4408:s3:Ensure we always check call_id when validating an RPC reply.Jeremy Allison2013-12-051-8/+25
| | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* CVE-2013-4408:s3:rpc_client: verify frag_len at least contains the header sizeStefan Metzmacher2013-12-051-0/+8
| | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* build: Build with system md5.h on OpenIndianaAndrew Bartlett2013-06-191-1/+1
| | | | | | | | | | | | | | | | | | | | This changes (again...) our system md5 detection to cope with how OpenIndiana does md5. I'm becoming increasingly convinced this isn't worth our while (we should have just done samba_md5...), but for now this change seems to work on FreeBSD, OpenIndiana and Linux with libbsd. This needs us to rename struct MD5Context -> MD5_CTX, but we provide a config.h define to rename the type bad if MD5_CTX does not exist (it does however exist in the md5.h from libbsd). Andrew Bartlett Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Jun 19 21:32:36 CEST 2013 on sn-devel-104
* s3:rpc_client fix a crashChristian Ambach2013-02-201-1/+1
| | | | | | | | | | | | | | | state->cli->dc does not have to be set (e.g. when running net rpc join against an older Samba PDC), so check it before dereferencing it This fixes Bug 9669 - net rpc join crashes against a Samba 3.0.33 PDC Bug: https://bugzilla.samba.org/show_bug.cgi?id=9669 Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Christian Ambach <ambi@samba.org> Autobuild-Date(master): Wed Feb 20 19:00:52 CET 2013 on sn-devel-104
* s3:rpc_client: s/struct event_context/struct tevent_contextStefan Metzmacher2013-02-195-26/+26
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* s3:rpc_client: make use of samba_tevent_context_init()Stefan Metzmacher2013-02-192-2/+2
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* spoolss: make spoolss deal with ndr64 ULONG_PTR of devmode_ptr and secdesc_ptr.Günther Deschner2013-01-171-2/+2
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* spoolss: Make OpenPrinterEx work with NDR64 by using UserInfo Container.Günther Deschner2013-01-161-4/+4
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* libcli/auth: rename netlogon_creds_decrypt_samlogon() to ↵Günther Deschner2012-12-151-2/+4
| | | | | | | | | netlogon_creds_decrypt_samlogon_validation(). Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s3-rpc_client: use netlogon_creds_aes_encrypt in interactive netlogon samlogon.Günther Deschner2012-12-091-1/+4
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3-rpc_client: support AES encryption in netr_ServerPasswordSet2 client.Günther Deschner2012-12-091-2/+6
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3-rpc_client: use netlogon_creds_arcfour_crypt() in init_netr_CryptPassword.Günther Deschner2012-12-093-5/+5
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3-rpc_client: make dcerpc_lsa_lookup_names_generic() public.Günther Deschner2012-11-302-11/+22
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3-rpc_cli: make dcerpc_lsa_lookup_sids_generic() public.Günther Deschner2012-11-302-11/+20
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3-rpc_cli: Remove some unused wrapping code.Günther Deschner2012-11-302-76/+0
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3-rpc_client: try to use socket_addr if available in rpc_pipe_open_tcp() ↵Günther Deschner2012-11-262-7/+17
| | | | | | | | | | | | (bug #9426) Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Mon Nov 26 17:36:20 CET 2012 on sn-devel-104
* s3-rpc_client: lookup nametype 0x20 in rpc_pipe_open_tcp_port(). (bug #9426)Günther Deschner2012-11-231-1/+1
| | | | | | | | | | | | | | The server name type (0x20) is much more likely to be available in the name cache, as this type gets stored by winbind itself - the primary user of the ncacn_ip_tcp code currently. Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Fri Nov 23 16:30:57 CET 2012 on sn-devel-104
* s3-spoolss: Fix builtin forms order to match Windows again.Andreas Schneider2012-09-261-120/+118
| | | | | | | Thanks to mamachine@gmail.com. Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Wed Sep 26 20:07:44 CEST 2012 on sn-devel-104
* s3:rpc_client: rename pipe_auth_data->user_session_key to transport_session_keyStefan Metzmacher2012-08-011-4/+4
| | | | metze
* s3:rpc_client: make use of smbXcli_session_application_key()Stefan Metzmacher2012-08-011-3/+16
| | | | metze
* s3-rpc_client: Fix updating netlogon credentials.Andreas Schneider2012-07-171-8/+7
| | | | Signed-off-by: Günther Deschner <gd@samba.org>
* s3-rpc_client: Add capabilities check for AES encrypted connections.Andreas Schneider2012-07-171-1/+158
| | | | Signed-off-by: Günther Deschner <gd@samba.org>
* s3-rpc: Return the correct ntstatus depending on the transport.Andreas Schneider2012-07-061-3/+15
|
* s3: Give machine password changes 10 minutes of timeVolker Lendecke2012-06-221-0/+13
| | | | | | | This is what we do at domain join time as well, see lib/netapi/joindomain.c:141 Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s3:rpc_client: tstream_cli_np_open_send() doesn't expect a leading backslashStefan Metzmacher2012-05-281-0/+4
| | | | | | This fixes winbindd against a windows server using SMB2. metze
* s3:libsmb: get rid of cli_state_remote_nameLuk Claes2012-05-282-8/+10
| | | | | Signed-off-by: Luk Claes <luk@debian.org> Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s3: Fix Coverity ID 242715 Uninitialized scalar variableVolker Lendecke2012-05-101-1/+1
| | | | In an error path we are closing hive_hnd without opening it
* s3: Fix Coverity ID 242716 Uninitialized scalar variableVolker Lendecke2012-05-101-1/+2
| | | | In an error path we are closing key_hnd without opening it
* s3: Fix Coverity ID 242691 Dereference before null checkVolker Lendecke2012-05-101-10/+6
| | | | winreg_printer_openkey above already dereferences winreg_handle
* s3: Fix Coverity ID 242692 Dereference before null checkVolker Lendecke2012-05-101-9/+6
| | | | winreg_printer_openkey above already dereferences winreg_handle
* s3: Fix Coverity ID 242693 Dereference before null checkVolker Lendecke2012-05-101-9/+6
| | | | winreg_printer_openkey above already dereferences winreg_handle
* s3: Fix Coverity ID 242694 Dereference before null checkVolker Lendecke2012-05-101-9/+6
| | | | winreg_printer_openkey above already dereferences winreg_handle
* s3: Fix Coverity ID 242695 Dereference before null checkVolker Lendecke2012-05-101-9/+6
| | | | winreg_printer_openkey above already dereferences winreg_handle
* s3: Fix Coverity ID 242696 Dereference before null checkVolker Lendecke2012-05-101-9/+6
| | | | winreg_printer_openkey above already dereferences winreg_handle
* s3: Fix Coverity ID 242697 Dereference before null checkVolker Lendecke2012-05-101-9/+6
| | | | winreg_printer_openkey above already dereferences winreg_handle
* s3: Fix Coverity ID 242698 Dereference before null checkVolker Lendecke2012-05-101-9/+6
| | | | winreg_printer_openkey above already dereferences winreg_handle
* s3: Fix Coverity ID 242699 Dereference before null checkVolker Lendecke2012-05-101-9/+6
| | | | winreg_printer_openkey above already dereferences winreg_handle
* s3: Fix Coverity ID 242700 Dereference before null checkVolker Lendecke2012-05-101-9/+6
| | | | winreg_printer_openkey above already dereferences winreg_handle
* s3: Fix Coverity ID 242701 Dereference before null checkVolker Lendecke2012-05-101-9/+6
| | | | winreg_printer_openkey above already dereferences winreg_handle
* s3: Fix Coverity ID 242702 Dereference before null checkVolker Lendecke2012-05-101-9/+6
| | | | winreg_printer_openkey above already dereferences winreg_handle
* s3: Fix Coverity ID 242703 Dereference before null checkVolker Lendecke2012-05-101-9/+6
| | | | winreg_printer_openkey above already dereferences winreg_handle
* s3: Fix Coverity ID 242704 Dereference before null checkVolker Lendecke2012-05-101-9/+6
| | | | winreg_printer_openkey above already dereferences winreg_handle
* s3: Fix Coverity ID 242705 Dereference before null checkVolker Lendecke2012-05-101-9/+6
| | | | winreg_printer_openkey above already dereferences winreg_handle
* s3: Fix Coverity ID 242706 Dereference before null checkVolker Lendecke2012-05-101-9/+6
| | | | winreg_printer_openkey above already dereferences winreg_handle
* cli_pipe: Avoid sys_connect.Jelmer Vernooij2012-03-241-1/+3
|