summaryrefslogtreecommitdiff
path: root/source3/groupdb
Commit message (Collapse)AuthorAgeFilesLines
* s3/groupdb: clang: 'Value stored during its initialization is never read'Noel Power2019-09-261-1/+1
| | | | | | | | | | | | Fixes: source3/groupdb/mapping_tdb.c:460:11: warning: Value stored to 'status' during its initialization is never read <--[clang] NTSTATUS status = NT_STATUS_OK; ^~~~~~ ~~~~~~~~~~~~ 1 warning generated. Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3/groupdb: clang: Fix 'Value stored during its initialization is never read'Noel Power2019-09-261-1/+1
| | | | | | | | | | | | Fixes: ource3/groupdb/mapping.c:648:11: warning: Value stored to 'status' during its initialization is never read <--[clang] NTSTATUS status = NT_STATUS_OK; ^~~~~~ ~~~~~~~~~~~~ 1 warning generated. Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Jeremy Allison <jra@samba.org>
* source3: Update all consumers of strtoul_err(), strtoull_err() to new APISwen Schillig2019-06-302-10/+16
| | | | | | Signed-off-by: Swen Schillig <swen@linux.ibm.com> Reviewed-by: Ralph Boehme <slow@samba.org> Reviewed-by: Christof Schmitt <cs@samba.org>
* groupdb: Use wrapper for string to integer conversionSwen Schillig2019-03-012-5/+18
| | | | | | | | | | | | In order to detect an value overflow error during the string to integer conversion with strtoul/strtoull, the errno variable must be set to zero before the execution and checked after the conversion is performed. This is achieved by using the wrapper function strtoul_err and strtoull_err. Signed-off-by: Swen Schillig <swen@linux.ibm.com> Reviewed-by: Ralph Böhme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* groupdb: Use dom_sid_str_bufVolker Lendecke2018-12-202-2/+4
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
* passdb: Use dom_sid_str_bufVolker Lendecke2018-11-091-9/+7
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* passdb: Use dom_sid_str_bufVolker Lendecke2018-11-091-7/+9
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* passdb: Use dom_sid_str_bufVolker Lendecke2018-11-021-8/+3
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* lib: Pass mem_ctx to state_path()Volker Lendecke2018-08-171-3/+3
| | | | | | | | Fix a confusing API: Many places TALLOC_FREE the path where it's not clear you have to do it. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* Fix Jean François name to be UTF-8Simo Sorce2018-05-092-2/+2
| | | | | | | | Signed-off-by: Simo Sorce <idra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Wed May 9 10:38:57 CEST 2018 on sn-devel-144
* groupdb: Fix CID 1167984 Ignoring number of bytes readVolker Lendecke2018-04-041-1/+5
| | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* Correct "errror" typos.Chris Lamb2017-02-221-1/+1
| | | | | | Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* Update smbrun to allow for settings environment variables.Trever L. Adams2016-10-131-5/+5
| | | | | | | | | Signed-off-by: Trever L. Adams <trever.adams@gmail.com> Reviewed-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Oct 13 04:26:26 CEST 2016 on sn-devel-144
* Convert all uses of uint32/16/8 to _t in source3/groupdb.Richard Sharpe2015-05-142-7/+7
| | | | | Signed-off-by: Richard Sharpe <rsharpe@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* groupdb: Fix a typoVolker Lendecke2015-03-301-1/+1
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* lib: Remove tdb_compatVolker Lendecke2015-03-171-1/+1
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* mapping_tdb: add missing talloc_free in error pathDavid Disseldorp2014-11-101-0/+1
| | | | | | Reported-by: Michael Croes <mycroes@gmail.com> Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* groupdb: don't leak state_path onto talloc tosDavid Disseldorp2014-11-031-3/+16
| | | | | | | Also check for allocation failures. Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* param: rename lp function and variable from "setprimarygroup_script" to ↵Garming Sam2014-02-071-2/+2
| | | | | | | | "set_primary_group_script" Signed-off-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* param: rename lp function and variable from "deluserfromgroup_script" to ↵Garming Sam2014-02-071-2/+2
| | | | | | | | "delete_user_from_group_script" Signed-off-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* param: rename lp function and variable from "delgroup_script" to ↵Garming Sam2014-02-071-2/+2
| | | | | | | | "delete_group_script" Signed-off-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* param: rename lp function and variable from "addusertogroup_script" to ↵Garming Sam2014-02-071-2/+2
| | | | | | | | "add_user_to_group_script" Signed-off-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* param: rename lp function and variable from "addgroup_script" to ↵Garming Sam2014-02-071-2/+2
| | | | | | | | "add_group_script" Signed-off-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* dbwrap: add a dbwrap_flags argument to db_open()Michael Adam2014-02-071-1/+1
| | | | | | | | | | This is in preparation to support handing flags to backends, in particular activating read only record support for ctdb databases. For a start, this does nothing but adding the parameter, and all databases use DBWRAP_FLAG_NONE. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* group_mapping: Avoid a tallocVolker Lendecke2014-01-091-7/+5
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Christof Schmitt <cs@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Jan 9 20:41:15 CET 2014 on sn-devel-104
* s3:passdb add a gid argument to pdb_create_builtin_aliasChristian Ambach2013-06-211-12/+22
| | | | | | | | make it possible to skip the allocation of a new gid from winbind by specifying the gid to be used Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* loadparm: make the source3/ lp_ functions take an explicit TALLOC_CTX *.Rusty Russell2012-07-181-10/+10
| | | | | | | | | | They use talloc_tos() internally: hoist that up to the callers, some of whom don't want to us talloc_tos(). A simple patch, but hits a lot of files. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
* s3: Add a "lock_order" argument to db_openVolker Lendecke2012-01-181-1/+2
| | | | | | | This will be used to enforce a lock hierarchy between the databases. We have seen deadlocks between locking.tdb, brlock.tdb, serverid.tdb and notify*.tdb. These should be fixed by refusing a dbwrap_fetch_locked that does not follow a defined lock hierarchy.
* s3: Fix a crash in group_mapping.ldb->tdb conversionVolker Lendecke2011-11-281-0/+13
| | | | | | | | When we find a group_mapping.ldb entry without a comment, the upgrade code would have crashed with a NULL dereference Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Mon Nov 28 12:24:08 CET 2011 on sn-devel-104
* s3-passdb: move group mapping headers into passdb.hGünther Deschner2011-10-141-98/+0
| | | | Guenther
* s3-group-mapping: Remove fstrings from GROUP_MAP.Simo Sorce2011-10-124-107/+276
| | | | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Wed Oct 12 19:28:12 CEST 2011 on sn-devel-104
* s3-groupdb: split out groupdb/mapping_tdb.h.Günther Deschner2011-10-124-4/+32
| | | | Guenther
* s3:groupdb: convert mapping_tdb.c to use dbwrap wrapper functions onlyMichael Adam2011-10-111-21/+31
|
* s3:dbwrap: convert dbwrap_fetch(), dbwrap_fetch_bystring() and ↵Michael Adam2011-10-111-4/+5
| | | | dbwrap_fetch_bystring_upper() to NTSTATUS
* s3-passdb: Cleanup use of fstring and move to talloc.Simo Sorce2011-09-261-2/+8
| | | | Signed-off-by: Andreas Schneider <asn@samba.org>
* s3-group-mapping: Remove unused functions.Simo Sorce2011-09-262-36/+0
| | | | Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:dbwrap: move all .c and .h files of dbwrap to lib/dbwrap/Michael Adam2011-07-291-1/+1
| | | | | Autobuild-User: Michael Adam <obnox@samba.org> Autobuild-Date: Fri Jul 29 13:34:22 CEST 2011 on sn-devel-104
* s3:dbwrap: move db_open() to a file dbwrap_open.c of its own.Michael Adam2011-07-291-0/+1
| | | | | | Also start new folder lib/dbwrap/ where dbwrap_open.c is stored and make the fallbacke implementation functoins non-static and create a dbwrap_private.h header file that contains their prototypes.
* tdb_traverse/tdb_traverse_read: check returns for negative, not -1.Rusty Russell2011-06-201-1/+1
| | | | | | | | | | | TDB2 returns a negative error number on failure. This is compatible if we always check for < 0 instead of == -1. Also, there's no tdb_traverse_read in TDB2: we don't try to make traverse reliable any more, so there are no write locks anyway. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
* tdb_compat.h: divert every tdb build and includes to tdb_compatRusty Russell2011-06-201-1/+1
| | | | | | | | We change all the headers and wscript files to use tdb_compat; this means we have one place to decide whether to use TDB1 or TDB2. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
* s3-talloc Change TALLOC_ARRAY() to talloc_array()Andrew Bartlett2011-06-092-2/+2
| | | | | Using the standard macro makes it easier to move code into common, as TALLOC_ARRAY isn't standard talloc.
* s3:groupdb/proto.h: add _GROUPDB_PROTO_H_ guardMichael Adam2011-05-311-0/+5
|
* s3:groupdb/proto.h: add GPL/Copyright headerMichael Adam2011-05-311-0/+22
|
* s3-lib Replace StrCaseCmp() with strcasecmp_m()Andrew Bartlett2011-05-181-7/+7
| | | | | | | strcasecmp_m() never needs to call to talloc, and via next_codepoint() still has an ASCII fast-path bypassing iconv() calls. Andrew Bartlett
* A couple more off-by-one calculations with strlcpy.Jeremy Allison2011-05-061-2/+2
| | | | | Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Fri May 6 18:39:17 CEST 2011 on sn-devel-104
* s3: only include tdb headers where needed.Günther Deschner2011-05-062-0/+2
| | | | Guenther
* Fix warning messages caused by addition of null check in fstrcpy macro.Jeremy Allison2011-05-041-2/+2
|
* s3-passdb: add passdb.h where needed.Günther Deschner2011-03-302-0/+2
| | | | Guenther
* s3-groupdb: move groupdb headers to groupdb/proto.h.Günther Deschner2011-03-301-0/+75
| | | | Guenther
* s3-includes: only include system/filesys.h when needed.Günther Deschner2011-03-301-0/+1
| | | | Guenther
View Lorry Controller Status