summaryrefslogtreecommitdiff
path: root/source/smbd/lanman.c
Commit message (Collapse)AuthorAgeFilesLines
* Fix some "ignoring asprintf result" warningsVolker Lendecke2008-05-051-15/+15
| | | | (cherry picked from commit 155d62ddfd3584d44a493c2aa1ea7f096bcff432)
* Fix typo.Karolin Seeger2008-02-051-1/+1
| | | | Karolin
* Refactor the crypto code after a very helpful conversationJeremy Allison2008-01-041-1/+1
| | | | | | with Volker. Mostly making sure we have data on the incoming packet type, not stored in the smb header. Jeremy.
* Replace sid_string_static by sid_string_dbg in DEBUGsVolker Lendecke2007-12-151-1/+1
|
* Remove the char[1024] strings from dynconfig. ReplaceJeremy Allison2007-12-101-1/+1
| | | | | | them with malloc'ing accessor functions. Should save a lot of static space :-). Jeremy.
* Remove next_token - all uses must now be next_token_talloc.Jeremy Allison2007-12-071-16/+35
| | | | | No more temptations to use static length strings. Jeremy.
* Remove unused wpstring and macros. Stop using pstrcpy in smbd/*.cJeremy Allison2007-12-031-26/+34
| | | | Jeremy.
* Fix bug 5055Volker Lendecke2007-11-261-1/+1
|
* Always check return from push_ascii.Jeremy Allison2007-11-191-0/+6
| | | | Jeremy.
* Remove pstrings from lanman.cJeremy Allison2007-11-121-54/+148
| | | | Jeremy.
* RIP BOOL. Convert BOOL -> bool. I found a few interestingJeremy Allison2007-10-181-50/+50
| | | | | | | bugs in various places whilst doing this (places that assumed BOOL == int). I also need to fix the Samba4 pidl generation (next checkin). Jeremy.
* r25138: More pstring elimination. Add a TALLOC_CTX parameterJeremy Allison2007-10-101-1/+1
| | | | | to unix_convert(). Jeremy.
* r25103: Ensure we don't return unwritten memory (valgrind caught).Jeremy Allison2007-10-101-61/+74
| | | | Jeremy.
* r24949: Remove some static buffersVolker Lendecke2007-10-101-7/+5
|
* r24809: Consolidate the use of temporary talloc contexts.Volker Lendecke2007-10-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds the two functions talloc_stackframe() and talloc_tos(). * When a new talloc stackframe is allocated with talloc_stackframe(), then * the TALLOC_CTX returned with talloc_tos() is reset to that new * frame. Whenever that stack frame is TALLOC_FREE()'ed, then the reverse * happens: The previous talloc_tos() is restored. * * This API is designed to be robust in the sense that if someone forgets to * TALLOC_FREE() a stackframe, then the next outer one correctly cleans up and * resets the talloc_tos(). The original motivation for this patch was to get rid of the sid_string_static & friends buffers. Explicitly passing talloc context everywhere clutters code too much for my taste, so an implicit talloc_tos() is introduced here. Many of these static buffers are replaced by a single static pointer. The intended use would thus be that low-level functions can rather freely push stuff to talloc_tos, the upper layers clean up by freeing the stackframe. The more of these stackframes are used and correctly freed the more exact the memory cleanup happens. This patch removes the main_loop_talloc_ctx, tmp_talloc_ctx and lp_talloc_ctx (did I forget any?) So, never do a tmp_ctx = talloc_init("foo"); anymore, instead, use tmp_ctx = talloc_stackframe() :-) Volker
* r24244: Complete the conversion of reply_trans[s]Volker Lendecke2007-10-101-2/+2
| | | | Remove reply_prep/post_legacy from send_trans_replies
* r24243: Remove reply_prep_legacy from api_replyVolker Lendecke2007-10-101-22/+16
|
* r24130: Explicitly pass flags2 to srvstr_pushVolker Lendecke2007-10-101-1/+1
| | | | | This is in preparation of the trans2 conversion: srvstr_push should not look at inbuf directly.
* r23967: Memleak fix from Atsushi Nakabayashi <nakabayashi@miraclelinux.com>Volker Lendecke2007-10-101-0/+3
| | | | | | Thanks! Volker
* r23784: use the GPLv3 boilerplate as recommended by the FSF and the license textAndrew Tridgell2007-10-101-2/+1
|
* r23779: Change from v2 or later to v3 or later.Jeremy Allison2007-10-101-1/+1
| | | | Jeremy.
* r23055: Rewrite messages.c to use auto-generated marshalling in the tdb. I'mVolker Lendecke2007-10-101-2/+1
| | | | | | | | | | | doing this because for the clustering the marshalling is needed in more than one place, so I wanted a decent routine to marshall a message_rec struct which was not there before. Tridge, this seems about the same speed as it used to be before, the librpc/ndr overhead in my tests was under the noise. Volker
* r22911: Pass a messaging_context to message_send_allVolker Lendecke2007-10-101-1/+2
|
* r22761: This introduces lib/conn_tdb.c with two main functions: ↵Volker Lendecke2007-10-101-1/+2
| | | | | | | | | connections_traverse and connections_forall. This centralizes all the routines that did individual tdb_open("connections.tdb") and direct tdb_traverse. Volker
* r22561: Fix a memleak in lanman.c: Nobody would free the session_list.Volker Lendecke2007-10-101-1/+1
| | | | Volker
* r22391: Looks bigger than it is. Make "inbuf" availableJeremy Allison2007-10-101-5/+19
| | | | | | | to all callers of smb_setlen (via set_message() calls). This will allow the server to reflect back the correct encryption context. Jeremy.
* r22065: First logic change I've found :-(. We were being tooJeremy Allison2007-10-101-9/+24
| | | | | | | | restrictive about strings being NULL. If an info level doesn't use a subformat the subformat string may be missing (null). Add debug statements to help track this. Jeremy
* r22050: Fix a couple of off-by-one errors in the rapJeremy Allison2007-10-101-3/+15
| | | | | | | call patch. Jerry, this works now for displaying shares on Win9x (and hopefully everything else as well :-). Jeremy.
* r22045: As Volker noticed, skip_string's last argument isJeremy Allison2007-10-101-94/+98
| | | | | redundent. Remove it. Jeremy.
* r22044: Remove the only skip_string(...,2) callerVolker Lendecke2007-10-101-1/+1
|
* r22043: Comparing lanman.c with -r22013 is now MUCH easier, thanks! This ↵Volker Lendecke2007-10-101-3/+0
| | | | | | | | | | | | | | looks much easier to review! Damn close to what I had in my tree, just the fn names were slightly different. This removes one unnecessary dupe. Next thing is to get rid of the parameter "n" of skip_string, there is only one (!) caller that does not pass in 1.... Volker
* r22042: Try and clean up my own mess using the API VolkerJeremy Allison2007-10-101-71/+76
| | | | | | | | | | | | | | suggested. I now use : BOOL is_offset_safe(const char *buf_base, size_t buf_len, char *ptr, size_t off) char *get_safe_ptr(const char *buf_base, size_t buf_len, char *ptr, size_t off) char *get_safe_str_ptr(const char *buf_base, size_t buf_len, char *ptr, size_t off) int get_safe_SVAL(const char *buf_base, size_t buf_len, char *ptr, size_t off, int failval) int get_safe_IVAL(const char *buf_base, size_t buf_len, char *ptr, size_t off, int failval) Volker, please criticize and comment. Thanks, Jeremy.
* r22017: After changing 2000 lines of this I think this is needed :-).Jeremy Allison2007-10-101-0/+1
| | | | Jeremy.
* r22014: Make us pass RANDOMIPC test again :-(. This is an ugly check-in,Jeremy Allison2007-10-101-277/+601
| | | | | but I've no option. Jeremy.
* r19963: Add 'registry shares = yes' and registry key security descriptors.Volker Lendecke2007-10-101-0/+1
|
* r19203: Part two of returning our real name. This code is a bit ancient... :-)Volker Lendecke2007-10-101-1/+1
|
* r19184: W2k3 returns its name for the GetServerInfo RAP call. Do the same.Volker Lendecke2007-10-101-1/+1
| | | | | | Implement 'net rap server name'. Volker
* r18271: Big change:Gerald Carter2007-10-101-1/+1
| | | | | | | | | | | * autogenerate lsa ndr code * rename 'enum SID_NAME_USE' to 'enum lsa_SidType' * merge a log more security descriptor functions from gen_ndr/ndr_security.c in SAMBA_4_0 The most embarassing thing is the "#define strlen_m strlen" We need a real implementation in SAMBA_3_0 which I'll work on after this code is in.
* r17879: Make it explicit that we can never pass NULL for buflen or stringlen.Jeremy Allison2007-10-101-6/+2
| | | | | Stanford Checker fix. Jeremy.
* r16945: Sync trunk -> 3.0 for 3.0.24 code. Still needJeremy Allison2007-10-101-13/+32
| | | | | | | to do the upper layer directories but this is what everyone is waiting for.... Jeremy.
* r16241: Fix Klocwork #106 and others like it.Jeremy Allison2007-10-101-5/+6
| | | | | | | | | | | | | | Make 2 important changes. pdb_get_methods() returning NULL is a *fatal* error. Don't try and cope with it just call smb_panic. This removes a *lot* of pointless "if (!pdb)" handling code. Secondly, ensure that if samu_init() fails we *always* back out of a function. That way we are never in a situation where the pdb_XXX() functions need to start with a "if (sampass)" test - this was just bad design, not defensive programming. Jeremy.
* r16230: Fix Klocwork #861 and others. localtime and asctimeJeremy Allison2007-10-101-0/+3
| | | | | can return NULL. Ensure we check all returns correctly. Jeremy.
* r13983: Fix Coverity bug # 111Volker Lendecke2007-10-101-0/+1
|
* r13915: Fixed a very interesting class of realloc() bugs found by Coverity.Jeremy Allison2007-10-101-10/+166
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | realloc can return NULL in one of two cases - (1) the realloc failed, (2) realloc succeeded but the new size requested was zero, in which case this is identical to a free() call. The error paths dealing with these two cases should be different, but mostly weren't. Secondly the standard idiom for dealing with realloc when you know the new size is non-zero is the following : tmp = realloc(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } However, there were *many* *many* places in Samba where we were using the old (broken) idiom of : p = realloc(p, size) if (!p) { return error; } which will leak the memory pointed to by p on realloc fail. This commit (hopefully) fixes all these cases by moving to a standard idiom of : p = SMB_REALLOC(p, size) if (!p) { return error; } Where if the realloc returns null due to the realloc failing or size == 0 we *guarentee* that the storage pointed to by p has been freed. This allows me to remove a lot of code that was dealing with the standard (more verbose) method that required a tmp pointer. This is almost always what you want. When a realloc fails you never usually want the old memory, you want to free it and get into your error processing asap. For the 11 remaining cases where we really do need to keep the old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR, which can be used as follows : tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the pointer p, even on size == 0 or realloc fail. All this is done by a hidden extra argument to Realloc(), BOOL free_old_on_error which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR macros (and their array counterparts). It remains to be seen what this will do to our Coverity bug count :-). Jeremy.
* r13590: * replace all pdb_init_sam[_talloc]() calls with samu_new()Gerald Carter2007-10-101-2/+2
| | | | * replace all pdb_{init,fill}_sam_pw() calls with samu_set_unix()
* r13576: This is the beginnings of moving the SAM_ACCOUNT data structureGerald Carter2007-10-101-3/+3
| | | | | | | | | | | | | | | | | | | | | | | to make full use of the new talloc() interface. Discussed with Volker and Jeremy. * remove the internal mem_ctx and simply use the talloc() structure as the context. * replace the internal free_fn() with a talloc_destructor() function * remove the unnecessary private nested structure * rename SAM_ACCOUNT to 'struct samu' to indicate the current an upcoming changes. Groups will most likely be replaced with a 'struct samg' in the future. Note that there are now passbd API changes. And for the most part, the wrapper functions remain the same. While this code has been tested on tdb and ldap based Samba PDC's as well as Samba member servers, there are probably still some bugs. The code also needs more testing under valgrind to ensure it's not leaking memory. But it's a start......
* r13571: Replace all calls to talloc_free() with thye TALLOC_FREE()Gerald Carter2007-10-101-2/+2
| | | | macro which sets the freed pointer to NULL.
* r13443: Fix the build.Günther Deschner2007-10-101-2/+2
| | | | Guenther
* r13316: Let the carnage begin....Gerald Carter2007-10-101-1240/+1450
| | | | Sync with trunk as off r13315
* r12163: Change lookup_sid and lookup_name to return const char * instead of ↵Volker Lendecke2007-10-101-1/+1
| | | | | | | | char *, use a temporary talloc_ctx for clarity. Volker
View Lorry Controller Status