summaryrefslogtreecommitdiff
path: root/source/lib/tdb/common/traverse.c
Commit message (Collapse)AuthorAgeFilesLines
* Convert in_transaction to a bool. Add the same fix VolkerJeremy Allison2008-05-201-4/+9
| | | | | used for tdb_traverse() to tdb_traverse_read(). Jeremy.
* Fix nesting tdb_traverse in a transactionVolker Lendecke2008-05-201-3/+8
| | | | | | | | | | | | | | | | | Calling tdb_traverse inside a transaction led to the transaction lock being held indefinitely. This was caused by the tdb_transaction_lock/unlock inside tdb_traverse: The transaction code holds the global lock at offset TRANSACTION_LOCK. The call to tdb_transaction_lock does nothing because the transaction_lock is already being held. tdb_transaction_unlock inside tdb_wrap resets tdb->have_transaction_lock but does not release the kernel-level fcntl lock. transaction_commit later on does not release that fcntl lock either, because tdb->have_transaction_lock was already reset by tdb_transaction(). This patch does fix that problem for me. An alternative would be to make tdb->have_transaction_lock a counter that can cope with proper nesting, maybe in other places as well. Volker
* Sync tdb with the tdb changes in ctdb. Spoke to tridge aboutJeremy Allison2008-01-111-0/+3
| | | | | this. Fixes insidious problem with order n^2 freelist merging. Jeremy.
* Add a warning for a potential bug I've run intoVolker Lendecke2007-11-281-0/+3
|
* Keep the tdb code in sync with Samba4.Jeremy Allison2007-11-061-9/+5
| | | | | | | | | | | | | | | | | | | Mainly this is the svn changes : ------------------------------------------------------------------------ r23238 | tridge | 2007-05-30 01:15:49 -0700 (Wed, 30 May 2007) | 6 lines merged transaction lock changes from ctdb this ensures that having the global lock also implies the transaction lock ------------------------------------------------------------------------ r22832 | tridge | 2007-05-13 18:00:06 -0700 (Sun, 13 May 2007) | 3 lines merged the latest tdb changes from ctdb to Samba4 Jeremy.
* r24340: Use standard data type uint32_t rather than tdb-specific u32.Jelmer Vernooij2007-10-101-1/+1
|
* r23798: updated old Temple Place FSF addresses to new URLAndrew Tridgell2007-10-101-2/+1
|
* r23790: LGPLv3+ conversion for our LGPLv2+ library codeAndrew Tridgell2007-10-101-1/+1
|
* r23371: Fix the misleading comment I added - it really *should*Jeremy Allison2007-10-101-2/+2
| | | | | | say "locks chain and returned record", not "and returns record" Jeremy.
* r23370: Traverse in tdb wasn't consistently using theJeremy Allison2007-10-101-8/+10
| | | | | | | | | | | | travlocks.lock_rw for lock read/write types, it was sometimes using it (tdb_next_lock) and sometimes explicitly using F_WRLCK instead. Change this to consistently use travlocks.lock_rw only. I'm pretty sure about this fix (else I woudn't be checking this in :-) but tridge and Volker please review. Jeremy.
* r22249: move tdb code to lib/tdb/ as in samba4Stefan Metzmacher2007-10-101-0/+335
metze