summaryrefslogtreecommitdiff
path: root/selftest/knownfail.d
Commit message (Collapse)AuthorAgeFilesLines
* s4:dsdb:acl_read: Implement "List Object" mode featureStefan Metzmacher2020-10-271-50/+0
| | | | | | | | | | | | | | | | | | | | | | | See [MS-ADTS] 5.1.3.3.6 Checking Object Visibility I tried to avoid any possible overhead for the common cases: - SEC_ADS_LIST (List Children) is already granted by default - fDoListObject is off by default Overhead is only added if the administrator turned on the fDoListObject feature and removed SEC_ADS_LIST (List Children) from a parent object. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14531 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Wed Oct 21 08:48:02 UTC 2020 on sn-devel-184 (cherry picked from commit 7223f6453b1b38c933c9480c637ffd06d9f39b97)
* s4:dsdb:acl_read: defer LDB_ERR_NO_SUCH_OBJECTStefan Metzmacher2020-10-271-104/+0
| | | | | | | | | | | We may need to return child objects even if the base dn is invisible. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14531 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> (cherry picked from commit e1529bedb2b6c8553e69a42537ac0cffd03af6d6)
* s4:dsdb:tests: add AclVisibiltyTestsStefan Metzmacher2020-10-271-0/+154
| | | | | | | | | | | | | | | | | | | | | | | | | | This tests a sorts of combinations in order to demonstrate the visibility of objects depending on: - with or without fDoListObject - with or without explicit DENY ACEs - A hierachy of objects with 4 levels from the base dn - SEC_ADS_LIST (List Children) - SEC_ADS_LIST_LIST_OBJECT (List Object) - SEC_ADS_READ_PROP - all possible scopes and basedns This demonstrates that NO_SUCH_OBJECT doesn't depend purely on the visibility of the base dn, it's still possible to get children returned und an invisible base dn. It also demonstrates the additional behavior with "List Object" mode. See [MS-ADTS] 5.1.3.3.6 Checking Object Visibility BUG: https://bugzilla.samba.org/show_bug.cgi?id=14531 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> (cherry picked from commit 06d134406739e76b97273db3023855150dbaebbc)
* s3:smbd: Fix %U substitutions if it contains a domain nameAndreas Schneider2020-09-141-1/+0
| | | | | | | | | | | 'valid users = DOMAIN\%U' worked with Samba 3.6 and broke in a newer version. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14467 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> (cherry picked from commit 5de7c91e6d4e98f438157a7675c8582cabdd828d)
* s3:tests: Add test for 'valid users = DOMAIN\%U'Andreas Schneider2020-09-141-0/+1
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14467 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> (cherry picked from commit 53b6dd951249052772e1ffcf651b7efd0963b931)
* s3:share_mode_lock: make sure share_mode_cleanup_disconnected() removes the ↵Stefan Metzmacher2020-09-031-1/+0
| | | | | | | | | | | | | | | | | | | | | | | record This fixes one possible trigger for "PANIC: assert failed in get_lease_type()" https://bugzilla.samba.org/show_bug.cgi?id=14428 This is no longer enough to remove the record: d->have_share_modes = false; d->modified = true; Note that we can remove it completely from share_mode_cleanup_disconnected() as share_mode_forall_entries() already sets it when there are no entries left. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14428 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> (cherry picked from commit b5c0874fd5d31e252cf9ac8b84bde5c536b1e8ef)
* s3:share_mode_lock: reproduce problem with stale disconnected share mode entriesStefan Metzmacher2020-09-031-0/+1
| | | | | | | | | | | | | | This reproduces the origin of "PANIC: assert failed in get_lease_type()" (https://bugzilla.samba.org/show_bug.cgi?id=14428). share_mode_cleanup_disconnected() removes disconnected entries from leases.tdb and brlock.tdb but not from locking.tdb. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14428 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> (cherry picked from commit 444f2bedf723b89bb9f493c47812bff2154c4113)
* tldap: Receiving "msgid == 0" means the connection is deadVolker Lendecke2020-09-031-1/+0
| | | | | | | | | | | | | | | | | | We never use msgid=0, see tldap_next_msgid(). RFC4511 section 4.4.1 says that the unsolicited disconnect response uses msgid 0. We don't parse this message, which supposedly is an extended response: Windows up to 2019 sends an extended response in an ASN.1 encoding that does not match RFC4511. Bug: https://bugzilla.samba.org/show_bug.cgi?id=14465 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Fri Aug 21 20:37:25 UTC 2020 on sn-devel-184 (cherry picked from commit ccaf661f7c75717341140e3fbfb2a48f96ea952c)
* test: Test winbind idmap_ad ticket expiry behaviourVolker Lendecke2020-09-031-0/+1
| | | | | | | | | | | | | | | | | | | | | | We need to make sure that winbind's idmap_ad deals fine with an expired krb ticket used to connect to AD via LDAP. In a customer situation we have seen the RFC4511 section 4.4.1 unsolicited ldap exop response coming through, but the TCP disconnect that Windows seems to do after that did not make it. Winbind deals fine with a TCP disconnect, but right now it does not handle just the section 4.4.1 response properly: It completely hangs. This test requests a ticket valid for 5 seconds and makes the LDAP server postpone the TCP disconnect after the ticket expiry for 10 seconds. The tests that winbind reacts to the ticket expiry exop response by making sure in this situation the wbinfo call running into the issue takes less than 8 seconds. If it did not look at the expiry exop response, it would take more than 10 seconds. Bug: https://bugzilla.samba.org/show_bug.cgi?id=14465 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit a4ecd112e7754ab25bcae749594952a28c4c8905)
* ldap_server: Terminate LDAP connections on krb ticket expiryVolker Lendecke2020-09-031-1/+0
| | | | | | | | | | | | | | | | | See RFC4511 section 4.4.1 and https://lists.samba.org/archive/cifs-protocol/2020-August/003515.html for details: Windows terminates LDAP connections when the krb5 ticket expires, Samba should do the same. This patch slightly deviates from Windows behaviour by sending a LDAP exop response with msgid 0 that is ASN1-encoded conforming to RFC4511. Bug: https://bugzilla.samba.org/show_bug.cgi?id=14465 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit eb72f887b0bf91c050fd5d911f58a1b3ff9b8bcc)
* torture: Test ldap session expiryVolker Lendecke2020-09-031-0/+1
| | | | | | | | | | | | | | | LDAP connections should time out when the kerberos ticket used to authenticate expires. Windows does this with a RFC4511 section 4.4.1 message (that as of August 2020 is encoded not according to the RFC) followed by a TCP disconnect. ldb sees the section 4.4.1 as a protocol violation and returns LDB_ERR_PROTOCOL_ERROR. Bug: https://bugzilla.samba.org/show_bug.cgi?id=14465 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit 35c4bb0b0c55a65490fe199edb1a534548104e95)
* param: Allow tests to silence deprecation warningsAndrew Bartlett2020-08-241-1/+0
| | | | | | | | | | This helps make output sensitive tests more reliable. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14460 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit d14cc45c98a77fb8a6ac96181eec33f368b8dbd8)
* selftest: Add test for suppression of deprecation warningsAndrew Bartlett2020-08-241-0/+1
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14460 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit d3ff49f48507d8a64b9c4847f79d7939f647e6f0)
* winbind: Fix lookuprids cache problemVolker Lendecke2020-08-101-1/+0
| | | | | | | | | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=14435 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Thu Jul 9 21:40:52 UTC 2020 on sn-devel-184 (cherry picked from commit cd4122d91e942ca465c03505d5e148117f505ba4) Autobuild-User(v4-13-test): Stefan Metzmacher <metze@samba.org> Autobuild-Date(v4-13-test): Mon Aug 10 10:46:37 UTC 2020 on sn-devel-184
* winbind: Add test for lookuprids cache problemVolker Lendecke2020-08-101-0/+1
| | | | | | | | | | | | | | | | | | | | | When reading entries from gencache, wb_cache_rids_to_names() can return STATUS_SOME_UNMAPPED, which _wbint_LookupRids() does not handle correctly. This test enforces this situation by filling gencache with one wbinfo -R and then erasing the winbindd_cache.tdb. This forces winbind to enter the domain helper process, which will then read from gencache filled with the previous wbinfo -R. Without having the entries cached this does not happen because wb_cache_rids_to_names() via the do_query: path calls deep inside calls dcerpc_lsa_lookup_sids_noalloc(), which hides the STATUS_SOME_UNMAPPED that came in as lsa_LookupSids result value. Bug: https://bugzilla.samba.org/show_bug.cgi?id=14435 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> (cherry picked from commit 04eafce653afcff517317d2b190acc4f0cbf4c61)
* kdc:db-glue: ignore KRB5_PROG_ETYPE_NOSUPP also for Primary:KerberosStefan Metzmacher2020-08-071-1/+0
| | | | | | | | | | | | | | | | | | | | | | | Currently we only ignore KRB5_PROG_ETYPE_NOSUPP for Primary:Kerberos-Newer-Keys, but not for Primary:Kerberos. If a service account has msDS-SupportedEncryptionTypes: 31 and DES keys stored in Primary:Kerberos, we'll pass the DES key to smb_krb5_keyblock_init_contents(), but may get KRB5_PROG_ETYPE_NOSUPP. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14354 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Isaac Boukris <iboukris@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Tue Jul 28 14:04:26 UTC 2020 on sn-devel-184 (cherry picked from commit 4baa7cc8e473f6b63316b4ae5db34796c0f864c3) Autobuild-User(v4-13-test): Stefan Metzmacher <metze@samba.org> Autobuild-Date(v4-13-test): Fri Aug 7 10:39:26 UTC 2020 on sn-devel-184
* Add a test with old msDS-SupportedEncryptionTypesIsaac Boukris2020-08-071-0/+1
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14354 Signed-off-by: Isaac Boukris <iboukris@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit 07399831794e28c7c2cf0140d0f1d1b5538b5f60)
* selftest/Samba3: make use of 'smbd:FSCTL_SMBTORTURE = yes'Stefan Metzmacher2020-07-081-1/+0
| | | | | | | | | | | | | | | This makes sure the lease/oplock break retry logic based on missing TCP acks is tested. We're still not able to run multichannel tests automatically, as socket wrapper doesn't support fd-passing yet. But this testing this with single channels is a good start. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s4:torture/smb2: split smb2.oplock.batch22 into a and bStefan Metzmacher2020-07-081-0/+1
| | | | | | | | | | batch22a tests the timeout on a valid connection and batch22b tests the timeout on a broken/blocked connection. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3:smbcacls: Add support for DFS pathAnubhav Rakshit2020-07-071-1/+0
| | | | | | | | | | | | | | | | | smbcacls does not handle DFS paths correctly. This is beacuse once the command encounters a path which returns STATUS_PATH_NOT_COVERED, it does not attempt a GET REFERRAL. We use cli_resolve_path API to perform a DFS path resolution to solve the above problem. Additionally this removes the known fail against smbcacls tests Signed-off-by: Anubhav Rakshit <anubhav.rakshit@gmail.com> Reviewed-by: Noel Power <noel.power@suse.com> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Tue Jul 7 23:03:00 UTC 2020 on sn-devel-184
* selftest: run smbcacls test against a share with a DFS linkNoel Power2020-07-071-0/+1
| | | | | | | | | | | | | The commit creates a dfs link in existing 'fileserver' env share msdfs_share. Additionally we create a new dfs target in a new share (with associated directory) Additionally add a known fail as smbcacls doesn't not yet navigate DFS links. A subsequent commit will fix smcacls to handle DFS (and remove the knownfail) Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3:smbd: make sure vfs_ChDir() always sets conn->cwd_fsp->fh->fd = AT_FDCWDStefan Metzmacher2020-07-021-1/+0
| | | | | | | | | This is what all consumers of conn->cwd_fsp->fh->fd expect! BUG: https://bugzilla.samba.org/show_bug.cgi?id=14427 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s4:torture/smb2: add smb2.delete-on-close-perms.BUG14427Stefan Metzmacher2020-07-021-0/+1
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14427 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* CVE-2020-14303: s4 nbt: fix busy loop on empty UDP packetGary Lockyer2020-07-021-1/+0
| | | | | | | | | | | | An empty UDP packet put the nbt server into a busy loop that consumes 100% of a cpu. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14417 Signed-off-by: Gary Lockyer <gary@catalyst.net.nz> Autobuild-User(master): Karolin Seeger <kseeger@samba.org> Autobuild-Date(master): Thu Jul 2 10:26:24 UTC 2020 on sn-devel-184
* CVE-2020-14303 Ensure an empty packet will not DoS the NBT serverAndrew Bartlett2020-07-021-0/+1
| | | | Signed-off-by: Andrew Bartlett <abartlet@samba.org>
* CVE-2020-10760 dsdb: Add tests for paged_results and VLV over the Global ↵Andrew Bartlett2020-07-021-1/+1
| | | | | | | | Catalog port This should avoid a regression. Signed-off-by: Andrew Bartlett <abartlet@samba.org>
* CVE-2020-10745: ndr/dns-utils: prepare for NBT compatibilityDouglas Bagnall2020-07-022-3/+0
| | | | | | | | | | | | | | | | | NBT has a funny thing where it sometimes needs to send a trailing dot as part of the last component, because the string representation is a user name. In DNS, "example.com", and "example.com." are the same, both having three components ("example", "com", ""); in NBT, we want to treat them differently, with the second form having the three components ("example", "com.", ""). This retains the logic of e6e2ec0001fe3c010445e26cc0efddbc1f73416b. Also DNS compression cannot be turned off for NBT. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14378 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
* CVE-2020-10745: dns_util/push: forbid names longer than 255 bytesDouglas Bagnall2020-07-021-1/+0
| | | | | | | | As per RFC 1035. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14378 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
* CVE-2020-10745: ndr_dns: do not allow consecutive dotsDouglas Bagnall2020-07-022-2/+0
| | | | | | | | | | The empty subdomain component is reserved for the root domain, which we should only (and always) see at the end of the list. That is, we expect "example.com.", but never "example..com". BUG: https://bugzilla.samba.org/show_bug.cgi?id=14378 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
* CVE-2020-10745: librpc/tests: cmocka tests of dns and ndr stringsDouglas Bagnall2020-07-021-0/+4
| | | | | | | | | | | These time the push and pull function in isolation. Timing should be under 0.0001 seconds on even quite old hardware; we assert it must be under 0.2 seconds. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14378 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
* CVE-2020-10745: pytests: hand-rolled invalid dns/nbt packet testsDouglas Bagnall2020-07-021-0/+2
| | | | | | | | | | | | The client libraries don't allow us to make packets that are broken in certain ways, so we need to construct them as byte strings. These tests all fail at present, proving the server is rendered unresponsive, which is the crux of CVE-2020-10745. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14378 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
* s3:smbd: fix the handling of the durable_v2_timeoutStefan Metzmacher2020-06-271-24/+0
| | | | | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Sat Jun 27 05:42:05 UTC 2020 on sn-devel-184
* s4:torture/smb2: adjust durable v2 tests to pass against Windows Server 2019Stefan Metzmacher2020-06-271-0/+24
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3: smbd: Allow a SHUTDOWN_CLOSE on a file with outstanding aio if there are ↵Jeremy Allison2020-06-241-2/+0
| | | | | | | | | | | | | | | | | | | no client connections alive. The process is exiting now so pthreads will never complete to cause problems. Remove the knownfail.d/aio_outstanding entry. Followup-bugfix for: BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Jun 24 20:14:15 UTC 2020 on sn-devel-184
* s3: selftest: Add samba3.blackbox.aio-outstanding test.Jeremy Allison2020-06-241-0/+2
| | | | | | | | | | | | | Shows smbd panics if connection is terminated (torn down) by killing the client with outstanding aio requests in the queue. As we're closing smbd we should cope with this. Followup-bugfix for: BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* Properly handle msDS-AdditionalDnsHostName returned from Windows DCIsaac Boukris2020-06-181-3/+0
| | | | | | | | | | | | | | Windows DC adds short names for each specified msDS-AdditionalDnsHostName attribute, but these have a suffix of "\0$" and thus fail with ldap_get_values(), use ldap_get_values_len() instead. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14406 Signed-off-by: Isaac Boukris <iboukris@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Isaac Boukris <iboukris@samba.org> Autobuild-Date(master): Thu Jun 18 16:43:47 UTC 2020 on sn-devel-184
* selftest: add tests for binary msDS-AdditionalDnsHostNameIsaac Boukris2020-06-181-0/+3
| | | | | | | | | Like the short names added implicitly by Windows DC. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14406 Signed-off-by: Isaac Boukris <iboukris@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* db-glue.c: set forwardable flag on cross-realm tgt ticketsIsaac Boukris2020-06-122-3/+0
| | | | | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14233 Match Windows behavior and allow the forwardable flag to be set in cross-realm tickets. We used to allow forwardable to any server, but now that we apply disallow-forwardable policy in heimdal we need to explicitly allow in the corss-realm case (and remove the workaround we have for it the MIT plugin). Signed-off-by: Isaac Boukris <iboukris@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Fri Jun 12 22:10:34 UTC 2020 on sn-devel-184
* selftest: test forwardable flag in cross-realm with s4u2proxyIsaac Boukris2020-06-121-0/+2
| | | | | Signed-off-by: Isaac Boukris <iboukris@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* selftest: test forwardable flag in cross-realm tgt ticketsIsaac Boukris2020-06-121-0/+1
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14233 Signed-off-by: Isaac Boukris <iboukris@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* heimdal: apply disallow-forwardable on server in TGS requestIsaac Boukris2020-06-121-1/+0
| | | | | | | | | | upstream commit: 839b073facd2aecda6740224d73e560bc79965dc BUG: https://bugzilla.samba.org/show_bug.cgi?id=14233 Signed-off-by: Isaac Boukris <iboukris@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* selftest: add test for disallowed-forwardable serverIsaac Boukris2020-06-121-0/+1
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14233 Signed-off-by: Isaac Boukris <iboukris@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s3: VFS: default. Ensure read_dfs_pathat() returns stat info.Jeremy Allison2020-06-031-3/+0
| | | | | | | | | | | | | | Remove the knownfail.d/msdfs-attr file. Everything now passes. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14391 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Wed Jun 3 06:19:21 UTC 2020 on sn-devel-184
* s3: torture: Add test for getting attibutes on an MSDFS link.Jeremy Allison2020-06-031-0/+3
| | | | | | | | | Mark as knownfail for now. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14391 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* Add msDS-AdditionalDnsHostName entries to the keytabIsaac Boukris2020-05-291-2/+0
| | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14396 Signed-off-by: Isaac Boukris <iboukris@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* Add a test for msDS-AdditionalDnsHostName entries in keytabIsaac Boukris2020-05-291-0/+2
| | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14396 Signed-off-by: Isaac Boukris <iboukris@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* Fix accidental overwrite of dnsHostName by the last netbios aliasIsaac Boukris2020-05-291-2/+0
| | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14396 Signed-off-by: Isaac Boukris <iboukris@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* Add a test to check dNSHostName with netbios aliasesIsaac Boukris2020-05-291-0/+2
| | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14396 Signed-off-by: Isaac Boukris <iboukris@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* smbd: Protect smbd_smb2_getinfo_send() against invalid quota filesVolker Lendecke2020-05-291-2/+0
| | | | | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=14367 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Fri May 29 09:55:10 UTC 2020 on sn-devel-184
* torture3: Check error code for quotactl on a non-quota file handleVolker Lendecke2020-05-291-0/+4
| | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=14367 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>