summaryrefslogtreecommitdiff
path: root/pidl
Commit message (Collapse)AuthorAgeFilesLines
* s4: COM: Remove talloc_autofree_context() from (unused) COM code.Jeremy Allison2017-07-261-3/+3
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12932 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* libndr/compression: pass down compressed length in ndr_pull_compression_startGünther Deschner2017-07-191-1/+2
| | | | | | | Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* pidl:NDR/Parser: add missing {start,end}_flags() to ParseElementPrint()Stefan Metzmacher2017-06-271-0/+4
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* pidl:NDR/Parser: initialize [skip] values in ndr_pull_*Stefan Metzmacher2017-06-261-0/+3
| | | | | | | | It's too dangerous to leave values uninitialzed! [skip_noinit] can be used if required. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* pidl:NDR/Parser: add "skip_noinit" elementStefan Metzmacher2017-06-262-6/+7
| | | | | | | | In future "skip" will be changed to initialize the element with ZERO_STRUCT() on ndr_pull_*. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* pidl:NDR/Parser: fix "skip" for pointersStefan Metzmacher2017-06-261-10/+30
| | | | | | | | We should handle the "skip" at the element level before we traverse trough the element levels. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* pidl: Fix array range checks in python outputVolker Lendecke2017-06-201-3/+6
| | | | | | | | | | | | | | | | | | Without this, we generated code like if (ndr_table_dnsserver.num_calls < 0) { PyErr_SetString(PyExc_TypeError, "Internal Error, ndr_interface_call missing for py_DnssrvOperation_ndr_pack"); return NULL; } call = &ndr_table_dnsserver.calls[0]; This does not really make sense, and Coverity found comparing the unsigned num_calls against <0 a bit pointless. Should fix 138 Coverity findings and make the code a bit more correct. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* python3: Use "y#" instead of "s#" for binary data in PyArg_ParseTuplePetr Viktorin2017-05-191-3/+3
| | | | | | | | | | | | | | | | | The "s#" format code for PyArg_ParseTupleAndKeywords and Py_BuildValue converts a char* and size to/from Python str (with utf-8 encoding under Python 3). In some cases, we want bytes (str on Python 2, bytes on 3) instead. The code for this is "y#" in Python 3, but that is not available in 2. Introduce a PYARG_BYTES_LEN macro that expands to "s#" or "y#", and use that in: - credentials.get_ntlm_response (for input and output) - ndr_unpack argument in PIDL generated code Signed-off-by: Petr Viktorin <pviktori@redhat.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* pidl: Fix Coverity warnings from duplicate NULL checks.Jeremy Allison2017-05-061-25/+38
| | | | | | | | | | | Pair-Programmed-With: Stefan Metzmacher <metze@samba.org> Signed-off-by: Jeremy Allison <jra@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Sat May 6 16:03:17 CEST 2017 on sn-devel-144
* lib: modules: Change XXX_init interface from XXX_init(void) to ↵Jeremy Allison2017-04-221-2/+2
| | | | | | | | | | | | | | | | | | | | XXX_init(TALLOC_CTX *) Not currently used - no logic changes inside. This will make it possible to pass down a long-lived talloc context from the loading function for modules to use instead of having them internally all use talloc_autofree_context() which is a hidden global. Updated all known module interface numbers, and added a WHATSNEW. Signed-off-by: Jeremy Allison <jra@samba.org> Signed-off-by: Ralph Böhme <slow@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Sat Apr 22 01:17:00 CEST 2017 on sn-devel-144
* python: pidl: Port Python interface generatorLumir Balhar2017-03-101-23/+34
| | | | | | | | | | | | Port PIDL generator of Python interfaces to generate interfaces in Python 3 compatible form. Python 2.7 is now required, so we can use PyCapsule in both versions. Signed-off-by: Lumir Balhar <lbalhar@redhat.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Pair-programmed-by: Andrew Bartlett <abartlet@samba.org>
* pidl:Python: use of pytalloc_GenericObject_reference*() for ↵Stefan Metzmacher2017-02-251-78/+7
| | | | | | | | | | | | pyrpc_{ex,im}port_union() wrapping BUG: https://bugzilla.samba.org/show_bug.cgi?id=12601 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Sat Feb 25 06:33:33 CET 2017 on sn-devel-144
* pidl:Python: replace pytalloc_CObject_FromTallocPtr() with ↵Stefan Metzmacher2017-02-251-9/+11
| | | | | | | | | pytalloc_GenericObject_reference_ex() BUG: https://bugzilla.samba.org/show_bug.cgi?id=12601 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* pidl:Python: make sure print HASH references for STRUCT typesStefan Metzmacher2017-02-251-1/+7
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12601 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* pidl: use ndr_push_charset_to_null() when [to_null] keyword is used in IDLGünther Deschner2017-01-241-1/+5
| | | | | | | Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s4-rpc_server: Allow each interface to declare if it uses handlesAndrew Bartlett2016-12-201-8/+13
| | | | | | | | This will allow the NETLOGON server in the AD DC to declare that it does not use handles, and so allow some more flexibility with association groups Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s4-rpc_server: Add back support for lsa over \\pipe\\netlogon optionallyAndrew Bartlett2016-12-151-1/+4
| | | | | | | | | | The idea here is that perhaps some real client relies on this (and not just Samba torture commands), so we need a way to support it for the 4.6 release. If no such client emerges, it can be deprecated and removed in the normal way. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* pidl: Make dcesrv\_$name\_interface "static const"Andrew Bartlett2016-12-081-1/+1
| | | | | | | | | | This moves it out of the global namespace Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Thu Dec 8 13:25:57 CET 2016 on sn-devel-144
* pidl: Make static struct api_struct also constAndrew Bartlett2016-12-011-1/+1
| | | | | | | | This moves the table to read-only memory Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* pidl: Change *_get_pipe_fns() to return const struct api_struct *Andrew Bartlett2016-12-011-3/+3
| | | | | | | | This will allow the table to be made static const in the next commit Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* pidl: Use a static const initialised struct in dcerpc_server_$name_init(void)Andrew Bartlett2016-12-011-9/+8
| | | | | | Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* Fix typoAlexis La Goutte2016-12-011-1/+1
| | | | | | | | Fix (minor) typo found in wireshark with lintian tools https://code.wireshark.org/review/#/c/18485/ Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* pidl:Python: add PyTypeObject objects for function structsStefan Metzmacher2016-10-261-1/+477
| | | | | | | | | | | | | They provide get/set methods for the in_* and out_* elements and the magic __ndr_{push,pull,print}_{in,out}__ hooks to enable the marshalling via ndr_{push,pull,print}_{in,out}(). This provides an easy way to generate and parse the payload of DCERPC requests and responses, which is very useful for writing tests. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* pidl:Python: split out a PythonElementGetSet() helper functionStefan Metzmacher2016-10-261-29/+35
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* pidl:NDR: add ReturnTypeElement() helper functionStefan Metzmacher2016-10-261-1/+20
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* pidl:Python: the py_{import,export}_*() functions can be static now.Stefan Metzmacher2016-10-261-4/+2
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* pidl:Python: make use of the pyrpc_{import,export}_union() functionsStefan Metzmacher2016-10-261-7/+25
| | | | | | | This avoids the linking problems at C shared object level. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* pidl:Python: provide a PyTypeObject with METH_CLASS __import__() and ↵Stefan Metzmacher2016-10-261-0/+214
| | | | | | | | | | | | | | | | __export__() hooks These are wrappers around the currently public C functions 'py_import_*() and 'py_export_*(). In order to let other python module use these function, we should resolve the needed type object and call the __import__() or __export__() hooks instead of linking to the other shared module at C level. We already do the same for structs. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* pidl:Python: provide the abstract syntax as <module>.<interface>_abstract_syntaxStefan Metzmacher2016-10-261-12/+34
| | | | | | | | The <module>.abstract_syntax alias is only kept as legacy for the first interface in a module. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* pidl:Python: prettify names of constantsStefan Metzmacher2016-10-261-2/+2
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* pidl:NDR: keep interface->{ORIGINAL}Stefan Metzmacher2016-10-261-1/+2
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* pidl:Python: improve the .doc string for the get/set elementsStefan Metzmacher2016-10-261-1/+1
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* pidl:Python: make use of NDR_ERR_CODE_IS_SUCCESS()Stefan Metzmacher2016-10-261-2/+2
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* pidl:Python: __ndr_print__ functions don't get arguments and need METH_NOARGSStefan Metzmacher2016-10-261-1/+1
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* pidl:Python: check the return values of talloc_ptrtype()Stefan Metzmacher2016-10-261-0/+18
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* pidl: in s3 server templates, support default HRESULT error returns.Günther Deschner2016-09-111-0/+2
| | | | | | | Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* pidl: fix field2name wireshark dissector test.Günther Deschner2016-09-071-1/+1
| | | | | | | | | | Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Günther Deschner <gd@samba.org> Autobuild-Date(master): Wed Sep 7 16:05:26 CEST 2016 on sn-devel-144
* pidl: Keep case from fieldnames.Günther Deschner2016-09-071-1/+1
| | | | | | | | | | Change-Id: I5626cfa0487cc88eb65cc349c05ae1762bc953f4 Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-on: https://code.wireshark.org/review/16720 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* pidl: support HRESULT as return code in wireshark autogenerated dissectors.Günther Deschner2016-09-061-1/+8
| | | | | | | | | | Guenther Change-Id: I68b7c579c5a519e429d2f4c2b3f63247e02f24e3 Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-on: https://code.wireshark.org/review/16718 Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* pidl/ws: fix missing $name when generating MAPI dissectorAurelien Aptel2016-06-201-3/+6
| | | | | | | | | | | | | | | | | | Port Wireshark commit 0e80176 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Fri Mar 4 19:28:26 2016 +0100 PIDL (NDR): fix missing $name when regenerate MAPI dissector Issue coming from ge41f08858b Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Mon Jun 20 16:20:00 CEST 2016 on sn-devel-144
* pidl/ws: fix failing testsAurelien Aptel2016-06-202-4/+3
| | | | | | | | | | | | | This commit fixes 2 test failures in Pidl test suite. - commit 02cd7808 changed the error the test was expecting => update expected output in the test - commit c76b65e changed whitespaces in the output => revert to the old output in the generator Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* pidl/s4/python: typo in commentAurelien Aptel2016-06-201-1/+1
| | | | | | Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* pidl/ws: directly use `di` param instead of casting `private_data` member.Aurelien Aptel2016-06-201-7/+2
| | | | | | | | As in Wireshark repo. Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* pidl/ws: Document CODE_START and HEADER_STARTAurelien Aptel2016-06-201-0/+8
| | | | | | | | | | | | | | | | | Port Wireshark commit 833d315 Author: Guy Harris <guy@alum.mit.edu> Date: Mon Jan 13 21:18:29 2014 +0000 Document {CODE,HEADER} {START,END}. Clean up indentation. svn path=/trunk/; revision=54721 Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* pidl/ws: whitespace cleanupAurelien Aptel2016-06-202-12/+12
| | | | | | | | Imported from the WS repo. Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* pidl/ws: Add HEADER START/HEADER END in ws dissectorAurelien Aptel2016-06-202-5/+57
| | | | | | | | | | | | | | | | | | | | | | Port Wireshark commit a297950 Author: Guy Harris <guy@alum.mit.edu> Date: Mon Jan 13 21:05:44 2014 +0000 Add HEADER START and HEADER END, similar to CODE START and CODE END, to allow stuff to be put into the .h file; that way, if you put helper functions into the .c file, for use by dissectors other than the one being generated, you can put declarations for them into the .h file. Do some checks for mis-nesting of CODE and HEADER blocks. Clean up the "this is generated code" header. svn path=/trunk/; revision=54720 Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* pidl/ws: dereference pointers when passing name param.Aurelien Aptel2016-06-201-8/+30
| | | | | | | | Port parts of Wireshark commit a58c986f to the samba repo. Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* pidl/ws: Remove pinfo->private_data from DCERPC dissectors.Aurelien Aptel2016-06-201-69/+63
| | | | | | | | | | | | | | | | | | | | | Sort of re-apply Wireshark commit 79cd356 which was never sync with samba. It was reverted then reintroduced in the WS repo (yes this is quite convulted). Original commit message: Author: Michael Mann <mmann78@netscape.net> Date: Wed Nov 6 12:36:09 2013 +0000 Remove pinfo->private_data from DCERPC dissectors. Bug 9387 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9387) This is the PIDL input file changes necessary to support removing pinfo->private_data from the DCERPC dissectors in favor of passing it through function parameters. I didn't regenerate the dissector source, so this is just a "good faith" effort to mimic the manual changes. svn path=/trunk/; revision=53098 Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* pidl/ws: remove any starting _ in WS field namesAurelien Aptel2016-06-201-0/+1
| | | | | | Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* pidl/ws: avoid trailing tabsAurelien Aptel2016-06-201-1/+4
| | | | | | | | | | | | | | | | | | Port Wireshark commit 4f04a3c Author: Stefan Metzmacher <metze@samba.org> Date: Thu Oct 29 08:32:52 2015 +0100 tools/pidl: avoid trailing tabs Change-Id: I293dd6f2d7ff3b0e27bc3cc49e69977604f12260 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/11433 Reviewed-by: Anders Broman <a.broman58@gmail.com> Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
View Lorry Controller Status