summaryrefslogtreecommitdiff
path: root/pidl
Commit message (Collapse)AuthorAgeFilesLines
...
* pidl:NDR: add ReturnTypeElement() helper functionStefan Metzmacher2016-10-261-1/+20
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* pidl:Python: the py_{import,export}_*() functions can be static now.Stefan Metzmacher2016-10-261-4/+2
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* pidl:Python: make use of the pyrpc_{import,export}_union() functionsStefan Metzmacher2016-10-261-7/+25
| | | | | | | This avoids the linking problems at C shared object level. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* pidl:Python: provide a PyTypeObject with METH_CLASS __import__() and ↵Stefan Metzmacher2016-10-261-0/+214
| | | | | | | | | | | | | | | | __export__() hooks These are wrappers around the currently public C functions 'py_import_*() and 'py_export_*(). In order to let other python module use these function, we should resolve the needed type object and call the __import__() or __export__() hooks instead of linking to the other shared module at C level. We already do the same for structs. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* pidl:Python: provide the abstract syntax as <module>.<interface>_abstract_syntaxStefan Metzmacher2016-10-261-12/+34
| | | | | | | | The <module>.abstract_syntax alias is only kept as legacy for the first interface in a module. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* pidl:Python: prettify names of constantsStefan Metzmacher2016-10-261-2/+2
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* pidl:NDR: keep interface->{ORIGINAL}Stefan Metzmacher2016-10-261-1/+2
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* pidl:Python: improve the .doc string for the get/set elementsStefan Metzmacher2016-10-261-1/+1
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* pidl:Python: make use of NDR_ERR_CODE_IS_SUCCESS()Stefan Metzmacher2016-10-261-2/+2
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* pidl:Python: __ndr_print__ functions don't get arguments and need METH_NOARGSStefan Metzmacher2016-10-261-1/+1
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* pidl:Python: check the return values of talloc_ptrtype()Stefan Metzmacher2016-10-261-0/+18
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* pidl: in s3 server templates, support default HRESULT error returns.Günther Deschner2016-09-111-0/+2
| | | | | | | Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* pidl: fix field2name wireshark dissector test.Günther Deschner2016-09-071-1/+1
| | | | | | | | | | Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Günther Deschner <gd@samba.org> Autobuild-Date(master): Wed Sep 7 16:05:26 CEST 2016 on sn-devel-144
* pidl: Keep case from fieldnames.Günther Deschner2016-09-071-1/+1
| | | | | | | | | | Change-Id: I5626cfa0487cc88eb65cc349c05ae1762bc953f4 Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-on: https://code.wireshark.org/review/16720 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* pidl: support HRESULT as return code in wireshark autogenerated dissectors.Günther Deschner2016-09-061-1/+8
| | | | | | | | | | Guenther Change-Id: I68b7c579c5a519e429d2f4c2b3f63247e02f24e3 Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-on: https://code.wireshark.org/review/16718 Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* pidl/ws: fix missing $name when generating MAPI dissectorAurelien Aptel2016-06-201-3/+6
| | | | | | | | | | | | | | | | | | Port Wireshark commit 0e80176 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Fri Mar 4 19:28:26 2016 +0100 PIDL (NDR): fix missing $name when regenerate MAPI dissector Issue coming from ge41f08858b Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Mon Jun 20 16:20:00 CEST 2016 on sn-devel-144
* pidl/ws: fix failing testsAurelien Aptel2016-06-202-4/+3
| | | | | | | | | | | | | This commit fixes 2 test failures in Pidl test suite. - commit 02cd7808 changed the error the test was expecting => update expected output in the test - commit c76b65e changed whitespaces in the output => revert to the old output in the generator Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* pidl/s4/python: typo in commentAurelien Aptel2016-06-201-1/+1
| | | | | | Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* pidl/ws: directly use `di` param instead of casting `private_data` member.Aurelien Aptel2016-06-201-7/+2
| | | | | | | | As in Wireshark repo. Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* pidl/ws: Document CODE_START and HEADER_STARTAurelien Aptel2016-06-201-0/+8
| | | | | | | | | | | | | | | | | Port Wireshark commit 833d315 Author: Guy Harris <guy@alum.mit.edu> Date: Mon Jan 13 21:18:29 2014 +0000 Document {CODE,HEADER} {START,END}. Clean up indentation. svn path=/trunk/; revision=54721 Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* pidl/ws: whitespace cleanupAurelien Aptel2016-06-202-12/+12
| | | | | | | | Imported from the WS repo. Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* pidl/ws: Add HEADER START/HEADER END in ws dissectorAurelien Aptel2016-06-202-5/+57
| | | | | | | | | | | | | | | | | | | | | | Port Wireshark commit a297950 Author: Guy Harris <guy@alum.mit.edu> Date: Mon Jan 13 21:05:44 2014 +0000 Add HEADER START and HEADER END, similar to CODE START and CODE END, to allow stuff to be put into the .h file; that way, if you put helper functions into the .c file, for use by dissectors other than the one being generated, you can put declarations for them into the .h file. Do some checks for mis-nesting of CODE and HEADER blocks. Clean up the "this is generated code" header. svn path=/trunk/; revision=54720 Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* pidl/ws: dereference pointers when passing name param.Aurelien Aptel2016-06-201-8/+30
| | | | | | | | Port parts of Wireshark commit a58c986f to the samba repo. Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* pidl/ws: Remove pinfo->private_data from DCERPC dissectors.Aurelien Aptel2016-06-201-69/+63
| | | | | | | | | | | | | | | | | | | | | Sort of re-apply Wireshark commit 79cd356 which was never sync with samba. It was reverted then reintroduced in the WS repo (yes this is quite convulted). Original commit message: Author: Michael Mann <mmann78@netscape.net> Date: Wed Nov 6 12:36:09 2013 +0000 Remove pinfo->private_data from DCERPC dissectors. Bug 9387 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9387) This is the PIDL input file changes necessary to support removing pinfo->private_data from the DCERPC dissectors in favor of passing it through function parameters. I didn't regenerate the dissector source, so this is just a "good faith" effort to mimic the manual changes. svn path=/trunk/; revision=53098 Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* pidl/ws: remove any starting _ in WS field namesAurelien Aptel2016-06-201-0/+1
| | | | | | Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* pidl/ws: avoid trailing tabsAurelien Aptel2016-06-201-1/+4
| | | | | | | | | | | | | | | | | | Port Wireshark commit 4f04a3c Author: Stefan Metzmacher <metze@samba.org> Date: Thu Oct 29 08:32:52 2015 +0100 tools/pidl: avoid trailing tabs Change-Id: I293dd6f2d7ff3b0e27bc3cc49e69977604f12260 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/11433 Reviewed-by: Anders Broman <a.broman58@gmail.com> Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* pidl: use https urls and update dead msdn linkAurelien Aptel2016-06-202-5/+5
| | | | | | Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* pidl/ws: Eliminate e_uuid_t in favor of e_guid_tAurelien Aptel2016-06-201-1/+1
| | | | | | | | | | | | | | | | | | | | | Port Wireshark commit 499d959 Author: Guy Harris <guy@alum.mit.edu> Date: Tue Mar 3 02:47:53 2015 -0800 Eliminate e_uuid_t in favor of e_guid_t. That eliminates a redundant and confusing data type, and avoids issues with one piece of code using e_uuid_t but wanting to use routines expecting an e_guid_t. Change-Id: I95e172d46d342ab40f6254300ecbd2a0530cde60 Reviewed-on: https://code.wireshark.org/review/7506 Reviewed-by: Guy Harris <guy@alum.mit.edu> Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* pidl/ws: Remove #pragma warning (MSVC)Aurelien Aptel2016-06-201-7/+0
| | | | | | | | | | | | | | | | | Port Wireshark commit ceda0f9 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Sun Oct 5 19:34:46 2014 +0200 Remove #pragma warning (MSVC) for PIDL generate dissector Change-Id: I1e4c7944a2cd877f5c707703dcff44fe9f955a2c Reviewed-on: https://code.wireshark.org/review/4479 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* pidl/ws: fix Assigned value is garbage or undefined found by Clang AnalyzerAurelien Aptel2016-06-201-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Port Wireshark commit 683d657 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Sun Oct 5 19:27:15 2014 +0200 PIDL (DCERPC): fix Assigned value is garbage or undefined found by Clang Analyzer packet-dcerpc-dnsserver.c:1002:12: warning: Assigned value is garbage or undefined packet-dcerpc-frstrans.c:1137:12: warning: Assigned value is garbage or undefined packet-dcerpc-lsa.c:6345:12: warning: Assigned value is garbage or undefined packet-dcerpc-nspi.c:7805:12: warning: Assigned value is garbage or undefined packet-dcerpc-dfs.c:3245:11: warning: Function call argument is an uninitialized value packet-dcerpc-dfs.c:3245:9: warning: 'level' may be used uninitialized in this function [-Wmaybe-uninitialized] Change-Id: Ife6a2f565ae215535d0e3d72ef50800114240e3f Reviewed-on: https://code.wireshark.org/review/4478 Reviewed-by: Evan Huus <eapache@gmail.com> Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* pidl/ws: fix indent (use 4 tabs) and remove trailing whitespaceAurelien Aptel2016-06-203-76/+76
| | | | | | | | | | | | | | | | | Port Wireshark commit 4110bde Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Fri Sep 26 19:51:34 2014 +0200 PIDL: fix indent (use 4 tabs) and remove trailing whitespace Change-Id: I0ee63a040867b44ac9915704f5e581483ed6f7e2 Reviewed-on: https://code.wireshark.org/review/4310 Reviewed-by: Anders Broman <a.broman58@gmail.com> Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* pidl/ws: Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAurelien Aptel2016-06-201-2/+6
| | | | | | | | | | | | | | | | | Port Wireshark commit f6b9e7a Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Sun Sep 28 20:57:13 2014 +0200 PIDL: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Change-Id: Ibae478771b30d6e9ae07315985f1e71bc6b65423 Reviewed-on: https://code.wireshark.org/review/4350 Reviewed-by: Michael Mann <mmann78@netscape.net> Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* pidl/ws: enhance dissectorAurelien Aptel2016-06-201-0/+1
| | | | | | | | | | | | | | | | | | | | | Port Wireshark commit 28ec9c2 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Fri Sep 26 23:29:43 2014 +0200 PIDL (DCERPC winreg): enhance dissector * Fix PIDL generator for NOEMIT Element (fix -Wunused-function for DCERPC winreg dissector) * Fix indent (use tabs) * Remove DCERPC winreg dissector from DIRTY list Change-Id: I5d16cbfe8481a5e5f7e5df9b51735c93ae4375a7 Reviewed-on: https://code.wireshark.org/review/4322 Reviewed-by: Michael Mann <mmann78@netscape.net> Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* pidl/ws: fix -Wmissing-prototypeAurelien Aptel2016-06-201-1/+5
| | | | | | | | | | | | | | | | | | | Port Wireshark commit e759d82 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Fri Sep 26 18:47:53 2014 +0200 PIDL: fix -Wmissing-prototype Change-Id: I4cae47450e8026b10bd373828f235184560e0a99 Reviewed-on: https://code.wireshark.org/review/4308 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* pidl/ws: Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAurelien Aptel2016-06-201-1/+1
| | | | | | | | | | | | | | | | | Port Wireshark commit f0b5fb7 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Fri Sep 26 21:31:32 2014 +0200 PIDL: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Change-Id: I7f6f974732b7905f4ea4686e1a79ca6fbef78fa8 Reviewed-on: https://code.wireshark.org/review/4319 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* Python pidl: avoid segfault with "del obj->attr"Douglas Bagnall2016-05-101-0/+8
| | | | | | | | | | | | Deleting an attribute in Python (using the "del" statement) is (at some stages along a winding path, for C objects) converted into setting the attribute to NULL. Not None, actual NULL. The way we handled this NULL was to dereference it. This changes the behaviour to raising an AttributeError, which is more or less what Python does in similar situations with builtin objects. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* pidl: Correct string handling to use talloc and be in commonAndrew Bartlett2016-05-101-42/+61
| | | | | | | | | | | | The previous string handling assumed the python variables referenced by PyString_AS_STRING had infinite life. When they were re-used the C structure started to point at unexpected things. We now check correctly for Unicode in every case, and we always duplicate the string with talloc_strdup() Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
* ndr: Use ndr_steal to avoid long listsDouglas Bagnall2016-03-221-10/+16
| | | | | | | | | | When pulling complex structures like nt-acls, a long list of tokens may be produced. By removing tokens along the way with ndr_token_steal, future calls to retrieve from the token list are not as expensive. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* ndr: avoid unnecessary searches of token listDouglas Bagnall2016-03-221-14/+35
| | | | | | | | | | When pulling complex structures like nt-acls, a long list of tokens may be produced. This change means the token list won't be walked in the buffers case if the switch value is not needed. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* pidl: Use a tmp_ctx helper variableAndrew Bartlett2016-03-081-2/+13
| | | | | | | | This is so we free the ndr_push_struct_blob() return value after we make it into a string Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* pidl: Use the $mem_ctx helper variableAndrew Bartlett2016-03-081-1/+1
| | | | | | | This is already set to pytalloc_get_mem_ctx(py_obj) Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* pidl: Fix our python reference handlingAndrew Bartlett2016-03-081-5/+7
| | | | | | | | | | | | The new talloc.BaseObject allow us to hold a talloc context per python object (there may be many referring to the same C object) and the talloc context that the actual object pointer is under. Another advantage is that talloc.BaseObject(), has less of an ABI surface. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* pidl: Change PyGetSetDef in generated python bindings to use C99 initialisersAndrew Bartlett2016-01-181-2/+9
| | | | | Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* pidl: Use PY_SSIZE_T_CLEANAndrew Bartlett2016-01-071-1/+2
| | | | | | | This changes the type used for # arguments to PyArg_ParseTupleAndKeywords Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
* build:wafsamba: removed most import * statementsThomas Nagy2015-10-281-4/+1
| | | | | | | | | | | | | The 'import *' statements make it more difficult to reason about the modules and tends to conceal bugs. These changes enable running pyflakes against most of the build scripts. Signed-off-by: Thomas Nagy <tnagy@waf.io> Reviewed-by: Andrew Bartlet <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Wed Oct 28 12:52:17 CET 2015 on sn-devel-104
* pidl/python: also add a ndr_PyLong_FromLongLong() for symnetric reasonsStefan Metzmacher2015-09-011-1/+10
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=11429 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* pidl/python: Provide static inline helper function ↵Andrew Bartlett2015-09-011-3/+12
| | | | | | | | | | | | | | | | | | | ndr_PyLong_FromUnsignedLongLong This should isolate any coverity warnings on 64-bit platforms (where LONG_MAX is larger than any possible 32 bit value) to a single spot, or possibly eliminate it. This is needed for the unsigned 64 bit case, and on 32 bit systems, as PyInt_FromLong is limited to a signed "long" int. The compiler should be able to eliminate many of these calls with the embedded type knowlege. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11429 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* pidl/python: Calculate maximum integer values using a lookup tableAndrew Bartlett2015-09-011-2/+39
| | | | | | | | | | | | | This avoids a << of 64 bits in the unused end of the conditional expression. This was flagged by Coverity and the fix was suggested by metze. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11429 Andrew Bartlett Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* pidl: Assert that python arrays will not overflow the C arrayAndrew Bartlett2015-08-241-0/+7
| | | | | | | | | | We do not write network services in Python, so this is not a security issue, but would cause a crash or other odd behaviour if the length was changed BUG: https://bugzilla.samba.org/show_bug.cgi?id=11430 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* pidl: Change PIDL to correctly use and validate python integer typesAndrew Bartlett2015-08-241-35/+118
| | | | | | | | | | | | | | | | | In particular, it is critical that we use unsigned integers of sufficient size in python for unsigned C integers, and it is critical that we check for overflow at both the python and C level. Otherwise, we may both represent and sort these incorrectly, in particular when sorting attributeID values from DRSUAPI which are represented as an signed enum in C and a uint32_t in IDL, but which often has the high bit set (in schema extensions). BUG: https://bugzilla.samba.org/show_bug.cgi?id=11429 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
View Lorry Controller Status