summaryrefslogtreecommitdiff
path: root/libcli/cldap
Commit message (Collapse)AuthorAgeFilesLines
* CVE-2020-10704: libcli ldap_message: Add search size limits to ldap_decodeGary Lockyer2020-04-211-3/+15
| | | | | | | | | | | | | | | | Add search request size limits to ldap_decode calls. The ldap server uses the smb.conf variable "ldap max search request size" which defaults to 250Kb. For cldap the limit is hard coded as 4096. Credit to OSS-Fuzz REF: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20454 BUG: https://bugzilla.samba.org/show_bug.cgi?id=14334 Signed-off-by: Gary Lockyer <gary@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* CVE-2020-10704: lib util asn1: Add ASN.1 max tree depthGary Lockyer2020-04-211-1/+1
| | | | | | | | | | | | | Add maximum parse tree depth to the call to asn1_init, which will be used to limit the depth of the ASN.1 parse tree. Credit to OSS-Fuzz REF: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20454 BUG: https://bugzilla.samba.org/show_bug.cgi?id=14334 Signed-off-by: Gary Lockyer <gary@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* tevent: Fix callers of tevent_req_set_endtimeVolker Lendecke2018-04-241-1/+0
| | | | | | | | tevent_req_set_endtime internally already calls tevent_req_nomem and thus sets the error status correctly. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* cldap: Avoid a ZERO_STRUCTPVolker Lendecke2018-04-041-1/+0
| | | | | | | | This is done implicitly by tevent_req_create Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3: cldap: cldap_multi_netlogon_send() fails with one bad IPv6 address.Jeremy Allison2016-10-181-0/+5
| | | | | | | | | | | | | | | | | | | Analysis by: Rebecca Gellman <rebecca@starfleet-net.co.uk> Ignore cldap_socket_init() failure when sending multiple cldap netlogon requests. Allow cldap_netlogon_send() to catch the bad address and correctly return through a tevent subreq. Make sure cldap_search_send() copes with cldap parameter == NULL. BUG: https://bugzilla.samba.org/show_bug.cgi?id=12381 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Tue Oct 18 02:16:20 CEST 2016 on sn-devel-144
* dlist: remove unneeded type argument from DLIST_ADD_END()Michael Adam2016-02-061-1/+1
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* libcli: Remove a reference to asn1->ofsVolker Lendecke2016-01-061-7/+5
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* libcli: Make sure status is initialized.Andreas Schneider2014-10-311-1/+1
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* libcli: Remove unreachable code in cldap.Andreas Schneider2014-09-281-6/+2
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* lib/clap fix compiler warningsChristian Ambach2013-12-121-2/+1
| | | | | | | about set but unused variable Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* libcli/cldap: Add utility to create netlogon filterBenjamin Franzke2013-11-112-40/+52
| | | | | | | This utility is splitted of from cldap_netlogon_send. Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Nadezhda Ivanova <nivanova@symas.com>
* libcli/cldap: make use of samba_tevent_context_init()Stefan Metzmacher2013-02-191-2/+2
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* libcli/cldap/cldap.c - remove outdated commentMatthias Dieter Wallnöfer2011-11-101-2/+0
| | | | | | | Reviewed-by: metze Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org> Autobuild-Date: Thu Nov 10 20:32:08 CET 2011 on sn-devel-104
* libcli/cldap: fix a crash bug in cldap_socket_recv_dgram() (bug #8593)Stefan Metzmacher2011-11-101-10/+25
| | | | | | | | | | | | After a calling any wrapper of tevent_req_notify_callback(), e.g. tevent_req_nterror(), tevent_req_done(), tevent_req_nomem(), a function has to return immediately otherwise it is very likely to crash, unless in calls tevent_req_defer_callback() before. metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Thu Nov 10 16:31:59 CET 2011 on sn-devel-104
* libcli-cldap: avoid the case local == remote == NULLMatthieu Patou2011-10-211-1/+5
|
* libcli/cldap: make sure the local and remote address family matchesStefan Metzmacher2011-10-211-5/+25
| | | | | | metze Signed-off-by: Matthieu Patou <mat@matws.net>
* libcli/cldap: don't pass tevent_context to cldap_socket_init()Stefan Metzmacher2011-10-102-2/+0
| | | | | | | metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Mon Oct 10 23:23:07 CEST 2011 on sn-devel-104
* libcli/cldap: make use of explicit tevent_contextsStefan Metzmacher2011-10-101-50/+75
| | | | metze
* libcli/cldap: pass tevent_context to cldap_search_send()Stefan Metzmacher2011-10-102-4/+8
| | | | metze
* libcli/cldap: pass tevent_context to cldap_netlogon_send()Stefan Metzmacher2011-10-102-3/+5
| | | | metze
* libcli/cldap: pass tevent_context to cldap_set_incoming_handler()Stefan Metzmacher2011-10-102-1/+4
| | | | metze
* build: provide tevent-util as a public libraryAndrew Bartlett2011-08-081-1/+1
| | | | | | | This is needed so that OpenChange can get at _tevent_req_nterr(), which is referenced by generated PIDL output. Andrew Bartlett
* cli_cldap: Lowercase name.Jelmer Vernooij2011-07-261-1/+1
|
* Use tevent_req_oomVolker Lendecke2011-06-201-2/+2
| | | | This fixes a few Coverity errors
* libcli/util Rename common map_nt_error_from_unix to avoid duplicate symbolAndrew Bartlett2011-06-201-4/+4
| | | | | | | | | | | | The two error tables need to be combined, but for now seperate the names. (As the common parts of the tree now use the _common function, errmap_unix.c must be included in the s3 autoconf build). Andrew Bartlett Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Mon Jun 20 08:12:03 CEST 2011 on sn-devel-104
* libcli/cldap/cldap.c: don't hand huge values to tevent_timeval_add usecsRusty Russell2011-06-011-2/+4
| | | | | | | | state->request.delay is two million here, resulting in an invalid timeval. Since tevent doesn't have a convenient wrapper to add arbitrary usecs, do the arithmetic here (it's the sole caller of this function). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
* waf-build: Add more libraries to avoid duplicate symbolsAndrew Bartlett2011-05-181-5/+6
| | | | | | The new source of duplicates is calling libnetapi from inside smbtorture. Andrew Bartlett
* netlogon: move netlogon helpers to ../libcli/netlogon.Günther Deschner2011-01-071-1/+1
| | | | Guenther
* s4: Remove the old perl/m4/make/mk-based build system.Jelmer Vernooij2010-10-311-7/+0
| | | | | | | | The new waf-based build system now has all the same functionality, and the old build system has been broken for quite some time. Autobuild-User: Jelmer Vernooij <jelmer@samba.org> Autobuild-Date: Sun Oct 31 02:01:44 UTC 2010 on sn-devel-104
* waf: Stop automaticaly changing dashes to underscores in library names.Jelmer Vernooij2010-10-261-1/+1
|
* waf: Remove lib prefix from libraries manually.Jelmer Vernooij2010-10-261-1/+1
|
* s4: Rename LIBCLI_LDAP to libcli_ldap.Jelmer Vernooij2010-10-241-1/+1
|
* s4: Rename LIBSAMBA-* to libsamba-*Jelmer Vernooij2010-10-241-1/+1
|
* cldap: prevent crashes when freeing cldap socketAndrew Tridgell2010-09-151-6/+15
| | | | | | | As a callback may destroy the cldap socket we need to ensure we don't reference the cldap structure after the callback Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
* cldap: use ipv4 not up for unbound cldap socketsAndrew Tridgell2010-09-151-1/+5
| | | | | If we use "ip" we end up with a PF_INET6 socket which breaks sendto() for v4 addresses.
* Finish removal of iconv_convenience in public API's.Jelmer Vernooij2010-05-182-9/+1
|
* s4-waf: removed the AUTOGENERATED markersAndrew Tridgell2010-04-061-3/+0
| | | | we won't be using the mk -> wscript generator again
* s4-waf: mark the wscript files as python so vim/emacs knows how to highlight ↵Andrew Tridgell2010-04-061-0/+2
| | | | them
* build: commit all the waf build files in the treeAndrew Tridgell2010-04-061-0/+10
|
* Replace the "ipv4" specific strings in libcli/cldap/cldap.c with "ip". CLDAP canJeremy Allison2009-06-081-2/+2
| | | | | | | | run over IPv4/IPv6, even though some of the netlogon messages are IPv4 specific. Fix the new ads_cldap_netlogon() to be IPv6/IPv4 agnostic. This compiles but I don't have a good test env. for this (although as the previous code was *completely* broken over IPv6 this will expose previously hidden bugs if it's broken :-). Jeremy.
* libcli/cldap: convert to tsocket_* function to tdgram_*Stefan Metzmacher2009-04-021-45/+38
| | | | metze
* libcli/cldap: fix memory/resource leakStefan Metzmacher2009-04-011-1/+8
| | | | | | We need to remove the message id, when a search request is finished metze
* move source4/libcli/cldap => libcli/cldapStefan Metzmacher2009-03-193-0/+1265
metze
View Lorry Controller Status