summaryrefslogtreecommitdiff
path: root/lib
Commit message (Collapse)AuthorAgeFilesLines
* tdb: fix locking errorRusty Russell2009-07-211-1/+1
| | | | | | | | | | | | | | | | | | 54a51839ea65aa788b18fce8de0ae4f9ba63e4e7 "Make tdb transaction lock recursive (samba version)" was broken: I "cleaned it up" and prevented it from ever unlocking. To see the problem: $ bin/tdbtorture -s 1248142523 tdb_brlock failed (fd=3) at offset 8 rw_type=1 lck_type=14 len=1 tdb_transaction_lock: failed to get transaction lock tdb_transaction_start failed: Resource deadlock avoided My testcase relied on the *count* being correct, which it was. Fixing that now. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by: Michael Adam <obnox@samba.org>
* lib util: Fix const warningTim Prouty2009-07-201-1/+1
|
* Make tdb transaction lock recursive (samba version)Rusty Russell2009-07-203-21/+20
| | | | | | | | | | | | | | | | | | | This patch replaces 6ed27edbcd3ba1893636a8072c8d7a621437daf7 and 1a416ff13ca7786f2e8d24c66addf00883e9cb12, which fixed the bug where traversals inside transactions would release the transaction lock early. This solution is more general, and solves the more minor symptom that nested traversals would also release the transaction lock early. (It was also suggestd in Volker's comment in 6ed27ed). This patch also applies to ctdb, if the traverse.c part is removed (ctdb's tdb code never received the previous two fixes). Tested using the testsuite from ccan (adapted to the samba code). Thanks to Michael Adam for feedback. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by: Michael Adam <obnox@samba.org>
* Remove unused parameter setting.Jelmer Vernooij2009-07-192-11/+0
|
* lib/util/util_file.c(file_save): fixed file descriptor leak when read(2) fails.Slava Semushin2009-07-191-0/+1
| | | | | Found by cppcheck: [./lib/util/util_file.c:383]: (error) Resource leak: fd
* Fix broken password quality checkMatthieu Patou2009-07-192-1/+4
| | | | | This fixes broken password tests when the passwords contain non ASCII characters (e.g. accentuated chars like ('e, `e, ...)
* include unix.h if it's availableMatt Kraai2009-07-192-0/+5
|
* tevent: try to fix the build on QNX qnx18 6.4.1 it doesn't have SA_RESTART ↵Stefan Metzmacher2009-07-161-1/+11
| | | | | | defined metze
* tsocket: rename sa_len => sa_socklen, because sa_len is a macro on some ↵Stefan Metzmacher2009-07-161-21/+21
| | | | | | platforms metze
* Change to talloc_zero_size instead of extra memset.Jeremy Allison2009-07-141-2/+1
| | | | Jeremy.
* When tallocing a memory block for the state in a tevent_req struct,Jeremy Allison2009-07-141-0/+1
| | | | | ensure it's zeroed out. Vl & Metze please check. Jeremy.
* libreplace: update library search path variablesBjörn Jacke2009-07-051-1/+4
|
* Fix some warningsVolker Lendecke2009-07-041-2/+3
|
* tdb: fix define of tdbdir when srcdir != "."Björn Jacke2009-07-031-2/+2
|
* Sort the signature filesSimo Sorce2009-07-034-89/+89
|
* Expose functions need by backend writersSimo Sorce2009-07-035-52/+67
| | | | | | | move publicly needed structures and functions in the public header. Stop installing internal headers. Update the signature and exports files with the new exposed function.
* Restore ABI compatibility for talloc.Simo Sorce2009-07-036-60/+106
|
* talloc: change TALLOC_MAGIC for version 2.0.0Stefan Metzmacher2009-07-021-1/+12
| | | | metze
* change talloc to 2.0.0Andrew Tridgell2009-07-021-1/+1
| | | | | | | This is needed to prevent samba3 and samba4 from using an ABI incompatible system version of talloc See ongoing discussion on the samba-technical mailing list
* lib/util: fix order of includes in tevent_ntstatus.cMichael Adam2009-07-011-1/+1
| | | | | | replace.h needs to be included first. Michael
* fixed the talloc testsuite for the recent changesAndrew Tridgell2009-07-011-6/+10
|
* a talloc_realloc() to zero size needs to use an unambiguous freeAndrew Tridgell2009-07-011-1/+1
|
* changes to remove the ambiguity in talloc_free() and talloc_steal() Andrew Tridgell2009-07-012-26/+109
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These changes follow from the discussions on samba-technical. The changes are in several parts, and stem from the inherent ambiguity that was in talloc_free() and talloc_steal() when the pointer that is being changes has more than one parent, via references. The changes are: 1) when you call talloc_free() on a pointer with more than one parent the free will fail, and talloc will log an error to stderr like this: ERROR: talloc_free with references at some/foo.c:123 reference at other/bar.c:201 reference at other/foobar.c:641 2) Similarly, when you call talloc_steal() on a pointer with more than one parent, the steal will fail and talloc will log an error to stderr like this: ERROR: talloc_steal with references at some/foo.c:123 reference at other/bar.c:201 3) A new function talloc_reparent() has been added to change a parent in a controlled fashion. You need to supply both the old parent and the new parent. It handles the case whether either the old parent was a normal parent or a reference The use of stderr in the logging is ugly (and potentially dangerous), and will be removed in a future patch. We'll need to add a debug registration function to talloc.
* fixed use of reference in pytallocAndrew Tridgell2009-07-012-3/+24
| | | | | | | | | | | | The previous code caused memory leaks, and also caused situations where talloc_free could be called on pointers with multiple parents The new approach is to have two functions: py_talloc_import : steals the pointer, so it becomes wholly owned by the python object py_talloc_reference: uses a reference, so it is owned by both python and C
* lib/util: fix building tevent_ntstatus without config.hMichael Adam2009-06-291-1/+0
| | | | | | (when called from places with "#define NO_CONFIG_H" set, such as configure) Michael
* tsocket/bsd: also ask for TEVENT_FD_READ when we want to write into a stream ↵Stefan Metzmacher2009-06-291-2/+9
| | | | | | | | socket Otherwise we would not notice a broken connection. metze
* tsocket/bsd: more correctly check if the cached tevent_fd is still validStefan Metzmacher2009-06-291-4/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | I some cases the pointer value of tevent_context is the same again, if we do something like: ev1 = tevent_context_init(); ... fde = tevent_add_fd(ev1, fd, TEVENT_FD_READ...); ... talloc_free(ev1); ... ev2 = tevent_context_init(); if (ev1 == ev2) { /* this can happen! */ } if (tevent_fd_get_flags(fde) == 0) { /* this is always true */ } But the "talloc_free(ev1)" will set fde->event_ctx to NULL and tevent_fd_get_flags() will always return 0. metze
* Fix ndrdump to use a common setup_logging() APIAndrew Bartlett2009-06-292-1/+18
| | | | | | | | | By adding a new common setup_logging_stdout() API, we no longer need to abuse the ABI compatability between the different setup_logging() calls in Samba3 and Samba4's DEBUG() subsystems. The revert of 49a6d757b4d944cd22c91b2838beb83f04fbe1e9 works with this to fix bug 6211. Andrew Bartlett
* Revert "s4:debug: make setup_logging() a bit more compatible with samba3"Andrew Bartlett2009-06-291-1/+1
| | | | | | | | The problem is that the enum was previously a 'rachet', that is, it would only reset to a level higher than it was previouly set to. Changing the order broke file-based logging for our production sites. This reverts commit 49a6d757b4d944cd22c91b2838beb83f04fbe1e9.
* Two patches which fix issues on cross compiling/buildingNathaniel McCallum2009-06-291-1/+1
|
* Properly free a downlevel readv request. Metze, please checkVolker Lendecke2009-06-271-0/+1
|
* Move asn1_load_nocopy() to lib/util/asn1.cVolker Lendecke2009-06-202-0/+11
|
* Move asn1_blob() to lib/util/asn1.cVolker Lendecke2009-06-202-0/+17
|
* Partially revert restriction of socket_wrapper to 1500 byte writesAndrew Bartlett2009-06-191-10/+32
| | | | | | | | | | | This keeps the restriction for stream sockets (where the caller will retry), without creating problems on datagram sockets (CLDAP is not defined, as far as I know, across multiple UDP packets). The commit adding this restriction was 47b106c0ae8b91c9cccfc21bf8e4e416b1abfd5d Andrew Bartlett
* Revert "For tevent to install tevent_util.h"Simo Sorce2009-06-181-1/+0
| | | | | | This reverts commit b112cc5503350b248949bdbcce8072f5523ce877. tevent_util.h is a private header. Must not be installed.
* For tevent to install tevent_util.hEric Sandall2009-06-181-0/+1
| | | | | | | Patch for bug #6270 This patch is for the future when samba4 builds using external libraries. With this patch, tevent now installs tevent_util.h which is required by samba4.
* s4: Call va_end() after all va_start()/va_copy() calls.Andrew Kroeger2009-06-181-0/+2
| | | | | | | | This corrects the issues reaised in bug #6129, and some others that were not originally identified. It also accounts for some code that was in the original bug report but appears to have since been made common between S3 and S4. Thanks to Erik Hovland <erik@hovland.org> for the original bug report.
* tdb: Fix help string in configure flag to enable Python bindings.Jelmer Vernooij2009-06-171-1/+1
|
* fix release scripts to always git cleanSimo Sorce2009-06-172-0/+6
| | | | | This makes sure we do not include foreign object files or other build byproducts by mistake.
* Add exports file and abi checker for teventSimo Sorce2009-06-157-2/+157
| | | | | | | | This is a first attempt at exporting symbols only for public functions We also provide a rudimentary ABI checker that tries to check that function signatures are not changed by mistake. Given our use of macros this is not an API checker. It's all based on tevent.h contents and the gcc -aux-info option
* Add exports file and abi checker for talloctalloc-1.3.1Simo Sorce2009-06-158-9/+169
| | | | | | | | This is a first attempt at exporting symbols only for public functions We also provide a rudimentary ABI checker that tries to check that function signatures are not changed by mistake. Given our use of macros this is not an API checker. It's all based on talloc.h contents and the gcc -aux-info option
* Add exports file and abi checker for tdbtdb-1.1.5Simo Sorce2009-06-157-3/+172
| | | | | | | | This is a first attempt at exporting symbols only for public functions We also provide a rudimentary ABI checker that tries to check that function signatures are not changed by mistake. Given our use of macros this is not an API checker. It's all based on tdb.h contents and the gcc -aux-info option
* Add new replace check for --version-scriptSimo Sorce2009-06-151-0/+16
| | | | | | Allows us to pass an export files on Linux and Solaris so that we can expose only symbols that are actually supposed to be global, and keep as local anything else.
* Add option to --disable-python on buildSimo Sorce2009-06-151-0/+9
|
* Fix a = vs == error in writev_handlerVolker Lendecke2009-06-151-1/+1
|
* s4:heimdal: import lorikeet-heimdal-200906080040 (commit ↵Andrew Bartlett2009-06-121-1/+5
| | | | | | | | | | | 904d0124b46eed7a8ad6e5b73e892ff34b6865ba) Also including the supporting changes required to pass make test A number of heimdal functions and constants have changed since we last imported a tree (for the better, but inconvenient for us). Andrew Bartlett
* selftest: Fix handling of testsuite, reintroduce progress indication.Jelmer Vernooij2009-06-111-1/+0
|
* Fix build of recurusion fix in reopen_logs()Andrew Bartlett2009-06-111-1/+1
|
* Don't recurse in reopen_logs().Andrew Bartlett2009-06-111-0/+6
| | | | | | | Use the state to avoid recursion in reopen_logs(), as DEBUG() can call this function. Andrew Bartlett
* lib-util: move set_blocking() call into own file.Günther Deschner2009-06-103-31/+63
| | | | Guenther
View Lorry Controller Status