summaryrefslogtreecommitdiff
path: root/buildtools
Commit message (Collapse)AuthorAgeFilesLines
* waf: Add -fstack-clash-protectionAndreas Schneider2018-09-261-0/+17
| | | | | | | | | | | | | https://developers.redhat.com/blog/2018/03/21/compiler-and-linker-flags-gcc/ BUG: https://bugzilla.samba.org/show_bug.cgi?id=13601 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit fc4df251c88365142515a81bea1120b2b84cc4a0) Autobuild-User(v4-9-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-9-test): Wed Sep 26 15:55:52 CEST 2018 on sn-devel-144
* waf: Check for -fstack-protect-strong supportAndreas Schneider2018-09-261-17/+19
| | | | | | | | | | | | | The -fstack-protector* flags are compiler only flags, don't pass them to the linker. https://developers.redhat.com/blog/2018/03/21/compiler-and-linker-flags-gcc/ BUG: https://bugzilla.samba.org/show_bug.cgi?id=13601 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 38e97f8b52e85bdfcf2d74a4fb3c848fa46ba371)
* wafsamba: Fix 'make -j<jobs>'Andreas Schneider2018-09-111-2/+7
| | | | | | | | | | | | | | | | | | Currently only 'make -j' enables parallel builds and e.g. 'make -j4' results in no parallel compile jobs at all. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13606 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Fri Sep 7 20:24:46 CEST 2018 on sn-devel-144 (cherry picked from commit 70169d4789fe8b2ee4efe5e88eeaa80e1a641b32) Autobuild-User(v4-9-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-9-test): Tue Sep 11 12:01:22 CEST 2018 on sn-devel-144
* wafsamba/samba_abi: always hide ABI symbols which must be localAlexander Bokovoy2018-08-232-4/+20
| | | | | | | | | | | | | | | | | | | | | | | binutils 2.31 is going to change how shared libraries are linked, such that they always provide their own local definitions of the _end, _edata and _bss_start symbols. This would all be fine, except for shared libraries that export all symbols be default. (Rather than just exporting those symbols that form part of their API). According to binutils developers, we should only export the symbols we explicitly want to be used. We don't use this principle for all our libraries and deliberately don't want to have ABI versioning control for all of them, so the change I introduce here is to explicitly mark those symbols that will always be added by default linker configuration with binutils 2.31 as local. Right now these are '_end', '_edata', and '__bss_start' symbols. Fixes: https://bugzilla.samba.org/show_bug.cgi?id=13579 Cherry-picked from commit 4e123c46820e737968fa3d1c594aa016cca39637 Signed-off-by: Alexander Bokovoy <ab@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* wscript: Add --with-system-heimdalkrb5Christof Schmitt2018-07-112-0/+3
| | | | | | | | | | | | | | | | | Add the configure option --with-system-heimdalkrb5 to build Samba explicitly with a system Heimdal kerberos library. This does the same as the more complicated syntax --bundled-libraries='!heimdal,!asn1,!com_err,!roken,!hx509,!wind,!gssapi,!hcrypto,!krb5,!heimbase,!asn1_compile,!compile_et,!kdc,!hdb,!heimntlm' and it also enforces the conflicts with MIT Kerbros and the AD DC build. Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Wed Jul 11 05:18:59 CEST 2018 on sn-devel-144
* wafsamba: Be strict when checking __attribute__ featuresAmitay Isaacs2018-07-041-0/+4
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493 Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org>
* wafsamba: Add strict option to CHECK_CODEAmitay Isaacs2018-07-041-1/+11
| | | | | | | | | | | | | | Some compilers (e.g. xlc) ignores unsupported features, generates a warning, but does not fail compilation. This ensures that any compiler warnings are treated as errors and the feature support is correctly identified. This adds equivalent compiler option to -Werror for xlc. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493 Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org>
* python: bulk replace dict.iteritems to items for py3Joe Guo2018-04-131-1/+1
| | | | | | | | In py3, iterxxx methods are removed. Signed-off-by: Joe Guo <joeg@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
* wafsamba: Add '-Werror=strict-overflow -Wstrict-overflow=2' to the developer ↵Andreas Schneider2018-04-061-0/+2
| | | | | | | | | | | | | build We could move it to 3, but shouldn't go higher. If you set it to 4 and 5 you will probably also get a lot of false positives. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri Apr 6 02:07:16 CEST 2018 on sn-devel-144
* wafsamba: Add missing cflags_end argument to SAMBA_BINARYAndreas Schneider2018-04-031-0/+2
| | | | | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Tue Apr 3 23:08:33 CEST 2018 on sn-devel-144
* wafsamba: Add missing cflags_end argument to SAMBA_MODULEAndreas Schneider2018-04-031-0/+3
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* wafsamba: Build with -Wimplicit-fallthrough if supportedAndreas Schneider2018-03-011-0/+2
| | | | | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Thu Mar 1 19:38:12 CET 2018 on sn-devel-144
* buildtools python: convert 'except X, e' to 'except X as e'Douglas Bagnall2018-02-154-5/+5
| | | | | | | | Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Thu Feb 15 05:40:55 CET 2018 on sn-devel-144
* wafsamba: Allow passing 'lib' to CHECK_STRUCTURE_MEMBERAndreas Schneider2018-01-221-1/+3
| | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13238 We need to be able to point it to the right header location, so we need to be able to pass the 'lib' that it gets set. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org>
* waf: Remove build system info (uname -a)Mathieu Parent2018-01-141-4/+0
| | | | | | | | | | | | Preventing reproducible builds while adding minor benefit. More information at <https://reproducible-builds.org/>. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13213 Signed-off-by: Mathieu Parent <math.parent@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlet <abartlet@samba.org>
* third_party: Update socket_wrapper to version 1.1.9Andreas Schneider2017-12-061-1/+1
| | | | | | | | | | | | | | | * Fixed thread - signal deadlock issue * Added support for openat() * Added support for open64() and fopen64() * Always turn on logging * Increased maximum of wrapped interfaces to 64 * Improved fd duplication code * Fixed strict-aliasing issues * Fixed some use after free issues * Fixed issues on ppc64le Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org>
* build: Move pam_wrapper to third_partyAndreas Schneider2017-11-251-0/+5
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org>
* build: Move uid_wrapper to third_partyAndreas Schneider2017-11-251-0/+5
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org>
* build: Move resolv_wrapper to third_partyAndreas Schneider2017-11-251-0/+5
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org>
* build: Move nss_wrapper to third_partyAndreas Schneider2017-11-251-0/+5
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org>
* build: Move socket_wrapper to third_partyAndreas Schneider2017-11-251-0/+5
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org>
* build: ensure compiler flags are properly detectedUri Simchoni2017-11-221-1/+4
| | | | | | | | | | | | While checking for compiler flag availability, treat warnings as errors. Thus if the compiler only warns about unsupported flag, it will fail the test and the flag shall be marked as unsupported. Signed-off-by: Uri Simchoni <uri@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Wed Nov 22 14:19:20 CET 2017 on sn-devel-144
* build: specify -Wformat as a prerequisite of -Wformat-securityUri Simchoni2017-11-221-1/+2
| | | | | Signed-off-by: Uri Simchoni <uri@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* build: allow specifying prerequisite flags when checking flagsUri Simchoni2017-11-221-4/+6
| | | | | | | | | In gcc, "-Wformat-security" is ignored unless "-Wformat" is also specified. This patch allow adding a "prerequisite flag" to a flag we're testing during configuration. Signed-off-by: Uri Simchoni <uri@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* build: disable format-zero-length warningUri Simchoni2017-11-221-0/+1
| | | | | | | | | | | | | | | format-zero-length warns against printf-style calls with zero-length format string. vfs_full_audit module has such calls, and up until now there was no warning against it because the do_log in vfs_full_audit is not recognized as printf-style function. In a following commit the do_log will be converted to a printf-style function, hence the need to disable this warning. (an alternative would be to disable only for vfs_full_audit, but that would complicate things needlessly). Signed-off-by: Uri Simchoni <uri@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* build: allow adding cflags to end of python module build commandUri Simchoni2017-11-221-0/+2
| | | | | Signed-off-by: Uri Simchoni <uri@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* build: allow passing custom cflags to end of library buildUri Simchoni2017-11-221-0/+2
| | | | | Signed-off-by: Uri Simchoni <uri@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* wafsamba: We need to honor DESTDIR in INSTALL_DIRAndreas Schneider2017-09-161-8/+9
| | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12957 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Sat Sep 16 04:47:29 CEST 2017 on sn-devel-144
* wafsamba: Do not chmod already existing dirs on installAndreas Schneider2017-09-161-2/+0
| | | | | | | | | This might break backward compatibility. BUG: https://bugzilla.samba.org/show_bug.cgi?id=12957 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* param: Add 'binddns dir' parameterAndreas Schneider2017-09-051-0/+1
| | | | | | | | | | This allows to us to have restricted access to the directory by the group 'named' which bind is a member of. BUG: https://bugzilla.samba.org/show_bug.cgi?id=12957 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlet <abartlet@samba.org>
* wafsamba: Call INSTALL_DIR in INSTALL_DIRSAndreas Schneider2017-08-241-2/+2
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12957 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* wafsamba: Add INSTALL_DIR functionAndreas Schneider2017-08-241-0/+18
| | | | | | | | | | | The install_dir function in waf has been deprecated and it doesn't support setting directory permissions. So we need to implement our own function anyway. BUG: https://bugzilla.samba.org/show_bug.cgi?id=12957 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* build: Do not recurse on symlinks to directories when building tarballsMartin Schwenke2017-08-101-1/+1
| | | | | | | | | | | | | | | | | | DIST_FILES() causes all files in any specified directory to be recursively added to the tarball. However, a symbolic link to a directory is detected as a regular directory so is also subject to recursion. This means that a symbolic link to a directory is dereferenced and the directory of files beyond it are added to the tarball under a directory corresponding to the link. This is almost certainly not what is intended because it will usually result in duplicate files. This is because the contents of a symbolic link's target directory will already be present in the tarball. Instead, do not treat symbolic links to directories as directories, but add them to the tarball like normal files. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* build: Do not ignore symlinks to directories when building tarballsMartin Schwenke2017-08-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Tarballs currently do not contain symbolic links to directories even if they are committed in git. This means that CTDB tests fail when run in-tree from a tarball, due to a couple of missing links needed by unit tests: ERROR: Directory .../ctdb/tests/var/unit_eventscripts/etc-ctdb/events.d does not exist. Subdirectories of directories specified via DIST_DIRS() are ignored, since all the files within them are separately added to the tarball. Symbolic links to directories are detected as directories, so they are also ignored, causing them to be missing from the tarball. Instead, do not treat symbolic links to directories as directories, but add them to the tarball like normal files. It is easy to confirm that this change causes no difference to current tarballs other than causing the missing CTDB test links to be added: $ diff -u samba-4.8.0pre1-GIT-eb691cd0242.tar.gz.contents samba-4.8.0pre1-GIT-dfb16de0149.tar.gz.contents --- samba-4.8.0pre1-GIT-eb691cd0242.tar.gz.contents 2017-08-08 20:21:40.022993091 +1000 +++ samba-4.8.0pre1-GIT-dfb16de0149.tar.gz.contents 2017-08-08 20:35:11.001580747 +1000 @@ -578,7 +578,9 @@ ctdb/tests/eventscripts/91.lvs.startup.001.sh ctdb/tests/eventscripts/91.lvs.startup.002.sh ctdb/tests/eventscripts/README +ctdb/tests/eventscripts/etc-ctdb/events.d ctdb/tests/eventscripts/etc-ctdb/functions +ctdb/tests/eventscripts/etc-ctdb/nfs-checks.d ctdb/tests/eventscripts/etc-ctdb/nfs-linux-kernel-callout ctdb/tests/eventscripts/etc-ctdb/public_addresses ctdb/tests/eventscripts/etc-ctdb/rc.local Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* s3: drop build_envBernhard M. Wiedemann2017-07-141-14/+0
| | | | | | | | | | | | | | | As a follow up to eedebe2ef1b ("docs-xml: Sort input file list"), this change enables reproducible builds, without the added complexity of https://lists.samba.org/archive/samba-technical/2017-June/121302.html Bug: https://bugzilla.samba.org/show_bug.cgi?id=12906 Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de> Reviewed-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): David Disseldorp <ddiss@samba.org> Autobuild-Date(master): Fri Jul 14 18:48:08 CEST 2017 on sn-devel-144
* wafsamba: add maxversion and version_blacklist to CHECK_BUNDLED_SYSTEM[_PKG]()Stefan Metzmacher2017-07-021-2/+19
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12859 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* wafsamba: Pass down the install argument for samba modulesAndreas Schneider2017-06-061-2/+4
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* wafsamba: Allow to specify VERSION file pathAmitay Isaacs2017-05-241-2/+2
| | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
* lib: modules: Change XXX_init interface from XXX_init(void) to ↵Jeremy Allison2017-04-221-0/+3
| | | | | | | | | | | | | | | | | | | | XXX_init(TALLOC_CTX *) Not currently used - no logic changes inside. This will make it possible to pass down a long-lived talloc context from the loading function for modules to use instead of having them internally all use talloc_autofree_context() which is a hidden global. Updated all known module interface numbers, and added a WHATSNEW. Signed-off-by: Jeremy Allison <jra@samba.org> Signed-off-by: Ralph Böhme <slow@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Sat Apr 22 01:17:00 CEST 2017 on sn-devel-144
* wafsamba: add source directory define SRCDIR to config.hRalph Boehme2017-04-201-0/+2
| | | | | | | | This will be used in the next commit to prepare the path to a test script in a smbtorture test. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* wafsamba: Add CHECK_CMOCKA functionAndreas Schneider2017-04-101-0/+6
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlet <abartlet@samba.org>
* wafsamba: move -L/some/path from LINKFLAGS_PYEMBED to LIBPATH_PYEMBEDStefan Metzmacher2017-04-041-0/+6
| | | | | | | | | | | | | | | LINKFLAGS should not have path components. This fixes the build on systems like FreeBSD where python is located in /usr/local/lib. BUG: https://bugzilla.samba.org/show_bug.cgi?id=12724 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Tue Apr 4 16:10:18 CEST 2017 on sn-devel-144
* waf: disable-python - add option globally to build systemIan Stakenvicius2017-03-102-1/+37
| | | | | | | | | | | This commit adds --disable-python as an option to the build system. It adds PYTHON_BUILD_IS_ENABLED() to bld, to be used with enabled= on other modules, and adjusts SAMBA_PYTHON() to set enabled=False if PYTHON_BUILD_IS_ENABLED() is false. Signed-off-by: Ian Stakenvicius <axs@gentoo.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
* buildtools: Work around a . being in the target name when building python3 ↵Andrew Bartlett2017-03-101-0/+1
| | | | | | | | | | | | | helpers The pyparam_util module becomes pyparam_util.cpython_35m_x86_64_linux_gnu but the command line parser for -D stops at the first . That we even set -DSTATIC_subsystem_MODULES_PROTO for these subsystems without any modules ever declared is left for another time Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
* talloc: use the system pytalloc-util for python3 as wellAndrew Bartlett2017-03-103-7/+16
| | | | | | | | | | | | | | | | This involves installing a .pc file for the python3 library as well To get the .pc file generated and installed is quite a mission, we have to rework the talloc build system to ensure that the second 'env' created for EXTRA_PYTHON has everything set up on it, the TALLOC_VERSION in particular. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Incorportaing fixes by Petr Viktorin <pviktori@redhat.com> Signed-off-by: Petr Viktorin <pviktori@redhat.com>
* waf: Fix a typoVolker Lendecke2017-03-011-1/+1
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* build:wafsamba: Remove ambiguous 'if x in conf.env' constructsThomas Nagy2017-02-211-2/+2
| | | | | | | | | | | | | | | | | | | Configuration values such as HAVE_STDDEF_H can be set to 0 to indicate a test failure. Waf 1.5 has a few bugs that prevent configuration tests from setting such values consistently on failures. Consequently, conditions such as 'if conf.env.VARNAME' must be used to indicate that config test successes are expected. Note that conf.env.VARNAME always returns an empty list (False value) when no variable is defined so there are no risk of raising AttributeError/KeyError exceptions. Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Uri Simchoni <uri@samba.org> Autobuild-User(master): Uri Simchoni <uri@samba.org> Autobuild-Date(master): Tue Feb 21 13:47:07 CET 2017 on sn-devel-144
* wafsamba: Remove 2010 comments that seems not accurate anymoreMatthieu Patou2017-02-091-2/+0
| | | | | | | | | In my tests default value is correctly used and if we provide explicitly a --with it will comply with the store_true and if we provide --without then it will comply with the store_false Change-Id: I820a7f2f08c51ec23b694bce7009c3891d4ab8ef Reviewed-by: Jeremy Allison <jra@samba.org>
* wafsamba: Move command line option function labelled as 'samba3' to the ↵Matthieu Patou2017-02-092-29/+29
| | | | | | | | | | | common set of functions It allows to be used for things that are not 'samba3' only (or more accurately things not in common and not related to the AD DC implementation) Signed-off-by: Matthieu Patou <mat@matws.net> Reviewed-by: Jeremy Allison <jra@samba.org>
* wscript: remove executable bits for all wscript* filesStefan Metzmacher2017-01-111-0/+0
| | | | | | | | | | These files should not be executable. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Wed Jan 11 20:21:01 CET 2017 on sn-devel-144