summaryrefslogtreecommitdiff
path: root/buildtools
Commit message (Collapse)AuthorAgeFilesLines
* build: Fix build with perl on debian sid.Andrew Bartlett2016-10-291-1/+2
| | | | | | | | | | | | | build: Fix build with perl on debian sid. It appears that "." is no longer in perl_inc BUG: https://bugzilla.samba.org/show_bug.cgi?id=12395 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Martin Schwenke <martin@meltin.net> Autobuild-User(master): Martin Schwenke <martins@samba.org> Autobuild-Date(master): Sat Oct 29 09:32:37 CEST 2016 on sn-devel-144
* wafsamba: add -Werror=format-security to the developer buildStefan Metzmacher2016-09-051-0/+1
| | | | | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Mon Sep 5 20:23:00 CEST 2016 on sn-devel-144
* build: avoid -Wtautological-compare errors from gcc6+ by disabling it globallyMichael Adam2016-07-151-0/+1
| | | | | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri Jul 15 04:31:27 CEST 2016 on sn-devel-144
* configure: set HAVE___ATTRIBUTE__ for heimdalDouglas Bagnall2016-03-091-0/+16
| | | | | | | | | | | | | Without this, heimdal ends up defining __attribute__ away, causing gcc-6 compile errors with -Werror=return-type because it can't tell when functions have __attribute__((noreturn)). Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Wed Mar 9 13:52:26 CET 2016 on sn-devel-144
* Error when private libraries have public headers.Jelmer Vernooij2016-01-131-1/+5
| | | | | | Signed-Off-By: Jelmer Vernooij <jelmer@samba.org> Reviewed-By: Andrew Bartlett <abartlet@samba.org> Reviewed-By: Stefan Metzmacher <metze@samba.org>
* Add private_headers flag to SAMBA_*() functions.Jelmer Vernooij2016-01-131-0/+5
| | | | | | | | | While this argument is correctly ignored, it does mean that we can associate private headers with specific subsystems/libraries. Signed-Off-By: Jelmer Vernooij <jelmer@samba.org> Reviewed-By: Andrew Bartlett <abartlet@samba.org> Reviewed-By: Stefan Metzmacher <metze@samba.org>
* build: Add space before -D optionAndrew Bartlett2016-01-081-1/+1
| | | | | | | | | | This ensures that it is not concatonated with the previous option Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jelmer Vernooij <jelmer@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Fri Jan 8 02:36:47 CET 2016 on sn-devel-144
* python: Assert that we use Py_ssize_t consistently for PyParseArgs*()Andrew Bartlett2016-01-071-0/+11
| | | | | Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
* build:wafsamba: Use the upstream version of gccdepsThomas Nagy2016-01-022-127/+5
| | | | | | | | | | | | | This removes the duplicate gccdeps file provided in the Samba tree. The two files buildtools/wafsamba/gccdeps.py and thirdparty/wafadmin/3rdparty/gccdeps.py are identical except for the whitespaces (compare them with `diff -burN`) Signed-off-by: Thomas Nagy <tnagy@waf.io> Reviewed-by: Michael Adam <obnox@samba.org> Reviewed-by: Uri Simchoni <uri@samba.org> Autobuild-User(master): Uri Simchoni <uri@samba.org> Autobuild-Date(master): Sat Jan 2 22:31:56 CET 2016 on sn-devel-144
* build:wafsamba: Ensure that check_group_ordering can be overriddenThomas Nagy2015-11-241-2/+2
| | | | | | | | | | | | | | Group ordering verifications are performed by default in Waf 1.8, so this method will be redundant. The purpose of this change is to make it easier to disable check_group_ordering as it contains code that is very specific to Waf 1.5. Signed-off-by: Thomas Nagy <tnagy@waf.io> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Tue Nov 24 08:03:29 CET 2015 on sn-devel-104
* build:wafsamba: Ensure that target clones get a different nameThomas Nagy2015-11-241-0/+1
| | | | | | | | | | | Changing the 'target' attribute results in a different file name, which is visibly necessary. Yet the 'name' attribute should also be modified even if invisible as it is used to query targets (uselib for example). Failing to do so results in errors in Waf 1.8. Signed-off-by: Thomas Nagy <tnagy@waf.io> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* build:wafsamba: Specify whether node objects or flat lists in ant_globThomas Nagy2015-11-242-3/+3
| | | | | | | | | The changes enable the ant_glob declaration to be compatible with more recent versions of Waf. Signed-off-by: Thomas Nagy <tnagy@waf.io> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* build:wafsamba: remove check_orphaned_targetsThomas Nagy2015-11-191-19/+0
| | | | | | | | | | | | The function check_orphaned_targets is not used and has no specification, so it can be removed safely. Signed-off-by: Thomas Nagy <tnagy@waf.io> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Thu Nov 19 13:10:53 CET 2015 on sn-devel-104
* build:wafsamba: Waf 1.8 compatible declaration of 'mandatory' configuration ↵Thomas Nagy2015-11-163-6/+14
| | | | | | | | | | | | | | | tests The configuration tests raise exceptions by default in later Waf versions, but the samba tests do not specify whether the errors should be raised or not. This changes lifts the ambiguity. Signed-off-by: Thomas Nagy <tnagy@waf.io> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Mon Nov 16 14:50:39 CET 2015 on sn-devel-104
* build:wafsamba: Replace Options.is_install by bld.is_installThomas Nagy2015-11-164-7/+5
| | | | | | | | | Options.is_install is a deprecated module variable that is more verbose than bld.is_install and complicates the Waf 1.8 upgrade. Signed-off-by: Thomas Nagy <tnagy@waf.io> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* build:wafsamba: Remove the print_commands code from the build scriptsThomas Nagy2015-11-062-21/+1
| | | | | | | | Using the print_commands tool makes it easier to upgrade to Waf 1.8. Signed-off-by: Thomas Nagy <tnagy@waf.io> Reviewed-by: Uri Simchoni uri@samba.org Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* build:wafsamba: Remove samba_utils.runonceThomas Nagy2015-11-066-30/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The decorator order matters in the following: """ @runonce @conf function() """ First, the @conf decorator binds the function to the configuration context and then returns the same function. The @runonce decorator then takes the output function and replaces it by another that performs caching. This new function remains in the current script and is never bound to the configuration context, so caching never occurs. The declaration would have been correct if written like this: """ @conf @runonce function() """ Yet the decorator @run_once does not keep the function name (__name__), so the annotation with @conf would fail. The straightforward approach is to remove all the incorrect @runonce occurrences. Besides that, the function Utils.run_once is already present in the Waf library, and is sufficient for the current needs of the Samba code (it caches only the first argument). Therefore samba_utils.runonce can be safely replaced by Utils.run_once, which is also present in Waf 1.8. Note: at runtime, only SETUP_BUILD_GROUPS seems to actually use caching. Signed-off-by: Thomas Nagy <tnagy@waf.io> Reviewed-by: Uri Simchoni uri@samba.org Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* build:wafsamba: Moved samba_before_apply_obj_vars to samba_utilsThomas Nagy2015-11-062-22/+25
| | | | | | | | | | The function samba_before_apply_obj_vars serves to remove system paths, it is certainly not an optimisation and has no place in that module. By optimisation, we mean that the build process could run without it. Signed-off-by: Thomas Nagy <tnagy@waf.io> Reviewed-by: Uri Simchoni uri@samba.org Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* build:wafsamba: Removed unnecessary and misleading variablesThomas Nagy2015-11-061-8/+2
| | | | | | | | | | | There is no 'allow_duplicates' attribute anywhere. The function 'check_duplicate_sources' always returns True unless it raises an exception There is no list of source files to use The variable 'tstart' is unused Signed-off-by: Thomas Nagy <tnagy@waf.io> Reviewed-by: Uri Simchoni uri@samba.org Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* ldb: Run the Python testsuitePetr Viktorin2015-11-051-1/+4
| | | | | | Signed-off-by: Petr Viktorin <pviktori@redhat.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* wafsamba: detect programmer errors in CHECK_BUNDLED_SYSTEM()Stefan Metzmacher2015-11-041-25/+25
| | | | | | | | | | | | | | | | All prerequisite libraries of CHECK_BUNDLED_SYSTEM[_PKG](onlyif='lib1 lib2') need to be checked before. That means conf.env['FOUND_SYSTEMLIB_lib1'] and conf.env['FOUND_SYSTEMLIB_lib2'] need to exist independed of its value (True or False). Otherwise this is a logic error. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11458 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Wed Nov 4 18:38:18 CET 2015 on sn-devel-104
* build:wafsamba: Remove the now unneeded special treatment of rpath flagsThomas Nagy2015-11-021-55/+1
| | | | | | | | | | | | The flags parsing fixes were backported to waf 1.5 from waf 1.8. There is no reason to keep the flags parsing fixes in Samba. Signed-off-by: Thomas Nagy <tnagy@waf.io> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Mon Nov 2 03:35:31 CET 2015 on sn-devel-104
* buildtools: Ignore exact Python version for ABI checkingPetr Viktorin2015-11-012-2/+13
| | | | | | | | | | | | | | | | Utilities for Python libraries are built for a specific Python version. Starting with Python 3, the Python version is recorded in the shared library filename as an ABI tag, e.g. "pytalloc.cpython-34m.so. The exact version doesn't matter for Samba's ABI check. Replace the ABI tag with a simpler one that just records the major version of Python. Signed-off-by: Petr Viktorin <pviktori@redhat.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Sun Nov 1 01:09:06 CET 2015 on sn-devel-104
* build:wafsamba: Removed hard-coded class names from build scriptsThomas Nagy2015-10-281-4/+3
| | | | | | | | | | | Using hard-coded class names prevents subclassing and make it hard to reason about the workflow. The wscript files read during the build must be read during the installation phase as well. Signed-off-by: Thomas Nagy <tnagy@waf.io> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* build:wafsamba: removed most import * statementsThomas Nagy2015-10-2822-58/+64
| | | | | | | | | | | | | The 'import *' statements make it more difficult to reason about the modules and tends to conceal bugs. These changes enable running pyflakes against most of the build scripts. Signed-off-by: Thomas Nagy <tnagy@waf.io> Reviewed-by: Andrew Bartlet <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Wed Oct 28 12:52:17 CET 2015 on sn-devel-104
* build: --picky-developer implies --enable-developerMartin Schwenke2015-10-271-1/+5
| | | | | | | | | | | | Have --picky-developer enable --enable-developer too, instead of requiring both options to be specified. This makes it obey the principle of least surprise. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Martin Schwenke <martins@samba.org> Autobuild-Date(master): Tue Oct 27 07:19:33 CET 2015 on sn-devel-104
* build:wafsamba: dead code removal in gettext detectionThomas Nagy2015-10-271-3/+0
| | | | | | | | | | | | Since the --gettext-location command-line option has no effect, the misleading code is removed. The samba functions ADD_CFLAGS must also be used in the future Signed-off-by: Thomas Nagy <tnagy@waf.io> Reviewed-by: Uri Simchoni <uri@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Tue Oct 27 03:34:28 CET 2015 on sn-devel-104
* build:wafsamba: Enable feature-compatible declaration for Waf 1.8Thomas Nagy2015-10-137-15/+15
| | | | | | | | | In Waf 1.8 the declaration is features='c', not features='cc'. These changes prepare the replacement of Waf 1.5 by Waf 1.8 for Samba. Signed-off-by: Thomas Nagy <tnagy@waf.io> Reviewed-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* build: Move __attribute__ ((destructor)) and ((constructor)) tests to wafsambaAndrew Bartlett2015-10-091-0/+34
| | | | | | | | This allows us to use them in talloc as well. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Signed-off-by: Adrian Cochrane <adrianc@catalyst.net.nz> Reviewed-by: Jeremy Allison <jra@samba.org>
* build: improve stack protector checkGustavo Zacarias2015-09-211-3/+17
| | | | | | | | | | | | | | | | | | | | | Testing a toolchain for proper -fstack-protector must go beyond ensuring the compiler and linker accept the option. If the test C program does nothing with the stack then guards aren't inserted and/or are optimized away giving the false impression that it works when in fact the libc might not support it. Update the check to a program that uses the stack, hence making a link fail if proper support isn't available, for example in non-ssp enabled uclibc toolchains like this: test.c:(.text.startup+0x64): undefined reference to `__stack_chk_fail' Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <rb@sernet.de> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Mon Sep 21 23:29:13 CEST 2015 on sn-devel-104
* build:wafsamba: Use the Waf 1.8 API get_tgen_by_name instead of name_to_objThomas Nagy2015-09-025-40/+40
| | | | | | | | | Signed-off-by: Thomas Nagy <tnagy@waf.io> Reviewed-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Wed Sep 2 03:49:51 CEST 2015 on sn-devel-104
* build:wafsamba: Close file handles in the build scripts tooThomas Nagy2015-09-027-49/+14
| | | | | | Signed-off-by: Thomas Nagy <tnagy@waf.io> Reviewed-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* wafsamba: don't add -DSTATIC_%s_MODULES* arguments for ↵Stefan Metzmacher2015-08-061-0/+3
| | | | | | | | | | | | | | | SAMBA_LIBRARY(pyembed=True) Python helper libraries don't have any modules and having something like '.cpython-34m' in the name, e.g. STATIC_pytalloc-util.cpython-34m_MODULES breaks the build. Another way to fix this would be removing PYTHON_SO_ABI_FLAG from the name. This allows --extra-python=/usr/bin/python3 to work on Ubuntu 14.04. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* buildtools: Fix crash on invalid --extra-python optionPetr Viktorin2015-07-211-1/+1
| | | | | | Signed-off-by: Petr Viktorin <pviktori@redhat.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* buildtools: Don't configure Python more than oncePetr Viktorin2015-07-211-0/+4
| | | | | | Signed-off-by: Petr Viktorin <pviktori@redhat.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* wafsamba: Cache final_libs for each targetAmitay Isaacs2015-06-301-1/+2
| | | | | | | | | | | | The code for saving/loading dependencies does not cache final_libs for each target. If wafsamba tries to reuse the saved dependencies, then it does not get the dependencies on the private libraries correctly. Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net> Autobuild-User(master): Martin Schwenke <martins@samba.org> Autobuild-Date(master): Tue Jun 30 09:44:10 CEST 2015 on sn-devel-104
* Always use Samba's CHECK_CFG instead of waf check_cfgThomas Nagy2015-06-261-1/+1
|
* Remove PYTHONDIR and PYTHONARCHDIR in a single placeThomas Nagy2015-06-261-0/+4
|
* wafsamba: Also build libraries with RELRO protectionAndreas Schneider2015-06-191-0/+2
| | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=11346 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Fri Jun 19 12:51:48 CEST 2015 on sn-devel-104
* wafsamba: let CHECK_DECLS() find enum valuesStefan Metzmacher2015-06-121-1/+12
| | | | | | | | In the current state this still generates the same config.h at least on ubuntu 14.04 amd64. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* wafsamba: remove unused allow_warnings=True from SAMBA_PYTHON()Stefan Metzmacher2015-06-121-1/+0
| | | | | | | This is not needed anymore all python bindings build without wawrnings now. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* buildtools: Always reset the build environmentPetr Viktorin2015-06-101-81/+82
| | | | | | | | | | | | | In install_library, the Build object's environment was not reset after an early return, so the extrapython env would be used in subsequent build steps. Wrap everything in a try-finally block to make sure the env is reset. (Almost all of the change is indentation, `git show -w` recommended.) Signed-off-by: Petr Viktorin <pviktori@redhat.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
* waf: add a sample run-on-target scriptUri Simchoni2015-05-201-0/+148
| | | | | | | | | | This is a sample script that can be used with the --cross-execute configure switch to run configure tests on a remote target for which samba is being cross-compiled. Signed-off-by: Uri Simchoni <urisimchoni@gmail.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org>
* waf: Fix parsing of cross-answers file in case answer includes a colonUri Simchoni2015-05-201-1/+1
| | | | | | | | | | The answer provided in the cross-answers file may include a colon, as in: Checking uname version type: "#57-Ubuntu SMP Tue Jul 15 03:51:08 UTC 2014" Signed-off-by: Uri Simchoni <urisimchoni@gmail.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org>
* waf: allow cross-execute program to have arguments with spacesUri Simchoni2015-05-201-1/+2
| | | | | | | | | | | | | | | | | | | | | When cross-compiling samba using the cross-execute method, allow the cross-excute command to have arguments that contain spaces by quoting them. For example: ./configure --cross-compile '--cross-execute=ce-program "par am"' In this case, for each cross test whose binary is /path/testprog, waf shall run the equivalent of running from a shell: ce-program "par am" /path/testprog This is useful for passing an arbitrary argument list to a subprocess of the cross-execute program, such as in buildtools/examples/run_on_target.py Signed-off-by: Uri Simchoni <urisimchoni@gmail.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org>
* waf: improve readability of cross-answers generated by cross-executeUri Simchoni2015-05-201-5/+8
| | | | | | | | | | | | | | When generating a result for cross-answers from the (retcode, retstring) tuple: - (0, "output") indicated as "output" - 1 is interpreted as generic fail code, instead of 255, because most if not all tests fail with 1 as exit code rather than 255 - For failing test, use NO instead of FAIL, because that's not necessarily a failure (it could mean that something is NOT broken) Signed-off-by: Uri Simchoni <urisimchoni@gmail.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org>
* Adds a new mode to samba cross-compiling.Uri Simchoni2015-05-201-12/+34
| | | | | | | | | | | | When both --cross-answers and --cross-execute are set, this means: - Use cross-answers - If answer is unknown, then instead of adding UNKNOWN to the cross-answers file and failing configure, the new mode runs cross-execute to determine the answer and adds that to the cross-answers file. Signed-off-by: Uri Simchoni <urisimchoni@gmail.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org>
* waf: sanitize and fix added cross answerUri Simchoni2015-05-201-2/+11
| | | | | | | | | | | | | | | | When configuring samba for cross-compilation using the cross-answers method, the function add_answer receives the standard output and exit code of a configuration test and updates the cross-answers file accordingly. This patch sanitizes the standard output to conform to the cross-answers file format - one line of output. It also adds a missing newline. (Note - at this point add_answer is only ever called with empty output but this change is significant for the reminder of this patchset) Signed-off-by: Uri Simchoni <urisimchoni@gmail.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org>
* waf: always close cross answers fileUri Simchoni2015-05-201-0/+2
| | | | | | | | | | When configuring samba for cross-compilation using the cross-answers file, the file is not closed in a couple of cases - fix that. Signed-off-by: Uri Simchoni <urisimchoni@gmail.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org>
* Factor out submodule presence checking.Jelmer Vernooij2015-05-191-1/+10
| | | | | | | | Signed-off-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Tue May 19 22:17:48 CEST 2015 on sn-devel-104
View Lorry Controller Status