summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* s3:net: make use of cli_rpc_pipe_open_with_creds() by using net_context_creds()Stefan Metzmacher2020-05-281-3/+11
| | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3:net: avoid prompting for a password if --use-ccache is usedStefan Metzmacher2020-05-281-0/+4
| | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3:net: add net_context_creds() helper functionStefan Metzmacher2020-05-282-0/+106
| | | | | | Pair-Programmed-With: Andreas Schneider <asn@samba.org> Signed-off-by: Andreas Schneider <asn@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3:net: always set ctx->opt_user_specified = true when we overwrite ↵Stefan Metzmacher2020-05-283-0/+3
| | | | | | | | opt_user_name If we force changing the used username we should make that clear. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3:net: remove unused net_use_machine_account()Stefan Metzmacher2020-05-282-23/+0
| | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3:cli_pipe: remove unused 'use_kerberos' from cli_rpc_pipe_open_generic_auth()Stefan Metzmacher2020-05-283-3/+0
| | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* OID: Reserve 1.3.6.1.4.1.7165.777.x for use on the wikiAndrew Bartlett2020-05-271-1/+6
| | | | | | | | | | | This allows us to handle some OIDs more freely and use them in example schema without patching the main git repo each time. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz> Autobuild-User(master): Gary Lockyer <gary@samba.org> Autobuild-Date(master): Wed May 27 22:17:10 UTC 2020 on sn-devel-184
* lib/util: Allow gdb to be started by samba_start_debugger() under the ↵Andrew Bartlett2020-05-271-0/+10
| | | | | | | | | | | default Ubuntu restrictions Ubuntu (in particular) restricts ptrace by default for security reasons but the processe to be traced can allow tracing by a child process using prctl(). This matches what is done for panic action = Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
* s3: VFS: cap. Fixup mistake using the wrong parameter to capencode.Jeremy Allison2020-05-261-1/+1
| | | | | | | | | | Caught by Coverity. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Tue May 26 21:35:55 UTC 2020 on sn-devel-184
* libgpo: Remove unused codeStefan Metzmacher2020-05-263-239/+0
| | | | | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Tue May 26 11:22:07 UTC 2020 on sn-devel-184
* s3-net: disable net_ads_gpo_apply() and net_ads_gpo_refresh()David Mulder2020-05-261-245/+0
| | | | | | | | These are now handled in samba-gpupdate, and the net ads gpo refresh has not worked for some time. Signed-off-by: David Mulder <dmulder@suse.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* libsmb: Apply some const to parse_finfo_id_both_directory_info()Volker Lendecke2020-05-251-1/+1
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Mon May 25 09:36:15 UTC 2020 on sn-devel-184
* libsmb: Remove unused cli_errstr()Volker Lendecke2020-05-252-36/+0
| | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* torture3: Remove some ancient unused codeVolker Lendecke2020-05-251-51/+0
| | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* libsmb: Move a variable declaration closer to its useVolker Lendecke2020-05-251-1/+1
| | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* libsmb: Remove some lines that were never usedVolker Lendecke2020-05-251-34/+0
| | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* libsmb: Avoid castsVolker Lendecke2020-05-251-2/+2
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* libsmb: Use IS[DOT]DOTVolker Lendecke2020-05-251-1/+1
| | | | | | | strequal is not necessary here Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* libsmb: Remove a pointless ZERO_STRUCT()Volker Lendecke2020-05-251-1/+0
| | | | | | | "c" is a pointer that was initialized to NULL above Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* libsmb: Simplify callers of SMBC_dlist_contains()Volker Lendecke2020-05-253-20/+15
| | | | | | | This function already does the NULL check on the file pointer Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* libsmb: Make SMBC_dlist_contains return boolVolker Lendecke2020-05-252-8/+10
| | | | | | | | It returned True/False, and is used as boolean only. Modernize formatting a bit. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* libsmb: Align calls to SMBC_dlist_contains()Volker Lendecke2020-05-251-7/+2
| | | | | | | Everywhere else it's called as !SMBC_dlist_contains() Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* build: add configure option to control vfs_snapper buildMatt Taylor2020-05-251-3/+9
| | | | | | | | | | | | | | | vfs_snapper is currently built if dbus development headers / libraries are detected during configure. This commit adds new --disable-snapper and --enable-snapper (default) configure parameters. When enabled, configure will fail if the dbus development headers / libraries are missing. Signed-off-by: Matt Taylor <liverbugg@rinux.org> Reviewed-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Mon May 25 01:16:46 UTC 2020 on sn-devel-184
* build: quota wscript error message spelling fixMatt Taylor2020-05-241-1/+1
| | | | | | Signed-off-by: Matt Taylor <liverbugg@rinux.org> Reviewed-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s3: rpc_server: Avoid casts calling to find_policy_by_hnd()Samuel Cabrero2020-05-2410-302/+329
| | | | | Signed-off-by: Samuel Cabrero <scabrero@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s3: rpc_server: Remove dead codeSamuel Cabrero2020-05-249-189/+2
| | | | | Signed-off-by: Samuel Cabrero <scabrero@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s3: rpc_server: Drop s3 rpc handles implementationSamuel Cabrero2020-05-246-285/+42
| | | | | Signed-off-by: Samuel Cabrero <scabrero@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* pidl: Set dce_call in pipes_struct before dispatching callSamuel Cabrero2020-05-243-0/+5
| | | | | Signed-off-by: Samuel Cabrero <scabrero@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s3: rpc_server: Remove SAMR specific policy_handle_find() functionSamuel Cabrero2020-05-243-47/+10
| | | | | | | The generic function already checks the handle type. Signed-off-by: Samuel Cabrero <scabrero@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s3: rpc_server: Move SAMR handle based access check to a wrapper functionSamuel Cabrero2020-05-241-453/+304
| | | | | | | | Now that the type associated to the handle is the same for all handle types we can wrap the access check. Signed-off-by: Samuel Cabrero <scabrero@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s3: rpc_server: Remove SAMR specific policy_handle_create() functionSamuel Cabrero2020-05-243-275/+234
| | | | | | | | | | | | | | Now that we pass the handle type to the generic handle creation and find functions we can drop the specific SAMR ones. The policy_handle_create() function labeled the talloc chunk used to allocate the handle's associated data, and the policy_handle_find() is checking the name matches with the expected data. The check is performed now by the generic functions based on the handle type so we can drop these SAMR specific functions. Signed-off-by: Samuel Cabrero <scabrero@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s3: rpc_server: pass DCE/RPC handle type to find_policy_handleSamuel Cabrero2020-05-2410-191/+401
| | | | | | | | | Following changes in commit c7a4578d06427a82ead287f0c5248c1a54cc9336 pass the handle type to the handle search functions. The handle type will be verified unless passing DCESRV_HANDLE_ANY to find functions. Signed-off-by: Samuel Cabrero <scabrero@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s3: rpc_server: Strip out access check field from s3 handles implementationSamuel Cabrero2020-05-243-105/+382
| | | | | | | | | The handle based security model is a SAMR specific feature. The access granted is stored in the handle's associated data after creating it and the access is verified after searching the handle. Signed-off-by: Samuel Cabrero <scabrero@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* librpc: core: Move the s4 handles implementation to the RPC server coreSamuel Cabrero2020-05-243-6/+7
| | | | | Signed-off-by: Samuel Cabrero <scabrero@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* selftest: Add test for handle typesSamuel Cabrero2020-05-244-1/+220
| | | | | | | | The test is written for SAMR, but as the handle type is verified by the server core library it also applies to other RPC services. Signed-off-by: Samuel Cabrero <scabrero@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* ldb: also use portable __has_attribute macro to check for attribute supportBjörn Jacke2020-05-241-1/+1
| | | | | Signed-off-by: Bjoern Jacke <bjacke@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* talloc: also use portable __has_attribute macro to check for attribute supportBjörn Jacke2020-05-241-1/+6
| | | | | Signed-off-by: Bjoern Jacke <bjacke@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* tdb: also use __has_attribute macro to check for attribute supportBjörn Jacke2020-05-241-1/+1
| | | | | Signed-off-by: Bjoern Jacke <bjacke@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* replace, attr.: use function attributes only if supported by feature macro ↵Björn Jacke2020-05-242-10/+19
| | | | | | | | | (or old gcc) BUG: https://bugzilla.samba.org/show_bug.cgi?id=12296 Signed-off-by: Bjoern Jacke <bjacke@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* gitlab-ci: Create a single samba-fips runnerAndreas Schneider2020-05-242-22/+6
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* ctdb-tests: Add a new fetch ring test that also checks hot keysMartin Schwenke2020-05-221-0/+161
| | | | | | | | Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> Autobuild-User(master): Amitay Isaacs <amitay@samba.org> Autobuild-Date(master): Fri May 22 08:05:54 UTC 2020 on sn-devel-184
* ctdb-tests: Update fetch_ring to take database and key on command lineMartin Schwenke2020-05-222-12/+21
| | | | | Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-daemon: Fix sorting of hot keysMartin Schwenke2020-05-221-14/+19
| | | | | | | | | | The current code only ever swaps with slot 0. This will only ever happen with slots 0 and 1, so probably never sorts. Replace with qsort(). Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-daemon: Add extra logging of hot keysMartin Schwenke2020-05-223-0/+14
| | | | | | | | | | | ctdbd currently only logs when a new hot key is added. If a key gets hotter then nothing new is logged. Log hot key updates when the number of migrations has doubled since the last time that key was logged. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-daemon: Update hot key loggingMartin Schwenke2020-05-221-3/+4
| | | | | | | | | This message indicates that a hot key was added, so say that. After all the hot key slots have been filled the id will always be 0, so don't bother logging it. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-daemon: Fix bug in slot 0 comparison optimisationMartin Schwenke2020-05-221-2/+7
| | | | | | | This is only valid if all slots are in use. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-daemon: Switch some variables to unsignedMartin Schwenke2020-05-222-4/+4
| | | | | | | These should be unsigned but luck is currently on our side. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-daemon: Add separate hot keys array for database statisticsMartin Schwenke2020-05-223-23/+38
| | | | | | | | | | There are 2 reasons for this. Sorting of hot keys is broken and will be changed to an implementation that needs a named (i.e. not anonymous) structure. Also, at least one non-protocol field will be added to facilitate more useful logging. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-build: Fix a typoMartin Schwenke2020-05-221-1/+1
| | | | | Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* smbd: prepare DH disconnect for AT-namesRalph Boehme2020-05-211-1/+1
| | | | | | | | | | | This ensure cookie.base_name is set to the full path to deal with fsp->fsp_name being an atname in the future. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu May 21 22:01:25 UTC 2020 on sn-devel-184