summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* s4-dns: Deprecate BIND9_FLATFILE and remove "rndc command"Andrew Bartlett2019-08-227-294/+13
| | | | | | | | Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Thu Aug 22 21:24:00 UTC 2019 on sn-devel-184
* docs: Deprecate "rndc command" for Samba 4.11Andrew Bartlett2019-08-221-0/+7
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14092 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3: VFS: Complete the replacement of SMB_VFS_MKNOD() -> SMB_VFS_MKNODAT().Jeremy Allison2019-08-228-71/+1
| | | | | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Aug 22 19:17:07 UTC 2019 on sn-devel-184
* s3: VFS: vfs_time_audit. Remove mknod_fn(). No longer used.Jeremy Allison2019-08-221-22/+0
| | | | | | | | NB, this will now fail smb_vfs_assert_all_fns() until we remove the mknod_fn() from the VFS definitions. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s3: VFS: vfs_full_audit. Remove mknod_fn(). No longer used.Jeremy Allison2019-08-221-18/+0
| | | | | | | | NB, this will now fail smb_vfs_assert_all_fns() until we remove the mknod_fn() from the VFS definitions. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s3: VFS: vfs_unityed_media. Remove mknod_fn(). No longer used.Jeremy Allison2019-08-221-27/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s3: VFS: vfs_syncops. Remove mknod_fn(). No longer used.Jeremy Allison2019-08-221-10/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s3: VFS: vfs_snapper. Remove mknod_fn(). No longer used.Jeremy Allison2019-08-221-20/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s3: VFS: vfs_shadow_copy2. Remove mknod_fn(). No longer used.Jeremy Allison2019-08-221-20/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s3: VFS: vfs_media_harmony. Remove mknod_fn(). No longer used.Jeremy Allison2019-08-221-35/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s3: VFS: vfs_glusterfs. Remove mknod_fn(). No longer used.Jeremy Allison2019-08-221-15/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s3: VFS: vfs_ceph_snapshots. Remove mknod_fn(). No longer used.Jeremy Allison2019-08-221-23/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s3: VFS: vfs_ceph. Remove mknod_fn(). No longer used.Jeremy Allison2019-08-221-13/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s3: VFS: vfs_cap. Remove mknod_fn(). No longer used.Jeremy Allison2019-08-221-37/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s3: smbd: Make smb_unix_mknod() call SMB_VFS_MKNODAT() instead of ↵Jeremy Allison2019-08-221-1/+8
| | | | | | | | | | | SMB_VFS_MKNOD() Use conn->cwd_fsp as current fsp. No logic change for now. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s3: torture: Change cmd_mknod to call SMB_VFS_MKNODAT().Jeremy Allison2019-08-221-1/+9
| | | | | | | | | Use conn->cwd_fsp as current fsp. No logic change for now. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s3: VFS: vfs_time_audit. Implement mknodat().Jeremy Allison2019-08-221-1/+27
| | | | | | | Currently identical to mknod(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s3: VFS: vfs_full_audit. Implement mknodat().Jeremy Allison2019-08-221-0/+23
| | | | | | | Currently identical to mknod(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s3: VFS: vfs_unityed_media. Implement mknodat().Jeremy Allison2019-08-221-0/+36
| | | | | | | Currently identical to mknod(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s3: VFS: vfs_syncops. Implement mknodat().Jeremy Allison2019-08-221-0/+16
| | | | | | | Currently identical to mknod(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s3: VFS: vfs_snapper. Implement mknodat().Jeremy Allison2019-08-221-0/+25
| | | | | | | Currently identical to mknod(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s3: VFS: vfs_shadow_copy2. Implement mknodat().Jeremy Allison2019-08-221-0/+25
| | | | | | | Currently identical to mknod(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s3: VFS: vfs_media_harmony. Implement mknodat().Jeremy Allison2019-08-221-0/+45
| | | | | | | Currently identical to mknod(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s3: VFS: vfs_glusterfs. Implement mknodat().Jeremy Allison2019-08-221-0/+17
| | | | | | | Currently identical to mknod(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* 3: VFS: vfs_ceph_snapshots. Implement mknodat().Jeremy Allison2019-08-221-0/+28
| | | | | | | Currently identical to mknod(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s3: VFS: vfs_ceph. Implement mknodat().Jeremy Allison2019-08-221-0/+15
| | | | | | | Currently identical to mknod(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s3: VFS: vfs_cap. Implement mknodat().Jeremy Allison2019-08-221-0/+42
| | | | | | | Currently identical to mknod(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s3: VFS: Add SMB_VFS_MKNODAT().Jeremy Allison2019-08-228-0/+94
| | | | | | | | | | Currently identical to SMB_VFS_MKNOD(). Next, add to all VFS modules that implement mknod and eventually remove mknod. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s3: smbd: Add sys_mknodat() wrapper call.Jeremy Allison2019-08-223-1/+17
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s3: VFS: Remove extraneous enum/struct values for removed SMB_VFS_OP_LINK.Jeremy Allison2019-08-221-2/+0
| | | | | | | Forgot this in removal of SMB_VFS_LINK() patch previously pushed. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s3:net: load registry shares too in 'net vfs stream2adouble'Ralph Wuerthner2019-08-221-2/+2
| | | | | | | | | Signed-off-by: Ralph Wuerthner <ralph.wuerthner@de.ibm.com> Reviewed-by: Ralph Böhme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Aug 22 17:41:20 UTC 2019 on sn-devel-184
* docs-xml: fix problamatic quotes from panic action exampleBjörn Jacke2019-08-221-1/+1
| | | | | | | | | | | those quotes work for smbd but do not work for the samba binary. Without quotes it works with both. Signed-off-by: Bjoern Jacke <bjacke@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Björn Jacke <bjacke@samba.org> Autobuild-Date(master): Thu Aug 22 13:46:14 UTC 2019 on sn-devel-184
* python: use os.urandom, which is available in python by definitionBjörn Jacke2019-08-221-39/+2
| | | | | | | | os.urandom also uses CSPRNG methods like getrandom() when the underlying OS provides those. Signed-off-by: Bjoern Jacke <bjacke@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* lib: free popt context in texpectSwen Schillig2019-08-221-5/+9
| | | | | | | | | | | If done with popt context it should be free'd. Signed-off-by: Swen Schillig <swen@linux.ibm.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Thu Aug 22 01:41:37 UTC 2019 on sn-devel-184
* s4: free popt context in dnsserverSwen Schillig2019-08-221-0/+2
| | | | | | | | If done with popt context it should be free'd. Signed-off-by: Swen Schillig <swen@linux.ibm.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s4: free popt context in utilsSwen Schillig2019-08-221-0/+2
| | | | | | | | If done with popt context it should be free'd. Signed-off-by: Swen Schillig <swen@linux.ibm.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s4: free popt context in clientSwen Schillig2019-08-221-0/+2
| | | | | | | | If done with popt context it should be free'd. Signed-off-by: Swen Schillig <swen@linux.ibm.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s4: free popt context in tortureSwen Schillig2019-08-224-0/+14
| | | | | | | | If done with popt context it should be free'd. Signed-off-by: Swen Schillig <swen@linux.ibm.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* rpcclient: free popt context when doneSwen Schillig2019-08-221-0/+1
| | | | | | | | If done with popt context it should be free'd. Signed-off-by: Swen Schillig <swen@linux.ibm.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s3: free popt context in utilsSwen Schillig2019-08-2213-17/+58
| | | | | | | | If done with popt context it should be free'd. Signed-off-by: Swen Schillig <swen@linux.ibm.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* torture: fix mem leak found by ASAN (smb2_connect)Swen Schillig2019-08-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | Direct leak of 96 byte(s) in 1 object(s) allocated from: #0 0x7f0b16624c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08) #1 0x7f0b15e4ba5c in __talloc_with_prefix ../../lib/talloc/talloc.c:782 #2 0x7f0b15e4ba5c in __talloc ../../lib/talloc/talloc.c:824 #3 0x7f0b15e4ba5c in _talloc_named_const ../../lib/talloc/talloc.c:981 #4 0x7f0b15e4ba5c in talloc_named_const ../../lib/talloc/talloc.c:1748 #5 0x55ffdd30d591 in torture_smb2_connect ../../source4/torture/smb2/connect.c:199 #6 0x7f0b12723772 in wrap_simple_test ../../lib/torture/torture.c:633 #7 0x7f0b1272775e in internal_torture_run_test ../../lib/torture/torture.c:442 #8 0x7f0b12728543 in torture_run_tcase_restricted ../../lib/torture/torture.c:507 #9 0x7f0b12728dd5 in torture_run_suite_restricted ../../lib/torture/torture.c:357 #10 0x7f0b12729434 in torture_run_suite ../../lib/torture/torture.c:339 #11 0x55ffdd10c54a in run_matching ../../source4/torture/smbtorture.c:93 #12 0x55ffdd10df56 in torture_run_named_tests ../../source4/torture/smbtorture.c:143 #13 0x55ffdd11199d in main ../../source4/torture/smbtorture.c:691 #14 0x7f0b0aa45412 in __libc_start_main (/lib64/libc.so.6+0x24412) Signed-off-by: Swen Schillig <swen@linux.ibm.com> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Wed Aug 21 15:42:43 UTC 2019 on sn-devel-184
* ctdb-tests: Clear deleted record via recovery instead of vacuumingMartin Schwenke2019-08-211-12/+5
| | | | | | | | | | | | | | | | | This test has been flapping because sometimes the record is not vacuumed within the expected time period, perhaps even because the check for the record can interfere with vacuuming. However, instead of waiting for vacuuming the record can be cleared by doing a recovery. This should be much more reliable. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14085 RN: Fix flapping CTDB tests Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> Autobuild-User(master): Martin Schwenke <martins@samba.org> Autobuild-Date(master): Wed Aug 21 13:06:57 UTC 2019 on sn-devel-184
* ctdb-tests: Wait for child process when killing cluster mutex helperMartin Schwenke2019-08-211-1/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The following test sometimes fails: ================================================== Running "cluster_mutex_test lock-unlock-lock-unlock ./tests/var/cluster_mutex.lockfile" -------------------------------------------------- Output (Exit status: 134): -------------------------------------------------- LOCK UNLOCK CONTENTION NOLOCK cluster_mutex_test: ../../tests/src/cluster_mutex_test.c:307: test_lock_unlock_lock_unlock: Assertion `dl2->mh != NULL' failed. -------------------------------------------------- Required output (Exit status: 0): -------------------------------------------------- LOCK UNLOCK LOCK UNLOCK FAILED ========================================================================== TEST FAILED: tests/cunit/cluster_mutex_001.sh (status 1) (duration: 0s) ========================================================================== This is due to a race in the test. For the first UNLOCK a signal is sent to the cluster mutex handler but the test tries to retake the lock before that process is scheduled and the signal is processed. Therefore, the fcntl() lock is still held and contention is seen. After unlocking, tests need to wait until the child has gone, so build this into ctdb_kill(). This is one of the only places where the PID is accessible. Outside of testing, on a real system, nothing will never try to (re)take the lock so quickly. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14085 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-tests: Strengthen volatile DB traverse testMartin Schwenke2019-08-211-15/+52
| | | | | | | | | | Check the record count more often, from multiple nodes. Add a case with multiple records. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14085 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-recoverd: Only check for LMASTER nodes in the VNN mapMartin Schwenke2019-08-211-4/+10
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14085 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-tests: Don't retrieve the VNN map from target node for notlmasterMartin Schwenke2019-08-211-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Use the VNN map from the node running node_has_status(). This means that wait_until_node_has_status 1 notlmaster 10 0 will run "ctdb status" on node 0 and check (for up to 10 seconds) if node 1 is in the VNN map. If the LMASTER capability has been dropped on node 1 then the above will wait for the VNN map to be updated on node 0. This will happen as part of the recovery that is triggered by the change of LMASTER capability. The next command will then only be able to attach to $TESTDB after the recovery is complete thus guaranteeing a sane state for the test to continue. This stops simple/79_volatile_db_traverse.sh from going into recovery during the traverse or at some other inconvenient time. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14085 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-tests: Handle special cases first and returnMartin Schwenke2019-08-211-31/+28
| | | | | | | | | All the other cases involve matching bits. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14085 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-tests: Inline handling of recovered and notlmaster statusesMartin Schwenke2019-08-211-6/+12
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14085 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-tests: Drop unused node statuses frozen/unfrozenMartin Schwenke2019-08-211-6/+2
| | | | | | | | | Silently drop unused local variable mpat. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14085 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-tests: Reformat node_has_status()Martin Schwenke2019-08-211-46/+48
| | | | | | | | | Re-indent and drop non-POSIX left-parenthesis from case labels. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14085 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
View Lorry Controller Status