summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* credentials: Initialize krb5 client to retrieve creds from ccacheSamuel Cabrero2019-04-291-0/+15
| | | | | | | | | MIT kerberos require krb5_creds.client to be initialized to match krb5_creds.server with the cached credentials. Signed-off-by: Samuel Cabrero <scabrero@suse.de> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* selftests: Place credential cache file inside environment directorySamuel Cabrero2019-04-291-1/+1
| | | | | | | Pair-Programmed-With: Andreas Schneider <asn@samba.org> Signed-off-by: Samuel Cabrero <scabrero@suse.de> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* waf: only set mandatory to False if not already set by the callerRalph Boehme2019-04-291-1/+3
| | | | | | | | | | | | | | | | | | | There are a bunch of callers that call find_program with mandatory=True, we should not overwrite this when explicity passed, eg: ctx.find_program('objcopy', var='OBJCOPY', mandatory=True) conf.SAMBA_CHECK_PERL(mandatory=True) -> conf.find_program('perl', var='PERL', mandatory=mandatory) With this patch we only change the default from False to True, but allow callers to choose specific behaviour. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Mon Apr 29 17:07:02 UTC 2019 on sn-devel-184
* gitlab-ci: Install missing krb5-kdc package on Ubuntu/DebianAndreas Schneider2019-04-2915-3/+15
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* wafsamba: Enable warnings for missing field initializerAndreas Schneider2019-04-291-0/+1
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3:libsmb: Fix C99 initializer in cli_smb2_fnum.cAndreas Schneider2019-04-291-3/+3
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s4:dsdb: Use C99 initializer in dsdb util_trustsAndreas Schneider2019-04-291-11/+29
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3:lib: Use correct C99 initializer for 'struct flock' in messages_dgmAndreas Schneider2019-04-291-1/+3
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* lib:audit_logging: Use C99 initializer for server_id in audit_loggingAndreas Schneider2019-04-291-1/+3
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3:utils: use struct initializer in async-tracker long_optionsRalph Boehme2019-04-291-2/+14
| | | | | | | | | | s3:utils: use struct initializer in async-tracker long_options The previous initializer list was missing a NULL as last element. Using struct initializers instead for correct initialisation. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* Revert "lib/replace: define NAME_MAX for platforms that don't have it"Günther Deschner2019-04-261-4/+0
| | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13872 This reverts commit e3c894fb6b87df8aa56e29ef3b16ae1ef456a875. Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Autobuild-User(master): Günther Deschner <gd@samba.org> Autobuild-Date(master): Fri Apr 26 13:03:05 UTC 2019 on sn-devel-184
* s3/vfs_glusterfs_fuse: Dynamically determine NAME_MAXAnoop C S2019-04-261-6/+26
| | | | | | | | | | This allows the vfs_glusterfs_fuse build to complete on AIX. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13872 Signed-off-by: Anoop C S <anoopcs@redhat.com> Reviewed-by: Guenther Deschner <gd@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3/vfs_glusterfs: Dynamically determine NAME_MAXAnoop C S2019-04-261-8/+29
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13872 Signed-off-by: Anoop C S <anoopcs@redhat.com> Reviewed-by: Guenther Deschner <gd@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* gitlab-ci: Remove Ubuntu 14.04Andreas Schneider2019-04-253-8/+3
| | | | | | | | | | | Ubuntu 14.04 a compiler which complains about valid C99 code and also it doesn't offer GnuTLS >= 3.2 which we require to move to GnuTLS. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Thu Apr 25 16:52:57 UTC 2019 on sn-devel-184
* gitlab-ci: Enable fedora29 and update generated distsAndreas Schneider2019-04-2525-7/+72
| | | | | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Thu Apr 25 11:46:23 UTC 2019 on sn-devel-184
* bootstrap: Add glusterfs and cephfs packagesAndreas Schneider2019-04-251-0/+14
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* bootstrap: Add missing packages for XFS quota supportAndreas Schneider2019-04-251-0/+3
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* bootstrap: Add missing packages on RPM distributionsAndreas Schneider2019-04-251-0/+3
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* bootstrap: Fix dnf commandsAndreas Schneider2019-04-251-2/+2
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s4:heimdal: Disable format truncation warningsAndreas Schneider2019-04-251-0/+5
| | | | | | | | We build that code and do not treat warnings as errors anyway, so just disable format truncation. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3:modules: Fix size typesAndreas Schneider2019-04-251-4/+4
| | | | | | | | error: assuming signed overflow does not occur when simplifying conditional to constant [-Werror=strict-overflow] Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* autobuild: Build also Samba AD with MIT KerberosAndreas Schneider2019-04-251-1/+1
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* wscript: Remove checks for shm_open and shmgetChristof Schmitt2019-04-251-3/+0
| | | | | | | | | | | | | Commit 74a16a1094278 "s3:smbprofile: Replace sysv shmem with tdb" removed the usage of the shared memory segment for profiling data. As there are no other users of shared memory segments, remove the configure check for these functions. Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Apr 25 00:54:16 UTC 2019 on sn-devel-184
* s3-mdssvc: add a comment to mds_init()Ralph Boehme2019-04-241-0/+3
| | | | | | | | Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Noel Power <npower@samba.org> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Wed Apr 24 19:32:12 UTC 2019 on sn-devel-184
* s3-mdssvc: make mds_ctx_destructor_cb staticRalph Boehme2019-04-242-31/+30
| | | | | | | This is only used in this compilation unit. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Noel Power <npower@samba.org>
* s3-mdssvc: add missing call to g_cancellable_new()Ralph Boehme2019-04-241-0/+6
| | | | | Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Noel Power <npower@samba.org>
* s3-mdssvc: use default g_main contextRalph Boehme2019-04-241-9/+1
| | | | | | | | | | | Way back when the module was developed it seemed to be necessary the use a private context with push/pop as thread default. Maybe there was a bug in libtracker-sparql dispatching callback in the wrong (global) context. It's not necessary anymore with a recent libtracker-sparql version. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Noel Power <npower@samba.org>
* s3-mdssvc: use tevent_glib_glue in mdssvc RPC serviceRalph Boehme2019-04-243-146/+75
| | | | | Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Noel Power <npower@samba.org>
* s3-mdssvc: call [un]become_authenticated_pipe_user()Ralph Boehme2019-04-242-2/+24
| | | | | | | | This ensures we're running as the authenticated user int the tevent callback which might be running in an arbitrary impersonation context. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Noel Power <npower@samba.org>
* s3-mdssvc: add tevent context arg to mds_init_ctxRalph Boehme2019-04-243-1/+7
| | | | | | | This is needed later when adding tevent_glib_glue support, not used for now. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Noel Power <npower@samba.org>
* s3/lib: tevent-glib-glue test utiltity with TrackerRalph Boehme2019-04-242-0/+298
| | | | | | | | | A small utilitly useful for tesing the tevent_glib_glue code. It runs a tracker-sparql search query against your local tracker store that must be setup and running. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Noel Power <npower@samba.org>
* s3/lib: add a tevent_glib_glue subsystem testRalph Boehme2019-04-244-0/+431
| | | | | | | Tests adapted from glib2 glib/tests/mainloop.c. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Noel Power <npower@samba.org>
* s3/lib: new tevent_glib_glue subsystemRalph Boehme2019-04-244-0/+970
| | | | | | | | | | | tevent_glib_glue_create() takes glib GMainContext and adds its event sources to a tevent context. tevent will poll the sources and run handlers for pending events as detailed in the glib documentation: https://developer.gnome.org/glib/stable/glib-The-Main-Event-Loop.html Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Noel Power <npower@samba.org>
* s3:wscript: fix flex and bison detectionRalph Boehme2019-04-241-2/+2
| | | | | | | conf.env['BISON'] and conf.env['FLEX'] return lists. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Noel Power <npower@samba.org>
* s3:wscript: fix flex and bison detection message when not installedRalph Boehme2019-04-241-9/+11
| | | | | | | | | | | | | | | | | | | If flex or bison are not installed, conf.env['BISON'] and conf.env['FLEX'] respectively return an empty string, so conf.CHECK_COMMAND() runs $ /bin/sh -c " --version | head -n1" and $ /bin/sh -c " --version" which results in the following message /bin/sh: []: command not found Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Noel Power <npower@samba.org>
* s3: build: seperate out check for Gnome Tracker from SpotlightRalph Boehme2019-04-241-22/+33
| | | | | Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Noel Power <npower@samba.org>
* waf: fix array access out of bounds exception in the check for flexRalph Boehme2019-04-241-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If flex is not installed the following expection is triggered: Checking for flex Checking for program 'flex' : not found Traceback (most recent call last): File "/home/slow/git/samba/scratch/third_party/waf/waflib/Scripting.py", line 158, in waf_entry_point run_commands() File "/home/slow/git/samba/scratch/third_party/waf/waflib/Scripting.py", line 251, in run_commands ctx = run_command(cmd_name) File "/home/slow/git/samba/scratch/third_party/waf/waflib/Scripting.py", line 235, in run_command ctx.execute() File "/home/slow/git/samba/scratch/third_party/waf/waflib/Configure.py", line 159, in execute super(ConfigurationContext, self).execute() File "/home/slow/git/samba/scratch/third_party/waf/waflib/Context.py", line 204, in execute self.recurse([os.path.dirname(g_module.root_path)]) File "/home/slow/git/samba/scratch/third_party/waf/waflib/Context.py", line 286, in recurse user_function(self) File "/home/slow/git/samba/scratch/wscript", line 307, in configure conf.RECURSE('source3') File "./buildtools/wafsamba/samba_utils.py", line 66, in fun return f(*k, **kw) File "./buildtools/wafsamba/samba_utils.py", line 481, in RECURSE return ctx.recurse(relpath) File "/home/slow/git/samba/scratch/third_party/waf/waflib/Context.py", line 286, in recurse user_function(self) File "/home/slow/git/samba/scratch/source3/wscript", line 1660, in configure flex.configure(conf) File "/home/slow/git/samba/scratch/third_party/waf/waflib/Tools/flex.py", line 59, in configure if re.search (r"\\msys\\[0-9.]+\\bin\\flex.exe$", conf.env.FLEX[0]): IndexError: list index out of range This happens because when the detection of flex fails, an excpetion is thrown in Configure.py:find_program by calling self.fatal(), but as Configure.py:find_program() is called from samba_waf18.py:find_program_samba() which sets the keyword argument mandatory=False, Configure.py:conf:fun() catches the expection. As a result in flex.py the call to conf.find_program('flex', var='FLEX') does not abort and if re.search (r"\\msys\\[0-9.]+\\bin\\flex.exe$", conf.env.FLEX[0]) is executed even though conf.env.FLEX is None. As this is a not a problem of upstream Samba, but triggered by our samba_waf18.py:find_program_samba(), I don't pursue an upstream fix. Instead, just use conf.find_program() directly instead of the wrapper in flex.py. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Noel Power <npower@samba.org>
* bootstrap: move flex to common packagesRalph Boehme2019-04-2413-3/+13
| | | | | Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* waf: build: Respect --disable-python for third_party modulesLutz Justen2019-04-243-13/+26
| | | | | | | | | | | | | | | | Skips installation of samba/third_party stuff into the python directory if --disable-python is set. Added test after install that confirms no python modules installed. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13905 Signed-off-by: Lutz Justen <ljusten@google.com> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Wed Apr 24 07:32:31 UTC 2019 on sn-devel-184
* winbind: Fix overlapping id rangesVolker Lendecke2019-04-242-3/+10
| | | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Christof Schmitt <cs@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Apr 24 02:25:56 UTC 2019 on sn-devel-184
* selftest: Add trusted domain tests for idmap_adChristof Schmitt2019-04-242-0/+107
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13903 Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* selftest: Pass trusted domain information to idmap_ad testChristof Schmitt2019-04-242-3/+6
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13903 Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* selftest: Add idmap configuration for trusted domain for idmap_adChristof Schmitt2019-04-241-0/+2
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13903 Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* selftest: Make trusted domain information available for idmap_ad environmentChristof Schmitt2019-04-241-0/+7
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13903 Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* selftest: Use fl2008r2dc for ad_member_idmap_adChristof Schmitt2019-04-241-1/+1
| | | | | | | | | | fl2008r2dc already has a trusted domain. That will be used to use idmap_ad for querying idmap attributes from the trusted domain. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13903 Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* selftest: Add gid-to-sid lookup to idmap_ad testChristof Schmitt2019-04-241-0/+24
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13903 Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* .gitlab-ci.yml: use the ubuntu1804 image as defaultStefan Metzmacher2019-04-241-3/+3
| | | | | | | | | | | This matches our move from sn-devel-144 to sn-devel-184 for the final autobuild. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Wed Apr 24 01:01:58 UTC 2019 on sn-devel-184
* pyldb: avoid segfault when adding an element with no nameDouglas Bagnall2019-04-232-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | We don't want to see this: python3 -c "import sys sys.path.insert(0, 'bin/python') import ldb m = ldb.Message() e = ldb.MessageElement('q') try: m.add(e) except ldb.LdbError: pass print(m) " Segmentation fault (core dumped) instead we want this: Traceback (most recent call last): File "<string>", line 7, in <module> ValueError: The element has no name Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Noel Power <npower@samba.org> Autobuild-User(master): Noel Power <npower@samba.org> Autobuild-Date(master): Tue Apr 23 19:03:35 UTC 2019 on sn-devel-144
* pytest/segfault: segfault with nameless elementDouglas Bagnall2019-04-232-0/+11
| | | | | Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Noel Power <npower@samba.org>
* waf: install: Remove installation of PIDL and manpages.Lutz Justen2019-04-232-75/+0
| | | | | | | | | | | | It's not used outside of Samba other than wireshark who have their own vendor fork. Signed-off-by: Lutz Justen <ljusten@google.com> Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Tue Apr 23 02:08:56 UTC 2019 on sn-devel-144