summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* docs: Add man samba-regedit.8.Karolin Seeger2013-08-302-0/+122
| | | | | | | | | | | Fix bug #10001 - Man page for samba-regedit tool missing. Signed-off-by: Karolin Seeger <kseeger@samba.org> Signed-off-by: Björn Jacke <bj@sernet.de> Autobuild-User(master): Björn Jacke <bj@sernet.de> Autobuild-Date(master): Thu Aug 29 03:15:51 CEST 2013 on sn-devel-104 (cherry picked from commit 4dd1523b95b214723dc9c0dfc5b5a6778bf4fc4d)
* Fix bug #10063 - source3/lib/util.c:1493 leaking memory w/ pam_winbind.so / ↵Jeremy Allison2013-08-271-2/+4
| | | | | | | | | | | | | | | | winbind Don't use talloc_tos() in something that can be linked to in pam_winbindd.so Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Simo Sorce <idra@samba.org> Autobuild-User(master): Simo Sorce <idra@samba.org> Autobuild-Date(master): Sat Aug 24 02:28:28 CEST 2013 on sn-devel-104 (cherry picked from commit 9423d5afb71e272298f4858d82f436e19ee2b07f) Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Tue Aug 27 11:36:39 CEST 2013 on sn-devel-104
* ntdbtool.8.xml: Bump version up to 4.1.Karolin Seeger2013-08-221-1/+1
| | | | | | | | | | | Signed-off-by: Karolin Seeger <kseeger@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit cc82c161bf09226696fdfb428f6ba93caa751de5) The last 5 patches address bug #10000 - Man pages for ntdb tools missing. Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Thu Aug 22 12:49:17 CEST 2013 on sn-devel-104
* ntdbrestore.8.xml: Bump version up to 4.1.Karolin Seeger2013-08-221-1/+1
| | | | | | Signed-off-by: Karolin Seeger <kseeger@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 178023ad726d4328b1fd7efc52c05a165d5b1a08)
* ntdbdump.8.xml: Bump version up to 4.1.Karolin Seeger2013-08-221-1/+1
| | | | | | Signed-off-by: Karolin Seeger <kseeger@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 20d22f0b9ad5fd1b40a298182166a4f0abafa42f)
* ntdbbackup.8.xml: Bump version up to 4.1.Karolin Seeger2013-08-221-1/+1
| | | | | | Signed-off-by: Karolin Seeger <kseeger@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 9bef5aadac7720bfcf4c07872728ef15afafdef3)
* ntdb.3.xml: Bump version up to 4.1.Karolin Seeger2013-08-221-1/+1
| | | | | | Signed-off-by: Karolin Seeger <kseeger@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 8d021b34b460246dbb3df23798994915cbd8e6e4)
* Man pages for ntdb tools missingRusty Russell2013-08-206-5/+708
| | | | | | | | | | | | | | Copied and modified from tdb man pages. Avoided reproducing API documentation which is extensively documented in the ntdb.h header already. BUG: https://bugzilla.samba.org/show_bug.cgi?id=10000 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 3e11421e7476d968a3d550491279d0ad6b6c398f) Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Tue Aug 20 13:13:56 CEST 2013 on sn-devel-104
* s3-winbindd: fix fallback to ncacn_np in cm_connect_lsat().Günther Deschner2013-08-201-2/+7
| | | | | | | | | | | | | | | | | | Fallback to lsa named-pipe connection when tcp connection has failed twice (it could be a trusted domain connection where we cannot setup a secure channel). Guenther BUG: https://bugzilla.samba.org/show_bug.cgi?id=9615 BUG: https://bugzilla.samba.org/show_bug.cgi?id=9899 Signed-off-by: Günther Deschner <gd@samba.org> Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Tested-by: Christof Schmitt <christof.schmitt@us.ibm.com> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Tue Aug 13 20:55:33 CEST 2013 on sn-devel-104
* waf: replace dependency to libintl with samba_intlChristian Ambach2013-08-203-4/+4
| | | | | | | | | | | | Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Christian Ambach <ambi@samba.org> Autobuild-Date(master): Mon Aug 12 00:46:34 CEST 2013 on sn-devel-104 (cherry picked from commit 20b64eae75b8809d67b8c2824616996bb4722612) The last 5 patches address bug #9911 - Build Samba 4.0.x on AIX with IBM XL C/C++.
* waf: consolidate libintl related checksChristian Ambach2013-08-203-18/+41
| | | | | | | | | | | | | | | consolidate the dealing with functions from libintl and the handling of checking if libiconv is required or not to a common place in lib/replace also add a new samba_intl subsystem that has dependencies on the appropriate set of libraries (libintl, libintl+libiconv or none) that can be used as a general dependency by code that depends on the internationalization libraries Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 07b3a048724a6b41282e1f673aea5ce2c1202a5e)
* waf: add --without-gettext optionChristian Ambach2013-08-201-0/+3
| | | | | | Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit a742e87b39bed97ac59f5ec8bff9bf3cedf8b68a)
* waf: fix build on AIX7Christian Ambach2013-08-201-1/+1
| | | | | | | | the same works for AIX 5,6,7 so leave away the version specifics (as autoconf build did) Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit ce8fbdf76ee2792d011d9da4d0116f04d9656886)
* s3:lib/system fix build on AIX 7Christian Ambach2013-08-201-3/+12
| | | | | | | | | | | | AIX uses struct stat64 with struct timespec64, so direct assignment does not work any more. Pair-Programmed-With: Volker Lendecke <vl@samba.org> Signed-off-by: Christian Ambach <ambi@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Fri Aug 2 09:47:43 CEST 2013 on sn-devel-104 (cherry picked from commit ba40d0d9d320e500621a6a8107a2ef0a34aeb6ba)
* smbd: Fix async echo handler forking (Bug 10086)Volker Lendecke2013-08-201-3/+6
| | | | | | | If SMB3 is chosen via an SMB1 negprot, we forked the echo handler because set_Protocol is called later, after the full protocol negotiation is done. Signed-off-by: Volker Lendecke <vl@samba.org>
* Fix bug #10097 - MacOSX 10.9 will not follow path-based DFS referrals handed ↵Richard Sharpe2013-08-203-6/+19
| | | | | | | | | | | | | out by Samba. Windows overloads the EA Length field in the DIRECTORY INFO leves of FIND FIRST/FIND NEXT. This field indicates either the REPARSE_TAG if the file/folder has a reparse proint or the EA Length if it has EAs, and is the fundamental reason you cannot have both on a file or folder. Signed-off-by: Richard Sharpe <rsharpe@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* docs: Fix variable list in man vfs_crossrename.Karolin Seeger2013-08-201-9/+11
| | | | | | | | | | | | | | The varlist entries need a paragraph, otherwise the list is broken and the list entries end with ".RE". Fix bug #10076 - varlist in man vfs_crossrename broken. Signed-off-by: Karolin Seeger <kseeger@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Tue Aug 20 04:19:42 CEST 2013 on sn-devel-104 (cherry picked from commit 1808316b1245290fd4a4aa87a801410899e4c1e3)
* Followup patch for BUG: https://bugzilla.samba.org/show_bug.cgi?id=10082Andreas Schneider2013-08-161-1/+1
| | | | | | | | | | | | | | Thanks to Jim Brown <jim.brown@rsmas.miami.edu> Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Volker Lendecke <Volker.Lendecke@SerNet.DE> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Aug 15 03:46:20 CEST 2013 on sn-devel-104 Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Fri Aug 16 10:48:55 CEST 2013 on sn-devel-104
* s3-winbind: Fix a segfault passing NULL to a fstring argument.Andreas Schneider2013-08-141-2/+11
| | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=10082 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Tue Aug 13 13:58:26 CEST 2013 on sn-devel-104 Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Wed Aug 14 12:55:05 CEST 2013 on sn-devel-104
* docs: Add man vfs_syncops.8 to waf build.Karolin Seeger2013-08-131-0/+1
| | | | | | | | | | | | | | | Signed-off-by: Karolin Seeger <kseeger@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> Part of a fix for bug #7364 - man vfs_syncops missing. Autobuild-User(master): Karolin Seeger <kseeger@samba.org> Autobuild-Date(master): Tue Aug 13 12:09:45 CEST 2013 on sn-devel-104 (cherry picked from commit dc3c4c00e65f1ffdd32bf7c2e957da98b5913084) Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Tue Aug 13 14:42:31 CEST 2013 on sn-devel-104
* docs: Add basic man page for vfs_syncops.Karolin Seeger2013-08-131-0/+99
| | | | | | | | | | | Fix bug #7364 - man vfs_syncops missing. Signed-off-by: Karolin Seeger <kseeger@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> Autobuild-User(master): David Disseldorp <ddiss@samba.org> Autobuild-Date(master): Fri Aug 9 13:19:12 CEST 2013 on sn-devel-104 (cherry picked from commit 6fb300f7b44cc6eb83e10b7272c2e08c150e05ba)
* s3-libads: Print a message if no realm has been specified.Andreas Schneider2013-08-131-1/+7
| | | | | | | | | | | | | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Mon Aug 5 12:24:44 CEST 2013 on sn-devel-104 (cherry picked from commit 6659f0164c6b8d7ad522bcd6c2c6748c3d9bca81) The last 2 patches address bug #10073 - net ads join - segmentation fault in create_local_private_krb5_conf_for_domain. Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Tue Aug 13 12:16:00 CEST 2013 on sn-devel-104
* s3-libads: Fail create_local_private_krb5_conf_for_domain() if parameters ↵Günther Deschner2013-08-131-0/+4
| | | | | | | | | | | missing. Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> (cherry picked from commit 6dc7c63efa95d0c04b542667d9b6a6621c8139bf)
* docs: Add man page for vfs_linux_xfs_sgid.Karolin Seeger2013-08-132-0/+75
| | | | | | | | | | | Signed-off-by: Karolin Seeger <kseeger@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Tue Aug 13 02:06:30 CEST 2013 on sn-devel-104 (cherry picked from commit 906de702e641bb0da8ec9074b80d6e94bdb17cfe) Fix bug #7490 - man vfs_linux_xfs_sgid missing.
* VERSION: Bump version number up to 4.1.0rc3...Karolin Seeger2013-08-091-2/+2
| | | | | | and re-enable git snapshots. Signed-off-by: Karolin Seeger <kseeger@samba.org>
* VERSION: Disable git snapshots for the 4.1.0rc2 release.samba-4.1.0rc2Karolin Seeger2013-08-091-1/+1
| | | | Signed-off-by: Karolin Seeger <kseeger@samba.org>
* WHATSNEW: Add release notes for Samba 4.1.0rc2.Karolin Seeger2013-08-081-5/+64
| | | | | | | Signed-off-by: Karolin Seeger <kseeger@samba.org> Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Thu Aug 8 13:45:41 CEST 2013 on sn-devel-104
* Ensure gpfs kernel leases are wrapped in a become_root()/unbecome_root() pair.Ralph Wuerthner2013-08-071-0/+6
| | | | | | | | | | | | | | | | | Ensures correct lease owner for signal delivery. Signed-off-by: Ralph Wuerthner <ralphw@de.ibm.com> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Simo Sorce <idra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Aug 1 03:57:11 CEST 2013 on sn-devel-104 The last 2 patches address bug #10064 - Linux kernel oplock breaks can miss signals. Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Wed Aug 7 14:56:04 CEST 2013 on sn-devel-104
* Wrap setting leases in become_root()/unbecome_root() to ensure correct ↵Jeremy Allison2013-08-071-13/+20
| | | | | | | | | | delivery of signals. Remove workaround for Linux kernel bug https://bugzilla.kernel.org/show_bug.cgi?id=43336 as we don't need to set capabilities when we're already root. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Simo Sorce <idra@samba.org>
* Add torture tests to raw.eas to check sending Windows invalid names in the ↵Jeremy Allison2013-08-072-0/+115
| | | | | | | | | | | middle of an EA list. Add torture tests to probe the set of invalid Windows EA names. Bug 9992 - Windows error 0x800700FE when copying files with xattr names containing ":" Signed-off-by: Jeremy Allison <jra@samba.org>
* Reply with correct trans2 message on a setpathinfo with a bad EA name.Jeremy Allison2013-08-071-1/+10
| | | | | | Bug 9992 - Windows error 0x800700FE when copying files with xattr names containing ":" Signed-off-by: Jeremy Allison <jra@samba.org>
* Ensure we do pathname processing before SD and EA processing in NTTRANS_CREATE.Jeremy Allison2013-08-071-37/+37
| | | | | | Bug 9992 - Windows error 0x800700FE when copying files with xattr names containing ":" Signed-off-by: Jeremy Allison <jra@samba.org>
* Ensure we can't create a file using NTTRANS with an invalid EA list.Jeremy Allison2013-08-071-0/+20
| | | | | | Bug 9992 - Windows error 0x800700FE when copying files with xattr names containing ":" Signed-off-by: Jeremy Allison <jra@samba.org>
* Ensure we can't create a file using TRANS2_OPEN with an invalid EA list.Jeremy Allison2013-08-071-0/+14
| | | | | | Bug 9992 - Windows error 0x800700FE when copying files with xattr names containing ":" Signed-off-by: Jeremy Allison <jra@samba.org>
* Add error map of STATUS_INVALID_EA_NAME -> ERRDOS, ERRbadfileJeremy Allison2013-08-071-0/+1
| | | | | | | | (from Windows2012 tests). Bug 9992 - Windows error 0x800700FE when copying files with xattr names containing ":" Signed-off-by: Jeremy Allison <jra@samba.org>
* Add the ability to send an NTSTATUS result back with a trans2 reply so we ↵Jeremy Allison2013-08-073-14/+32
| | | | | | | | | | | can return a parameter block with an error code. This is needed when returning a STATUS_INVALID_NAME result (tested from Windows 2012). Bug 9992 - Windows error 0x800700FE when copying files with xattr names containing ":" Signed-off-by: Jeremy Allison <jra@samba.org>
* Ensure we can't create a file using SMB2_CREATE with an invalid EA list.Jeremy Allison2013-08-071-0/+5
| | | | | | Bug 9992 - Windows error 0x800700FE when copying files with xattr names containing ":" Signed-off-by: Jeremy Allison <jra@samba.org>
* Ensure we never return an EA name to a Windows client it can't handle.Jeremy Allison2013-08-071-0/+9
| | | | | | Bug 9992 - Windows error 0x800700FE when copying files with xattr names containing ":" Signed-off-by: Jeremy Allison <jra@samba.org>
* Ensure set_ea cannot set invalid Windows EA names.Jeremy Allison2013-08-071-0/+9
| | | | | | Bug 9992 - Windows error 0x800700FE when copying files with xattr names containing ":" Signed-off-by: Jeremy Allison <jra@samba.org>
* Add ea_list_has_invalid_name() function.Jeremy Allison2013-08-072-0/+36
| | | | | | | | Invalid character list probed from Windows Server 2012. Bug 9992: Windows error 0x800700FE when copying files with xattr names containing ":" Signed-off-by: Jeremy Allison <jra@samba.org>
* nsswitch: Add OPT_KRB5CCNAME to avoid an error message.Andreas Schneider2013-08-051-2/+4
| | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=10048 Reviewed-by: Günther Deschner <gd@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Fri Jul 26 17:40:26 CEST 2013 on sn-devel-104 Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Mon Aug 5 22:14:36 CEST 2013 on sn-devel-104
* s3: Remove old mode special substitution.Alexander Werth2013-08-051-13/+2
| | | | | | | | | | | | | | The mode special substitution now happens in a separate function. The substitution at this point is unnecessary. Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Christian Ambach <ambi@samba.org> Autobuild-User(master): Christian Ambach <ambi@samba.org> Autobuild-Date(master): Tue Jul 16 00:52:26 CEST 2013 on sn-devel-104 (cherry picked from commit 9b2aa351ceb756d6ea63f3158f0e983ae7262da8) Fix bug #10045 - Remove a redundant inlined substitution of ACLs.
* s4:server: avoid calling into nss_winbind from within 'samba'Stefan Metzmacher2013-08-052-0/+16
| | | | | | | | | | | | | | | | | | | | The most important part is that the 'winbind_server' doesn't recurse into itself. This could happen if the krb5 libraries call getlogin(). As we may run in single process mode, we need to set _NO_WINBINDD=1 everywhere, the only exception is the forked 'smbd'. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Wed Jul 10 23:18:06 CEST 2013 on sn-devel-104 (cherry picked from commit 596b51c666e549fb518d92931d8837922154a2fe) The last 4 patches address bug #9820 - crash of winbind after "ls -l /usr/local/samba/var/locks/sysvol".
* s4:rpc_server: make sure we don't terminate a connection with pending ↵Stefan Metzmacher2013-08-052-3/+60
| | | | | | | | | | | | | | requests (bug #9820) Sadly we may have nested event loops, which won't work correctly with broken connections, that's why we have to do this... Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Wed Jul 10 08:47:38 CEST 2013 on sn-devel-104 (cherry picked from commit e6a58d370403e818bc2cfb8389751b78adcc14fd)
* s4-winbindd: Do not terminate a connection that is still pending (bug #9820)Andrew Bartlett2013-08-053-2/+64
| | | | | | | | | | | | | | | | Instead, wait until the call attempts to reply, and let it terminate then (often this happens in the attempt to then write to the broken pipe). Andrew Bartlett Pair-Programmed-With: Stefan Metzmacher <metze@samba.org> Signed-off-by: Andrew Bartlett <abartlet@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit 2505d48e4fbcd8a805a88ad0b05fb1a16a588197)
* service_stream: Log if the connection termination is deferred or not (bug #9820)Andrew Bartlett2013-08-051-1/+5
| | | | | | Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit df929d6feb857668ad9da277213e9fae1480ff63)
* Fix bug 9678 - Windows 8 Roaming profiles failGregor Beck2013-08-051-7/+2
| | | | | | | | Windows 8 tries to set 'ATTRIBUTE_SECURITY_INFORMATION' on some dirs. Ignoring it makes roaming profiles work again. Just like w2k3 gracefully ignore all the other bits. Signed-off-by: Gregor Beck <gbeck@sernet.de>
* security.idl: add new security_secinfo bitsGregor Beck2013-08-051-0/+3
| | | | | | [MS-DTYP].pdf 2.4.7 Signed-off-by: Gregor Beck <gbeck@sernet.de>
* samba-tool dbcheck: Correctly remove deleted DNs in dbcheckAndrew Bartlett2013-08-051-1/+1
| | | | | | | | | | | | | | | | The previous pattern never matched, as it was a typo. Andrew Bartlett Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Tue Jul 30 12:55:00 CEST 2013 on sn-devel-104 (cherry picked from commit 7615b2549d9549683978cb3e85b926e2ba63e294) The last 4 patches address bug #9029 - Replication with --domain-crictical-only fails to fill in backlinks.
* dsdb: Include MS-ADTS doc references on deleted object contstraintsAndrew Bartlett2013-08-051-0/+16
| | | | | | Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit f2afdb61698c37389be286f9443471d4aeba49b8)