summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* third_party: Remove zlib from third_partyAndrew Bartlett2019-08-17201-54091/+1038
| | | | | | | | | | | | | | | | | | | | | | | | | We require zlib 1.2.3. We stopped requring a patched zlib with 5631a1b9bc03d6cf31af66b13872255f18979fe8 As discussed on samba-technical here: https://lists.samba.org/archive/samba-technical/2019-May/133476.html In short, zlib contains some (old, now broken) crypto code that while not compiled in Samba is best left out of our tarball to ease crypto audits. It is also very very out of date and is a slightly modified copy of something otherwise very likely available on our supported host OSs. It would be strange to say that GnuTLS and dependencies are an acceptable burden to install but say zlib is a step to far. So it is removed from Samba's third_party with this commit. The diff between zlib in Samba and official zlib 1.2.3 is included in third_party/zlib/last-samba-from-1.2.3.diff Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org>
* Prevent samba-tool online backup crashDavid Mulder2019-08-172-5/+33
| | | | | | | | | | | | On some GPOs, getting a files ntacl throws an NT_STATUS_ACCESS_DENIED. Catch and log the failure when this happens. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14088 Signed-off-by: David Mulder <dmulder@suse.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Tim Beale <timbeale@samba.org>
* ctdb-tcp: Mark node as disconnected if incoming connection goes awayMartin Schwenke2019-08-162-2/+5
| | | | | | | | | | | | | | To make it easy to pass the node data to the upcall, the private data for ctdb_tcp_read_cb() needs to be changed from tnode to node. RN: Avoid marking a node as connected before it can receive packets BUG: https://bugzilla.samba.org/show_bug.cgi?id=14084 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> Autobuild-User(master): Martin Schwenke <martins@samba.org> Autobuild-Date(master): Fri Aug 16 22:50:35 UTC 2019 on sn-devel-184
* ctdb-tcp: Only mark a node connected if both directions are upMartin Schwenke2019-08-161-3/+17
| | | | | | | | | | | | | Nodes are currently marked as up if the outgoing connection is established. However, if the incoming connection is not yet established then this node could send a request where the replying node can not queue its reply. Wait until both directions are up before marking a node as connected. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14084 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-tcp: Create outbound queue when the connection becomes writableMartin Schwenke2019-08-163-12/+25
| | | | | | | | | | | | | | | | Since commit ddd97553f0a8bfaada178ec4a7460d76fa21f079 ctdb_queue_send() doesn't queue a packet if the connection isn't yet established (i.e. when fd == -1). So, don't bother creating the outbound queue during initialisation but create it when the connection becomes writable. Now the presence of the queue indicates that the outbound connection is up. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14084 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-tcp: Use TALLOC_FREE()Martin Schwenke2019-08-161-4/+2
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14084 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-tcp: Move incoming fd and queue into struct ctdb_tcp_nodeMartin Schwenke2019-08-164-34/+61
| | | | | | | | | | This makes it easy to track both incoming and outgoing connectivity states. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14084 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-tcp: Rename fd -> out_fdMartin Schwenke2019-08-163-49/+72
| | | | | | | | | | | | | in_fd is coming soon. Fix coding style violations in the affected and adjacent lines. Modernise some debug macros and make them more consistent (e.g. drop logging of errno when strerror(errno) is already logged. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14084 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-daemon: Add function ctdb_ip_to_node()Martin Schwenke2019-08-162-5/+21
| | | | | | | | | | | | | | This is the core logic from ctdb_ip_to_pnn(), so re-implement that that function using ctdb_ip_to_node(). Something similar (ctdb_ip_to_nodeid()) was recently removed in commit 010c1d77cd7e192b1fff39b7b91fccbdbbf4a786 because it wasn't required. Now there is a use case. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14084 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* s3: VFS: vfs_default. Convert underlying system call to renameat().Jeremy Allison2019-08-161-4/+4
| | | | | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri Aug 16 21:10:14 UTC 2019 on sn-devel-184
* s3: VFS: Complete the replacement of SMB_VFS_RENAME() -> SMB_VFS_RENAMEAT().Jeremy Allison2019-08-168-71/+1
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_time_audit. Remove rename_fn(). No longer used.Jeremy Allison2019-08-161-21/+0
| | | | | | | | NB, this will now fail smb_vfs_assert_all_fns() until we remove the rename_fn() from the VFS definitions. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_full_audit. Remove rename_fn(). No longer used.Jeremy Allison2019-08-161-18/+0
| | | | | | | | NB, this will now fail smb_vfs_assert_all_fns() until we remove the rename_fn() from the VFS definitions. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_virusfilter. Remove rename_fn(). No longer used.Jeremy Allison2019-08-161-35/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_unityed_media. Remove rename_fn(). No longer used.Jeremy Allison2019-08-161-49/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_syncops. Remove rename_fn(). No longer used.Jeremy Allison2019-08-161-22/+1
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_streams_xattr. Remove rename_fn(). No longer used.Jeremy Allison2019-08-161-89/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_streams_depot: Change to using SMB_VFS_RENAMEAT() instead of ↵Jeremy Allison2019-08-161-2/+5
| | | | | | | SMB_VFS_RENAME(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_streams_depot. Remove rename_fn(). No longer used.Jeremy Allison2019-08-161-53/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_snapper. Remove rename_fn(). No longer used.Jeremy Allison2019-08-161-28/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_shadow_copy2. Remove rename_fn(). No longer used.Jeremy Allison2019-08-161-44/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_netatalk. Remove rename_fn(). No longer used.Jeremy Allison2019-08-161-39/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_media_harmony. Remove rename_fn(). No longer used.Jeremy Allison2019-08-161-57/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_glusterfs. Remove rename_fn(). No longer used.Jeremy Allison2019-08-161-9/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_fruit. Remove rename_fn(). No longer used.Jeremy Allison2019-08-161-55/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_extd_audit. Remove rename_fn(). No longer used.Jeremy Allison2019-08-161-25/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_crossrename. Remove rename_fn(). No longer used.Jeremy Allison2019-08-161-27/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_ceph_snapshots. Remove rename_fn(). No longer used.Jeremy Allison2019-08-161-33/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_ceph. Remove rename_fn(). No longer used.Jeremy Allison2019-08-161-16/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_catia. Remove rename_fn(). No longer used.Jeremy Allison2019-08-161-59/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_cap. Remove rename_fn(). No longer used.Jeremy Allison2019-08-161-44/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_audit. Remove rename_fn(). No longer used.Jeremy Allison2019-08-161-18/+0
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_recycle. Use SMB_VFS_RENAMEAT() instead of SMB_VFS_RENAME().Jeremy Allison2019-08-161-1/+5
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: smbd: vfs_virusfilter: Use SMB_VFS_RENAMEAT() instead of SMB_VFS_RENAME.Jeremy Allison2019-08-161-1/+5
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: torture: Change cmd_vfs to call SMB_VFS_RENAMEAT().Jeremy Allison2019-08-161-1/+6
| | | | | | | | | Use conn->cwd_fsp as current src and dst fsp's. No logic change for now. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: smbd: Change rename_internals_fsp() to call SMB_VFS_RENAMEAT().Jeremy Allison2019-08-161-1/+3
| | | | | | | | | Use conn->cwd_fsp as current src and dst fsp's. No logic change for now. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_virusfilter. Implement renameat().Jeremy Allison2019-08-161-0/+42
| | | | | | | Currently identical to rename(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_unityed_media. Implement renameat().Jeremy Allison2019-08-161-0/+59
| | | | | | | Currently identical to rename(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_time_audit. Implement renameat().Jeremy Allison2019-08-161-0/+27
| | | | | | | Currently identical to rename(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_syncops. Implement renameat().Jeremy Allison2019-08-161-0/+27
| | | | | | | Currently identical to rename(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_streams_xattr. Implement renameat().Jeremy Allison2019-08-161-0/+94
| | | | | | | Currently identical to rename(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_streams_depot. Implement renameat().Jeremy Allison2019-08-161-0/+61
| | | | | | | Currently identical to rename(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_snapper. Implement renameat().Jeremy Allison2019-08-161-0/+35
| | | | | | | Currently identical to rename(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_shadow_copy2. Implement renameat().Jeremy Allison2019-08-161-0/+51
| | | | | | | Currently identical to rename(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_netatalk. Implement renameat().Jeremy Allison2019-08-161-0/+47
| | | | | | | Currently identical to rename(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_media_harmony. Implement renameat().Jeremy Allison2019-08-161-0/+65
| | | | | | | Currently identical to rename(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_glusterfs. Implement renameat().Jeremy Allison2019-08-161-0/+11
| | | | | | | Currently identical to rename(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_full_audit. Implement renameat().Jeremy Allison2019-08-161-0/+24
| | | | | | | Currently identical to rename(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_fruit. Implement renameat().Jeremy Allison2019-08-161-0/+65
| | | | | | | Currently identical to rename(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: VFS: vfs_extd_audit. Implement renameat().Jeremy Allison2019-08-161-0/+31
| | | | | | | Currently identical to rename(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
View Lorry Controller Status