summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* s4:torture: test setting EOF of a stream to 0 with enabled AAPL extensionsRalph Boehme2018-07-122-0/+200
| | | | | | | | | | | | | | | | macOS SMB server uses xattrs as storage backend for streams, directly exposing xattr get/set characteristics. Setting EOF on a stream to 0 just deletes the xattr as macOS doesn't support 0-byte sized xattrs. Note that this does not apply to the AFP_AfpInfo and AFP_Resource streams, they have even stranger semantics and we have other tests for those. Bug: https://bugzilla.samba.org/show_bug.cgi?id=13441 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit cf5d471544f0cb0d072e4af1ee36798580d32897)
* s4:torture/vfs/fruit: decrease large resource fork size in test from 1 GB to ↵Ralph Boehme2018-07-121-2/+2
| | | | | | | | | | | 64 MB 64 MB is a more realistic value and lets the test pass on FreeBSD with fruit:resource=stream and vfs_streams_xattr. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 2729b4329af0ad0b6a8bd188450b8abd76670d8a)
* ctdb-tests: Avoid segfault by initializing loggingAmitay Isaacs2018-07-101-0/+2
| | | | | | | | | | | | | | | This is in addition to af697008531. Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net> Autobuild-User(master): Martin Schwenke <martins@samba.org> Autobuild-Date(master): Thu Jul 5 15:22:16 CEST 2018 on sn-devel-144 (cherry picked from commit a30ac853ff9bca023c53ad98775eabb23156c566) Autobuild-User(v4-8-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-8-test): Tue Jul 10 15:09:25 CEST 2018 on sn-devel-144
* ctdb-tests: Avoid segfault by initializing loggingAmitay Isaacs2018-07-1012-3/+33
| | | | | | | | | | | | | | Setting DEBUGLEVEL before calling debug_init() causes segmentation violation with gcc8. DEBUGLEVEL_CLASS is statically initialized to debug_class_list_initial which is defined as const. Only after debug_init() is called, DEBUGLEVEL_CLASS becomes a talloc'd array. So before modifying DEBUGLEVEL, ensure debug_init() is called via setup_logging(). (debug_init is a static function.) Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net> (cherry picked from commit af697008531bd74546656841dd3a1ed92522fc57)
* ctdb-pmda: Use modified API in pcp library 4.0Amitay Isaacs2018-07-102-9/+22
| | | | | | | | | | | | | | Support backward compatibility by checking for __pmID_int type, which was previously in <pcp/impl.h>. In the new version, this type is not defined anymore and there is no need to include <pcp/impl.h>. Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net> Autobuild-User(master): Martin Schwenke <martins@samba.org> Autobuild-Date(master): Fri Mar 2 00:38:52 CET 2018 on sn-devel-144 (cherry picked from commit 426e4a5a20cff73a80d80b46f15826deac3f934f)
* socket_wrapper: Add missing dependency on tirpcAmitay Isaacs2018-07-101-1/+1
| | | | | | | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Amitay Isaacs <amitay@samba.org> Autobuild-Date(master): Tue May 22 13:57:07 CEST 2018 on sn-devel-144 (cherry picked from commit 7049b2153b08152f03a0fcbb1817b430fe0a8451)
* ctdb-daemon: Only consider client ID for local database attachMartin Schwenke2018-07-103-13/+35
| | | | | | | | | | | | | | | | | The comment immediately above this code says "don't allow local clients to attach" and then looks up the client ID regardless of whether the request is local or remote. This means that an intentional remote attach from a client will not work correctly. No real client should ever do that since clients attach so they an access databases locally. Perhaps some sanity checks should be added. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13500 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> (cherry picked from commit 63255ef92552da92956c05160f33622d0bbc3a28)
* ctdb-tests: Switch fake_ctdbd to use ctdb_get_peer_pid()Martin Schwenke2018-07-101-8/+2
| | | | | | Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> (cherry picked from commit 05a908d71c4b7484ba0243fa51bc05c79c8fb357)
* uid_wrapper: Be strict when checking __attribute__ featuresAmitay Isaacs2018-07-101-1/+3
| | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493 Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Martin Schwenke <martins@samba.org> Autobuild-Date(master): Thu Jul 5 03:01:33 CEST 2018 on sn-devel-144 (cherry picked from commit 734ea271ab01e74d0694f3fbc9acdf980d866b30)
* resolv_wrapper: Be strict when checking __attribute__ featuresAmitay Isaacs2018-07-101-0/+2
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493 Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> (cherry picked from commit c220e310b40c67b73248141b3af544bad19fd39d)
* pam_wrapper: Be strict when checking __attribute__ featuresAmitay Isaacs2018-07-101-0/+2
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493 Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> (cherry picked from commit 65b0746694a0cbd8f40c5e89dc9a680044f7a1a9)
* nss_wrapper: Be strict when checking __attribute__ featuresAmitay Isaacs2018-07-101-0/+2
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493 Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> (cherry picked from commit 9a670bde563b269587c051c655a7b3778c008c87)
* socket_wrapper: Be strict when checking __attribute__ featuresAmitay Isaacs2018-07-101-0/+2
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493 Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> (cherry picked from commit 77cdfe3ecc06a9aef9ea4201a1a76a9a7b47a73f)
* wafsamba: Be strict when checking __attribute__ featuresAmitay Isaacs2018-07-101-0/+4
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493 Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> (cherry picked from commit a9775c2429554e029164ad9b98dc8c8c749c50fe)
* wafsamba: Add strict option to CHECK_CODEAmitay Isaacs2018-07-101-1/+11
| | | | | | | | | | | | | | | Some compilers (e.g. xlc) ignores unsupported features, generates a warning, but does not fail compilation. This ensures that any compiler warnings are treated as errors and the feature support is correctly identified. This adds equivalent compiler option to -Werror for xlc. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493 Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> (cherry picked from commit c08d65c3eea997d52e311f027d84bdc3f9c93059)
* ctdb-common: Use correct return type for tevent_queue_add_entryAmitay Isaacs2018-07-101-3/+3
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493 Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net> (cherry picked from commit b977ded38a79e1eadd6965e8b7fd49f86322b4d6)
* tdb: Fix build on AIXAmitay Isaacs2018-07-101-4/+4
| | | | | | | | | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493 Here is the build error on AIX 7.1. ../../lib/tdb/tools/tdbtool.c:39:12: error: 'disable_lock' redeclared as different kind of symbol static int disable_lock; ^~~~~~~~~~~~ In file included from /usr/include/sys/gfs.h:24:0, from /usr/include/sys/vfs.h:27, from ../../lib/replace/system/filesys.h:48, from ../../lib/tdb/tools/tdbtool.c:26: /usr/include/sys/lock_def.h:314:5: note: previous declaration of 'disable_lock' was here int disable_lock(int,simple_lock_t); ^~~~~~~~~~~~ Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net> (cherry picked from commit edffe4d16514fa0c87655e040842f6c20d89791c)
* ctdb: Fix build on AIXAmitay Isaacs2018-07-105-12/+12
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493 Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net> (cherry picked from commit 40a8ab1ce0c1b291af7263da13c25c37cee69670)
* ctdb-common: Use sin6_len only if the structure supports itAmitay Isaacs2018-07-103-4/+4
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493 Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net> (cherry picked from commit 79992dbb73ac9749ac987cb6a88964fa600b4c35)
* replace: Add test for sin6_len in sockaddr_in6 structureAmitay Isaacs2018-07-101-0/+4
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13493 Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net> (cherry picked from commit 7eeba9c5a4541e581b062fb9ee26f13b7373c541)
* ctdb-docs: Fix the documentation for VNN mapMartin Schwenke2018-07-101-4/+3
| | | | | | | | | | | It is incorrectly says that nodes not in the VNN map can not be DMASTER. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13499 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> (cherry picked from commit af446d5209e37a38363911e5f339869b73d87963)
* ctdb-server: Rename CTDB_BROADCAST_VNNMAP -> CTDB_BROADCAST_ACTIVEMartin Schwenke2018-07-107-17/+27
| | | | | | | | | | | | | | | | | | | | | | This broadcast is misnamed. Both places where this type of broadcast is used expect the broadcast to go to all active nodes. Make the corresponding change to the semantics in the daemon by sending to all active nodes. There is a mismatch between the ideas of VNN map and active nodes. A node that is not in the VNN map but is active can still host database records. These were the same until the LMASTER capability was introduced and then the logic was not updated. The only place where the VNN map is relevant is when finding the location master of a record in the migration code. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13499 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> (cherry picked from commit 36938bfdd075a174daecb466085702adfe6a6c09)
* ctdb-tests: Add a simple test for database traversesMartin Schwenke2018-07-101-0/+94
| | | | | | | | | | | This tests that volatile databases traverse correctly, including the case where a record was updated on a non-lmaster node. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13499 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> (cherry picked from commit ec72fadecd5233234947633360fe46a3a4053c07)
* ctdb-tests: Add check for non-lmaster node status in integration testsMartin Schwenke2018-07-101-0/+1
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13499 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> (cherry picked from commit 4b008556d6b1f07fd5057af845526bf941497f18)
* ctdb-client: Fix typo where CTDB_BROADCAST_ALL is repeatedMartin Schwenke2018-07-101-1/+1
| | | | | | | | | | Surely this is meant to be CTDB_BROADCAST_CONNECTED? BUG: https://bugzilla.samba.org/show_bug.cgi?id=13499 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> (cherry picked from commit 77db0b15b56f9921961bd753c210e6fdbaf97f6d)
* s3:tests: Add test for smbclient --quietJustin Stephenson2018-07-101-0/+34
| | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13485 Signed-off-by: Justin Stephenson <jstephen@redhat.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Björn Baumbach <bb@sernet.de> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Tue Jun 26 20:29:19 CEST 2018 on sn-devel-144 (cherry picked from commit f90f434e041461fbea2e101066c79ec8caf35cce)
* s3:client: Add --quiet option to smbclientJustin Stephenson2018-07-101-1/+8
| | | | | | | | | | | | Add quiet command-line argument to allow suppressing the help log message printed automatically after establishing a smbclient connection BUG: https://bugzilla.samba.org/show_bug.cgi?id=13485 Signed-off-by: Justin Stephenson <jstephen@redhat.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Björn Baumbach <bb@sernet.de> (cherry picked from commit 89a8b3ecd47b6d9a33e66f22d2786f0ae3b4cb72)
* VERSION: Bump version up to 4.8.4...Karolin Seeger2018-06-261-2/+2
| | | | | | and re-enable GIT_SNAPSHOT. Signed-off-by: Karolin Seeger <kseeger@samba.org>
* VERSION: Disable GIT_SNAPSHOT for the 4.8.3 release.samba-4.8.3Karolin Seeger2018-06-261-1/+1
| | | | Signed-off-by: Karolin Seeger <kseeger@samba.org>
* WHATSNEW: Add release notes for Samba 4.8.3.Karolin Seeger2018-06-261-0/+51
| | | | Signed-off-by: Karolin Seeger <kseeger@samba.org>
* ldb: version 1.3.4ldb-1.3.4Andrew Bartlett2018-06-264-1/+284
| | | | | | | | | | | * Fix memory leaks and missing error checks (bug 13459, 13471, 13475) * Fix fallback to full scan (performance regression) on one-level search (bug 13448) * Fix read corruption (missing results) during writes, particularly during a Samba subtree rename (bug 13452) Autobuild-User(v4-8-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-8-test): Tue Jun 26 13:31:53 CEST 2018 on sn-devel-144
* .gitlab-ci.yml: Adapt to current GitLab CI setupAndrew Bartlett2018-06-261-4/+10
| | | | Signed-off-by: Andrew Bartlett <abartlet@samba.org>
* Fix several mem leaks in ldb_index ldb_search ldb_tdbAndrej Gessel2018-06-263-3/+10
| | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13475 Signed-off-by: Andrej Gessel <Andrej.Gessel@janztec.com> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Fri Jun 15 23:07:25 CEST 2018 on sn-devel-144 (cherry picked from commit 3ca1c09f686fbfa9257cd95710dba4a98c3eeb8f)
* check return value before using key_valuesAndrej Gessel2018-06-261-3/+10
| | | | | | | | | | | there are also mem leaks in this function BUG: https://bugzilla.samba.org/show_bug.cgi?id=13475 Signed-off-by: Andrej Gessel <Andrej.Gessel@janztec.com> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit f75e8f58cd2390c092631803d333adadb475306a)
* ldb: check return valuesAndrej Gessel2018-06-262-1/+11
| | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13475 Signed-off-by: Andrej Gessel <Andrej.Gessel@janztec.com> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 6b52d21e6040699a72aff12fd6ebb34534dcb457)
* ldb_tdb: Use mem_ctx and so avoid leak onto long-term memory on duplicated add.Andrew Bartlett2018-06-261-1/+1
| | | | | | | | | | | | | | | | | | After a duplicated add a small amount of memory can be leaked onto a long-term context. Found by Andrej Gessel https://github.com/andiges https://github.com/samba-team/samba/commit/e8fb45125e6a279b918694668e0d4fbddac10aee#commitcomment-29334102 BUG: https://bugzilla.samba.org/show_bug.cgi?id=13471 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri Jun 15 04:39:41 CEST 2018 on sn-devel-144 (cherry picked from commit f4f3abfa0e18bb4968b37b1cac40cd8c185c8d7b)
* ldb: Fix memory leak on module contextLukas Slebodnik2018-06-261-2/+2
| | | | | | | | | | | | | | | Introduced in e8cdacc509016d9273d63faf334d9f827585c3eb BUG: https://bugzilla.samba.org/show_bug.cgi?id=13459 Signed-off-by: Lukas Slebodnik <lslebodn@fedoraproject.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Fri Jun 1 11:10:24 CEST 2018 on sn-devel-144 (cherry picked from commit d161aa3522576545d269208426bb0014ee2ab35f)
* ldb: Add tests for when we should expect a full scanAndrew Bartlett2018-06-264-2/+135
| | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=13448 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> (cherry picked from commit e99c199d811e607e7867e7b40d82a1642226c647)
* ldb: One-level search was incorrectly falling back to full DB scanAndrew Bartlett2018-06-261-11/+12
| | | | | | | | | | | | | | | | | | When no search filter is specified, the code falls back to using '(|(objectClass=*)(distinguishedName=*)'. ltdb_index_dn() then failed because matching against '*' is not indexed. The error return then caused the code to fallback to a full-scan of the DB, which could have a considerable performance hit. Instead, we want to continue on and do the ltdb_index_filter() over the indexed results that were returned. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13448 Signed-off-by: Tim Beale <timbeale@catalyst.net.nz> Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> (cherry picked from commit 88ae60ed186c9c479722ad62d65a07d0c2e71469)
* ldb: Explain why an entry can vanish from the indexAndrew Bartlett2018-06-261-1/+6
| | | | | | | Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> (cherry picked from commit 9e143ee9b9f7be53c193cee3153f64c4dedc07e9)
* ldb: Indicate that the ltdb_dn_list_sort() in list_union is a bit subtle.Andrew Bartlett2018-06-261-0/+3
| | | | | | | Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> (cherry picked from commit 3632775d7ad31e06437ed76b8731d9895930caa1)
* ldb: Save a copy of the index result before calling the callbacks.Andrew Bartlett2018-06-262-18/+336
| | | | | | | | | | | Otherwise Samba modules like subtree_rename can fail as they modify the index during the callback. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13452 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> (cherry picked from commit d02cd236dcbd8a44ecc85d1f7e95a48c95c0a479)
* samdb: Fix build error with gcc8Andreas Schneider2018-06-261-1/+1
| | | | | | | | | | | | | | | | | | | ../source4/dsdb/samdb/ldb_modules/samldb.c: In function ‘samldb_add’: ../source4/dsdb/samdb/ldb_modules/samldb.c:424:6: error: ‘found’ may be used uninitialized in this function [-Werror=maybe-uninitialized] if (found) { ^ ../source4/dsdb/samdb/ldb_modules/samldb.c:348:11: note: ‘found’ was declared here bool ok, found; ^~~~~ BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org> (cherry picked from commit 76828876faa3cd463023e323983df0be597c7361) Autobuild-User(v4-8-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-8-test): Tue Jun 26 02:26:15 CEST 2018 on sn-devel-144
* s3:winbind: Fix regression introduced with bso #12851Andreas Schneider2018-06-251-18/+10
| | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12851 Pair-Programmed-With: Guenther Deschner <gd@samba.org> Signed-off-by: Andreas Schneider <asn@samba.org> Signed-off-by: Guenther Deschner <gd@samba.org> (cherry picked from commit c1c764925e24788905ab91aa455b415765d6f71f)
* s3:smbget: Fix buffer truncation issues with gcc8Andreas Schneider2018-06-251-1/+1
| | | | | | | | | | | | | ../source3/utils/smbget.c: In function ‘smb_download_file’: ../source3/utils/smbget.c:97:27: error: ‘b’ directive output may be truncated writing 1 byte into a region of size between 0 and 19 [-Werror=format-truncation=] snprintf(buffer, l, "%jdb", (intmax_t)s); ^ BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org> (cherry picked from commit 4a3164e0beea35c1f4ce44fbe43547f7104587d1)
* s3:registry: Fix buffer truncation issues issues with gcc8Andreas Schneider2018-06-251-7/+5
| | | | | | | | | | | | ../source3/registry/reg_perfcount.c: In function ‘reg_perfcount_get_hkpd’: ../source3/registry/reg_perfcount.c:337:29: error: ‘snprintf’ output may be truncated before the last format character [-Werror=format-truncation=] snprintf(buf, buflen,"%d%s", key_part1, key_part2); BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org> (cherry picked from commit 29f6842ee86b768f3677b38c5640655e312c398e)
* heimdal: lib/krb5: do not fail set_config_files due to parse errorJeffrey Altman2018-06-252-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | Follow Apple's lead and do not fail krb5_set_config_files() simply because one of the files in the profile list fails to parse correctly. Doing so can lead to hard to find failures and could lead to an end user shooting themselves in the foot and no longer be able to login to their system to fix it. Parse as many of the files as we can. Only fail krb5_set_config_files() if init_context_from_config_file() fails. Change-Id: I122664c6d707a5f926643808ba414bf4f681f8b8 Cherry-pick of Heimdal commit b7cf5e7caf9b270f4d4151d2690177b11a7a1bdf BUG: https://bugzilla.samba.org/show_bug.cgi?id=11573 Signed-off-by: Björn Baumbach <bb@sernet.de> Reviewed-by: Alexander Bokovoy <ab@samba.org> (cherry picked from commit f05a1554b770c6a2c905170347bfb41157f4aa78) Autobuild-User(v4-8-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-8-test): Mon Jun 25 17:30:14 CEST 2018 on sn-devel-144
* krb5_plugin: Add winbind localauth plugin for MIT KerberosAndreas Schneider2018-06-254-0/+287
| | | | | | | | | | | | | | | | Applications (like OpenSSH) don't know about users and and their relationship to Kerberos principals. This plugin allows that Kerberos principals can be validated against local user accounts. Administrator@WURST.WORLD -> WURST\Administrator https://web.mit.edu/kerberos/krb5-latest/doc/plugindev/localauth.html BUG: https://bugzilla.samba.org/show_bug.cgi?id=13480 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org> (cherry picked from commit 5e89a23ffaceccdc83d70a4ab2798ae25c10d580)
* krb5_wrap: fix keep_old_entries logic for older kerberos librariesChristof Schmitt2018-06-251-1/+1
| | | | | | | | | | | | | | | | | | | | MIT kerberos 1.13 and older only stores 8 bits of the KVNO. The change from commit 35b2fb4ff32 resulted in breakage for these kerberos versions: 'net ads keytab create' reads a large KVNO from AD, and only the lower 8 bits are stored. The next check then removed the entry again as the 8 bit value did not match the currently valid KVNO. Fix this by limiting the check to only 8 bits. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13478 Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org> Autobuild-User(master): Christof Schmitt <cs@samba.org> Autobuild-Date(master): Sat Jun 23 00:57:47 CEST 2018 on sn-devel-144 (cherry picked from commit 97eaeea6a130871cfac5be42459380c0c4e0fae6)
* blaKarolin Seeger2018-06-251-2/+40
|
View Lorry Controller Status