summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Simplify handling of dependencies on external libraries in test_headers.Jelmer Vernooij2016-01-131-11/+2
| | | | Signed-off-by: Jelmer Vernooij <jelmer@jelmer.uk>
* Use full path to dlinklist.h in includes.Jelmer Vernooij2016-01-133-3/+3
| | | | Signed-off-by: Jelmer Vernooij <jelmer@jelmer.uk>
* Revert "winbind: Retry after SESSION_EXPIRED error in ping-dc"Christof Schmitt2016-01-131-8/+0
| | | | | | | | | | | | | | This reverts commit a2670f15dea27c10e3827216adf572f9c3894f85. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11670 cm_connect_netlogon now handles the retry for an expired session. Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Jan 13 03:35:57 CET 2016 on sn-devel-144
* winbindd: Retry on expired session in cm_connect_netlogonChristof Schmitt2016-01-131-0/+8
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=11670 Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* winbindd: Retry on expired session in cm_connect_samChristof Schmitt2016-01-131-0/+48
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=11670 Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* winbindd: Retry on expired session in cm_connect_lsaChristof Schmitt2016-01-131-0/+48
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=11670 Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* winbindd: Remove double retry from some ADS methodsChristof Schmitt2016-01-131-14/+12
| | | | | | | | | | | The retry through the new reconnect_ads layer is enough. This structure also makes the distinction between retry layer and actual methods call a bit clearer. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11670 Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* winbindd: Add retry also for ADS method callsChristof Schmitt2016-01-136-4/+335
| | | | | | | | | | RPC calls can return IO_DEVICE_ERROR on expired SMB2 sessions. Retrying on a new connection avoids surfacing this error to winbindd clients. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11670 Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* winbindd: Reset connection for expired session before reconnectingChristof Schmitt2016-01-131-15/+24
| | | | | | | | | | | A RPC call on a expired SMB2 session returns IO_DEVICE_ERROR. In this case, reset the connection before issuing the same call again. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11670 Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* ctdb-tests: Fix some incorrect memory allocationsMartin Schwenke2016-01-121-2/+9
| | | | | | | | | | | These allocate enough memory but things get confusing if they're used as a guide when updating the code. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Tue Jan 12 22:19:16 CET 2016 on sn-devel-144
* ctdb-scripts: Use more unique temporary file namesMartin Schwenke2016-01-121-4/+10
| | | | | | | | | | | | | | | | | | | | | | | Consider this sequence of events: 1. Instance of script running update_tickles() hangs 2. Script debugging is launched asynchronously 3. New instance of script is launched, creates temporary file(s) 4. Original hung script makes progress before asynchronous script debugging kills it, so it removes temporary file(s) 5. New instance of script produces error due to missing files(s) This is obviously rare. Use more unique filenames to avoid step (4) removing the file(s) belonging to other instances of the script. This requires some extra cleanup to avoid too many temporary files (which is why unique filenames were not originally usd). It is sufficient to remove files modified at least 10 minutes ago. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Michael Adam <obnox@samba.org>
* ctdb-scripts: Don't remove temporary files before useMartin Schwenke2016-01-121-2/+0
| | | | | | | They will be clobbered by the redirect anyway. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Michael Adam <obnox@samba.org>
* ctdb-scripts: Superficial clean-ups to 10.interfaceMartin Schwenke2016-01-121-23/+7
| | | | | | | | | | Whitespace and indentation improvements. Remove comments describing events, since the README covers that much better. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Michael Adam <obnox@samba.org>
* ctdb-scripts: Clarify logic for success of interface monitoringMartin Schwenke2016-01-121-6/+9
| | | | | | | | The current code uses so many shell idioms that it is difficult to follow. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Michael Adam <obnox@samba.org>
* ctdb-scripts: Fix regression in updateip codeMartin Schwenke2016-01-121-1/+1
| | | | | | | | Regression introduced in commit 6471541d6d2bc9f2af0ff92b280abbd1d933cf88. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Michael Adam <obnox@samba.org>
* ctdb-ipalloc: Fix a memory leakMartin Schwenke2016-01-121-2/+2
| | | | | | | | Commit cfa0ffe78073f9e3a014bb127fb9a4b7ad95fceb introduced a memory leak. Never assume... Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Michael Adam <obnox@samba.org>
* ctdb-daemon: Don't leak memory if not using recovery lockMartin Schwenke2016-01-121-7/+7
| | | | | Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Michael Adam <obnox@samba.org>
* ctdb-recoverd: Fix some uninitialised memory issuesMartin Schwenke2016-01-122-0/+3
| | | | | | | | | | The first element of these structures is a 32-bit PNN. On 64-bit systems this field can be followed by 32-bits of padding. When the structures are copied this can cause uninitialised memory to be copied. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Michael Adam <obnox@samba.org>
* ctdb-daemon: Drop the "schedule for deletion" messages to DEBUG levelMartin Schwenke2016-01-121-5/+5
| | | | | | | | Thousands of these can be generated each second, rendering INFO level debugging useless. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Michael Adam <obnox@samba.org>
* ctdb/web: Fix typo.Karolin Seeger2016-01-111-1/+1
| | | | | | | | | | assinged -> assigned Signed-off-by: Karolin Seeger <kseeger@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Mon Jan 11 21:40:36 CET 2016 on sn-devel-144
* talloc: Fix a documentation typoMartin Schwenke2016-01-111-1/+1
| | | | | | | | Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Mon Jan 11 18:34:53 CET 2016 on sn-devel-144
* nss_wrapper: bump version to 1.1.2Michael Adam2016-01-111-1/+1
| | | | | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Mon Jan 11 15:30:49 CET 2016 on sn-devel-144
* nwrap: Fix segfaults while reloading hosts fileAndreas Schneider2016-01-111-0/+13
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* nwrap: Don't fail if we want to add an existing entryAndreas Schneider2016-01-111-2/+4
| | | | | | Pair-Programmed-With: Michael Adam <obnox@samba.org> Signed-off-by: Andreas Schneider <asn@samba.org> Signed-off-by: Michael Adam <obnox@samba.org>
* nwrap: Fix the build on SolarisAndreas Schneider2016-01-111-0/+2
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* nwrap: Don't leak memory from gethostbyname*() functionsAndreas Schneider2016-01-111-0/+3
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* nwrap: Fix the build on FreeBSDAndreas Schneider2016-01-111-0/+2
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* nwrap: fix a copy and paste error in the destructor.Michael Adam2016-01-111-1/+1
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* nwrap: Cleanup shadow getspnam() memoryAndreas Schneider2016-01-111-0/+12
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Signed-off-by: Michael Adam <obnox@samba.org>
* nwrap: fix leaking the entlistsMichael Adam2016-01-111-0/+23
| | | | | | | | Track the list heads in a vector in the newrap_he_global struct and free the structures upon nwrap_he_unload. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* nwrap: catch error to add item to vector in nwrap_he_parse_line()Michael Adam2016-01-111-3/+13
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* nwrap: rename nwrap_he.entdata to nwrap_he.entriesMichael Adam2016-01-111-7/+7
| | | | | | | | | That's what is is the list of entries. In the guise nwrap_entdata structures but the code reads more naturally this way. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* nwrap: remove unused member list from struct nwrap_heMichael Adam2016-01-111-1/+0
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* nwrap: Small code shift in nwrap_ed_inventarize_add_to_existing()Robin Hack2016-01-111-6/+5
| | | | | | | | Allocate memory only when necessary. Signed-off-by: Robin Hack <hack.robin@gmail.com> Reviewed-by: Michael Adam <obnox@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* nwrap: Cast max_hostents to avoid warningsAndreas Schneider2016-01-111-2/+3
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* nwrap: Fix initialization of e entryAndreas Schneider2016-01-111-1/+3
| | | | | | | This fixes a compiler warning. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* nwrap: remove ai_tail argument from nwrap_files_getaddrinfo()Michael Adam2016-01-111-6/+3
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* nwrap: rewrite the loop for duplication ai entries if socktype not givenMichael Adam2016-01-111-34/+35
| | | | | | | | | This loop reads much more naturally now. It inserts the duplicated entry right after the entrie that is being duplicated. It does not need a ai_tail any more. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* nwrap: add an explaining comment for the ai duplicating loopMichael Adam2016-01-111-0/+5
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* nwrap: move setting of ai_{flags|socktype|protocol} into nwrap_convert_he_aiMichael Adam2016-01-111-13/+12
| | | | | | | | | This makes the code in nwrap_getaddrinfo() more readable and also treats all ai stuctures in the linked list, not just the first one! Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* nwrap: use symbols IPPROTO_TCP and IPPROTO_UDPMichael Adam2016-01-111-4/+7
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* nwrap: rename _ai -> ai_new in nwrap_files_getaddrinfo()Michael Adam2016-01-111-6/+6
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* nwrap: fix a memleak in nwrap_files_getaddrinfo()Michael Adam2016-01-111-0/+3
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* nwrap: rename ai_prev -> ai_cur in nwrap_files_getaddrinfo()Michael Adam2016-01-111-4/+4
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* nwrap: Fix inventarization of IPs when loading hostsMichael Adam2016-01-111-30/+1
| | | | | | | | | | | | | | Use nwrap_ed_inventarize() instead of nwrap_add_ai(). This not only removes code duplication, but also more correctly adds more than one line for a given IP address in a list behind this address. The original code would only have inventarized the first line for an IP found. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* nwrap: refactor nwrap_add_hname_* into one nwrap_ed_inventarize.Michael Adam2016-01-111-28/+15
| | | | | | | | This reduces code duplication and abstracts the logic out. It was not special to hname or hname_alias. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* nwrap: treat AI_NUMERICHOST correctly in getaddrinfo.Michael Adam2016-01-111-3/+6
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=11477 Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* nwrap: fix treatment of EAI_ADDRINFO in nwrap_files_getaddrinfoMichael Adam2016-01-111-5/+11
| | | | | | | | | Checking whether the passed in name (node) is a valid IPv6 or IPv4 address, we can do the checking for these two error conditions properly up front. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* nwrap: correctly track EAI_ADDRINFO in nwrap_files_getaddrinfoMichael Adam2016-01-111-8/+19
| | | | | | | | | | | | | When looping through the entry list and remember the EAI_ADDRINFO case, so that we can differentiate the cases - no entry found at all - an entry found buy wrong address type Adapt return codes accordingly. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* nwrap: in nwrap_files_getaddrinfo, treat failure of nwrap_convert_he_ai as errorMichael Adam2016-01-111-2/+1
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
View Lorry Controller Status