summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* libcli: Add an overflow checkVolker Lendecke2017-01-231-0/+4
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* libcli: Do not overwrite pointer on realloc failureVolker Lendecke2017-01-231-3/+5
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* winbind: Fix a typoVolker Lendecke2017-01-231-1/+1
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3/smbd: check for invalid access_mask smbd_calculate_access_mask()Ralph Boehme2017-01-232-1/+6
| | | | | | | | | This makes us pass "base.createx_access". Bug: https://bugzilla.samba.org/show_bug.cgi?id=12536 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* selftest: also run test base.createx_access against ad_dcRalph Boehme2017-01-232-1/+4
| | | | | | | | | Fails currently, will be made to work in the next commit. Bug: https://bugzilla.samba.org/show_bug.cgi?id=12536 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* Add explicit dependency on samba-debug from libinterfaces and libserverrole.Zentaro Kavanagh2017-01-232-2/+2
| | | | | | | | | | | | | | | | | | | Currently these dependencies are indirect via a SAMBA_SUBSYSTEM which does not propagate private library information. This results in these 2 libraries getting generated with no RPATH information in the ELF header. Additional discussion [1]. [1] - https://lists.samba.org/archive/samba-technical/2017-January/118078.html Signed-off-by: Zentaro Kavanagh <zentaro@google.com> Reviewed-by: Ralph Böhme <slow@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Mon Jan 23 08:26:43 CET 2017 on sn-devel-144
* selftest: Remove unsued variables WINBINDD_PRIV_PIPE_DIR and wbsockprivdirAndrew Bartlett2017-01-222-3/+0
| | | | | | | | | | I can not find anything that uses these in the testsuite Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Sun Jan 22 22:15:01 CET 2017 on sn-devel-144
* param: Remove winbindd privileged socket directory optionAndrew Bartlett2017-01-2211-33/+0
| | | | | | | | | | | | This option is unused and has not been used since before Samba 4.3 when the source4/ winbindd code went away. The associated dynconfig parameters used for the default are also removed. BUG: https://bugzilla.samba.org/show_bug.cgi?id=10066 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* lib/util: Avoid a talloc in ms_fnmatch_protocolVolker Lendecke2017-01-221-8/+6
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3/lib: Use ms_fnmatch_protocol in mask_matchVolker Lendecke2017-01-221-1/+1
| | | | | | | This avoids the talloc/free through push_ucs2_talloc Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* lib: Add "is_case_sensitive" to ms_fnmatch_protocolVolker Lendecke2017-01-227-21/+40
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* lib/util/charset: Optimize next_codepoint for the ascii caseVolker Lendecke2017-01-221-0/+4
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3/locking: Avoid a talloc for nonexisting fetch_share_mode_unlockedVolker Lendecke2017-01-221-15/+17
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* smbd: Streamline get_ea_names_from_fileVolker Lendecke2017-01-221-42/+54
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* smbd: Fix an indentationVolker Lendecke2017-01-221-2/+3
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* smbd: Fix a few signed/unsigned hickupsVolker Lendecke2017-01-221-6/+7
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* lib: Avoid a "includes.h"Volker Lendecke2017-01-221-1/+1
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* smbd: Fix a typoVolker Lendecke2017-01-221-1/+1
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* lib: Avoid an includes.hVolker Lendecke2017-01-221-1/+4
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* lib: Add lib/util/server_id.hVolker Lendecke2017-01-2243-31/+97
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* vfs_default: unlock the right file in copy chunkBjörn Jacke2017-01-211-1/+1
| | | | | | | | Signed-off-by: Bjoern Jacke <bj@sernet.de> Reviewed-by: David Disseldorp <ddiss@samba.org> Autobuild-User(master): Björn Jacke <bj@sernet.de> Autobuild-Date(master): Sat Jan 21 17:00:54 CET 2017 on sn-devel-144
* replace: fix some trailing whitespacesBjörn Jacke2017-01-211-10/+10
| | | | | Signed-off-by: Bjoern Jacke <bj@sernet.de> Reviewed-by: David Disseldorp <ddiss@samba.org>
* vfs_fruit: fix a typoBjörn Jacke2017-01-211-1/+1
| | | | | Signed-off-by: Bjoern Jacke <bj@sernet.de> Reviewed-by: David Disseldorp <ddiss@samba.org>
* s3/rpc_server/mdssvc: prefix public flex and bison global symbolsRalph Boehme2017-01-215-288/+322
| | | | | | | | | | | | | | | | | | | | | | | | | This fixes a clash with a parser in Heimdal when building with --nonshared-binary=smbd/smbd: ... [3139/3620] Linking default/source3/smbd/smbd ... default/source4/heimdal/lib/hx509/sel-lex_116.o: In function `yy_get_previous_state': /usr/build/packages/samba-4.5/bin/../source4/heimdal/lib/hx509/sel-lex.c:1122:multiple definition of `yyin' default/source3/rpc_server/mdssvc/sparql_lexer_28.o:/usr/build/packages/samba-4.5/bin/sparql_lexer.c:1149:first defined here ... The fix is to use namespace prefixes in the parser and the lexer as described here: <https://www.gnu.org/software/bison/manual/html_node/Multiple-Parsers.html> Bug: https://bugzilla.samba.org/show_bug.cgi?id=12528 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Sat Jan 21 13:13:19 CET 2017 on sn-devel-144
* s3/rpc_server/mdssvc: use flex noyyalloc noyyreallocRalph Boehme2017-01-213-97/+112
| | | | | | | | | | Redefine the symbols used for malloc and realloc in the flex source instead of running sed over the generated one. Bug: https://bugzilla.samba.org/show_bug.cgi?id=12528 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* smbcontrol: add ringbuf-logRalph Boehme2017-01-202-0/+52
| | | | | | | | Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Fri Jan 20 22:33:14 CET 2017 on sn-devel-144
* s4/messaging: register for MSG_REQ_RINGBUF_LOGRalph Boehme2017-01-201-0/+22
| | | | | Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* s3/debug: listen for MSG_REQ_RINGBUF_LOGRalph Boehme2017-01-201-0/+22
| | | | | Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* messaging.idl: add ringbuf message typesRalph Boehme2017-01-201-0/+3
| | | | | Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* debug: add "ringbuf" backend logging to a ringbufferRalph Boehme2017-01-203-0/+91
| | | | | | | | | | | | | This is useful for debugging bugs that involve timing effects and are not reproducible when logging at higher debug levels with the file backend. The log can be dumped to a file with gdb: (gdb) dump binary memory samba.log debug_ringbuf debug_ringbuf+SIZE Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* debug: parse, store and pass backend optionRalph Boehme2017-01-201-9/+22
| | | | | | | Will be used in the next commit by new "ringbuf" backend. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* ctdb-docs: Document configuration variable CTDB_NFS_CHECKS_DIRMartin Schwenke2017-01-201-0/+28
| | | | | | | | Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> Autobuild-User(master): Martin Schwenke <martins@samba.org> Autobuild-Date(master): Fri Jan 20 18:47:04 CET 2017 on sn-devel-144
* ctdb-scripts: Avoid log noise when NFS checks directory is emptyMartin Schwenke2017-01-201-0/+2
| | | | | Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-tests: Drop calls to ctdb_service_managed and ctdb_service_unmanagedAmitay Isaacs2017-01-201-12/+0
| | | | | | | | These functions have been removed as part of dropping CTDB_SERVICE_AUTOSTARTSTOP functionality. Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
* s3/rpc_server: move rpc_modules.c to its own subsystemRalph Boehme2017-01-201-3/+8
| | | | | | | | | | | | | | | | | The source file rpc_modules.c was used in two places which lead to the following build error when configuring with '--nonshared-binary=smbd/smbd': ERROR: source source3/rpc_server/rpc_modules.c is in more than one subsystem of target 'smbd/smbd': ['RPC_SERVICE', 'MDSSD'] Bug: https://bugzilla.samba.org/show_bug.cgi?id=12524 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Noel Power <nopower@suse.com> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Fri Jan 20 15:00:45 CET 2017 on sn-devel-144
* libgpo: Fix error check in gp_inifile_init_context_direct()Günther Deschner2017-01-201-2/+2
| | | | | | | Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3/winbindd: fix invalid freeAurelien Aptel2017-01-181-1/+1
| | | | | | | | | | | | | | | coverity fix. TALLOC_FREE() might be called on uninitialized 'rids' at the end of the function in case of an early error. Initialize it to NULL to turn the TALLOC_FREE() to a noop in this case. Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Wed Jan 18 17:19:39 CET 2017 on sn-devel-144
* ctdb-daemon: Remove stale eventd socketAmitay Isaacs2017-01-171-0/+9
| | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12513 Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net> Autobuild-User(master): Martin Schwenke <martins@samba.org> Autobuild-Date(master): Tue Jan 17 15:00:15 CET 2017 on sn-devel-144
* ctdb-tests: Add "13.per_ip_routing shutdown" testMartin Schwenke2017-01-171-0/+31
| | | | | | | | | | | | Ensure that it doesn't mangle the rt_tables file. BUG: https://bugzilla.samba.org/show_bug.cgi?id=12516 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> Autobuild-User(master): Amitay Isaacs <amitay@samba.org> Autobuild-Date(master): Tue Jan 17 06:02:23 CET 2017 on sn-devel-144
* ctdb-scripts: Fix regression when cleaning up routing table IDsMartin Schwenke2017-01-171-2/+2
| | | | | | | | | | | | | | | | | | | | | | Commit 0ca00267cd2620a14968961738bcd2a69b597e95 removed explicit continuations in strings for awk programs. In one case this causes a disconnect between condition and action, where an implicit continuation does not work. This results in duplicate lines in the rt_tables file. Move the opening brace for the action to make the implicit continuation work as expected. An alternative would be to revert the removal of the explicit continuations and add shellcheck tags. However, that doesn't mean that an author of future code will necessarily use explicit continuations, so the same mistake might still be make in the future. BUG: https://bugzilla.samba.org/show_bug.cgi?id=12516 Reported-by: Barry Evans <bevans@pixitmedia.com> Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-scripts: Fix remaining uses of "ctdb gratiousarp"Martin Schwenke2017-01-175-8/+8
| | | | | | | | | | | | | This changed to "ctdb gratarp" some time ago but the scripts were never updated. Fix the documentation for the ctdb tool too. BUG: https://bugzilla.samba.org/show_bug.cgi?id=12512 Reported-by: Ralph Böhme <slow@samba.org> Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-common: Add wait_send/wait_recv to sock_daemon_funcsAmitay Isaacs2017-01-164-55/+183
| | | | | | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12510 To be able to terminate the daemon from within the implementation, create a subreq using wait_send() provided by the implementation. When the subreq is finished, it signals the sock_daemon code to terminate the daemon. This avoids the need to keep track of the top level tevent_req causing layer violation and keeps the code flow straighforward. Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Mon Jan 16 21:16:51 CET 2017 on sn-devel-144
* ctdb-common: Avoid any processing after finishing tevent_reqAmitay Isaacs2017-01-161-2/+1
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12510 Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* ctdb-common: Pass tevent_req to the computation sub-functionsAmitay Isaacs2017-01-161-12/+12
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12510 Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* ctdb-common: Use consistent naming for sock_daemon_run computation functionsAmitay Isaacs2017-01-161-30/+32
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12510 Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* ctdb-common: Correct name of sock_daemon_run_send/recv state structureAmitay Isaacs2017-01-161-15/+15
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12510 Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* ctdb-tests: Fix name of the variable representing init scriptAmitay Isaacs2017-01-162-2/+2
| | | | | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net> Autobuild-User(master): Martin Schwenke <martins@samba.org> Autobuild-Date(master): Mon Jan 16 15:46:42 CET 2017 on sn-devel-144
* ctdb-scripts: Drop configuration variable CTDB_SCRIPT_DEBUGLEVELMartin Schwenke2017-01-162-34/+0
| | | | | | | | The debug() function, which is the only user of this variable, is no longer used. It is also dropped. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-scripts: Drop function ctdb_check_command()Martin Schwenke2017-01-162-16/+5
| | | | | | | This is only used in 1 place, so just inline the check. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-scripts: Inline simple uses of service_start() and service_stop()Martin Schwenke2017-01-162-20/+6
| | | | | | | This makes the scripts more readable. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
View Lorry Controller Status