summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* tdb: Release tdb 1.4.3tdb-1.4.3Uri Simchoni2019-11-182-1/+74
| | | | | | | | | * Upgrade waf to version 2.0.18 to fix a cross-compilation issue. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13846 Signed-off-by: Uri Simchoni <uri@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* talloc: Release talloc 2.3.1talloc-2.3.1Uri Simchoni2019-11-183-1/+82
| | | | | | | | | * Upgrade waf to 2.0.18 to fix a cross-compilation issue BUG: https://bugzilla.samba.org/show_bug.cgi?id=13846 Signed-off-by: Uri Simchoni <uri@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* ndrdump: avoid use after freeDouglas Bagnall2019-11-171-1/+2
| | | | | | | | Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org> Autobuild-Date(master): Sun Nov 17 23:54:11 UTC 2019 on sn-devel-184
* ndrdump: Use human-readable strings for NDR decode errorsAndrew Bartlett2019-11-173-24/+16
| | | | | | | | These make much more sense than the NTSTATUS values they can be forced to map to. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
* selftest: Test fix for ndrdump of structures by numberAndrew Bartlett2019-11-173-0/+23
| | | | | | | | | This requires that misc.GUID not move in the IDL, so a comment is added. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
* ndrdump: correctly find the public strict by numberDouglas Bagnall2019-11-171-14/+17
| | | | | | | | | | We were finding a function that happened to have the same ordinal number. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* librpc: Use the fact that file_save() now uses O_EXCL in dcerpc_log_packet()Andrew Bartlett2019-11-151-6/+6
| | | | | | | | | | | This avoids a race with file_exist() and demostrates a better way to use this function. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Fri Nov 15 18:48:27 UTC 2019 on sn-devel-184
* lib/util: change file_save_mode() to use O_EXCLAndrew Bartlett2019-11-152-1/+8
| | | | | | | | | | | | | | | | Almost all the callers are debug tools or developer debugging aids and these callers clearly expect to create a new file. Unchanged in behaviour is: - TLS certificate creation. This already confirms the files do no exist prior to generation. These will now no longer overwrite the given filename - net ads pac save - net eventlog export Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3-build: add missing gnutls dependencyBjörn Baumbach2019-11-151-1/+4
| | | | | Signed-off-by: Björn Baumbach <bb@sernet.de> Reviewed-by: Andreas Schneider <asn@samba.org>
* third_party: Update nss_wrapper to version 1.1.7Andreas Schneider2019-11-143-36/+59
| | | | | | | | | | This adds missing support for Address Sanitzer. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Nov 14 23:50:06 UTC 2019 on sn-devel-184
* lib: Fix an error path memleak in schannel_get_creds_state()Volker Lendecke2019-11-141-0/+1
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* vfs: Use dbwrap_delete() in acl_tdb_delete()Volker Lendecke2019-11-141-30/+4
| | | | | | | | Use the wrapper function that's already available for exactly this purpose. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* vfs: Use dbwrap_store() in store_acl_blob_fsp()Volker Lendecke2019-11-141-9/+4
| | | | | | | | Use the wrapper function that's already available for exactly this purpose. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* vfs: Use direct struct assignment in store_acl_blob_fsp()Volker Lendecke2019-11-141-3/+1
| | | | | | | 2 lines less code Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* pidl: Handle obtaining objects from a fixed-size arrayAndrew Bartlett2019-11-142-2/+5
| | | | | | | | | | | | | | | | | Previously we would assume the array head was the talloc context however this is not the case if the array is a fixed size inline array within the parent struct. In that case the overall object's talloc context is the correct context to reference. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Pair-programmed-with: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Noel Power <npower@samba.org> Autobuild-User(master): Noel Power <npower@samba.org> Autobuild-Date(master): Thu Nov 14 17:36:49 UTC 2019 on sn-devel-184
* pidl/python: allocate objects with ref pointersDouglas Bagnall2019-11-142-3/+56
| | | | | | | | | | Struct members that are marked as ref pointers need to have an object allocated for them. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Pair-programmed-with: Andrew Bartlett <abartlet@samba.org> Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Noel Power <npower@samba.org>
* pytests/segfault: pidl inline arraysDouglas Bagnall2019-11-142-1/+7
| | | | | Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Noel Power <npower@samba.org>
* pytests/segfaults: dcerpc ref elements segfaultDouglas Bagnall2019-11-142-1/+15
| | | | | | | These are just a couple of examples. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Noel Power <npower@samba.org>
* pytests: rpc echo should not segfaultDouglas Bagnall2019-11-141-0/+5
| | | | | Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Noel Power <npower@samba.org>
* s4/rpc/dcerpc_connect: no crash on NULL dest_hostDouglas Bagnall2019-11-141-1/+1
| | | | | Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Noel Power <npower@samba.org>
* ctdb-tests: Add tests for cmdline_add() apiAmitay Isaacs2019-11-142-0/+113
| | | | | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net> Autobuild-User(master): Martin Schwenke <martins@samba.org> Autobuild-Date(master): Thu Nov 14 12:03:46 UTC 2019 on sn-devel-184
* ctdb-common: Add api to add new section/commands to cmdlineAmitay Isaacs2019-11-142-0/+20
| | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
* ctdb-common: Change cmdline implementation to support multiple sectionsAmitay Isaacs2019-11-141-33/+101
| | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
* ctdb-tests: Update cmdline tests for section nameAmitay Isaacs2019-11-142-4/+4
| | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
* ctdb-common: Add section to group commands in cmdlineAmitay Isaacs2019-11-147-13/+78
| | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
* ctdb-common: Generate usage message from cmdline_parse()Amitay Isaacs2019-11-143-24/+34
| | | | | | | | If any of the option parsing or command parsing fails, generate usage message. Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
* libcli:auth Check return code of netlogon_creds_aes_encrypt()Andrew Bartlett2019-11-142-7/+21
| | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Thu Nov 14 09:25:36 UTC 2019 on sn-devel-184
* libcli:auth: Check return code of netlogon_creds_step_crypt()Andreas Schneider2019-11-141-7/+29
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* libcli:auth: Check return code of netlogon_creds_step()Andreas Schneider2019-11-141-3/+17
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:librpc: Check return code of netlogon_creds_client_authenticator()Andreas Schneider2019-11-141-1/+7
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* libcli:auth: Check return code of netlogon_creds_client_authenticator()Andreas Schneider2019-11-141-15/+41
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* auth:pycreds: Check return code of netlogon_creds_client_authenticator()Andreas Schneider2019-11-141-3/+8
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* libcli:auth: Return NTSTATUS for netlogon_creds_client_authenticator()Andreas Schneider2019-11-142-4/+8
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* libcli:auth: Check return status of netlogon_creds_first_step()Andreas Schneider2019-11-141-5/+19
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* libcli:auth: Check return status of netlogon_creds_init_64bit()Andreas Schneider2019-11-141-7/+22
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* libcli:auth: Check return value of netlogon_creds_init_128bit()Andreas Schneider2019-11-141-4/+10
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture: Remove calls to gnutls_global_(de)init() in backupkey testAndreas Schneider2019-11-141-48/+0
| | | | | | | This is handled by the gnutls library constructor/destructor. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:lib: Remove gnutls_global_(de)init() from libtlsAndreas Schneider2019-11-142-15/+0
| | | | | | | This is handled by the gnutls library constructor/destructor. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:rpc_server: Remove gnutls_global_(de)init()Andreas Schneider2019-11-141-3/+0
| | | | | | | This is done by the gnutls library constructor/destructor. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* libcli:auth: Check return code of SMBOWFencrypt_ntv2()Andreas Schneider2019-11-142-5/+33
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* libcli:auth: Return NTSTATUS for SMBOWFencrypt_ntv2()Andreas Schneider2019-11-142-14/+19
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* libcli:auth: Check return codes of SMBsesskeygen_ntv2()Andreas Schneider2019-11-142-4/+28
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* libcli:auth: Return NTSTATUS for SMBOWFencrypt_ntv2()Andreas Schneider2019-11-142-10/+19
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* librpc: Do not return an NDR table for a zero GUIDAndrew Bartlett2019-11-141-0/+8
| | | | | | | | | | | | The source3 RPC server will do a lookup by GUID and should not be returned a table for a zero GUID. Thankfully such a pipe would also need to have been registered but regardless this is not a determinsitic result so should be avoided. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* ctdb-tcp: Simplify freeing of transport data on shutdownMartin Schwenke2019-11-141-4/+1
| | | | | | | | | | The type-checking is superfluous and gets in the way of readability. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> Autobuild-User(master): Amitay Isaacs <amitay@samba.org> Autobuild-Date(master): Thu Nov 14 03:45:44 UTC 2019 on sn-devel-184
* ctdb-daemon: Rename ctdb_context private_data to transport_dataMartin Schwenke2019-11-144-11/+14
| | | | | | | This gives a casual reader a useful clue. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-daemon: Rename ctdb_node private_data to transport_dataMartin Schwenke2019-11-146-17/+23
| | | | | | | This gives a casual reader a useful clue. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-tcp: Close inflight connecting TCP sockets after forkVolker Lendecke2019-11-141-0/+6
| | | | | | | | | | | | | | | | | | | | | | | Commit c68b6f96f26 changed the talloc hierarchy such that outgoing TCP sockets while sitting in the async connect() syscall are not freed via ctdb_tcp_shutdown() anymore, they are hanging off a longer-running structure. Free this structure as well. If an outgoing TCP socket leaks into a long-running child process (possibly the recovery daemon), this connection will never be closed as seen by the destination node. Because with recent changes incoming connections will not be accepted as long as any incoming connection is alive, with that socket leak into the recovery daemon we will never again be able to successfully connect to the node that is affected by this leak. Further attempts to connect will be discarded by the destination as long as the recovery daemon keeps this socket alive. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14175 RN: Avoid communication breakdown on node reconnect Signed-off-by: Martin Schwenke <martin@meltin.net> Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* smbd: Make share_mode_do_locked() pass TDB_DATA instead of a recordVolker Lendecke2019-11-133-12/+14
| | | | | | | | | | | No callback used (and should not use) the record directly, this is all handled within share_mode_lock.c Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Nov 13 21:41:09 UTC 2019 on sn-devel-184
* gitlab-ci: Run samba-fileserver-heimdalkrb5Christof Schmitt2019-11-131-0/+3
| | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14179 Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Christof Schmitt <cs@samba.org> Autobuild-Date(master): Wed Nov 13 19:14:25 UTC 2019 on sn-devel-184
View Lorry Controller Status