summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* VERSION: Disable git snapshots for the 4.5.3 release.samba-4.5.3Karolin Seeger2016-12-091-1/+1
| | | | Signed-off-by: Karolin Seeger <kseeger@samba.org>
* WHATSNEW: Add release notes for Samba 4.5.3.Karolin Seeger2016-12-091-2/+84
| | | | Signed-off-by: Karolin Seeger <kseeger@samba.org>
* CVE-2016-2126: auth/kerberos: only allow known checksum types in ↵Stefan Metzmacher2016-12-091-0/+22
| | | | | | | | | | | | | | | check_pac_checksum() aes based checksums can only be checked with the corresponding aes based keytype. Otherwise we may trigger an undefined code path deep in the kerberos libraries, which can leed to segmentation faults. BUG: https://bugzilla.samba.org/show_bug.cgi?id=12446 Signed-off-by: Stefan Metzmacher <metze@samba.org>
* CVE-2016-2125: s4:gensec_gssapi: don't use GSS_C_DELEG_FLAG by defaultStefan Metzmacher2016-12-091-1/+1
| | | | | | | | | | | | This disabled the usage of GSS_C_DELEG_FLAG by default, as GSS_C_DELEG_POLICY_FLAG is still used by default we let the KDC decide if we should send delegated credentials to a remote server. BUG: https://bugzilla.samba.org/show_bug.cgi?id=12445 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org> Reviewed-by: Simo Sorce <idra@samba.org>
* CVE-2016-2125: s3:gse: avoid using GSS_C_DELEG_FLAGStefan Metzmacher2016-12-091-1/+0
| | | | | | | | | | | | We should only use GSS_C_DELEG_POLICY_FLAG in order to let the KDC decide if we should send delegated credentials to a remote server. BUG: https://bugzilla.samba.org/show_bug.cgi?id=12445 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org> Reviewed-by: Simo Sorce <idra@samba.org>
* CVE-2016-2125: s4:scripting: don't use GSS_C_DELEG_FLAG in nsupdate-gssStefan Metzmacher2016-12-091-1/+1
| | | | | | | | | | | This is just an example script that's not directly used by samba, but we should avoid sending delegated credentials to dns servers. BUG: https://bugzilla.samba.org/show_bug.cgi?id=12445 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org> Reviewed-by: Simo Sorce <idra@samba.org>
* CVE-2016-2123: Fix DNS vuln ZDI-CAN-3995Volker Lendecke2016-12-091-0/+9
| | | | | | | | Thanks to Trend Micro's Zero Day Initiative and Frederic Besler for finding this vulnerability with a PoC and a good analysis. Signed-off-by: Volker Lendecke <vl@samba.org> Bug: https://bugzilla.samba.org/show_bug.cgi?id=12409
* VERSION: Bump version up to 4.5.3...Karolin Seeger2016-12-091-2/+2
| | | | | | | and re-enable git snapshots. Signed-off-by: Karolin Seeger <kseeger@samba.org> (cherry picked from commit d869ba094a6fdeeb14c88b176d914e6756d89c52)
* VERSION: Disable git snapshots for the 4.5.2 release.samba-4.5.2Karolin Seeger2016-12-061-1/+1
| | | | Signed-off-by: Karolin Seeger <kseeger@samba.org>
* WHATSNEW: Add release notes for Samba 4.5.2.Karolin Seeger2016-12-061-2/+100
| | | | Signed-off-by: Karolin Seeger <kseeger@samba.org>
* printing: Fix building with CUPS version older than 1.7Andreas Schneider2016-12-061-0/+6
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12183 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Karolin Seeger <kseeger@samba.org>
* s3/smbd: fix the last resort check that sets the file type attributeJeremy Allison2016-12-011-6/+4
| | | | | | | | | | | | | | | | | | | | | | The rule is, a directory (with any other attributes) should always also set FILE_ATTRIBUTE_DIRECTORY, a file should only set FILE_ATTRIBUTE_NORMAL if no other attributes is set. Iow, if a file contains any existing attributes (e.g. FILE_ATTRIBUTE_HIDDEN), don't add in the FILE_ATTRIBUTE_NORMAL attribute. BUG: https://bugzilla.samba.org/show_bug.cgi?id=12436 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Sat Nov 19 11:55:35 CET 2016 on sn-devel-144 (cherry picked from commit a0783e8dd966a0b2d24d2ca5baa6bed3fe5a7d5a) Autobuild-User(v4-5-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-5-test): Thu Dec 1 15:16:56 CET 2016 on sn-devel-144
* nss_wins: Fix errno values for HOST_NOT_FOUNDAndreas Schneider2016-11-301-2/+1
| | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12269 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 08d1ac0e36339e97e4464f6a6724464b0a568347) Autobuild-User(v4-5-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-5-test): Wed Nov 30 16:25:05 CET 2016 on sn-devel-144
* samba_tool/fsmo: Allocate RID Set when seizing RID managerGarming Sam2016-11-302-3/+27
| | | | | | | | | | | | | | | | | | Seizing the role without allocating a RID set for itself is likely prone to cause issues. Pair-programmed-with: Clive Ferreira <cliveferreira@catalyst.net.nz> Signed-off-by: Clive Ferreira <cliveferreira@catalyst.net.nz> Signed-off-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=9954 Autobuild-User(master): Garming Sam <garming@samba.org> Autobuild-Date(master): Fri Nov 4 08:37:05 CET 2016 on sn-devel-144 (cherry picked from commit 815658d2db46e4accdd35f5925585ec1f1c3d74f)
* python-libnet: Use new NTSTATUSError, WERRORError and DsExtendedError exceptionsAndrew Bartlett2016-11-302-15/+103
| | | | | | | | | | | | This will allow callers to catch specific errors rather than RuntimeException As this slightly changes the exception, the timecmd test must be updated. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> BUG: https://bugzilla.samba.org/show_bug.cgi?id=12398 (cherry picked from commit 2a49c7451949d42e5a4d6fce3ce607f05f9e7b71)
* python: Add DsExtendedError ExceptionAndrew Bartlett2016-11-302-0/+9
| | | | | | | | | | | This will be used for checking errors during a GetNCChanges EXOP like RID Set allocation. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> BUG: https://bugzilla.samba.org/show_bug.cgi?id=12398 (cherry picked from commit e51256c7d58040eeee02fc189b55afbc58379f81)
* pyerrors: Add PyErr_Set{WERROR,HRESULT,NTSTATUS}_and_string()Andrew Bartlett2016-11-301-0/+15
| | | | | | | | | | This varient allows control of the text explaination string Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> BUG: https://bugzilla.samba.org/show_bug.cgi?id=12398 (cherry picked from commit e737171f6ef172de559b41d54989eca0d7663b4e)
* python: create NTSTATUSError, HRESULTError and WERRORErrorAndrew Bartlett2016-11-303-3/+36
| | | | | | | | | | | | The advantage of these over the previous use of just RuntimeError is that we can catch just the errors we want, without having to catch all possible RuntimeError cases and assume they decode to a tuple Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> BUG: https://bugzilla.samba.org/show_bug.cgi?id=12398 (cherry picked from commit c8505c53da3e21f31454f121efd5961d95349a38)
* dsdb: Catch errors in extended operations (like allocating a RID Set)Andrew Bartlett2016-11-301-2/+19
| | | | | | | | | There are cases where allocating a RID Set can reasonably fail. Catch those nicely. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> BUG: https://bugzilla.samba.org/show_bug.cgi?id=12398 (cherry picked from commit f72da5ba51ae8bf9f3f54bed36b4572cd1b57adb)
* dsdb: Rework DSDB code to use WERRORAndrew Bartlett2016-11-304-70/+89
| | | | | | | | | | | The WERROR codes are more descriptive for DSDB issues, and almost all the code was converting from WERROR to NTSTATUS. This will allow us to better catch specific errors like WERR_DS_DRA_MISSING_PARENT Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> BUG: https://bugzilla.samba.org/show_bug.cgi?id=12398 (cherry picked from commit 46fefb251f61b274cb687f6d1cb0a0a97fb36b44)
* dsdb: Create RID Set as SYSTEMAndrew Bartlett2016-11-301-2/+6
| | | | | | | | | | | We do not want random users with add-user rights to own the new RID Set for this server, and the ridSet class is thankfully system-only. BUG: https://bugzilla.samba.org/show_bug.cgi?id=9954 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> (cherry picked from commit fe90dadd2cd13c20484c06318724c592e5cf298e)
* dbcheck: Correctly initialise keep_transaction in missing_parent testAndrew Bartlett2016-11-301-1/+1
| | | | | | | | | | | Otherwise there is no point to this variable, we are trying to work out if the subsequent modify succeded Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> BUG: https://bugzilla.samba.org/show_bug.cgi?id=9954 (cherry picked from commit 09537a67b0e761c834fb7c14d7e8d55e07fc5156)
* dbcheck: confirm RID Set presence and consistencyClive Ferreira2016-11-302-1/+132
| | | | | | | | Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> BUG: https://bugzilla.samba.org/show_bug.cgi?id=9954 (cherry picked from commit 7fd5be535ade5ed119d869c8f215aa605aba2125)
* dsdb: Add python hooks to allocate a RID set and allocate a RID poolAndrew Bartlett2016-11-306-3/+154
| | | | | | | | | | This will help us to correct errors during dbcheck Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> BUG: https://bugzilla.samba.org/show_bug.cgi?id=9954 (cherry picked from commit 035df7adbe9cc119324275275c2605433f6c4292)
* tests/ridalloc_exop: Add a new suite of tests for RID allocationGarming Sam2016-11-304-163/+729
| | | | | | | | | | | | | | | | This moves some tests from getnc_exop.py regarding RID sets as well as adding new tests for actions on join. BUG: https://bugzilla.samba.org/show_bug.cgi?id=9954 Pair-programmed-with: Clive Ferreira <cliveferreira@catalyst.net.nz> Signed-off-by: Andrew Bartlett <abartlet@samaba.org> Signed-off-by: Garming Sam <garming@catalyst.net.nz> Signed-off-by: Clive Ferreira <cliveferreira@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 1b40bb69d101b767ee453c96234cc6d573142ab3)
* objectclass_attrs: Only abort on a missing attribute when an attribute is ↵Clive Ferreira2016-11-302-7/+17
| | | | | | | | | | | | | | | | | | | | | | | | | both MUST and replicated If an attribute is not replicated or constructed, it is quite normal for it to be missing. This is the case with both rIDNextRid and rIDPreviousAllocationPool. This currently prevents us switching the RID master. On Windows, missing this attribute does not cause any problems for the RID manager. We may now remove the knownfail entry added earlier. Signed-off-by: Clive Ferreira <cliveferreira@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Pair-programmed-with: Garming Sam <garming@catalyst.net.nz> Pair-programmed-with: Bob Campbell <bobcampbell@catalyst.net.nz> BUG: https://bugzilla.samba.org/show_bug.cgi?id=12394 Autobuild-User(master): Garming Sam <garming@samba.org> Autobuild-Date(master): Wed Nov 2 01:28:44 CET 2016 on sn-devel-144 (cherry picked from commit 79dd22aacb4c12bd008d9ad354ec5ec088560748)
* typo: supprise -> surpriseClive Ferreira2016-11-301-1/+1
| | | | | | | | | Signed-off-by: Clive Ferreira <cliveferreira@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Pair-programmed-with: Garming Sam <garming@catalyst.net.nz> BUG: https://bugzilla.samba.org/show_bug.cgi?id=12394 (cherry picked from commit e0aa05609556cf7bc93d585944542d630862ba0f)
* tests/getnc_exop: Finish a comment in getnc_exop.pyGarming Sam2016-11-301-1/+1
| | | | | | | | Signed-off-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=12394 (cherry picked from commit 4c567932165229e7fa9c33b071e9fabe79d9eef0)
* tests/getnc_exop: Improve the ridalloc test by performing an alloc against a ↵Bob Campbell2016-11-302-0/+77
| | | | | | | | | | | | | | | | new master Currently we fail against ourselves due to rIDNextRid and rIDPreviousAllocationPool normally being unset, despite being mandatory attributes (being the only attributes in this situation). Pair-programmed-with: Garming Sam <garming@catalyst.net.nz> Pair-programmed-with: Clive Ferreira <cliveferreira@catalyst.net.nz> Signed-off-by: Bob Campbell <bobcampbell@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=12394 (cherry picked from commit 37aa11ce5b2b91cd0d84f6c7370d64674fcf5479)
* objectclass_attrs: correctly indent a commentClive Ferreira2016-11-301-6/+7
| | | | | | | | Signed-off-by: Clive Ferreira <cliveferreira@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Pair-programmed-with: Garming Sam <garming@catalyst.net.nz> BUG: https://bugzilla.samba.org/show_bug.cgi?id=12394 (cherry picked from commit a3baf4b8049d222b8be71dce3bc1cd46b8391f73)
* selftest: Ensure we catch errors from samba-tool domain tombstones expungeAndrew Bartlett2016-11-301-1/+1
| | | | | | | | | The previous code would overwrite $? before the return, so always returned 0 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> BUG: https://bugzilla.samba.org/show_bug.cgi?id=12297 (cherry picked from commit 44d209c893d28030cb9928b974c8aa31348ac395)
* dbcheck: Correct message for orphaned backlinksAndrew Bartlett2016-11-301-4/+4
| | | | | | | | | The backlink name is in attrname, not in link_name Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> BUG: https://bugzilla.samba.org/show_bug.cgi?id=12297 (cherry picked from commit 04eb95a46b069f0238dbd232528fd1fadb745066)
* dbcheck: Be more careful with link checksAndrew Bartlett2016-11-302-10/+23
| | | | | | | | | | | | | Here we are more careful when checking links, flagging errors only when a non-deleted forward link appears incorrect. In particular, we trust the GUID more than we trust the name, as otherwise we can get caught out if there is a swap of names, (the link should follow the swap, staying on the same target GUID). Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> BUG: https://bugzilla.samba.org/show_bug.cgi?id=12297 (cherry picked from commit f051e5bf00d6df70048dd0cf901dd7b37be09669)
* selftest: Add test for link and deleted link behaviour in dbcheckAndrew Bartlett2016-11-307-0/+288
| | | | | | | | | | | The other dbcheck tests were getting over-complex, so we start a new test here based on tombestone-expunge.sh, as we are looking at very similar problems Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> BUG: https://bugzilla.samba.org/show_bug.cgi?id=12297 (cherry picked from commit 8315d4d03ac77f1727ff01e87392f6e49ba40def)
* upgradeprovision: Remove objectCategory from constructed attrsGarming Sam2016-11-301-1/+1
| | | | | | | | | | | | | The new dbcheck rules identify an error where the GUID of the objectCategory does not exist (pointing to a non-existent schema object). As objectClass was not copied over either, it makes sense not to copy over the objectCategory. Signed-off-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=12297 (cherry picked from commit 5889f399daad54124e0bb2be1fe81da1df67c84e)
* collect_tombstones: Allow links to recycled objects to be deletedGarming Sam2016-11-302-3/+3
| | | | | | | | | | | | | | | | | | The reason we choose to provide the string DN is because extended_dn_in will try to correct the <GUID=...> by searching on it (despite the fact it does not exist and then failing on a ldb_dn_validate in objectclass_attrs). We can now also remove the dangling link test from the knownfail. Signed-off-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=12385 Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Thu Nov 3 01:46:43 CET 2016 on sn-devel-144 (cherry picked from commit ef7e46d68a6596be6e904caaa04e917c576dd9d3)
* tombstones-expunge: Add a test for deleting links to recycled objectsGarming Sam2016-11-305-8/+27
| | | | | | | | | | | | | | Currently this fails because we rely on a GUID DN, which fails to resolve in the case that the GUID no longer exists in the database (i.e. when that object has been purged after 6 months). The tests use a made up extended DN built from fred where the GUID has been tweaked. Signed-off-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=12385 (cherry picked from commit dba624364cde1c885640386c4e2bca17e9d5297c)
* s4:torture: Fix cleanup of the secrets object in session_key testAndreas Schneider2016-11-301-17/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12433 The test is known to be failing if sealing is turned on in some circumstances. In this case a secret is created and then the function dcerpc_fetch_session_key() fails. The secret is not removed! We use torturesecret-%08x with random() to fill in the number. Sometimes it happens that random() returns a number we already used. So we end up trying to create a secret for an entry which already exists and run into a collision This change makes sure we always cleanup behind us and do not leave secret objects we created. Pair-Programmed-With: Guenther Deschner <gd@samba.org> Signed-off-by: Andreas Schneider <asn@samba.org> Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Nov 17 22:30:36 CET 2016 on sn-devel-144 (cherry picked from commit 9de04626c058563a6cf4c13e4f5399039e345ef5)
* s4:torture: Normalizes names in session_key testAndreas Schneider2016-11-301-1/+1
| | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12433 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 31d21de548d899f82fa7944767ad94e8aca8d96d)
* s4:torture: Strip trailing whitespaces in session_key.cAndreas Schneider2016-11-301-29/+29
| | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12433 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 80f7f568f8960c809756d5233c8f875db4ea07d6)
* s4:torture: Add tortue test for AddPrinterDriverEx with COPY_FROM_DIRECTORYAndreas Schneider2016-11-301-2/+165
| | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12415 Pair-Programmed-With: Guenther Deschner <gd@samba.org> Signed-off-by: Andreas Schneider <asn@samba.org> Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit b1ade58ffeb56a0238c820797905caa107b08265)
* lib:torture: Make variables constAndreas Schneider2016-11-301-4/+4
| | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12415 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 9c0f2576d8aa3dd95be1c5ddda2b10d891add0bc)
* s3:spoolss: Add support for COPY_FROM_DIRECTORY in AddPrinterDriverExAndreas Schneider2016-11-303-20/+96
| | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12415 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 4d9f4bfc69a5899bdf91406dfb7efb70a530446c)
* doc: Add doxygen for functions in srv_keytab.cGarming Sam2016-11-301-0/+47
| | | | | | | Signed-off-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=10882 (cherry picked from commit 683fcad3ca1617a07e9ade82ec7e44ac512ab415)
* s4-auth: Don't check for NULL saltPrincipal if it doesn't need itGarming Sam2016-11-301-6/+6
| | | | | | | | | | This check causes 4.1 domains to be unable to change their DNS backend correctly as they do not have the saltPrincipal value stored. BUG: https://bugzilla.samba.org/show_bug.cgi?id=10882 Signed-off-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit b02da114980d46e9e251a5d3dfbf549ef348548a)
* ctdb-recovery: Avoid NULL dereference in failure caseAmitay Isaacs2016-11-221-0/+1
| | | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12434 Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Mon Nov 21 12:26:04 CET 2016 on sn-devel-144 (cherry picked from commit 54e392b385728bba047404465207340a2e354ec6) Autobuild-User(v4-5-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-5-test): Tue Nov 22 13:56:50 CET 2016 on sn-devel-144
* ctdb-locking: Reset real-time priority in lock helperAmitay Isaacs2016-11-211-0/+2
| | | | | | | | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12392 Earlier we were relying on SCHED_RESET_ON_FORK to reset the priority of lock helper processes. Since SCHED_RESET_ON_FORK support has been removed, the scheduling priority of child processes created using vfork() need to be reset explicitly in the helper processes. Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net> Autobuild-User(master): Martin Schwenke <martins@samba.org> Autobuild-Date(master): Fri Nov 18 10:18:27 CET 2016 on sn-devel-144 (cherry picked from commit 6c6d63c04497fdfdbe665508f2a503f2392dc526) Autobuild-User(v4-5-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-5-test): Mon Nov 21 16:01:26 CET 2016 on sn-devel-144
* s4-torture: add spoolss_SetPrinter ndr test to validate secdesc_ptrGünther Deschner2016-11-181-0/+57
| | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=11197 Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 574dd65a8185c90828e49b295d89153bae1563bf) Autobuild-User(v4-5-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-5-test): Fri Nov 18 12:52:32 CET 2016 on sn-devel-144
* spoolss: Use correct values for secdesc and devmode pointersGünther Deschner2016-11-185-22/+22
| | | | | | | | | | | | | | | | ULONG_PTR needs to be decoded as a uint3264 and not as a 'uint32 *'. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11197 Guenther Pair-Programmed-With: Andreas Schneider <asn@samba.org> Signed-off-by: Guenther Deschner <gd@samba.org> Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 73f664710a8c9b312a54d0cf41d2f4440c8b42eb)
* build: Fix build with perl on debian sid.Andrew Bartlett2016-11-161-1/+2
| | | | | | | | | | | | | | | | | | build: Fix build with perl on debian sid. It appears that "." is no longer in perl_inc BUG: https://bugzilla.samba.org/show_bug.cgi?id=12395 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Martin Schwenke <martin@meltin.net> Autobuild-User(master): Martin Schwenke <martins@samba.org> Autobuild-Date(master): Sat Oct 29 09:32:37 CEST 2016 on sn-devel-144 (cherry picked from commit da67acbcfe2167fce9c360a55416ab10e9537a2a) Autobuild-User(v4-5-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-5-test): Wed Nov 16 12:36:38 CET 2016 on sn-devel-144
View Lorry Controller Status