summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* ctdb-common: Fix CID 1125553 Buffer not null terminated (BUFFER_SIZE_WARNING)Martin Schwenke2016-08-101-1/+1
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12110 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> (cherry picked from commit 763f9c13f2998a8858e8a3ec013d166a3d429835)
* ctdb-tests: Add explicit wait to the fork_helper()Amitay Isaacs2016-08-101-11/+6
| | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12109 To create a client process that waits after connect(), instead of trying to do a blocking write(), go to sleep. The parent can then kill the client process, once testing is done. Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net> (cherry picked from commit 049dd07b909dc56a246799f8a96235989a5a605f)
* ctdb-tests: Clean up and rename simple transaction_loop recovery testMartin Schwenke2016-08-101-14/+4
| | | | | | | | | | | | | | | * Rename to clarify purpose of test * Simplify test info to avoid unnecessary bit-rot * Restart after test since test does heavy database manipulation BUG: https://bugzilla.samba.org/show_bug.cgi?id=12109 Pair-programmed-with: Amitay Isaacs <amitay@gmail.com> Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> (cherry picked from commit 8ce8e1d7f8c05158f0f5f4e673f3d9a40f94f00d)
* ctdb-tests: Clean up and rename simple transaction_loop testMartin Schwenke2016-08-101-13/+2
| | | | | | | | | | | | | * Rename to clarify purpose of test * Simplify test info to avoid unnecessary bit-rot BUG: https://bugzilla.samba.org/show_bug.cgi?id=12109 Pair-programmed-with: Amitay Isaacs <amitay@gmail.com> Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> (cherry picked from commit de04cd578416168290c51f7c4e326b864ab425a4)
* ctdb-tests: Implement --interactive/-i option in transaction_loopMartin Schwenke2016-08-101-6/+13
| | | | | | | | | | | Also add PNNs to output. BUG: https://bugzilla.samba.org/show_bug.cgi?id=12109 Pair-programmed-with: Amitay Isaacs <amitay@gmail.com> Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> (cherry picked from commit 18b41fcb51942ebcd4041fe3e3694712a5a5e43a)
* ctdb-tests: Clean up and rename simple fetch_ring testMartin Schwenke2016-08-103-65/+48
| | | | | | | | | | | | | | | | | | | * Rename to clarify purpose of test * Simplify test info to avoid unnecessary bit-rot * Have fetch_ring print PNN for clearer output and update patterns in test script to suit * Simplify sanity checking pattern due to less data because of --interactive/-i option BUG: https://bugzilla.samba.org/show_bug.cgi?id=12109 Pair-programmed-with: Amitay Isaacs <amitay@gmail.com> Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> (cherry picked from commit c10dcc7b91df62f740a4789763234f8bb2f0a27f)
* ctdb-tests: Implement --interactive/-i option in fetch ringMartin Schwenke2016-08-101-3/+9
| | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12109 Pair-programmed-with: Amitay Isaacs <amitay@gmail.com> Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> (cherry picked from commit 82cffc2f5759fb73bba37e45fc20b24b30ab0438)
* ctdb-tests: Clean up and rename simple message_ring testMartin Schwenke2016-08-103-94/+69
| | | | | | | | | | | | | | | | | | | | | * Rename to clarify purpose of test * Simplify test info to avoid unnecessary bit-rot * Have message_ring print PNN for clearer output and update patterns in test script to suit. * Drop quantitative percentage check since this is hard to predict when under extreme load. To compensate, tighten up expectations for the total number of messages in each direction: at least 10 messages are required over 10 seconds. BUG: https://bugzilla.samba.org/show_bug.cgi?id=12109 Pair-programmed-with: Amitay Isaacs <amitay@gmail.com> Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> (cherry picked from commit e7a220377ec14090435f448c9a900f8f8e852a77)
* ctdb-tests: Implement --interactive/-i option in message_ringMartin Schwenke2016-08-101-5/+9
| | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12109 Pair-programmed-with: Amitay Isaacs <amitay@gmail.com> Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> (cherry picked from commit fbb3ef46b99f4e3ccf710367e50f8b9f89fee52c)
* ctdb-tests: Add --interactive/-i option to test options parsing codeMartin Schwenke2016-08-102-0/+4
| | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12109 Pair-programmed-with: Amitay Isaacs <amitay@gmail.com> Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> (cherry picked from commit b100d78597959ad314e4f4f6816a8ff14100fb6e)
* ctdb-tests: Stop cross-talk between reclock testsMartin Schwenke2016-08-101-0/+11
| | | | | | | | | | | | | | | | | | On a busy system the backgrounded counter reset can survive into the next test and interfere with its result. To avoid this, wait until all forks of 01.reclock exit before continuing on to the next test. BUG: https://bugzilla.samba.org/show_bug.cgi?id=12109 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Mon Aug 1 17:53:27 CEST 2016 on sn-devel-144 (cherry picked from commit 19ed8165bbe374e1ea277fd4dd5a65ee932b4f05)
* ctdb-packaging: Move ctdb tests to libexec directoryMartin Schwenke2016-08-101-2/+2
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12104 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Andreas Schneider <asn@samba.org> (cherry picked from commit 87c38d5d741f5e58f643ad4f797c523c67bbab00)
* ctdb-waf: Move ctdb tests to libexec directoryAndreas Schneider2016-08-101-12/+12
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=12104 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Martin Schwenke <martin@meltin.net> (cherry picked from commit f9c85d04e9edb3af9479e9c83d5b1ec77b9c2ee2)
* man: Wrong option for parameter ldap ssl in smb.conf man pageMarc Muehlfeld2016-08-101-2/+2
| | | | | | | | | | | - "ldap ssl" does not accept the value "yes" - Replaced "start_tls" with "start tls". BUG: https://bugzilla.samba.org/show_bug.cgi?id=12023 Signed-off-by: Marc Muehlfeld <mmuehlfeld@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> (cherry picked from commit 976be8fe39c78acfd3c2a23302d26cc262be0ae0)
* async_req: make async_connect_send() "reentrant"Ralph Boehme2016-08-101-3/+13
| | | | | | | | | | | | | | | | | | | Allow callers to pass in socket fds that where already passed to an earlier call of async_connect_send(). Callers expect this behaviour and it was working until 05d4dbda8357712cb81008e0d611fdb0e7239587 broke it. The proper fix would be to change callers to close the fd and start from scratch with a fresh socket. Bug: https://bugzilla.samba.org/show_bug.cgi?id=12105 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Thu Aug 4 05:03:21 CEST 2016 on sn-devel-144 (cherry picked from commit 9c6a4ea2788808bdcc7bfea798d838ea56c3b5ec)
* docs: Bump version up to 4.5.Karolin Seeger2016-08-1095-95/+95
| | | | Signed-off-by: Karolin Seeger <kseeger@samba.org>
* WHATSNEW: Start release notes for Samba 4.5.0rc2.Karolin Seeger2016-08-101-48/+54
| | | | Signed-off-by: Karolin Seeger <kseeger@samba.org>
* VERSION: Bump version up to 4.5.0rc2...Stefan Metzmacher2016-07-281-2/+2
| | | | | | ...and re-enable git snapshots. Signed-off-by: Stefan Metzmacher <metze@samba.org>
* VERSION: Set version to 4.5.0rc1...samba-4.5.0rc1Stefan Metzmacher2016-07-281-3/+3
| | | | | | and disable git snapshots for 4.5.0rc1 release. Signed-off-by: Stefan Metzmacher <metze@samba.org>
* WHATSNEW: add shadow:snapprefix and shadow:delimiterStefan Metzmacher2016-07-281-0/+24
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* shadow_copy2: Fix error handling in shadow_copy2_get_shadow_copy_dataRajesh Joseph2016-07-281-18/+16
| | | | | | | | | | | Memory was freed in most of the failure cases. It is always better to free the memory at the end of the function so that all exit path of the function will free the memory. Otherwise chances are that you might miss some cleanup. Signed-off-by: Rajesh Joseph <rjoseph@redhat.com> Reviewed-by: Uri Simchoni <uri@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* shadow_copy2: update man pages for the newly introduced optionsRajesh Joseph2016-07-281-1/+35
| | | | | | | | | shadow:snapprefix and shadow:delimiter are the two newly added options in shadow copy. Update man pages explaining the two options. Signed-off-by: Rajesh Joseph <rjoseph@redhat.com> Reviewed-by: Uri Simchoni <uri@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* shadow_copy2: Add test case for snapprefix and delimiterRajesh Joseph2016-07-282-1/+32
| | | | | | | | | Add test case for the newly addded option shadow:snapprefix and shadow:delimiter Signed-off-by: Rajesh Joseph <rjoseph@redhat.com> Reviewed-by: Uri Simchoni <uri@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* shadow_copy2: allow configurable prefix for snapshot nameRajesh Joseph2016-07-281-7/+303
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | With growing number of snapshots file-systems need some mechanism to differentiate one set of snapshots from other, e.g. monthly, weekly, manual, special events, etc. Therefore these file-systems provide different ways to tag snapshots, e.g. provide a configurable way to name snapshots, which is not just based on time. With only shadow:format it is very difficult to filter these snapshots. As part of this change added two new options, shadow:snapprefix and shadow:delimiter, in shadow_copy2 config. This option will accept regular expression (BRE) as input. With this optional parameter, one can specify a variable prefix component for names of the snapshot directories in the file-system. If this parameter is set, together with the shadow:format and shadow:delimiter parameters it determines the possible names of snapshot directories in the file-system. e.g. shadow:snapprefix = [a-z]*[0-9] When this option is provided then shadow:format option should always start with <delimiter> string. This delimiter is configurable via a new option, i.e. shadow:delimiter. Default value for this is "_GMT", e.g. _GMT-%Y.%m.%d-%H.%M.%S Signed-off-by: Rajesh Joseph <rjoseph@redhat.com> Reviewed-by: Uri Simchoni <uri@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* shadow_copy2: create structure to store module specific informationRajesh Joseph2016-07-281-23/+57
| | | | | | | | | | | | | Create a separate structure to store module specific information. Currently only config values are saved. As of now there is no cleaner way to store run-time information or other module specific information in shadow_copy2 module. Therefore created a new structure to store all module specific information including config. Signed-off-by: Rajesh Joseph <rjoseph@redhat.com> Reviewed-by: Uri Simchoni <uri@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* shadow_copy2: Add test cases to cover shadow:formatRajesh Joseph2016-07-282-0/+79
| | | | | | | | | Added test cases which will filter snapshot names based on shadow:format option in smb.conf Signed-off-by: Rajesh Joseph <rjoseph@redhat.com> Reviewed-by: Uri Simchoni <uri@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* shadow_copy2: Fix shadow_copy2_posix_gmt_string return typeRajesh Joseph2016-07-281-6/+6
| | | | | | | | | This function returns -1 on error but the return type is size_t which is unsigned. Signed-off-by: Rajesh Joseph <rjoseph@redhat.com> Reviewed-by: Uri Simchoni <uri@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* ldb: version 1.1.27ldb-1.1.27Stefan Metzmacher2016-07-285-2/+271
| | | | | | | | | * performance improvements * VLV control improvements * build fixes Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
* ldb: Use ldb_unpack_data_only_attr_list_flags in re_index()Andrew Bartlett2016-07-281-1/+6
| | | | | | | This avoids allocation of every value during a re-index scan Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
* ldb: fix compiler warnings on ldb_unpack_data() argumentsStefan Metzmacher2016-07-282-2/+10
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
* ldb: Add flags to ltdb_search_dn1() to control memory allocationAndrew Bartlett2016-07-285-21/+63
| | | | | | | | | | | This is used in the index code in particular to avoid an allocation per value (as there may be one value per DB object at times Pair-Programmed-With: Stefan Metzmacher <metze@samba.org> Signed-off-by: Andrew Bartlett <abartlet@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
* ldb: Prepare for adding flags to ltdb_search_dn1() to control memory allocationAndrew Bartlett2016-07-281-1/+9
| | | | | | | | Because the memory layout will change in the next commit, we need to add a talloc_steal() of msg, which holds the memory on one big chunk. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
* ldb: Add ldb_unpack_data_only_attr_list_flags()Andrew Bartlett2016-07-284-24/+138
| | | | | | | | | | | | This function allows us to control allocation of memory during parse of the packed ldb data. This in turn can have an important performance impact as each small allocation can have a large overhead Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
* ldb: Free empty index lists as talloc_realloc() fails in this caseAndrew Bartlett2016-07-281-1/+6
| | | | | | | | | talloc_realloc() requires that we know the correct parent to do the 0 -> free behaviour and we do not have the correct parent here, list->dn may be a child of the module->idxptr cache. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
* ldb_tdb index: fix whitespaceDouglas Bagnall2016-07-281-27/+27
| | | | | Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* torture: Add tests for ndr_push_struct_into_fixed_blob()Andrew Bartlett2016-07-281-0/+110
| | | | | Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* dsdb: Limit potential stack use when parsing extended DNsAndrew Bartlett2016-07-281-9/+15
| | | | | Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* lib/ldb-samba: Avoid talloc() in ldif_read_objectSid() by parsing the SID ↵Andrew Bartlett2016-07-281-15/+23
| | | | | | | string on the stack Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* lib/ldb-samba: Use ndr_push_struct_into_fixed_blob() in ldif_handlers.cAndrew Bartlett2016-07-281-2/+9
| | | | | | | | This avoids a number of pointless and pointlessly-large allocations in inner loops. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* librpc: Add ndr_push_struct_into_fixed_blob() and use it in GUID_to_ndr_blob()Andrew Bartlett2016-07-285-4/+310
| | | | | | | | This allows us to allocate only the correct size, not a default of 1024 bytes per push. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
* WHATSNEW: document new samba-tool drs replicate optionsStefan Metzmacher2016-07-281-0/+11
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Garming Sam <garming@samba.org>
* tests:samba_tool_drs: test samba-tool drs replicate with --async-opStefan Metzmacher2016-07-281-0/+23
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Garming Sam <garming@samba.org>
* tests:samba_tool_drs: test samba-tool drs replicate with implicit machine ↵Stefan Metzmacher2016-07-281-1/+12
| | | | | | | credentials Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Garming Sam <garming@samba.org>
* samba-tool: add --async-rep option to 'samba-tool drs replicate'Stefan Metzmacher2016-07-281-4/+11
| | | | | | | We may not want to wait for the replication to finish. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Garming Sam <garming@samba.org>
* samba-tool: use a timeout of 5 minutes in 'samba-tool drs replicate'Stefan Metzmacher2016-07-281-3/+4
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Garming Sam <garming@samba.org>
* s4:pyrpc: correctly implement .request_timeoutStefan Metzmacher2016-07-281-7/+26
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Garming Sam <garming@samba.org>
* rpc_server/drsuapi: Don't set msDS_IntId as attid for linked attributes if ↵Garming Sam2016-07-282-5/+8
| | | | | | | schema Signed-off-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* getncchanges: Set is_schema_nc when EXOP_OBJGarming Sam2016-07-281-2/+3
| | | | | Signed-off-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* msds_intid: Add test for schema linked attributesGarming Sam2016-07-282-1/+87
| | | | | | | | | | This test only covers the forward link case. NOTE: We can't confirm this against Windows because they prevent us from modifying the schema for the schema classes. Signed-off-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* replmd: Send replicated update OID for forward linksGarming Sam2016-07-281-1/+50
| | | | | | | (The backward link case needs to be tested) Signed-off-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>