summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* kdc:db-glue: ignore KRB5_PROG_ETYPE_NOSUPP also for Primary:KerberosStefan Metzmacher2020-08-072-7/+12
| | | | | | | | | | | | | | | | | | | | | | | Currently we only ignore KRB5_PROG_ETYPE_NOSUPP for Primary:Kerberos-Newer-Keys, but not for Primary:Kerberos. If a service account has msDS-SupportedEncryptionTypes: 31 and DES keys stored in Primary:Kerberos, we'll pass the DES key to smb_krb5_keyblock_init_contents(), but may get KRB5_PROG_ETYPE_NOSUPP. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14354 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Isaac Boukris <iboukris@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Tue Jul 28 14:04:26 UTC 2020 on sn-devel-184 (cherry picked from commit 4baa7cc8e473f6b63316b4ae5db34796c0f864c3) Autobuild-User(v4-13-test): Stefan Metzmacher <metze@samba.org> Autobuild-Date(v4-13-test): Fri Aug 7 10:39:26 UTC 2020 on sn-devel-184
* Add a test with old msDS-SupportedEncryptionTypesIsaac Boukris2020-08-073-0/+71
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14354 Signed-off-by: Isaac Boukris <iboukris@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit 07399831794e28c7c2cf0140d0f1d1b5538b5f60)
* VERSION: Bump version up to 4.13.0rc2...Stefan Metzmacher2020-08-061-2/+2
| | | | | | and re-enable GIT_SNAPSHOT. Signed-off-by: Stefan Metzmacher <metze@samba.org>
* VERSION: Disable GIT_SNAPSHOT for the 4.13.0rc1 release.samba-4.13.0rc1Karolin Seeger2020-07-091-3/+3
| | | | Signed-off-by: Karolin Seeger <kseeger@samba.org>
* WHATSNEW: Add release notes for Samba 4.13.0rc1.Karolin Seeger2020-07-091-1/+3
| | | | Signed-off-by: Karolin Seeger <kseeger@samba.org>
* s3:smbd: skip ctdb public ips in fsctl_network_iface_info()Stefan Metzmacher2020-07-081-0/+28
| | | | | | | | | | | | | Multi-Channel clients should not connect to ctdb public ip addresses (which move between nodes). BUG: https://bugzilla.samba.org/show_bug.cgi?id=11898 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Wed Jul 8 17:16:40 UTC 2020 on sn-devel-184
* s3:smbd: disconnect the all client connections if a ctdb public ip droppedStefan Metzmacher2020-07-083-0/+36
| | | | | | | | | | | For now we keep it simple and any disconnect on a connection that used a ctdb public address, will disconnect all other remaining connections. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11898 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3:smbd: make smbXsrv_client_connection_pass_loop() more robustStefan Metzmacher2020-07-081-9/+22
| | | | | | | | | Don't leak fds in the error paths. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11898 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3:smbd: make sure smbXsrv_connection_disconnect_transport() closes the ↵Stefan Metzmacher2020-07-082-2/+7
| | | | | | | | | | | | socket fd I assumed that TALLOC_FREE(xconn->transport.fde) would close the socket, but until now we didn't use tevent_fd_set_auto_close(). BUG: https://bugzilla.samba.org/show_bug.cgi?id=11898 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3:smbd: make sure we detect stale smbXsrv_connection pointers in ↵Stefan Metzmacher2020-07-082-0/+6
| | | | | | | | | | | | | | | | | | smbXsrv_session_auth0 Pointer values can be reused (yes, I hit that during my testing!). Introduce a channel_id to identify connections and also add some timestamps to make debugging easier. This makes smbXsrv_session_find_auth() much more robust. This is a similar change as 0cec96526bf4d3209caf36c4a19632ff5d5dd112: "smb2_server: make sure we detect stale smbXsrv_connection pointers in smbXsrv_channel_global" BUG: https://bugzilla.samba.org/show_bug.cgi?id=11898 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3:smbd: fill in xconn->client early in smbd_add_connection()Stefan Metzmacher2020-07-081-2/+1
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=11898 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3:smbd: handle NETWORK_ACCESS_DENIED in smbXsrv_client_connection_pass_loop()Stefan Metzmacher2020-07-081-0/+4
| | | | | | | | | | | | smbd_add_connection() may return a valid connection together with NT_STATUS_NETWORK_ACCESS_DENIED. We need additional cleanup for that case. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11898 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3:smbd: consistently use DLIST_ADD* to fill client->connections in ↵Stefan Metzmacher2020-07-081-1/+1
| | | | | | | | | | | | smbd_add_connection() We should not just overwrite the client->connections pointer if we reject the connection. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11898 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3:ctdbd_conn: add ctdbd_control_get_public_ips() and ctdbd_find_in_public_ips()Stefan Metzmacher2020-07-083-0/+92
| | | | | | | | | | These will be used in the multi channel code in order to handle public ip addresses, which can move arround ctdb nodes. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11898 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3:ctdbd_conn: make use of samba_sockaddr in ctdbd_connect()Stefan Metzmacher2020-07-081-9/+16
| | | | | | | | | | This avoids compiler warnings like this: dereferencing type-punned pointer might break strict-aliasing rules [-Wstrict-aliasing] BUG: https://bugzilla.samba.org/show_bug.cgi?id=11898 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3:ctdbd_conn: make use of ctdbd_control_local() in ctdbd_register_ips()Stefan Metzmacher2020-07-081-4/+4
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=11898 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* selftest/Samba3: make use of 'smbd:FSCTL_SMBTORTURE = yes'Stefan Metzmacher2020-07-082-1/+1
| | | | | | | | | | | | | | | This makes sure the lease/oplock break retry logic based on missing TCP acks is tested. We're still not able to run multichannel tests automatically, as socket wrapper doesn't support fd-passing yet. But this testing this with single channels is a good start. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3:smbd: implement FSCTL_SMBTORTURE_FORCE_UNACKED_TIMEOUTStefan Metzmacher2020-07-084-3/+98
| | | | | | | | | | | | This will be used by smbtorture in order to simulate channel failures without relying on iptables. 'smbd:FSCTL_SMBTORTURE = yes' is required in order to active this. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3:smbd: make use of the new ack infrastructure for oplock/lease breaksStefan Metzmacher2020-07-081-17/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This finally implements the retry of failed oplock/lease breaks. Before smbd_smb2_break_send/recv completed directly after sendmsg() passed the pdu to the kernel. Now the completion is (at least) deferred until the the next smbXsrv_connection_ack_checker() run happens and smbd_smb2_send_queue_ack_bytes() found that all bytes of the break notification left the kernel send queue (and were TCP acked). If the connection is disconnected all pending break notifications are completed with an error, which is then returned by smbd_smb2_break_recv(). smbXsrv_pending_break_submit() will then submit another break notification via the next available connection/channel. The smbXsrv_connection_ack_checker() runs each rto_usecs (between 0.2s and 1.0s). smbd_smb2_break_send() will set a timeout of 6*rto_usecs (between 1.2s and 6s). If smbXsrv_connection_ack_checker() detects via smbd_smb2_send_queue_ack_bytes() that a pending break notification is pending for more than its timeout we'll disconnect the connection with NT_STATUS_IO_TIMEOUT. This will be handled as any other disconnect and will in turn also trigger the retry on the next channel. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3:smbd: force multi-channel to be turned off without FreeBSD/Linux supportStefan Metzmacher2020-07-084-1/+35
| | | | | | | | | | | | | | | | | For now it's safer to disable multi-channel without having support for TIOCOUTQ/FIONWRITE on tcp sockets. Using a fixed retransmission timeout (rto) of 1 second would be ok, but we better require kernel support for requesting for unacked bytes in the kernel send queue. "force:server multi channel support = yes" can be used to overwrite the compile time restriction (mainly for testing). BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3:smbd: add infrastructure to wait for TCP acksStefan Metzmacher2020-07-083-1/+365
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will be the core of the logic that allows us to retry break notifications. When we start the "pending break cycle" we ask for the current retransmission timemout (rto) on the TCP connection and remember how many unacked bytes are in the kernel's send queue. Each time we send bytes into the kernel we add them to the unacked bytes. We use a timer using the rto interval in order to check the amount of unacked bytes again. The provides send_queu_entry.ack.req will be completed with tevent_req_done() when everything is completely acked, tevent_req_nterror(NT_STATUS_IO_TIMEOUT) when send_queu_entry.ack.timeout is expired or tevent_req_nterror(connection_error) when the connection gets disconnected. It works with support from the FreeBSD and Linux kernels. For other platforms we just have a fixed rto of 1 second. And pretend all bytes are acked when we recheck after 1 second. So only a connection error could trigger tevent_req_nterror(), but there's no timeout. A follow up commit will most likely disable support for multi-channel if we don't have kernel support. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3:smbd: add logic to retry break notifications on all available channelsStefan Metzmacher2020-07-081-2/+116
| | | | | | | | | | | | | | | | For leases we need to use any available connection with the same client_guid. That means all connections in the client->connections list. We try the oldest connection first, as that's what windows is doing. For oplocks we implement the same as that's what the specification says. Windows behaves different and we have 'smb2 disable oplock break retry = yes' in order to behave like Windows. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* docs-xml/smbdotconf: add "smb2 disable oplock break retry"Stefan Metzmacher2020-07-081-0/+39
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3:smbd: convert smbd_smb2_send_break() into async smbd_smb2_break_send/recv()Stefan Metzmacher2020-07-081-28/+91
| | | | | | | | | | | | | | This will make it possible to detect errors in order to retry sending the break on another connection. For now we always report NT_STATUS_OK, when we delivered the break notification to the kernel send queue. But that will change in the following commits. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3:smbd: add smbd_smb2_send_queue.sendfile_body_sizeStefan Metzmacher2020-07-082-0/+2
| | | | | | | | | The following patches require the size of the full sendfile() pdu. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3:smbd: introduce smbXsrv_pending_break infrastructureStefan Metzmacher2020-07-081-14/+67
| | | | | | | | | | | | This prepares support for oplock/lease break replay from the server to the client. We need some state in order to do replays later. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3:smbd: avoid dereferencing client->connectionsStefan Metzmacher2020-07-084-9/+7
| | | | | | | | | There're typically better ways to get the same information. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3:smbd: setup client->global->client_guid even without multichannel supportStefan Metzmacher2020-07-081-0/+6
| | | | | | | | | | It's too confusing if client->global->client_guid and client->connections->smb2.client.guid don't have the same value. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3:smbd: pass down smbXsrv_client to smbd_smb2_send_{oplock,lease}_break()Stefan Metzmacher2020-07-084-18/+13
| | | | | | | | | Which connection is actually used should not matter to the main logic. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3:smbd: pass smbXsrv_client to downgrade_lease()Stefan Metzmacher2020-07-083-10/+12
| | | | | | | | | | This prepares for multichannel support, where breaks are not bound to a single connection. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3:smbd: add smbd_server_disconnect_client[_ex]()Stefan Metzmacher2020-07-082-0/+24
| | | | | | | | | | | | | | | | | | With multichannel things may not happen only on one connection. We may need to disconnect all connections of a client, when something bad happens. The first users of this will be the lease/oplock break code, if they are not able allocate memory or something similar we need to bail out. Having a special smbXsrv_client based function is better than calling exit_server*() directly. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3:smbd: remove unused session,tcon parameters from ↵Stefan Metzmacher2020-07-083-28/+12
| | | | | | | | | | | | | smbd_smb2_send_oplock_break() They are no longer used. However we'll make use of op->compat->vuid in the next commits, as the session id should be part of oplock breaks. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3:smbd: pass down session_id to smbd_smb2_send_break()Stefan Metzmacher2020-07-081-5/+12
| | | | | | | | | | Oplock break should contain a valid session id of the open file handle, as file handles are relative to a session. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3:smbd: remove dead code from smbd_smb2_send_break()Stefan Metzmacher2020-07-081-55/+6
| | | | | | | | | | | Starting with commit 0a924d13cf4bb570cce3955cf0de9d8678b37dbe ("smbd: Send SMB2 oplock breaks unencrypted") we always passed in session=NULL and tcon=NULL. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s4:torture/smb2: add smb2.multichannel.oplocks.test3{_windows,specification}Stefan Metzmacher2020-07-081-0/+459
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is similar to the smb2.multichannel.leases.test5, but it tests the oplock case instead of leases. With Oplocks Windows only sends a single break on the latest channel, this is not what the spec says... Maybe we should have a similar test that would expect the behavior from the [MS-SMB2] (3/4/2020 rev 60.0) "3.3.4.6 Object Store Indicates an Oplock Break": ... If the server implements the SMB 3.x dialect family, SMB2 Oplock Break Notification MUST be sent to the client using the first available connection in Open.Session.ChannelList where Channel.Connection is not NULL. If the server fails to send the notification to the client, the server MUST retry the send using an alternate connection, if available, in Open.Session.ChannelList. ... Here I add one test that demonstrates the Windows behavior: smb2.multichannel.oplocks.test3_windows and a 2nd test that demonstrates the behavior from MS-SMB2. smb2.multichannel.oplocks.test3_specification Note that Windows 10 seems to behave differently and it's not possible to open all 32 channel used by this test. Against remote servers it's required to run iptables as root: #> smbtorture //server/torture -Uu%p \ --option="torture:use_iptables=yes" \ --option="torture:iptables_command=sudo /sbin/iptables" \ smb2.multichannel.oplocks.test3_windows #> smbtorture //server/torture -Uu%p \ --option="torture:use_iptables=yes" \ --option="torture:iptables_command=sudo /sbin/iptables" \ smb2.multichannel.oplocks.test3_specification The test will also work against a Samba server with 'smbd:FSCTL_SMBTORTURE = yes', and won't require iptables in that case. Samba will get a "smb2 disable oplock break retry" configuration option to switch between both behaviors, as it's much more common with Samba that leases are not supported and clients will fallback to oplocks together with multichannel. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s4:torture/smb2: (re-)add smb2.multichannel.leases.test4Stefan Metzmacher2020-07-081-0/+298
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This tests 32 channels, which is the maximum Windows Server versions support. (Note that Windows 10 (a Client OS as SMB server, seems to support only 20 channels and may differ in other aspects, so we ignore that for now). This works at least against Windows Server 2019 and we see lease break notification retries every ~ 1.3 seconds with ~ 5 TCP retransmissions. At that rate we see the remaining 5 retries after the conflicting SMB2 Create already returned. Older Windows Server versions use much longer timeouts in the TCP-stack, they send lease break notification retries less often and only 4 in total, all other channels get TCP-RST packets because of missing TCP keepalive packets before they're used. The intervals between lease break notification retries are ~19 seconds for 2012[_R2] and ~25 seconds for 2016. It means that only ~2 lease break notifications arrive before the open returns after ~35 seconds. Note that Windows 10 seems to behave differently and it's not possible to open all 32 channel used by this test. Against remote servers it's required to run iptables as root: #> smbtorture //server/torture -Uu%p \ --option="torture:use_iptables=yes" \ --option="torture:iptables_command=sudo /sbin/iptables" \ smb2.multichannel.leases.test4 The test will also work against a Samba server with 'smbd:FSCTL_SMBTORTURE = yes', and won't require iptables in that case. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s4:torture/smb2: remove useless 'smb2.multichannel.leases.test4'Stefan Metzmacher2020-07-081-190/+0
| | | | | | | | | | | | | | Having a test that would only pass against Samba makes things way to complex, they're already complex and we should try to behave like windows as much as possible. The next commit will add a better test that will work against Windows Servers and the future Samba servers. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s4:torture/smb2: fix smb2.multichannel.leases.test2 against windowsStefan Metzmacher2020-07-081-1/+11
| | | | | | | | | | | We still receive the break on the blocked channel, it's only the response ACKs, which we are blocking (or simulate to block). BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s4:torture/smb2: split smb2.oplock.batch22 into a and bStefan Metzmacher2020-07-083-6/+102
| | | | | | | | | | batch22a tests the timeout on a valid connection and batch22b tests the timeout on a broken/blocked connection. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s4:torture/smb2: move smb2_transport blocking to the generic block.[ch]Stefan Metzmacher2020-07-083-225/+236
| | | | | | | | | We may want to use this in other places too, not only multichannel.c BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s4:torture/smb2: make use of FSCTL_SMBTORTURE_FORCE_UNACKED_TIMEOUTStefan Metzmacher2020-07-081-24/+131
| | | | | | | | | This is a way to test without being able to use iptables. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s4:torture/smb2: refactor block.c to block the OUTPUT pathStefan Metzmacher2020-07-083-246/+116
| | | | | | | | | | | | In order to create useful tests, we should block the outgoing tcp packets only. That means we're able to see incoming break notifications, but prevent outgoing TCP ACKs to be delivered to the server. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s4:torture/smb2: add break_info.oplock_skip_ackStefan Metzmacher2020-07-082-0/+5
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s4:torture/smb2: move interface_info test to smb2.multichannel.genericGünther Deschner2020-07-081-1/+1
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s4:torture/smb2: make use of transport_options.only_negprot for multichannel ↵Stefan Metzmacher2020-07-081-3/+14
| | | | | | | | | | | connections This avoid useless session setups and tree connects on the wire. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s4:torture/smb2: simplify code to generate list of smb2 channelsGünther Deschner2020-07-081-46/+60
| | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Pair-Programmed-With: Stefan Metzmacher <metze@samba.org> Signed-off-by: Guenther Deschner <gd@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s4:torture/smb2: add const to options for test_multichannel_create_channel()Stefan Metzmacher2020-07-081-1/+1
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s4:libcli/smb2: add const to struct smbcli_options *options for smb2_connect()Stefan Metzmacher2020-07-081-1/+1
| | | | | | | | | | It will just be passed to smb2_connect_ext(), which already takes a const pointer. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s4:libcli/smb2: allow smb2_connect*() to fake session and tconStefan Metzmacher2020-07-082-0/+10
| | | | | | | | | | | For multichannel connection we want a way to have just a connection with a negprot finished. For now we just fake a tcon and session in order to avoid changes in the caller. We can clean that up later if needed. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s4:param: use struct initializer in lpcfg_smbcli_session_options()Stefan Metzmacher2020-07-081-3/+5
| | | | | | | We should zero all fields not initialiazed explicitly. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
View Lorry Controller Status