summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * CVE-2020-14303 Ensure an empty packet will not DoS the NBT serverAndrew Bartlett2020-06-252-0/+20
| | | | | | | | Signed-off-by: Andrew Bartlett <abartlet@samba.org>
| * CVE-2020-10745: ndr/dns-utils: prepare for NBT compatibilityDouglas Bagnall2020-06-257-77/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | NBT has a funny thing where it sometimes needs to send a trailing dot as part of the last component, because the string representation is a user name. In DNS, "example.com", and "example.com." are the same, both having three components ("example", "com", ""); in NBT, we want to treat them differently, with the second form having the three components ("example", "com.", ""). This retains the logic of e6e2ec0001fe3c010445e26cc0efddbc1f73416b. Also DNS compression cannot be turned off for NBT. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14378 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
| * CVE-2020-10745: dns_util/push: forbid names longer than 255 bytesDouglas Bagnall2020-06-252-2/+9
| | | | | | | | | | | | | | | | As per RFC 1035. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14378 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
| * CVE-2020-10745: ndr_dns: do not allow consecutive dotsDouglas Bagnall2020-06-253-2/+6
| | | | | | | | | | | | | | | | | | | | The empty subdomain component is reserved for the root domain, which we should only (and always) see at the end of the list. That is, we expect "example.com.", but never "example..com". BUG: https://bugzilla.samba.org/show_bug.cgi?id=14378 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
| * CVE-2020-10745: ndr/dns_utils: correct a commentDouglas Bagnall2020-06-251-1/+1
| | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14378 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
| * CVE-2020-10745: ndr_dns: move ndr_push_dns_string core into sharable functionDouglas Bagnall2020-06-254-75/+99
| | | | | | | | | | | | | | | | | | | | | | This is because ndr_nbt.c does almost exactly the same thing with almost exactly the same code, and they both do it wrong. Soon they will both be using the better version that this will become. Though in this patch we just move the code, not fix it. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14378 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
| * CVE-2020-10745: librpc/tests: cmocka tests of dns and ndr stringsDouglas Bagnall2020-06-254-0/+252
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These time the push and pull function in isolation. Timing should be under 0.0001 seconds on even quite old hardware; we assert it must be under 0.2 seconds. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14378 (backported from master commit) [abartlet@samba.org: backported due to differences in pre-existing tests - eg test_ndr - mentioned in wscript_build and tests.py] Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
| * CVE-2020-10745: pytests: hand-rolled invalid dns/nbt packet testsDouglas Bagnall2020-06-253-0/+223
| | | | | | | | | | | | | | | | | | | | | | | | The client libraries don't allow us to make packets that are broken in certain ways, so we need to construct them as byte strings. These tests all fail at present, proving the server is rendered unresponsive, which is the crux of CVE-2020-10745. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14378 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
| * ldb: Bump version to 2.1.4ldb-2.1.4Gary Lockyer2020-06-253-1/+287
| | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14364 Signed-off-by: Gary Lockyer <gary@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
| * CVE-2020-10730: lib ldb: Check if ldb_lock_backend_callback called twiceGary Lockyer2020-06-251-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | Prevent use after free issues if ldb_lock_backend_callback is called twice, usually due to ldb_module_done being called twice. This can happen if a module ignores the return value from function a function that calls ldb_module_done as part of it's error handling. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14364 Signed-off-by: Gary Lockyer <gary@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
| * CVE-2020-10730: s4 dsdb vlv_pagination: Prevent repeat call of ldb_module_doneGary Lockyer2020-06-251-12/+49
| | | | | | | | | | | | | | | | | | | | Check the return code from vlv_results, if it is not LDB_SUCCESS ldb_module_done has already been called, and SHOULD NOT be called again. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14364 Signed-off-by: Gary Lockyer <gary@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
| * CVE-2020-10730: s4 dsdb paged_results: Prevent repeat call of ldb_module_doneGary Lockyer2020-06-251-9/+34
| | | | | | | | | | | | | | | | | | | | Check the return code from paged_results, if it is not LDB_SUCCESS ldb_module_done has already been called, and SHOULD NOT be called again. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14364 Signed-off-by: Gary Lockyer <gary@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
| * CVE-2020-10730: dsdb: Ban the combination of paged_results and VLVAndrew Bartlett2020-06-251-0/+10
| | | | | | | | | | | | | | | | | | | | This (two different paging controls) makes no sense and fails against Windows Server 1709. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14364 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
| * CVE-2020-10730: dsdb: Fix crash when vlv and paged_results are combinedAndrew Bartlett2020-06-251-0/+4
| | | | | | | | | | | | | | | | | | | | The GUID is not returned in the DN for some reason in this (to be banned) combination. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14364 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
| * CVE-2020-10730: selftest: Add test to show that VLV and paged_results are ↵Andrew Bartlett2020-06-252-0/+50
| | | | | | | | | | | | | | | | | | | | | | incompatible As tested against Windows Server 1709 BUG: https://bugzilla.samba.org/show_bug.cgi?id=14364 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
| * CVE-2020-10730: vlv: Another workaround for mixing ASQ and VLVAndrew Bartlett2020-06-251-4/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | This is essentially an alternative patch, but without the correct behaviour. Instead this just avoids a segfault. Included in case we have something simialr again in another module. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14364 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
| * CVE-2020-10730: selftest: Add test to confirm VLV interaction with ASQAndrew Bartlett2020-06-251-0/+27
| | | | | | | | | | | | | | | | | | Tested against Windows 1709. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14364 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
| * CVE-2020-10730: vlv: Do not re-ASQ search the results of an ASQ search with VLVAndrew Bartlett2020-06-251-0/+11
| | | | | | | | | | | | | | | | | | | | This is a silly combination, but at least try and keep the results sensible and avoid a double-dereference. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14364 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
| * CVE-2020-10730: vlv: Use strcmp(), not strncmp() checking the NULL ↵Andrew Bartlett2020-06-251-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | terminated control OIDs The end result is the same, as sizeof() includes the trailing NUL, but this avoids having to think about that. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14364 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
| * VERSION: Bump version up to 4.12.4...Karolin Seeger2020-06-251-2/+2
| | | | | | | | | | | | | | and re-enable GIT_SNAPSHOT. Signed-off-by: Karolin Seeger <kseeger@samba.org> (cherry picked from commit 11abc955736af2e398cb0f208ab47bde9fadee60)
* | s3: msdfs: Fix missing struct stat return on msdfs links by doing an LSTAT call.Jeremy Allison2020-06-262-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This (unfortunately) re-exposes the fact the msdfs links are symlinks, bit fixing this correctly requires a VFS ABI change which we can't do for a released stream. Remove the knownfail.d/msdfs-attr file. Everything now passes. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14391 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-12-test): Fri Jun 26 11:18:10 UTC 2020 on sn-devel-184
* | s3: torture: Add test for getting attibutes on an MSDFS link.Jeremy Allison2020-06-262-0/+30
| | | | | | | | | | | | | | | | | | | | Mark as knownfail for now. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14391 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> (back ported from commit 2a4705129d06b91023bc3fc435fccf91d3939553)
* | s3: torture: Add a MSDFS-ATTRIBUTE test.Jeremy Allison2020-06-261-0/+79
| | | | | | | | | | | | | | | | | | | | Framework to drive comes next. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14391 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> (cherry picked from commit 84134812e3447317125ae08b2a98848a2e4bbd65)
* | s3: libsmb: Info level SMB_FIND_EA_SIZE encodes attibutes as a uint16, not a ↵Jeremy Allison2020-06-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | uint8. We will need this to detect FILE_ATTRIBUTE_REPARSE_POINT in a later commit. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14391 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> (cherry picked from commit 6463f2612a662f217af18455206afde122323375)
* | s3: libsmb: Info level SMB_FIND_INFO_STANDARD encodes attibutes as a uint16, ↵Jeremy Allison2020-06-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | not a uint8. We will need this to detect FILE_ATTRIBUTE_REPARSE_POINT in a later commit. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14391 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> (cherry picked from commit be52f87c376a8f71b2de4aa52f25818cad2b160e)
* | s3: libsmb: Info level SMB_FIND_FILE_BOTH_DIRECTORY_INFO encodes attibutes ↵Jeremy Allison2020-06-261-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | as a uint32, not a uint8. Cast to a uint16_t for now after pulling the information as finfo->mode is currently only 16 bits. We will need this to detect FILE_ATTRIBUTE_REPARSE_POINT in a later commit. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14391 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> (cherry picked from commit 5e3e6c4c0c70e171607f4b5351bd8ec146730f08)
* | s3: libsmb: Info level SMB2_FIND_ID_BOTH_DIRECTORY_INFO encodes attibutes as ↵Jeremy Allison2020-06-261-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | a uint32, not a uint8. Fix the SMB2 parsing code. Cast to a uint16_t for now after pulling the information as finfo->mode is currently only 16 bits. We will need this to detect FILE_ATTRIBUTE_REPARSE_POINT in a later commit. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> (cherry picked from commit 3063e1601ad9e2536651a75a47ebf4921ffddbdc)
* | s3: smbd: Allow a SHUTDOWN_CLOSE on a file with outstanding aio if there are ↵Jeremy Allison2020-06-262-2/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | no client connections alive. The process is exiting now so pthreads will never complete to cause problems. Remove the knownfail.d/aio_outstanding entry. Followup-bugfix for: BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Jun 24 20:14:15 UTC 2020 on sn-devel-184 (cherry picked from commit 205653732064ecf76d3198451240af468806ec14)
* | s3: smbd: Add smbXsrv_client_valid_connections().Jeremy Allison2020-06-262-0/+15
| | | | | | | | | | | | | | | | | | | | Next commit will make use of this. Followup-bugfix for: BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org>
* | s3: selftest: Add samba3.blackbox.aio-outstanding test.Jeremy Allison2020-06-263-0/+102
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Shows smbd panics if connection is terminated (torn down) by killing the client with outstanding aio requests in the queue. As we're closing smbd we should cope with this. Followup-bugfix for: BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> (cherry picked from commit f206d37f6ec8143b2051a8fe15783c188344adbe)
* | ldb_ldap: fix off-by-one increment in lldb_add_msg_attrAlexander Bokovoy2020-06-241-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix regression introduced by commit ce2bf5c72b6423fff680b3d6a9042103a6cdda55 lldb_add_msg_attr() calls ldb_msg_add_empty() which, in turn, calls calls _ldb_msg_add_el() which already increments msg->num_elements by one. As a result, msg->num_elements is bigger than the actual number of elements and any iteration over elements would step over elements array boundary. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14413 Signed-off-by: Alexander Bokovoy <ab@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Fri Jun 19 08:35:33 UTC 2020 on sn-devel-184 (cherry picked from commit 990a0fc4a0481aed817fad7575d8df453fbe7af9) Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-12-test): Wed Jun 24 11:22:16 UTC 2020 on sn-devel-184
* | lib/ldb: add unit test for ldb_ldap internal codeAlexander Bokovoy2020-06-242-0/+119
| | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14413 Signed-off-by: Alexander Bokovoy <ab@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> (cherry picked from commit 36bd6edd8a603f3aa34aff81c43ef26efd3ad4cf)
* | Fix usage of ldap_get_values_len for msDS-AdditionalDnsHostNameIsaac Boukris2020-06-241-2/+6
| | | | | | | | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14406 Signed-off-by: Isaac Boukris <iboukris@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Mon Jun 22 09:59:04 UTC 2020 on sn-devel-184
* | Properly handle msDS-AdditionalDnsHostName returned from Windows DCIsaac Boukris2020-06-242-6/+35
| | | | | | | | | | | | | | | | | | | | | | Windows DC adds short names for each specified msDS-AdditionalDnsHostName attribute, but these have a suffix of "\0$" and thus fail with ldap_get_values(), use ldap_get_values_len() instead. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14406 Signed-off-by: Isaac Boukris <iboukris@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* | selftest: add tests for binary msDS-AdditionalDnsHostNameIsaac Boukris2020-06-242-0/+25
| | | | | | | | | | | | | | | | | | Like the short names added implicitly by Windows DC. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14406 Signed-off-by: Isaac Boukris <iboukris@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* | Fix a typo in recent net man page changesIsaac Boukris2020-06-241-1/+1
| | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14406 Signed-off-by: Isaac Boukris <iboukris@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* | libcli ldap tests: remove use of zero length arrayGary Lockyer2020-06-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | libcli/ldap/tests/ldap_message_test.c defines a zero length array (uint8_t buf[0]), which is a GCC extension and breaks the build with some strict compilers like xlc. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14387 Signed-off-by: Gary Lockyer <gary@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Tue Jun 23 02:15:35 UTC 2020 on sn-devel-184 (cherry picked from commit d701bc1518766f36b1c7a3a00a82485098a8ee3d)
* | Add net-ads-join dnshostname=fqdn optionIsaac Boukris2020-06-045-3/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14396 Signed-off-by: Isaac Boukris <iboukris@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Fri May 29 13:33:28 UTC 2020 on sn-devel-184 Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-12-test): Thu Jun 4 13:12:27 UTC 2020 on sn-devel-184
* | Add msDS-AdditionalDnsHostName entries to the keytabIsaac Boukris2020-06-044-2/+71
| | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14396 Signed-off-by: Isaac Boukris <iboukris@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* | Add a test for msDS-AdditionalDnsHostName entries in keytabIsaac Boukris2020-06-042-0/+11
| | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14396 Signed-off-by: Isaac Boukris <iboukris@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* | Refactor ads_keytab_add_entry() to make it iterableIsaac Boukris2020-06-041-90/+107
| | | | | | | | | | | | | | | | | | so we can more easily add msDS-AdditionalDnsHostName entries. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14396 Signed-off-by: Isaac Boukris <iboukris@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* | Fix accidental overwrite of dnsHostName by the last netbios aliasIsaac Boukris2020-06-042-4/+3
| | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14396 Signed-off-by: Isaac Boukris <iboukris@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* | Add a test to check dNSHostName with netbios aliasesIsaac Boukris2020-06-042-0/+16
| | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14396 Signed-off-by: Isaac Boukris <iboukris@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* | s3:libads: prefer ENCTYPE_AES256_CTS_HMAC_SHA1_96 in ads_keytab_add_entry()Stefan Metzmacher2020-06-041-3/+3
| | | | | | | | | | | | | | | | | | This is currently not critical as we only use keytabs only as acceptor, but in future we'll also use them for kinit() and there we should prefer the newest type. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* | docs-xml: update list of posible VFS operations for vfs_full_auditBjörn Jacke2020-06-041-14/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | the list of valid operations can be generated by grep "{ SMB_VFS_OP_" source3/modules/vfs_full_audit.c |sed 's/.*,[ \t]*"//;s/".*//'|grep -v NULL | sort BUG: https://bugzilla.samba.org/show_bug.cgi?id=14386 based on 14470e4e4c16cfc36384027c39c1685dea42ad26 in master Signed-off-by: Bjoern Jacke <bjacke@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* | s3: libsmbclient: Finish unifing bad iconv behavior across CORE NT1 SMB2 ↵Jeremy Allison2020-06-042-4/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | protocols. On bad name conversion, exit the directory listing with an error, but leave the connection intact. We were already checking for finfo->name == NULL here, but were ignoring it and not reporting an error. Remove the knownfail.d/bad_iconv file as we now behave the same across CORE/NT1/SMB2. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14374 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Tue May 12 21:32:44 UTC 2020 on sn-devel-184 (cherry picked from commit 393da520e43bd3a28feb231bcd9fd5308a3daa4a)
* | s3: libsmb: In SMB2 return NT_STATUS_INVALID_NETWORK_RESPONSE if name ↵Jeremy Allison2020-06-042-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | conversion ended up with a NULL filename. Can happen if namelen == 0. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14374 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> (cherry picked from commit 753115a8d19f6ac8cd28305748fc6d888679dccc)
* | s3: libsmb: In SMB1 old protocol - return NT_STATUS_INVALID_NETWORK_RESPONSE ↵Jeremy Allison2020-06-041-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | if name conversion ended up with a NULL filename. Can happen if namelen == 0. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14374 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> (cherry picked from commit b10de0bb64fe022e6b066584013dfb0bdf2ade96)
* | s3: selftest: Add test_smbclient_iconv.sh to check client behavior on bad ↵Jeremy Allison2020-06-043-0/+62
| | | | | | | | | | | | | | | | | | | | | | | | | | name conversion. SMB2 and NT1 fail this, CORE already returns NT_STATUS_INVALID_NETWORK_RESPONSE on bad conversion. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14374 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> (back-ported from commit e016671d34c24c4768df774425ec743b88e30015)
* | s3: selftest: Add share definition [bad_iconv] in fileserver.Jeremy Allison2020-06-041-0/+20
| | | | | | | | | | | | | | | | | | | | | | Creates a utf8 valid filename within that is invalid in CP850. Useful to test smbclient list directory character set conversions. https://bugzilla.samba.org/show_bug.cgi?id=14374 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> (back-ported from commit a9651d6bc2b6dea8adc859ce21c2431253868887)
View Lorry Controller Status