summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* winbind: handle MSG_SMB_CONF_UPDATED in the winbinds childrenRalph Boehme2021-01-281-0/+22
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14602 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 072ef48001710ed8326c83295f2d3cc301d27cfe)
* winbind: set logfile after reloading configRalph Boehme2021-01-281-3/+3
| | | | | | | | | | lp_load_global() will overwrite whatever we've set with lp_set_logfile(). BUG: https://bugzilla.samba.org/show_bug.cgi?id=14602 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 0c4497f8c66d0ea7c68d42c19e859932ebc3e2ac)
* winbind: move config-reloading code to winbindd_dual.cRalph Boehme2021-01-283-17/+28
| | | | | | | | | | In preperation of forwarding MSG_SMB_CONF_UPDATED to all childs. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14602 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 81edc65e79aba121db800ec53aadd766e61a0001)
* script/release.sh: always select the GPG key by it's IDKarolin Seeger2021-01-221-2/+2
| | | | | | | | | Signed-off-by: Karolin Seeger <kseeger@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit 715b208b513035269a6523f8543c4bf328a7c0f2) Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-12-test): Fri Jan 22 14:09:07 UTC 2021 on sn-devel-184
* ReleaseKey: add GnuPG key transition statement for the Samba release keyKarolin Seeger2021-01-221-0/+27
| | | | | | Signed-off-by: Karolin Seeger <kseeger@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit 38a278b1afedd6c0a6de0fd4f08008e83f8597a9)
* script/release.sh: Use new GPG key.Karolin Seeger2021-01-221-3/+3
| | | | | Signed-off-by: Karolin Seeger <kseeger@samba.org> (cherry picked from commit 2f6cea063ddf52d77037644d612bbc209837e707)
* s3: smbd: Add call to conn_setup_case_options() to create_conn_struct_as_root().Jeremy Allison2021-01-201-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | Ensures temporary DFS share doesn't leave the case parameters set as zero (i.e.: conn->case sensitive = 0 conn->share_case_preserve = 0 and default case is lower which can cause problems doing a DFS_GET_REFERRALS request). BUG: https://bugzilla.samba.org/show_bug.cgi?id=14612 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Anoop C S <anoopcs@samba.org> Autobuild-User(master): Anoop C S <anoopcs@samba.org> Autobuild-Date(master): Wed Jan 13 18:14:31 UTC 2021 on sn-devel-184 (cherry picked from commit 39ce73321093a0a5e25f574d0d32d7f88892de46) Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-12-test): Wed Jan 20 11:29:51 UTC 2021 on sn-devel-184
* s3: smbd: Factor out setting up case parameters for a share to a function - ↵Jeremy Allison2021-01-203-10/+21
| | | | | | | | | | | | conn_setup_case_options(). Will allow it to be reused in the msdfs temporary share code. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14612 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Anoop C S <anoopcs@samba.org> (cherry picked from commit ab7700177c2badbf8ed649985be8029223b6e946)
* build: remove smbd_conn private libraryRalph Boehme2021-01-201-6/+1
| | | | | | | | | | | This is not needed anymore since 6822baa2920f30374ec84363497d97e24f359fab. Needed here for: BUG: https://bugzilla.samba.org/show_bug.cgi?id=14612 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 80ac7fa7c4c728bef4f947872c090fec35fb26f0)
* libcli/smb: allow unexpected padding in SMB2 IOCTL responsesStefan Metzmacher2021-01-181-1/+18
| | | | | | | | | | | | | | | | | | | | | A NetApp Ontap 7.3.7 SMB server add 8 padding bytes to an offset that's already 8 byte aligned. RN: Work around special SMB2 IOCTL response behavior of NetApp Ontap 7.3.7 BUG: https://bugzilla.samba.org/show_bug.cgi?id=14607 Pair-Programmed-With: Volker Lendecke <vl@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org> Signed-off-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Fri Jan 15 08:36:34 UTC 2021 on sn-devel-184 (cherry picked from commit 4c6c71e1378401d66bf2ed230544a75f7b04376f) Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-12-test): Mon Jan 18 08:57:48 UTC 2021 on sn-devel-184
* libcli/smb: split out smb2cli_ioctl_parse_buffer()Stefan Metzmacher2021-01-181-80/+110
| | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14607 Pair-Programmed-With: Volker Lendecke <vl@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org> Signed-off-by: Volker Lendecke <vl@samba.org> (cherry picked from commit 508ed5b42c23f8b3d9730d838bd921cb73c61358)
* libcli/smb: Allow smb2cli_validate_negotiate_info_done() to ignore ↵Jeremy Allison2021-01-181-0/+25
| | | | | | | | | | | | | | | | | NT_STATUS_INVALID_PARAMETER. This can be returned from NetApp Ontap 7.3.7 SMB server implementations. Now we have ensured smb2_signing_check_pdu() cannot return NT_STATUS_INVALID_PARAMETER on a signing error it's safe to check this error code here. Windows 10 clients ignore this error from the NetApp. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14607 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit 0abb5ca6b96c843909dea56d5594e334547ae90f)
* libcli/smb: Change some checks to SMB_ASSERTSStefan Metzmacher2021-01-181-7/+2
| | | | | | | | | | | If we end up here, it's definitely a programming error in the basic parsing layer of the SMB2 packet. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14607 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> (cherry picked from commit fdcdfceefdd3186ef0b70bb6e83dddc8f4c073db)
* WHATSNEW: Remove superfluous line.Karolin Seeger2021-01-181-1/+0
| | | | Signed-off-by: Karolin Seeger <kseeger@samba.org>
* VERSION: Bump version up to 4.12.12...Karolin Seeger2021-01-141-2/+2
| | | | | | and re-enable GIT_SNAPSHOT. Signed-off-by: Karolin Seeger <kseeger@samba.org>
* VERSION: Disable GIT_SNAPSHOT for the 4.12.11 release.samba-4.12.11Karolin Seeger2021-01-141-1/+1
| | | | Signed-off-by: Karolin Seeger <kseeger@samba.org>
* WHATSNEW: Add release notes for Samba 4.11.11.Karolin Seeger2021-01-141-3/+90
| | | | Signed-off-by: Karolin Seeger <kseeger@samba.org>
* vfs_fruit: fix close for fake_fdRalph Boehme2021-01-131-4/+10
| | | | | | | | | | | | | | | | | | | If the next backend doesn't use kernel fd's should not pass a fake_fd to the next backend. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14596 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri Jan 8 21:38:18 UTC 2021 on sn-devel-184 (back-ported from commit 564b62a6f7c0a9b9712946d723118122b9c3785f) Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-12-test): Wed Jan 13 13:45:00 UTC 2021 on sn-devel-184
* vfs_fruit: check fake_fd in fruit_pread_meta_stream()Ralph Boehme2021-01-131-0/+5
| | | | | | | | | | | | | Don't call into the next VFS backend if we know we still have a fake-fd. Just return -1 and the caller has the logic to handle this, which results in returning a AFP_AfpInfo blob initialized with some defaults. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14596 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (back-ported from commit c5da08422990dfc1e082bc01aa10d6e415eebe3f)
* vfs_fruit: use "fake_fd" instead of "created"Ralph Boehme2021-01-131-10/+1
| | | | | | | | | | | Both have basically the same semantics. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14596 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (back-ported from commit 36eb30fd7d4b82bffd0e1ab471c088f678d700a4)
* vfs_streams_xattr: make use of vfs_fake_fd_close()Stefan Metzmacher2021-01-131-2/+2
| | | | | | | | | | | | | | When we used vfs_fake_fd() we should use vfs_fake_fd_close() in order to have things symetric. That may allows us to change vfs_fake_fd() internally if required. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14596 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (back-ported from commit 40e70cbd3c3a1df9205a7b18d07784c1754cc340)
* vfs_fruit: make use of vfs_fake_fd_close()Stefan Metzmacher2021-01-131-2/+2
| | | | | | | | | | | | | | When we used vfs_fake_fd() we should use vfs_fake_fd_close() in order to have things symetric. That may allows us to change vfs_fake_fd() internally if required. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14596 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (back-ported from commit 719c83b4dc4cef16429ec2803621039545f6885e)
* s3:smbd: add vfs_fake_fd_close() helperStefan Metzmacher2021-01-132-0/+11
| | | | | | | | | | | | | | | When we used vfs_fake_fd() we should use vfs_fake_fd_close() in order to have things symetric. This makes code easier to understand and may allow us to change vfs_fake_fd() internally if required. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14596 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (back-ported from commit 8f057333466b2d9845cd8bc2b794d98252ade2a4)
* s3:lib: Create the cache path of user gencache recursivelyAndreas Schneider2021-01-131-1/+1
| | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14601 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Jan 6 23:59:58 UTC 2021 on sn-devel-184 (cherry picked from commit 38c989fab78c3baade3e441829b7becf6b25ef3f)
* lib:util: Add directory_create_or_exists_recursive()Andreas Schneider2021-01-133-7/+165
| | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14601 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> from commit bf7b165877bdfd07eb84ecafdc87bd7a6d945f09)
* vfs_virusfilter: Allocate separate memory for config char*Arne Kreddig2021-01-131-9/+57
| | | | | | | | | | | | | | | | Instead of using only the pointer to the configuration char* from the global configuration, vfs_virusfilter now allocates its own memory and copies the char* from the global configuration. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14606 Signed-off-by: Arne Kreddig <arne@kreddig.net> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Jan 7 19:25:38 UTC 2021 on sn-devel-184 (cherry picked from commit 2f21d1b0ac8526508161de73290f67858b2fe668)
* Do not create an empty DB when accessing a sam.ldbAndrew Bartlett2021-01-071-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | Samba already does this for samba-tool and doing this should make our errors more sensible, particularly in BIND9 if not provisioned with the correct --dns-backend=DLZ_BIND9 The old error was like: named[62954]: samba_dlz: Unable to get basedn for /var/lib/samba/private/dns/sam.ldb - NULL Base DN invalid for a base search. The new error will be like (in this case from the torture test): Failed to connect to Failed to connect to ldb:///home/abartlet/samba/st/chgdcpass/bind-dns/dns/sam.ldb: Unable to open tdb '/home/abartlet/samba/st/chgdcpass/bind-dns/dns/sam.ldb': No such file or directory: Operations error BUG: https://bugzilla.samba.org/show_bug.cgi?id=14579 Reviewed-by: Andreas Schneider <asn@samba.org> Signed-off-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit d49e96bc45ea5e2d3364242dad36fe9094b7cc42) Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-12-test): Thu Jan 7 09:50:29 UTC 2021 on sn-devel-184
* bootstrap: Cope with case changes in CentOS 8 repo namesMartin Schwenke2021-01-064-4/+6
| | | | | | | | | | | | RN: Be more flexible with repository names in CentOS 8 test environments BUG: https://bugzilla.samba.org/show_bug.cgi?id=14594 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (backported from commit 1c59f49aaede8ec1662d4e49aef84fcd902a8a76) Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-12-test): Wed Jan 6 12:19:21 UTC 2021 on sn-devel-184
* lib: Avoid declaring zero-length VLAs in various messaging functionsDimitry Andric2021-01-051-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | In messaging_rec_create(), messaging_recv_cb() and messaging_dispatch_rec(), variable length arrays of file descriptors are declared using an incoming num_fds parameter. However, there are several scenarios where num_fds can be zero, and declaring a zero-length VLA is undefined behavior. This can lead to segmentation faults and/or other crashes when compiling with recent versions of clang at high optimization levels. To avoid ever using zero as the length for these declarations, use MAX(1, length) instead. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14605 Signed-off-by: Dimitry Andric <dimitry@andric.com> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Mon Jan 4 10:50:07 UTC 2021 on sn-devel-184 (cherry picked from commit 3e96c95d41e4ccd0bf43b3ee78af644e2bc32e30) Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-12-test): Tue Jan 5 09:11:44 UTC 2021 on sn-devel-184
* vfs_zfsacl: add missing inherited flag on hidden "magic" everyone@ ACERalph Boehme2020-12-091-1/+2
| | | | | | | | | | | | | | | | | This was an omission in the fixes for bug 14470. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14587 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Tue Dec 1 20:29:34 UTC 2020 on sn-devel-184 (cherry picked from commit 936f74daed0d6221312f651f35c4ed357bbf1414) Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-12-test): Wed Dec 9 11:45:09 UTC 2020 on sn-devel-184
* vfs_zfsacl: reformattingRalph Boehme2020-12-091-2/+3
| | | | | | | | | | No change in behaviour. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14587 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit a8457ac3c80e22588e33a343c2306b702734ca88)
* s4/samba: call force_check_log_size() in standard_new_task()Ralph Boehme2020-12-091-0/+2
| | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14248 RN: samba process does not honor max log size Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Mon Dec 7 18:54:29 UTC 2020 on sn-devel-184 (cherry picked from commit 058f96f4c4eda42b404f0067521d3eafb495fe7d)
* s4/samba: call force_check_log_size() in standard_accept_connection()Ralph Boehme2020-12-091-0/+2
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14248 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 6fa5fb8ef26dab862df5c46bb5e74f19839c30e2)
* s4/samba: call force_check_log_size() in prefork_reload_after_fork()Ralph Boehme2020-12-091-0/+1
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14248 Signed-off-by: Ralph Boehme <slow@samba.org> (cherry picked from commit 82b64e930b0e2d3b2e5186017d9f8e420994136c)
* s4: call reopen_logs_internal() in the SIGHUP handler of the prefork process ↵Ralph Boehme2020-12-091-1/+1
| | | | | | | | | | | | | model With debug_schedule_reopen_logs() the actual reopen only takes place at some point in the future when a DEBUG message is processed. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14248 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 19413e76a46f07fdd46fde5e60707bb6845a782d)
* s4: replace low-level SIGUP handler with a tevent handlerRalph Boehme2020-12-091-0/+29
| | | | | | | | | | | | Replace the low-level signal handler for SIGHUP with a nice tevent signal handler. The low-level handler sig_hup() installed by setup_signals() remains being used during early startup before a tevent context is available. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14248 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 9f71e6173ab43a04804ba8061cb0e8ae6c0165bf)
* s4: install tevent tracing hooks to trigger logfile rotationRalph Boehme2020-12-093-2/+33
| | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14248 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (backported from commit 516c2a04a242a539f9fbddb2822295fee233644c) [slow@samba.org: process_prefork.c has additional include in master]
* s4: add samba server tevent trace helper stuffRalph Boehme2020-12-093-0/+131
| | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14248 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (backported from commit 68f71f227b17774a12c84575c1eecd82279fac95) [slow@samba.org: conflict due to rename source4/smbd/ -> source4/samba/ in master]
* debug: detect logrotation by checking inode numberRalph Boehme2020-12-091-2/+29
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14248 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 3651a51e93b45104323d5db1d5ea704d4f71acf1)
* debug: pass struct debug_class *config to do_one_check_log_size()Ralph Boehme2020-12-091-13/+9
| | | | | | | | | | | Pass a pointer to the struct instead of all struct members individually. No change in behaviour. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14248 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit b7ee36146458bcc2c944f5670b7632df8281ae61)
* debug: pass struct debug_class *config to reopen_one_log()Ralph Boehme2020-12-091-6/+6
| | | | | | | | | | | Pass a pointer to the struct instead of all struct members individually. No change in behaviour. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14248 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 29cd139a32d5dbf36bef68eb9c7f1160201e3042)
* loadparm: setup debug subsystem setting max_log_size from configRalph Boehme2020-12-091-0/+1
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14248 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit ab2c712c016f4e4dacd5064b9eb8f6417f4b9b60)
* s3: smbd: Quiet log messages from usershares for an unknown share.Jeremy Allison2020-12-091-0/+10
| | | | | | | | | | | | | | | | | No need to log missing shares/sharenames at debug level zero. Keep the debug level zero for all other usershare problems. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14590 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Rowland penny <rpenny@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri Dec 4 20:54:06 UTC 2020 on sn-devel-184 (cherry picked from commit 8a0a7359faba642baf55a8f98ff78c0d0884d0f0)
* vfs_glusterfs: print exact cmdline for disabling write-behind translatorGünther Deschner2020-12-022-3/+10
| | | | | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14486 Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Anoop C S <anoopcs@samba.org> Autobuild-User(master): Günther Deschner <gd@samba.org> Autobuild-Date(master): Fri Nov 27 17:15:07 UTC 2020 on sn-devel-184 (cherry picked from commit 369c1d539837b70e94fe9d533d44860c8a9380a1) Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-12-test): Wed Dec 2 17:35:21 UTC 2020 on sn-devel-184
* manpages/vfs_glusterfs: Mention silent skipping of write-behind translatorAnoop C S2020-12-021-0/+5
| | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14486 Signed-off-by: Anoop C S <anoopcs@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org> Autobuild-User(master): Günther Deschner <gd@samba.org> Autobuild-Date(master): Mon Nov 9 13:30:06 UTC 2020 on sn-devel-184 (cherry picked from commit be03ce7d8bb213633eedcfc3299b8d9865a3c67f)
* vfs_shadow_copy2: Preserve all open flags assuming ROFSAnoop C S2020-11-191-2/+2
| | | | | | | | | | | | | | | | | | Instead of replacing open flags with just O_RDONLY, filter out all those flags unrelated to a Read Only File System BUG: https://bugzilla.samba.org/show_bug.cgi?id=14573 Signed-off-by: Anoop C S <anoopcs@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Thu Nov 12 17:23:19 UTC 2020 on sn-devel-184 (cherry picked from commit e9e06a11daf036abf7a7022ebc8eaefde178aa52) Autobuild-User(v4-12-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-12-test): Thu Nov 19 14:09:43 UTC 2020 on sn-devel-184
* s3: spoolss: Make parameters in call to user_ok_token() match all other uses.Jeremy Allison2020-11-191-1/+2
| | | | | | | | | | | | | | | We already have p->session_info->unix_info->unix_name, we don't need to go through a legacy call to uidtoname(p->session_info->unix_token->uid). BUG: https://bugzilla.samba.org/show_bug.cgi?id=14568 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Mon Nov 9 04:10:45 UTC 2020 on sn-devel-184 (cherry picked from commit e5e1759057a767f517bf480a2172a36623df2799)
* s3: smbd: Don't overwrite contents of fsp->aio_requests[0] with NULL via ↵Jeremy Allison2020-11-191-1/+13
| | | | | | | | | | | | | | | | | | | TALLOC_FREE(). They may have been carefully set by the aio_del_req_from_fsp() destructor so we must not overwrite here. Found via some *amazing* debugging work from Ashok Ramakrishnan <aramakrishnan@nasuni.com>. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14515 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Wed Sep 30 11:18:43 UTC 2020 on sn-devel-184 (cherry picked from commit fca8cb63762faff54cda243c1ed8217b36333131)
* interface: fix if_index is not parsed correctlyJones Syue2020-11-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace probed_ifaces[i] with ifs. In SDC 2020 SMB3 Virtual IO Lab, run Windows Protocol Test Suite to test FileServer multichannel test cases. Samba server has 2 virtual interfaces for VPN connection: > name=tun2001, ip/mask=192.168.144.9/22 > name=tun2002, ip/mask=192.168.144.10/22 test suite client can ping these 2 ip addresses and browse shares. Then client try to use IOCTL FSCTL_QUERY_NETWORK_INTERFACE_INFO to get the virtual ip addresses of samba server, but samba server responded it without the virtual ip addresses. My VPN setup is point-to-point and the virtual interfaces 'tun2001' & 'tun2002' are without flag IFF_BROADCAST. So edit smb.conf and add "interfaces = ${virtual_ip}/${mask_length};if_index=${id}", like this: > interfaces = eth4 eth8 eth11 eth10 qvs0 "192.168.144.9/22;if_index=50" "192.168.144.10/22;if_index=51" then samba server IOCTL response could return the virtual ip addresses, but found a issue: the interface index of virtual ip addresses is always 4294967295 (0xFFFFFFFF, -1). Quote Metze: https://gitlab.com/samba-team/devel/samba/-/commit/6cadb55d975a6348a417caed8b3258f5be2acba4#note_419181789 This looks good, I think that also explains the possible memory corruption/crash I mentioned in the bug report. As 'i' is most likely the same as 'total_probed' and probed_ifaces[i] is not valid, so we overwrite unrelated memory. Later I see 'realloc(): invalid pointer' and this backtrace: BACKTRACE: #0 log_stack_trace + 0x29 [ip=0x7f2f1b6fffa9] [sp=0x7ffcd0ab53e0] #1 smb_panic + 0x11 [ip=0x7f2f1b700301] [sp=0x7ffcd0ab5d10] #2 sig_fault + 0x54 [ip=0x7f2f1b7004f4] [sp=0x7ffcd0ab5e20] #3 funlockfile + 0x50 [ip=0x7f2f17ce6dd0] [sp=0x7ffcd0ab5ec0] #4 gsignal + 0x10f [ip=0x7f2f1794970f] [sp=0x7ffcd0ab6b90] #5 abort + 0x127 [ip=0x7f2f17933b25] [sp=0x7ffcd0ab6cb0] #6 __libc_message + 0x297 [ip=0x7f2f1798c897] [sp=0x7ffcd0ab6de0] #7 malloc_printerr + 0x1c [ip=0x7f2f17992fdc] [sp=0x7ffcd0ab6ef0] #8 realloc + 0x23a [ip=0x7f2f17997f6a] [sp=0x7ffcd0ab6f00] #9 _talloc_realloc + 0xee [ip=0x7f2f1a365d2e] [sp=0x7ffcd0ab6f50] #10 messaging_filtered_read_send + 0x18c [ip=0x7f2f1a10f54c] [sp=0x7ffcd0ab6fb0] #11 messaging_read_send + 0x55 [ip=0x7f2f1a10f705] [sp=0x7ffcd0ab7000] #12 smb2srv_session_table_init + 0x83 [ip=0x7f2f1b3a6cd3] [sp=0x7ffcd0ab7040] #13 smbXsrv_connection_init_tables + 0x2d [ip=0x7f2f1b373f4d] [sp=0x7ffcd0ab7060] #14 smbd_smb2_request_process_negprot + 0x827 [ip=0x7f2f1b38cb47] [sp=0x7ffcd0ab7080] #15 smbd_smb2_request_dispatch + 0x19db [ip=0x7f2f1b38921b] [sp=0x7ffcd0ab71d0] #16 smbd_smb2_process_negprot + 0x298 [ip=0x7f2f1b38bb38] [sp=0x7ffcd0ab7260] #17 process_smb + 0x2ca [ip=0x7f2f1b37537a] [sp=0x7ffcd0ab72b0] #18 smbd_server_connection_read_handler + 0xd0 [ip=0x7f2f1b376420] [sp=0x7ffcd0ab7350] BUG: https://bugzilla.samba.org/show_bug.cgi?id=14514 Signed-off-by: Jones Syue <jonessyue@qnap.com> Reviewed-by: Ralph Boehme <slow@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit b78ff5717654064c8a4facc54a8e9833e5843c21)
* s3: modules: gluster. Fix the error I made in preventing talloc leaks from a ↵Jeremy Allison2020-11-191-8/+12
| | | | | | | | | | | | | | | | | | | | | | | function. file_lines_parse() plays horrible tricks with the passed-in talloc pointers and the hierarcy which makes freeing hard to get right. As we know mem_ctx is freed by the caller, after calling file_lines_parse don't free on exit and let the caller handle it. This violates good Samba coding practice but we know we're not leaking here. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14486 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org> Autobuild-User(master): Günther Deschner <gd@samba.org> Autobuild-Date(master): Wed Nov 11 15:02:27 UTC 2020 on sn-devel-184 (cherry picked from commit 457b49c67803dd95abc8502c2a410fac273f6fba)
View Lorry Controller Status