summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* .travis.yml: install python3-{crypto,dev,dnspython}Stefan Metzmacher2016-02-151-1/+1
| | | | | | | autobuild will use --extra-python=/usr/bin/python3 in future. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* .travis.yml: install python-cryptoStefan Metzmacher2016-02-151-1/+1
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* .travis.yml: we don't require python-all-devStefan Metzmacher2016-02-151-1/+1
| | | | | | | python-dev is enough. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* .travis.yml: we require 'realpath' nowStefan Metzmacher2016-02-151-1/+1
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* .travis.yml: do a sort -u on the installed packagesStefan Metzmacher2016-02-151-1/+1
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* ldb:ABI: add missing pyldb-util.py3-1.1.25.sigsStefan Metzmacher2016-02-151-0/+2
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* smbd: fix build with FAM supportRalph Boehme2016-02-141-0/+1
| | | | | | | | | | | | Add missing define of HAVE_FAM when FAM is detected. Bug: https://bugzilla.samba.org/show_bug.cgi?id=11733 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Sun Feb 14 13:50:56 CET 2016 on sn-devel-144
* smbd: fix build with FAM supportRalph Boehme2016-02-142-2/+2
| | | | | | | | | | | Rename _fam_watch() to fam_watch(). I don't see a reason why this should be prefixed with an underscore. It's also inline with the corresponding inotify function inotify_watch(). Bug: https://bugzilla.samba.org/show_bug.cgi?id=11733 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* lib/socket: Fix improper use of default interface speedAnoop C S2016-02-131-1/+1
| | | | | | | | | | | | | | | | | | | _get_interfaces() function from interfaces.c uses if_speed variable to store interface speed and is initialized with a default value at start. But if_speed populated via one iteration for a specific IP address will be treated as the default value for next iteration which is wrong. Therefore change is to move the initialization cum declaration of if_speed inside iteration of IP addresses loop. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11734 Signed-off-by: Anoop C S <anoopcs@redhat.com> Reviewed-by: Michael Adam <obnox@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Sat Feb 13 16:22:22 CET 2016 on sn-devel-144
* lib:socket: fix CID 1350009 - illegal memory accesses (BUFFER_SIZE_WARNING)Michael Adam2016-02-131-0/+5
| | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=11735 Pair-Programmed-With: Guenther Deschner <gd@samba.org> Signed-off-by: Michael Adam <obnox@samba.org> Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Uri Simchoni <uri@samba.org>
* smbd: Simplify chroot option in smbdAndreas Schneider2016-02-131-8/+15
| | | | | | | | | | | | | | | | rpmlint has a check for this and prefers to call chdir() before chroot(). If not it will complain with missing-call-to-chdir-with-chroot. The old code equivalent secure. See http://unixwiz.net/techtips/chroot-practices.html This removes several unneeded talloc_tos() calls. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Sat Feb 13 03:50:54 CET 2016 on sn-devel-144
* s3-waf: Install smbspool_krb5_wrapper in LIBEXECDIRAndreas Schneider2016-02-131-0/+1
| | | | | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Martin Schwenke <martin@meltin.net> Autobuild-User(master): Martin Schwenke <martins@samba.org> Autobuild-Date(master): Sat Feb 13 00:41:33 CET 2016 on sn-devel-144
* s3:winbindd/idmap_autorid_tdb fix a compiler warningChristian Ambach2016-02-121-1/+1
| | | | | | | | | | about a potentially uninitialized variable Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Fri Feb 12 12:07:07 CET 2016 on sn-devel-144
* s3:vfs_fruit fix a compiler warningChristian Ambach2016-02-121-1/+1
| | | | | | | about a potentially uninitialized variable Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s4:torture/ntlmssp fix a compiler warningChristian Ambach2016-02-121-3/+0
| | | | | | | about invalid array subscript Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s4:heimdal fix a compile warningChristian Ambach2016-02-121-2/+2
| | | | | | | about a potentially uninitialized variable Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* util: Update GPL header of talloc_stack.hAndreas Schneider2016-02-121-3/+2
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* ctdb: Install helpers under libexecdirMartin Schwenke2016-02-126-18/+28
| | | | | Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Andreas Schneider <asn@samba.org>
* ctdb-ipalloc: Remove most uses of struct ctdb_public_ip_list_oldMartin Schwenke2016-02-124-65/+70
| | | | | | | | | | | | | | Where possible, this should no longer be used. struct ctdb_public_ip_list is a fixed size structure and introduces an extra level of indirection. This means one level of indirection can be dropped for known_public_ips and available_public_ips. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> Autobuild-User(master): Amitay Isaacs <amitay@samba.org> Autobuild-Date(master): Fri Feb 12 08:40:21 CET 2016 on sn-devel-144
* ctdb-ipalloc: Use goto fail to avoid repetitionMartin Schwenke2016-02-121-8/+7
| | | | | | | This is getting unreadable... Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-tests: Remove unnecessary \ from transaction dataAmitay Isaacs2016-02-121-3/+3
| | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
* ctdb-tests: Improve ctdb detach testAmitay Isaacs2016-02-121-0/+12
| | | | | | | Confirm that after re-attaching detached database, it is empty. Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
* ctdb-tests: Remove last remaining instance of ctdb -n allAmitay Isaacs2016-02-121-1/+1
| | | | | | | | | | _cluster_is_recovered() is used to check if all the nodes in the cluster have recovery mode set to NORMAL. This is mainly used just after recovery to wait till the recovery is over. Instead just check the recovery mode on node 0. Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
* ctdb-recovery: Add a log message when marshalling recovery database failsAmitay Isaacs2016-02-121-0/+2
| | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
* ctdb-daemon: Improve log message when REQ_DMASTER is received on non-lmasterAmitay Isaacs2016-02-121-3/+4
| | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
* param: Fix str_list_v3 to accept ; againVolker Lendecke2016-02-111-1/+17
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Thu Feb 11 19:19:55 CET 2016 on sn-devel-144
* s3: smbd: posix_acls: Fix check for setting u:g:o entry on a filesystem with ↵Jeremy Allison2016-02-111-1/+38
| | | | | | | | | | | | | | | | | | | | no ACL support. Since 4.0.x we add 2 additional ACE entries, one SMB_ACL_USER and SMB_ACL_GROUP to match the existing SMB_ACL_USER_OBJ and SMB_ACL_GROUP_OBJ entries. The two additional entries break the simple "must have 3 entries" check done inside convert_canon_ace_to_posix_perms(). Replace this with a more complete test. Problem and initial fix provided by <tcleamy@ucdavis.edu> BUG: https://bugzilla.samba.org/show_bug.cgi?id=10489 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Uri Simchoni <uri@samba.org> Autobuild-User(master): Uri Simchoni <uri@samba.org> Autobuild-Date(master): Thu Feb 11 11:14:53 CET 2016 on sn-devel-144
* ctdb-recovery: Create recovery databases in state dirAmitay Isaacs2016-02-112-1/+10
| | | | | | | | | | This matches the behaviour during serial database recovery. Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net> Autobuild-User(master): Martin Schwenke <martins@samba.org> Autobuild-Date(master): Thu Feb 11 08:01:14 CET 2016 on sn-devel-144
* nss_netbsd: Remove unimplemented prototypesVolker Lendecke2016-02-111-13/+0
| | | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Uri Simchoni <uri@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Feb 11 04:43:53 CET 2016 on sn-devel-144
* nss_linux: Remove non-nss functionsVolker Lendecke2016-02-111-371/+0
| | | | | | | | | These functions were meant as a standard interface before libwbclient was developed. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Uri Simchoni <uri@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* ctdb-scripts: Drop use of "smbcontrol winbindd ip-dropped ..."Martin Schwenke2016-02-102-11/+0
| | | | | | | | | | | | | | | | This is unnecessary in Samba >= 4.0 because winbindd monitors IP address itself and no longer needs to be told when they are dropped. The smbcontrol commands can hang if a node has recovery mode active because smbcontrol is unable to connect to the registry. Therefore, the smbcontrol commands should be removed. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11719 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Ralph Boehme <slow@samba.org> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Wed Feb 10 14:08:17 CET 2016 on sn-devel-144
* lib/tsocket: workaround sockets not supporting FIONREADRalph Boehme2016-02-101-1/+61
| | | | | | | | | | | | | | | | | | Netlink sockets don't support querying pending bytes with ioctl(fd, FIONREAD, ...) and would return EOPNOTSUPP, so use recvmsg() with MSG_PEEK|MSG_TRUNC as a fallback. The MSG_TRUNC flag to recvmsg() is Linux only, but netlink is as well, so we're safe for now. Bug: https://bugzilla.samba.org/show_bug.cgi?id=11714 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Wed Feb 10 10:30:24 CET 2016 on sn-devel-144
* asn1: Ensure asn1_tag_remaining() only ever returns -1 as an error condition.Jeremy Allison2016-02-101-0/+4
| | | | | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Feb 10 01:38:03 CET 2016 on sn-devel-144
* asn1: Make asn1_peek_tag_needed_size() use the same overflow protection as ↵Jeremy Allison2016-02-091-1/+13
| | | | | | | asn1_start_tag(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* asn1: Protect against overlong tag lengthsVolker Lendecke2016-02-091-1/+12
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* ctdb-recovery: Fix newlines in log messagesAmitay Isaacs2016-02-091-5/+5
| | | | | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Uri Simchoni <uri@samba.org> Autobuild-User(master): Uri Simchoni <uri@samba.org> Autobuild-Date(master): Tue Feb 9 22:28:08 CET 2016 on sn-devel-144
* Revert "ctdb-daemon: Check packet generation against database generation"Amitay Isaacs2016-02-092-52/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0ff90f4fac74e61192aff100b168e38ce0adfabb. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11707 The checks against database generation are not required since the global generation is updated as part of updating vnnmap before the actual database recovery. This change was done in 5aab31a39a3589b910a78b96071d6aa5e6547696. Checking only against the database generation is incomplete. It can cause CTDB to abort if the following sequence of events happen. - CTDB gets REQ_DMASTER packet (gen1) This packet processing gets deferred to get a record lock - CTDB goes into recovery, marks RECOVERY_ACTIVE CTDB recovery helper updates vnnmap (gen2) - CTDB processes REQ_DMASTER packet (gen1) The check against database generation (gen1) succeeds. The check for lmaster is now invalid because VNNMAP has changed. This will cause CTDB to abort due to protocol error. Reverting the patch stops processing packets of older generation before they get into call processing. Signed-off-by: Amitay Isaacs <amitay@gmail.com> Signed-off-by: Martin Schwenke <martin@meltin.net> Autobuild-User(master): Martin Schwenke <martins@samba.org> Autobuild-Date(master): Tue Feb 9 12:39:24 CET 2016 on sn-devel-144
* selftest: add dbwrap_tdb_require_mutexes:* = yes, when using ↵Stefan Metzmacher2016-02-092-0/+8
| | | | | | | | | | | | dbwrap_tdb_mutexes:* = yes by default export SELFTEST_DONT_REQUIRE_TDB_MUTEX_SUPPORT=1 can overwrite this. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Tue Feb 9 01:42:14 CET 2016 on sn-devel-144
* s3:dbwrap: add dbwrap_tdb_require_mutexes:*= optionStefan Metzmacher2016-02-081-0/+10
| | | | | | | | This is similar to dbwrap_tdb_mutexes:*= (which is autodetected by default), but dbwrap_tdb_require_mutexes is off by default. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* test:docs: remove unused param_table/get_param_table_full()Michael Adam2016-02-081-64/+0
| | | | | | | | | No tests use this any more, hence we should not parse the file anymore either. It is generated directly from the parametersr.all.xml file. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* tldap: Add a missing TALLOC_FREE(frame)Volker Lendecke2016-02-081-1/+1
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* Fix ETIME handling for Solaris event ports.Nathan Huff2016-02-071-4/+18
| | | | | | | | | | | | | | | | It is possible for port_getn to return -1 with errno set to ETIME and still return events. If those events aren't processed the association is lost by samba since the kernel dissacociated them and samba never processed them so never reassociated them with the event port. The patch checks the nget return value in the case of ETIME and if it is non 0 it doesn't return and goes through the event processing loop. Signed-off-by: Nathan Huff <nhuff@acm.org> Reviewed-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Sun Feb 7 11:26:35 CET 2016 on sn-devel-144
* ctdb/server: fix gcc6 build warning.Günther Deschner2016-02-071-1/+2
| | | | | | | | | | | | | ctdb/server/ipalloc_lcp2.c:264:29: warning: 'minimbl' may be used uninitialized in this function [-Wmaybe-uninitialized] Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Sun Feb 7 00:56:44 CET 2016 on sn-devel-144
* s4-libgpo: fix gcc6 build warning.Günther Deschner2016-02-061-6/+0
| | | | | | | | | | source4/lib/policy/gp_ldap.c:48:35: warning: 'gpo_inheritance' defined but not used [-Wunused-const-variable] Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s4-torture: fix gcc6 build warnings.Günther Deschner2016-02-061-2/+7
| | | | | | | | | | | source4/torture/nbt/winsreplication.c:523:30: warning: 'addresses_X_1_2' defined but not used [-Wunused-const-variable] source4/torture/nbt/winsreplication.c:470:30: warning: 'addresses_B_2' defined but not used [-Wunused-const-variable] source4/torture/nbt/winsreplication.c:445:30: warning: 'addresses_A_3_4_X_1_2' defined but not used [-Wunused-const-variable] Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s4-torture: fix gcc6 build warning.Günther Deschner2016-02-061-1/+2
| | | | | | | | | | source4/torture/rpc/forest_trust.c:408:22: warning: 'my_blob' defined but not used [-Wunused-const-variable] Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s4-torture: fix gcc6 build warning.Günther Deschner2016-02-061-0/+2
| | | | | | | | | | | source4/torture/ndr/samr.c:277:22: warning: 'samr_changepassworduser3_w2k_out_data' defined but not used [-Wunused-const-variable] Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s4-torture: fix gcc6 build warning.Günther Deschner2016-02-061-0/+4
| | | | | | | | | | source4/torture/ndr/drsuapi.c:272:22: warning: 'DsBind_req2_dat' defined but not used [-Wunused-const-variable] Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s4-torture: fix gcc6 build warning.Günther Deschner2016-02-061-5/+1
| | | | | | | | | | source4/torture/raw/eas.c:322:17: warning: comparison of constant '0' with boolean expression is always false [-Wbool-compare] Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* ldb: remove outdated comment about type argument in dlistMichael Adam2016-02-061-4/+0
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
View Lorry Controller Status