summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* dns_server: Don't call tevent_req_finish twiceVolker Lendecke2015-08-071-3/+7
| | | | | | | | Both tevent_req_werror and tevent_req_done call tevent_req_finish on a request. This should not be done. We should only call either of both. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s4:torture:vfs_fruit: add a test for stream namesRalph Boehme2015-08-073-2/+143
| | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=11278 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s4:torture:vfs_fruit: pass xattr name as arg to torture_setup_local_xattr()Ralph Boehme2015-08-071-1/+3
| | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=11278 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* vfs_catia: run translation on stream namesRalph Boehme2015-08-071-4/+54
| | | | | | | | | | | | | With vfs_fruit option "fruit:encoding = native" we're already converting stream names that contain illegal NTFS characters from their on-the-wire Unicode Private Range encoding to their native ASCII representation. Unfortunately the reverse mapping for stream names was not perfomed. Bug: https://bugzilla.samba.org/show_bug.cgi?id=11278 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* vfs_streams_xattr: stream names may contain colonsRalph Boehme2015-08-071-1/+15
| | | | | | | | | | | | | | | With vfs_fruit option "fruit:encoding = native" we're already converting stream names that contain illegal NTFS characters from their on-the-wire Unicode Private Range encoding to their native ASCII representation. As as result the name of xattrs storing the streams (via vfs_streams_xattr) may contain a colon, so we have to use strrchr_m() instead of strchr_m() for matching the stream type suffix. Bug: https://bugzilla.samba.org/show_bug.cgi?id=11278 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* ctdb-tests: Add a policy routing test with misconfigurationMartin Schwenke2015-08-072-0/+36
| | | | | | | | | | | To support this, extend the "ip route add" stub to detect duplicate routes. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> Autobuild-User(master): Amitay Isaacs <amitay@samba.org> Autobuild-Date(master): Fri Aug 7 08:37:38 CEST 2015 on sn-devel-104
* ctdb-tests: Make fake gateway different to actual public IPsMartin Schwenke2015-08-071-2/+2
| | | | | Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-scripts: Improve error handling for 50.samba testparm failureMartin Schwenke2015-08-077-12/+151
| | | | | | | | Also add tests. Update testparm stub to fake error and timeout. Add timeout stub. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-pmda: Add missing prototype declaration for non-static functionAmitay Isaacs2015-08-071-1/+2
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=11434 Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
* ctdb-daemon: Reset database statistics when resetting statisticsAmitay Isaacs2015-08-073-0/+23
| | | | | | | | When the ctdb statistics is reset, reset per database statistics to keep it consistent with ctdb statistics. Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
* ctdb-system: Remove unused system specific callsAmitay Isaacs2015-08-077-297/+0
| | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
* source3/rpc_client: Fix CID 1273041 Condition is redundantAnoop C S2015-08-071-1/+2
| | | | | | | | | Signed-off-by: Anoop C S <anoopcs@redhat.com> Reviewed-by: Michael Adam <obnox@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Fri Aug 7 01:31:23 CEST 2015 on sn-devel-104
* lib/talloc: Fix CID 1291639 Missing unlockAnoop C S2015-08-061-0/+1
| | | | | | Signed-off-by: Anoop C S <anoopcs@redhat.com> Reviewed-by: Michael Adam <obnox@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* lib/talloc: Fix CID 1291640 Missing unlockAnoop C S2015-08-061-0/+1
| | | | | | Signed-off-by: Anoop C S <anoopcs@redhat.com> Reviewed-by: Michael Adam <obnox@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* smbd: Log smb2 requests returning !OK with higher log levelChristof Schmitt2015-08-061-3/+3
| | | | | | | | This can be useful for narrowing down problems without taking a full level 10 trace. Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* s4:rpc_server/netlogon: Fix for NetAppArvid Requate2015-08-061-11/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch fixes an issue where NetApp filers joined to a Samba/ADDC cannot resolve SIDs. Without this patch the issue can only be avoided by setting "allow nt4 crypto = yes" in smb.conf. The issue is triggered by NetApp filers in three steps: 1. The client calls netr_ServerReqChallenge to set up challenge tokens 2. Next it calls netr_ServerAuthenticate2 with NETLOGON_NEG_STRONG_KEYS set to 0. Native AD and Samba respond to this with NT_STATUS_DOWNGRADE_DETECTED. At this point Samba throws away the challenge token negotiated in the first step. 3. Next the client calls netr_ServerAuthenticate2 again, this time with NETLOGON_NEG_STRONG_KEYS set to 1. Samba returns NT_STATUS_ACCESS_DENIED as it has lost track of the challenge and denies logon with the message No challenge requested by client [CLNT1/CLNT1$], cannot authenticate Git commit 321ebc99b5a00f82265aee741a48aa84b214d6e8 introduced a workaround for a different but related issue. This patch makes a minor adjustment to that commit to delay flushing the cached challenge until it's clear that we are not in a NT_STATUS_DOWNGRADE_DETECTED situation. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11291 Signed-off-by: Arvid Requate <requate@univention.de> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Thu Aug 6 20:29:04 CEST 2015 on sn-devel-104
* dns: always add authority recordsKai Blin2015-08-063-25/+39
| | | | | | | | Signed-off-by: Kai Blin <kai@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Kai Blin <kai@samba.org> Autobuild-Date(master): Thu Aug 6 14:06:52 CEST 2015 on sn-devel-104
* dns: Add a SOA record to error repliesKai Blin2015-08-061-1/+51
| | | | | Signed-off-by: Kai Blin <kai@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* dns: Also pass nsrecs to handle_question()Kai Blin2015-08-061-4/+10
| | | | | Signed-off-by: Kai Blin <kai@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* dns: Just pass the name to create_response_rrKai Blin2015-08-061-4/+4
| | | | | Signed-off-by: Kai Blin <kai@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* dns: Add dns_get_authoritative_zone helper functionKai Blin2015-08-062-0/+18
| | | | | Signed-off-by: Kai Blin <kai@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* script/librelease.sh: this is replaced by script/release.sh nowStefan Metzmacher2015-08-061-110/+0
| | | | | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Thu Aug 6 03:49:40 CEST 2015 on sn-devel-104
* script/release.sh: This is a new script to do releasesStefan Metzmacher2015-08-061-0/+615
| | | | | | | | | | | | | | | | | | | | | | | This will replace script/librelease.sh and is more flexible and powerful. Usage: release.sh <PRODUCT> <COMMAND> PRODUCT: ldb, talloc, tevent, tdb, samba-rc COMMAND: fullrelease, create, push, upload, announce GNUPGHOME=/path/to/private/gpg script/librelease.sh tdb becomes GNUPGHOME=/path/to/private/gpg script/release.sh tdb fullrelease GNUPGHOME=/path/to/private/gpg script/librelease.sh samba becomes GNUPGHOME=/path/to/private/gpg script/release.sh samba-rc create or later GNUPGHOME=/path/to/private/gpg script/release.sh samba-stable create Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* wafsamba: don't add -DSTATIC_%s_MODULES* arguments for ↵Stefan Metzmacher2015-08-061-0/+3
| | | | | | | | | | | | | | | SAMBA_LIBRARY(pyembed=True) Python helper libraries don't have any modules and having something like '.cpython-34m' in the name, e.g. STATIC_pytalloc-util.cpython-34m_MODULES breaks the build. Another way to fix this would be removing PYTHON_SO_ABI_FLAG from the name. This allows --extra-python=/usr/bin/python3 to work on Ubuntu 14.04. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* selftest: Add test for GSSAPI with no authenticator checksum modeAndrew Bartlett2015-08-052-2/+2
| | | | | | | | | | | | This was seen in the wild, with a Huawei Unified Storage System S5500 V3 against the AD DC BUG: https://bugzilla.samba.org/show_bug.cgi?id=11425 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Wed Aug 5 09:43:40 CEST 2015 on sn-devel-104
* heimdal/gssapi: Allow a NULL authenticatorAndrew Bartlett2015-08-051-36/+35
| | | | | | | | | | | | | | | | | | Some non-GSSAPI implementations that instead try to create compatible packets by wrapping krb5_mk_req() can trigger a NULL authenticator here. Assume this to be equvilent to specifying an all-zero channel bindings and some reasonable (fixed) flags. This was seen in the wild, with a Huawei Unified Storage System S5500 V3 against the AD DC Original patch by Andrew Bartlett, restructured by Douglas Bagnall Cherry-picked from upstream GIT 0a5de96d72cdea9e465412d7dba1e5d13e53dc09 which is the merge of https://github.com/heimdal/heimdal/pull/134 BUG: https://bugzilla.samba.org/show_bug.cgi?id=11425 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* gensec: Add an option emulating another mode a client building GSSAPI/krb5 ↵Andrew Bartlett2015-08-051-3/+9
| | | | | | | | | | manually uses This was seen in the wild, with a Huawei Unified Storage System S5500 V3 against the AD DC BUG: https://bugzilla.samba.org/show_bug.cgi?id=11425 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* waf: Add talloc as a dependencyAndreas Schneider2015-08-051-2/+2
| | | | | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Wed Aug 5 04:08:30 CEST 2015 on sn-devel-104
* sdb: Assert if the HDB flags will changeAndreas Schneider2015-08-051-2/+34
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* hdb-samba: Translate SDB errors to HDB errorsAndreas Schneider2015-08-051-26/+97
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4-torture: add test for CLUSCTL_NODE_GET_ID in clusapi_NodeControl.Günther Deschner2015-08-041-3/+26
| | | | | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: José A. Rivera <jarrpa@samba.org> Autobuild-User(master): José A. Rivera <jarrpa@samba.org> Autobuild-Date(master): Tue Aug 4 22:14:33 CEST 2015 on sn-devel-104
* s3-rpcclient: add client for create enum ex.Günther Deschner2015-08-041-0/+58
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: José A. Rivera <jarrpa@samba.org>
* s4-torture: add more ndr tests for property lists.Günther Deschner2015-08-041-0/+226
| | | | | | | | | This data is derived from clusapi_NodeControl. Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: José A. Rivera <jarrpa@samba.org>
* s4-torture: add torture test for clusapi_NodeControl.Günther Deschner2015-08-041-0/+84
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: José A. Rivera <jarrpa@samba.org>
* clusapi: add clusapi_NodeControlCode to IDL.Günther Deschner2015-08-041-1/+20
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: José A. Rivera <jarrpa@samba.org>
* s4-torture: add tests for GroupControl.Günther Deschner2015-08-041-0/+93
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: José A. Rivera <jarrpa@samba.org>
* clusapi: add clusapi_GroupControlCode enum to IDL.Günther Deschner2015-08-041-1/+20
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: José A. Rivera <jarrpa@samba.org>
* s4-torture: also test ClusterControl with a large initial buffer size.Günther Deschner2015-08-041-0/+15
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: José A. Rivera <jarrpa@samba.org>
* clusapi: use winreg_Type in clusapi registry IDL.Günther Deschner2015-08-041-4/+4
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: José A. Rivera <jarrpa@samba.org>
* s4-torture: add ndr testsuite for complex clusapi_PROPERTY_LIST structs.Günther Deschner2015-08-044-2/+179
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: José A. Rivera <jarrpa@samba.org>
* clusapi: use ClusterEnumType in clusapi_CreateEnumEx.Günther Deschner2015-08-041-1/+1
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: José A. Rivera <jarrpa@samba.org>
* s4-torture: add test for clusapi_CreateEnumEx().Günther Deschner2015-08-041-0/+86
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: José A. Rivera <jarrpa@samba.org>
* clusapi: add PROPERTY_LIST IDL.Günther Deschner2015-08-041-26/+48
| | | | | | | | | | Note this is hand-marshalled in Windows, seen in ClusterControl reqplies for a CLUSCTL_CLUSTER_GET_RO_COMMON_PROPERTIES control. Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: José A. Rivera <jarrpa@samba.org>
* s4-torture: add test for GetResourceNetworkName.Günther Deschner2015-08-041-0/+47
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: José A. Rivera <jarrpa@samba.org>
* s3-clusapi: add test for GetResourceDependencyExpression.Günther Deschner2015-08-041-0/+47
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: José A. Rivera <jarrpa@samba.org>
* s4-torture: add more tests for clusapi_OpenResource().Günther Deschner2015-08-041-6/+38
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: José A. Rivera <jarrpa@samba.org>
* s3-net: use talloc array in share allowedusersRalph Boehme2015-08-041-4/+20
| | | | | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=11426 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Tue Aug 4 16:48:36 CEST 2015 on sn-devel-104
* dns_server: Fix CNAME handlingVolker Lendecke2015-08-041-5/+1
| | | | | | | | | | | | recs[i].wtype is == DNS_TYPE_CNAME, and my understanding of the union is that data.cname is filled. We get away with this, because ipv4 and ipv6 have the same char * representation, but it's confusing. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ira Cooper <ira@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Tue Aug 4 13:41:17 CEST 2015 on sn-devel-104
* dns_server: Add NULL checkVolker Lendecke2015-08-041-0/+1
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ira Cooper <ira@samba.org>
* lib/util/debug.h uses va_list, needs stdarg.hDouglas Bagnall2015-08-011-1/+1
| | | | | | | | | | Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Sat Aug 1 13:59:13 CEST 2015 on sn-devel-104
View Lorry Controller Status