summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* s3: smbd: Codenomicon crash in do_smb_load_module().Jeremy Allison2015-06-301-0/+5
| | | | | | | | | | | | | | | | | | | | | | Inside api_pipe_bind_req() we look for a pipe module name using dcerpc_default_transport_endpoint(pkt, NCACN_NP, table) which returns NULL when given invalid pkt data from the Codenomicon fuzzer. This gets passed directly to smb_probe_module(), which then calls do_smb_load_module() which tries to deref the (NULL) module name. https://bugzilla.samba.org/show_bug.cgi?id=11342 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ira Cooper <ira@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Jun 18 22:14:01 CEST 2015 on sn-devel-104 (cherry picked from commit 5a82cc21379e3fe28441cd82647313c9390b41e7)
* s3:winbindd: make sure we pass a valid server to ↵Stefan Metzmacher2015-06-301-5/+2
| | | | | | | | rpccli_netlogon_sam_network_logon*() BUG: https://bugzilla.samba.org/show_bug.cgi?id=11081 Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s3: smbd: Use separate flag to track become_root()/unbecome_root() state.Jeremy Allison2015-06-301-2/+6
| | | | | | | | | | | | | | | | | | | Early function exit can mean backup_priv is set but we haven't called become_root(). *Lots* of work by the reviewers went in to checking this isn't a security issue. Found by Codenomicon at the Redmond plugfest. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11339 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Jun 25 22:14:58 CEST 2015 on sn-devel-104 (cherry picked from commit e2c4b8967d33b610f9f076c614352e4b8fc7c558)
* s3:param/loadparm fix testparm --show-all-parametersChristian Ambach2015-06-301-1/+1
| | | | | | | | | | | | it didn't know about the new types of config parameters BUG: https://bugzilla.samba.org/show_bug.cgi?id=11170 Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Tue Jun 9 11:49:18 CEST 2015 on sn-devel-104
* VERSION: Bump version up to 4.1.20...Karolin Seeger2015-06-201-2/+2
| | | | | | and re-enable git snapshots. Signed-off-by: Karolin Seeger <kseeger@samba.org>
* VERSION: Disable git snapshots for the 4.1.19 release.samba-4.1.19Karolin Seeger2015-06-201-1/+1
| | | | Signed-off-by: Karolin Seeger <kseeger@samba.org>
* WHATSNEW: Add release notes for Samba 4.1.19.Karolin Seeger2015-06-201-3/+82
| | | | Signed-off-by: Karolin Seeger <kseeger@samba.org>
* s3: libsmbclient: Re-resolving targetcli on every ↵Jeremy Allison2015-06-102-185/+22
| | | | | | | | | | | | | | | | | read/write/lseek/ftruncate/close is both incorrect and slow. Cache targetcli on file open in the SMBCFILE struct. Bug 11295 - Excessive cli_resolve_path() usage can slow down transmission. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11295 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> (cherry picked from commit 9f57244bbd1ffa203a1f50bb289789628c4a3f66) Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Wed Jun 10 01:20:32 CEST 2015 on sn-devel-104
* nsswitch: Extend idmap_rfc2307 testcase for reverse lookupChristof Schmitt2015-06-092-10/+64
| | | | | | | | | | | | | | | Also test the codepaths to map UID and GID back to SID and names. Use different user and group to avoid returning results cached from the previous lookups. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11313 Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri Jun 5 01:24:32 CEST 2015 on sn-devel-104 (cherry picked from commit c1c07b462058f863e706127203e6f30dba89a2a9)
* idmap_rfc2307: Fix wbinfo --gid-to-sid queryChristof Schmitt2015-06-091-1/+1
| | | | | | | | | | Fix syntax error in LDAP query for gidNumber. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11313 Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 835c278e43b9dec98834de0fb12445720e9df2e5)
* s4.2/fsmo.py: fixed fsmo transfer exceptionSteve Howells2015-06-091-1/+0
| | | | | | | | | | | | | | | | | | In transfer_role() there is an duplicate call to samdb.modify() inside the if statement where the type of role is being determined (specifically for the naming fsmo). This call is unnecessary as after the if statement their is a correct call, with a try/catch block, used by all fsmo transfers that will handle errors - such as the DC with the fsmo role being offline. The call to samdb.modify() inside the if statement for naming fsmo has been removed. Bug: https://bugzilla.samba.org/show_bug.cgi?id=10924 Signed-off-by: Steve Howells <steve.howells@moscowfirst.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Marc Muehlfeld <mmuehlfeld@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 9198246f91c02e33ed7a3580588557d0fb9f8811)
* s3: IPv6 enabled DNS connections for ADS clientDavid Holder2015-06-022-41/+86
| | | | | | | | | | | | | | | | This patch makes DNS client connections protocol independent. For example DNS updates. This makes IPv6-only clients possible. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11283 Back-port from fff774eda3ed04d319232b108a94282af24cc6b0 Signed-off-by: David Holder <david.holder@erion.co.uk> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <rb@sernet.de> Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Tue Jun 2 01:55:28 CEST 2015 on sn-devel-104
* Add IPv6 support for determining FQDN during ADS join.David Holder2015-06-011-20/+32
| | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=11282 Back ported from commit 6e08bfb4441022a00d0c29205e835a4858a3a57f Signed-off-by: David Holder <david.holder@erion.co.uk> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <rb@sernet.de>
* Add IPv6 support to ADS client side LDAP connects. Corrected format for IPv6 ↵David Holder2015-06-011-1/+7
| | | | | | | | | | | | LDAP URI. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11281 (Back ported from commit c324d7901c991a6700abdc3ee701920fea5e5819) Signed-off-by: David Holder <david.holder@erion.co.uk> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <rb@sernet.de>
* s4:torture:smb2:compound: compound read and paddingRalph Boehme2015-06-011-0/+239
| | | | | | | | | | | | | | | | | Add test to check that compound read responses are padded to an 8 byte boundary. Bug: https://bugzilla.samba.org/show_bug.cgi?id=11277 Pair-Programmed-With: Stefan Metzmacher <metze@samba.org> Signed-off-by: Ralph Boehme <slow@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Thu May 28 16:50:39 CEST 2015 on sn-devel-104 (cherry picked from commit 2ffa939bbe2c02509e1790c8b3f6f9b6910e3cf6)
* s3:smb2: add padding to last command in compound requestsRalph Boehme2015-06-011-4/+12
| | | | | | | | | | | | | | | | | | | Following Windows behaviour, the last command in a compound request should be padded to an 8 byte boundary and OS X clients crash badly if we don't pad. [MS-SMB2] 3.3.4.1.3, "Sending Compounded Responses", doesn't make it clear whether the padding requirement governs the last command in a compound response, a future MS-SMB2 update will document Windwows product behaviour in a footnote. Bug: https://bugzilla.samba.org/show_bug.cgi?id=11277 Pair-Programmed-With: Stefan Metzmacher <metze@samba.org> Signed-off-by: Ralph Boehme <slow@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit dfa64b958b201931e0dbe11f153f606f20217594)
* s3: smbcacls: Ensure we read a hex number as %x, not %u.Jeremy Allison2015-06-011-1/+1
| | | | | | | | | Based on a patch from Zoe O'Connell <zoe@metail.com> BUG: https://bugzilla.samba.org/show_bug.cgi?id=11068 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Jim McDonough <jmcd@samba.org>
* s4: libcli/finddcs_cldap: continue processing CLDAP until all addresses are usedAlexander Bokovoy2015-05-211-10/+32
| | | | | | | | | | | | | | | | | | | | This is a subtle bug that causes CLDAP pings to fail if SRV records discovered cannot be resolved or connection to them cannot be established. The code that fires up CLDAP ping will silently cancel the whole tevent request without going to the next server in the queue. This may happen, for example, when connection to IPv6 addresses couldn't be established, or when IPv4 address is not online or blocked by firewall. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11284 Signed-off-by: Alexander Bokovoy <ab@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit eb029b32e95c9e7382488f3a1b033cdbe3237c1c) Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Thu May 21 17:44:11 CEST 2015 on sn-devel-104
* s3:winbindd: make sure we remove pending io requests before closing client ↵Stefan Metzmacher2015-05-212-0/+28
| | | | | | | | | | | | | | | | sockets This avoids a crash inside the tevent epoll backend. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11141 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Wed May 20 22:16:54 CEST 2015 on sn-devel-104 (cherry picked from commit 435ddd8223eaa6fafb62cead0399bdd042d998e8)
* s4:lib/tls: fix build with gnutls 3.4Evangelos Foutras2015-05-212-8/+2
| | | | | | | | | | | | | | | | | | gnutls_certificate_type_set_priority() was removed in GnuTLS 3.4.0. Use gnutls_priority_set_direct instead. BUG: https://bugzilla.samba.org/show_bug.cgi?id=8780 Signed-off-by: Björn Jacke <bj@sernet.de> Reviewed-By: Jelmer Vernooij <jelmer@samba.org> Autobuild-User(master): Björn Jacke <bj@sernet.de> Autobuild-Date(master): Wed Apr 29 22:29:02 CEST 2015 on sn-devel-104 (cherry picked from commit c6ad8a10c12c8a79dc83cab1591e5279edd62bd6) Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Thu May 21 12:00:39 CEST 2015 on sn-devel-104
* libads: record service ticket endtime for sealed ldap connectionsUri Simchoni2015-05-201-0/+23
| | | | | | | | | | | | | | | | | | | | When a ticket is obtained for binding a signed/sealed ldap connection, its liftime should be recorded in the ads struct, in order to enable reuse of the connection. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11267 Signed-off-by: Uri Simchoni <urisimchoni@gmail.com> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <rb@sernet.de> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed May 13 04:32:16 CEST 2015 on sn-devel-104 (cherry picked from commit 40eac8e4d8bc85f2329b8ed6c5ba96a141dc20a3) Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Wed May 20 18:44:55 CEST 2015 on sn-devel-104
* s3: smbd: VFS: fake_acl module called get_full_smb_filename() with a stream ↵Jeremy Allison2015-05-201-2/+18
| | | | | | | | | | | | path, then used the result to call XATTR functions directly. Ensure when pulling XATTR values, we don't allow a stream filename. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11249 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> (cherry picked from commit 0f23bf228ceb38b024a77fcf2916971ad4f6aa4d)
* s3: smbd: VFS: For all EA and ACL calls use synthetic_smb_fname(), not ↵Jeremy Allison2015-05-204-4/+4
| | | | | | | | | | | | | | synthetic_smb_fname_split(). EA's and ACL paths are all post-stream name checks (and shouldn't get stream names). This one took a *long* time to find. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11249 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> (cherry picked from commit ccb4f791fd19d9b3af79a205a15c0219ed7240ea)
* s3: smbd: VFS: All the places that are currently calling ↵Jeremy Allison2015-05-206-19/+26
| | | | | | | | | | | | | vfs_stat_smb_fname() and vfs_lstat_smb_fname() should be calling vfs_stat_smb_basename(). They are all post-stream name processing. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11249 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> (cherry picked from commit 14f4e254bb8d1f456ebb8da728f2fb812a9b3034)
* s3: smbd: VFS: Add vfs_stat_smb_basename() - to be called when we *know* ↵Jeremy Allison2015-05-202-0/+28
| | | | | | | | | | | stream name parsing has already been done. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11249 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> (cherry picked from commit 044dabfd92d09de4f168a36a07ac3232f5647a1d)
* vfs_gpfs: move failure label before END_PROFILERalph Boehme2015-05-201-1/+1
| | | | | | | | | | | | | | | The label was added in 5e65ae14ddb74c648f31b4dfbacd4af9c02ca058 as part of fix for bug 11244, but was wrongly placed behind END_PROFILE. Bug: https://bugzilla.samba.org/show_bug.cgi?id=11244 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Thu May 7 19:22:00 CEST 2015 on sn-devel-104 (cherry picked from commit 3876e59826ad17466975ae9e9a65879c76737b2b)
* vfp_gpfs: ensure END_PROFILE is always calledRalph Boehme2015-05-201-2/+7
| | | | | | | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=11244 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Christof Schmitt <cs@samba.org> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Thu Apr 30 19:34:41 CEST 2015 on sn-devel-104 (cherry picked from commit 5e65ae14ddb74c648f31b4dfbacd4af9c02ca058)
* s3:selftest: run smb2.notify with --signing=requiredStefan Metzmacher2015-05-201-0/+3
| | | | | | | | | | This reproduces a bug withe implicit canceled requests. Bug: https://bugzilla.samba.org/show_bug.cgi?id=11182 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (similar to commit c49ad3f89530d078fdd6ffcd1a6dc8c38be9169b)
* s3:smb2_sesssetup: remove unused smbd_smb2_session_setup_* destructorsStefan Metzmacher2015-05-201-59/+0
| | | | | | | | | | | The cleanup of a failing session setup is now handled in smbd_smb2_session_setup_wrap_*(). Bug: https://bugzilla.samba.org/show_bug.cgi?id=11182 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (similar to commit 5871d3da871349cba058bb91218ae58107cf05c8)
* s3:smb2_sesssetup: add smbd_smb2_session_setup_wrap_send/recv()Stefan Metzmacher2015-05-201-15/+171
| | | | | | | | | | | The wrapper calls smbXsrv_session_shutdown_send/recv() in case of an error, this makes sure a failing reauth shuts down the session like an explicit logoff. Bug: https://bugzilla.samba.org/show_bug.cgi?id=11182 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 50aeb6b38b14d6c26229834ece3c32eb50f9e56a)
* s3:smb2_sesssetup: always assign smb2req->session when a session was created.Stefan Metzmacher2015-05-201-1/+1
| | | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=11182 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 8f0d4d1132b74615dc6198ab736590dec52effda)
* s3:smb2_sesssetup: let smbd_smb2_logoff_* use smbXsrv_session_shutdown_*Stefan Metzmacher2015-05-201-60/+15
| | | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=11182 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (similar to commit 95057fe375348b918cb2ca58109f4c110a4a5f77)
* s3:smbXsrv_session: cancel pending requests when we logoff a previous sessionStefan Metzmacher2015-05-201-7/+38
| | | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=11182 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (similar to commit cc9d52e10f4f1b192171e03674061d4e8e6bcc84)
* s3:smbXsrv_session: add smb2srv_session_shutdown_send/recv helper functionsStefan Metzmacher2015-05-202-0/+112
| | | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=11182 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (similar to commit 4fceb4531ccd6bb1fd6ebd7b6eb5b894959bc010)
* s3:smbXsrv_session: clear smb2req->session of pending requests in ↵Stefan Metzmacher2015-05-201-0/+20
| | | | | | | | | | | | | smbXsrv_session_logoff_all_callback() smbXsrv_session_logoff_all_callback() is called when the last transport connection is gone, which means we won't need to sign any response... Bug: https://bugzilla.samba.org/show_bug.cgi?id=11182 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (similar to commit b6c34a07760141bda3e78624d62eb556bb70da65)
* s3:smbXsrv_session: clear smb2req->session of pending requests in ↵Stefan Metzmacher2015-05-201-0/+19
| | | | | | | | | | | | | smbXsrv_session_destructor() This won't be needed typically needed as the caller is supposted to cancel the requests already, but this makes sure we don't keep dangling pointers. Bug: https://bugzilla.samba.org/show_bug.cgi?id=11182 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (similar to commit 7fea42110596e8e9da0155d726aaa72223107fbd)
* s4:torture/smb2: add smb2.notify.session-reconnect testStefan Metzmacher2015-05-201-0/+81
| | | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=11182 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit f435c89d61385272bf5b79f82f6e1373908d2b94)
* s4:torture/smb2: add smb2.notify.invalid-reauth testStefan Metzmacher2015-05-201-0/+82
| | | | | | | | | | An invalid reauth closes the session. Bug: https://bugzilla.samba.org/show_bug.cgi?id=11182 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit a8ec77e86b17213eeb6a51a835639d79e9486223)
* s4:torture/smb2: add smb2.notify.close testStefan Metzmacher2015-05-201-0/+70
| | | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=11182 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 44f9e1052de81a0a3052997e7e19a01813fbec43)
* s4:torture/smb2: verify STATUS_NOTIFY_CLEANUP return valueStefan Metzmacher2015-05-201-0/+2
| | | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=11182 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 4bfa6b024e530694741c7c07171fa09762578389)
* s3:smbd: use STATUS_NOTIFY_CLEANUP on smb2 logoff (explicit and implicit) ↵Stefan Metzmacher2015-05-201-0/+14
| | | | | | | | | | and tdis Bug: https://bugzilla.samba.org/show_bug.cgi?id=11182 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 5169e9b20c69092d04b596f48ca0e69a46af438f)
* s3:smbd: use STATUS_NOTIFY_CLEANUP when closing a smb2 directory handleStefan Metzmacher2015-05-202-5/+11
| | | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=11182 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit a5981d137461e5715c92a4fb4cdeaa650f34e999)
* s3:smbd: add a smbd_notify_cancel_by_map() helper functionStefan Metzmacher2015-05-201-6/+13
| | | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=11182 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 2c47fb16089602a42f62124520e58bdcd8c7d053)
* smbd:smb2: fix error code when the header says the request is signed but we ↵Michael Adam2015-05-201-1/+1
| | | | | | | | | | | | | | | don't have a sesseion I.e. when the request is a session setup. We replied with ACCESS_DENIED, but windows expects USER_SESSION_DELETED Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Wed Oct 2 22:07:44 CEST 2013 on sn-devel-104 (cherry picked from commit c3a5fecdc1ff0320f4979fa21aa636aacaac8abe)
* s3:smb2_server: don't rely on the SMB2_HDR_FLAG_SIGNED if signing is requiredStefan Metzmacher2015-05-201-1/+1
| | | | | | | | | Windows (at least the test suites) may skip the SMB2_HDR_FLAG_SIGNED in a reauth session setup, but still provide a valid signature. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> (cherry picked from commit 4a7b792bc6d463a3aa4e1150a271ed6b929276cc)
* VERSION: Bump version up to 4.1.19...Karolin Seeger2015-05-111-2/+2
| | | | | | and re-enable git snapshots. Signed-off-by: Karolin Seeger <kseeger@samba.org>
* WHATSNEW: Add release notes for Samba 4.1.18.samba-4.1.18Karolin Seeger2015-05-101-3/+132
| | | | Signed-off-by: Karolin Seeger <kseeger@samba.org>
* s3: nmbd: Don't set work_changed = True inside update_server_ttl().Jeremy Allison2015-05-061-5/+0
| | | | | | | | | | | | | | | | | | | | | | | This is taken care of inside expire_servers() when it calls remove_server_from_workgroup(). Ensure the only functions in nmbd_serverlistdb.c that set subnet->work_changed are: remove_all_servers() add_server_to_workgroup() remove_server_from_workgroup() Fix inspired by a change from Volker. https://bugzilla.samba.org/show_bug.cgi?id=11254 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> (cherry picked from commit c3c820a661c092de31d56c16c8cd1ec57999d2f7) Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Wed May 6 22:32:36 CEST 2015 on sn-devel-104
* s3: nmbd: Ensure we only set work_changed = true if we modify the record.Jeremy Allison2015-05-061-5/+17
| | | | | | | | https://bugzilla.samba.org/show_bug.cgi?id=11254 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> (cherry picked from commit db6572ef80e20b0e577b9e9fb5d233f8bdd20713)
* vfs: kernel_flock and named streamsRalph Boehme2015-05-062-0/+19
| | | | | | | | | | | | | | Streams implementing VFS modules may implement streams in a way that the fsp will have the basefile open in the fsp fd, so lacking a distinct fd for the stream, kernel_flock will apply on the basefile which is wrong. The actual check is deffered to the VFS module implementing the kernel_flock call. Bug: https://bugzilla.samba.org/show_bug.cgi?id=11243 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit d748652e5b1c1c0238a2b86cdf14d7f6de7ce9b2)