summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* WHATSNEW: Add another change.samba-3.6.2Karolin Seeger2012-01-251-0/+1
| | | | | Jeremy, thanks a lot for the fix! (cherry picked from commit a3dcfb66bb3763ee95f2bfe8b7a615ffee859985)
* s3-spoolss: Pass the right pointer type.Jeremy Allison2012-01-251-1/+1
| | | | | Follow-up fix for an issue introduced by a fix for bug #4942. (cherry picked from commit 69fafa216ee45829d330e9564858f6702b4b268d)
* WHATSNEW: Add another change.Karolin Seeger2012-01-231-0/+2
| | | | | Karolin (cherry picked from commit 788c8af4453bcb711da2712d8526c22689b49d38)
* Second part of fix for 8636 - When returning an ACL without SECINFO_DACL ↵Jeremy Allison2012-01-231-2/+4
| | | | | | | | | | | | | | requested, we still set SEC_DESC_DACL_PRESENT in the type field. Ensure we always ask for the set: OWNER_SECURITY_INFORMATION | GROUP_SECURITY_INFORMATION | DACL_SECURITY_INFORMATION | SACL_SECURITY_INFORMATION when getting an ACL inside the module. (cherry picked from commit 4eb17aff84dc0dccec23e066db7a88581cf7668c)
* Fix bug 8636 - When returning an ACL without SECINFO_DACL requested, we ↵Jeremy Allison2012-01-232-0/+4
| | | | | | | | | still set SEC_DESC_DACL_PRESENT in the type field. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Wed Nov 30 04:59:07 CET 2011 on sn-devel-104 (cherry picked from commit da992be64f39364fbb8bca26e9421c7a36c49ac6) (cherry picked from commit c0ad67c1888e44be77d8f34681f12fc8b4f19f86)
* WHATSNEW: Add major changes.Karolin Seeger2012-01-231-2/+4
| | | | | | | Please feel free to add more entries. Karolin (cherry picked from commit 0b19c19ec6057b03fe0cbee91bbf974ca6bf3221)
* WHATSNEW: Add more changes.Karolin Seeger2012-01-231-0/+2
| | | | | Karolin (cherry picked from commit db645b334e591133d664a7d1f88e82925ad52c40)
* torture: add spoolss overlapping driver deletion testsDavid Disseldorp2012-01-231-1/+118
| | | | | | | The last 7 patches address bug #8697 (DeletePrinterDriverEx never removes printer driver files) and bug #4942 (DeletePrinterDriverEx deletes files in use). (cherry picked from commit c4a3d988a64723a51be4b3ddaddd83708d90ed13)
* torture: confirm printer driver file removalDavid Disseldorp2012-01-231-1/+81
| | | | (cherry picked from commit 31f491c98c07e468e1f0e840f6accb6da3281498)
* torture: add spoolss del printer driver testDavid Disseldorp2012-01-231-0/+63
| | | | | | Test handling of DeletePrinterDriverEx when the DPD_DELETE_ALL_FILES flag is set. (cherry picked from commit b894e6297f36b05259fc6932a7ee1c500bc806e9)
* s3-spoolss: fix printer_driver_files_in_use() call orderingDavid Disseldorp2012-01-231-10/+13
| | | | | | | | | | | | | printer_driver_files_in_use() performs two tasks: it returns whether any of the files in the to-be-deleted driver overlap with other drivers, it also trims such files from the info structure passed in. In processing a DeletePrinterDataEx request with DPD_DELETE_UNUSED_FILES set, printer_driver_files_in_use() must be called to ensure files in use by other drivers are not removed. https://bugzilla.samba.org/show_bug.cgi?id=4942 (cherry picked from commit 8e3c0ac2815bc25360bf408c50449d154b841f8a)
* s3-spoolss: fix printer driver version deletionDavid Disseldorp2012-01-231-174/+128
| | | | | | | | | Spoolss delete printer driver code currently makes invalid version assumptions based on the architecture requested by the client. Ugly hacks are in place to cover removal of other versions (2 and 3). This change wraps multi version deletion in a simple for loop. (cherry picked from commit 54bc662adb24be9950c827446130b91504965c8c)
* s3-spoolss: prefix print$ path on driver file deletionDavid Disseldorp2012-01-231-44/+37
| | | | | | | | Driver file paths stored in the registry do not include the server path prefix. delete_driver_files() incorrectly assumes such a prefix. https://bugzilla.samba.org/show_bug.cgi?id=8697 (cherry picked from commit c14586647451a878fdc911ee4be699b3e6485b83)
* spoolss: fix DPD_DELETE_ALL_FILES error returnDavid Disseldorp2012-01-231-2/+1
| | | | | | | | | | If DeletePrinterDriverEx is called with DPD_DELETE_ALL_FILES and files assigned to the to-be-deleted driver overlap with other drivers then an error is returned. Change the error code here to match Windows 2k8r2. Signed-off-by: David Disseldorp <ddiss@samba.org> Signed-off-by: Andreas Schneider <asn@samba.org> (cherry picked from commit 29c97b7132ac316327123f200a71e70317b2dbb9)
* WHATSNEW: Add more changes since 3.6.1.Karolin Seeger2012-01-231-0/+85
| | | | | Karolin (cherry picked from commit f71b7a83c4cc3d10085ed1b7db29e222a4a9f743)
* WHATSNEW: Start release notes for 3.6.2.Karolin Seeger2012-01-231-1/+48
| | | | | | | To be continued... Karolin (cherry picked from commit 3ea8d8acaefaadd2d3888bec1ef148b7242aaccf)
* [PATCH] s3: improve the code in the AES encryption.Matthieu Patou2012-01-231-8/+8
| | | | | | | | Remove looping replace them by memcpy. Fix bug #8674 (Buffer overflow in vfs_smb_traffic_analyzer). . (cherry picked from commit 0971582873f90bb592355fb53171d09a8ff3012e)
* s3: Fix bug #8674.Jeremy Allison2012-01-231-2/+1
| | | | | Buffer overflow issue with AES encryption in samba traffic analyzer. (cherry picked from commit bb38a79656b6ddee01327c328435043a7d0a112b)
* Third part of fix for bug #8673 - NT ACL issue.Jeremy Allison2012-01-231-4/+8
| | | | | | (Not needed in master as this code has changed). Ensure we set a temp access mask before calling open(O_RDONLY|O_DIRECTORY) on the directory. (cherry picked from commit 6b72809b7488cc530f47ad08dfde215627681cf6)
* Second part of fix for bug #8673 - NT ACL issue.Jeremy Allison2012-01-231-3/+4
| | | | | | | | | Ensure we process the entire ACE list instead of returning ACCESS_DENIED and terminating the walk - ensure we only return the exact bits that cause the access to be denied. Some of the S3 fileserver needs to know if we are only denied DELETE access before overriding it by looking at the containing directory ACL. (cherry picked from commit 28834ee4fcfc204fa9a88459700fed212a1e9fce)
* First part of fix for bug #8673 - NT ACL issue.Jeremy Allison2012-01-231-18/+34
| | | | | | Simplify the logic in the unlink/rmdir calls - makes it readable (and correct). Add some debug. (cherry picked from commit d40006aa7f8a594273a9d0ad1fa1a87ae7b1ebb0)
* Third part of fix for bug #8663 - deleting a symlink fails if the symlink ↵Jeremy Allison2012-01-232-12/+21
| | | | | | | | | | target is outside of the share. can_access_file_acl() - we can always delete a symlink. can_delete_file_in_directory() - We don't need to do another STAT call here, we know smb_fname->st is in a valid state. smbd_check_open_rights() - we can always delete a symlink. (cherry picked from commit c6bd2aa768ebf4308c53d057bc1db7adc2b67705)
* Second part of fix for bug #8663 - deleting a symlink fails if the symlink ↵Jeremy Allison2012-01-231-1/+9
| | | | | | | | target is outside of the share. Ensure we use UCF_UNIX_NAME_LOOKUP flags on filename_convert() when doing a restricted set of infolevels in trans2setfilepathinfo(). (cherry picked from commit cb5f2b3f9d5710ba66182e45bf8380c2f37b4190)
* First part of fix for bug #8663 - deleting a symlink fails if the symlink ↵Jeremy Allison2012-01-231-12/+0
| | | | | | | | target is outside of the share. Remove two unneeded check_name() calls. They have already been done in order to get here. (cherry picked from commit 8799e63b3859502e724cb870c954a0c03ce860e2)
* Fix bug 8710 - connections.tdb - major leak with SMB2.Jeremy Allison2012-01-233-22/+78
| | | | | | | | | | | Ensure the cnum used to claim the connection for SMB2 is the id that will be used for the SMB2 tcon. Based on code from Ira Cooper <ira@wakeful.net>. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Wed Jan 18 23:14:32 CET 2012 on sn-devel-104 (cherry picked from commit 39c627b60754bd89c419b2d7e32d32c7a9af5a11) (cherry picked from commit a455a63eaf84024f79922e95a740bf3443f37954)
* Fix bug #8664 - Renaming a symlink fails if the symlink target is outside of ↵Jeremy Allison2012-01-231-2/+4
| | | | | | the share. (cherry picked from commit 6e77eac8f21925460e3b1946c2c22f6eff296322)
* idl: add to_null propertyDavid Disseldorp2012-01-231-1/+8
| | | | | | | | | | | | | | to_null specifies that character conversion should only occur until the null pointer in an array based string. Signed-off-by: Jeremy Allison <jra@samba.org> Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Sat Jan 14 00:51:54 CET 2012 on sn-devel-104 The last 5 patches address bug #8606 (Intermittent print job failures caused by character conversion errors). (cherry picked from commit c92513e218432ba3fb4afe6e93c8c1fc8f684368)
* idl: add to_null attribute to the spoolss devicename arrayDavid Disseldorp2012-01-231-1/+1
| | | | | | | | | OpenPrinterEx requests have also been observed in the wild carrying non-utf16 garbage after the device mode devicename field null terminator. Signed-off-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 90f3708135ef6573997417bd8e53191df78519c2)
* idl: add to_null attribute to the spoolss formname arrayDavid Disseldorp2012-01-231-1/+1
| | | | | | | | | | | | | | | OpenPrinterEx requests have been observed in the wild carrying a device mode formname "A4" followed by non-utf16 garbage after the null terminator. Such requests currently fail during unmarshalling in the ndr_pull_charset() codepath, causing intermittent print job failures. This change ensures that garbage after the device mode formname null terminator is not processed in unmarshalling. https://bugzilla.samba.org/show_bug.cgi?id=8606 Signed-off-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 219d8c916fd890ca4b4eae77abd5a651aa37e4ff)
* ndr: add ndr_pull_charset_to_null()David Disseldorp2012-01-232-0/+33
| | | | | | | | The same as ndr_pull_charset(), however only perform character conversion on bytes prior to and including the null terminator. Signed-off-by: Jeremy Allison <jra@samba.org> (cherry picked from commit aa8fbd5005c06dfd0b5ee2865c49eab285f57e62)
* idl: add parser for the to_null propertyDavid Disseldorp2012-01-231-1/+5
| | | | | | | Compile into a ndr_pull_charset_to_null call. Signed-off-by: Jeremy Allison <jra@samba.org> (cherry picked from commit ec05a11c362f0aa4875c8dd3cfb853d0fae84c4c)
* s3-libads: fix malloc/talloc mismatch in ads_keytab_verify_ticket().Günther Deschner2012-01-231-1/+1
| | | | | | | | Guenther Fix big #8692 (ads_keytab_verify_ticket mixes talloc allocation with malloc free). (cherry picked from commit 6da7abe87db15d260db807643a25a96fc05e5ad9)
* libcli/cldap: fix a crash bug in cldap_socket_recv_dgram() (bug #8593)Stefan Metzmacher2012-01-231-5/+5
| | | | | | | | | | | | After a calling any wrapper of tevent_req_notify_callback(), e.g. tevent_req_nterror(), tevent_req_done(), tevent_req_nomem(), a function has to return immediately otherwise it is very likely to crash. metze (similar to commit 17f1a97a614db4ed8292544988cb6a6cf56621d8) (cherry picked from commit 740a001971bab647c1ab129b3dd2fbccaddc4e7b)
* s3:lib/ctdbd_conn: try ctdbd_init_connection() as root (bug #8684)Stefan Metzmacher2012-01-231-0/+2
| | | | | | | | | | | | | ctdbd_traverse is only called if the main db_context is already open. So if we could get to information via dbwrap_fetch, we should also be able to traverse. metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Fri Dec 23 18:19:14 CET 2011 on sn-devel-104 (cherry picked from commit 4a1895eb9921ad533910d08823c2814c470875fd) (cherry picked from commit ff4e1df575a3d7eb484b31d6afe46825ba418981)
* s3-printing: fix migrate printer code (bug 8618)Björn Baumbach2012-01-231-0/+27
| | | | | | Removed path from driver files. We only need the basenames. (cherry picked from commit d61993043fcb7676a58658476421f5f4ff1a3fea)
* Fix bug #8686 - Packet validation checks can be done before length ↵Volker Lendecke2012-01-231-2/+2
| | | | | | validation causing uninitialized memory read. (cherry picked from commit 24ac26ddfd9ee8841d1984e710a4dfe535b9abcf)
* Fix bug #8687 - net memberships usage info is wrongJeremy Allison2012-01-231-1/+1
| | | | | | | | Typo in usage. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Fri Jan 6 00:30:20 CET 2012 on sn-devel-104 (cherry picked from commit 0453544900ef2ebff7a3c677d4048ef530713b64)
* s3-libsmb: Don't duplicate kerberos service tickets.Andreas Schneider2012-01-231-5/+0
| | | | | | | | | | | | | This fixes bug #8628. Each time we do a client connection. Each time we call to function to get the service ticket from the cache we duplicate it. So with each connection we end up with one or three duplicated tickets. Autobuild-User: Andreas Schneider <asn@cryptomilk.org> Autobuild-Date: Thu Dec 15 19:30:42 CET 2011 on sn-devel-104 (cherry picked from commit d0330c7dd64b320cd86e2341b31da6be81ba829b) (cherry picked from commit 60cb113d98d98200b1d8b279591c930e6b0d1857)
* Final part of fix for bug #8679 - recvfile code path using splice() on Linux ↵Jeremy Allison2012-01-231-5/+0
| | | | | | | | | | | | | | | leaves data in the pipe on short write. The code to set a DOS error on short writeX return is amazingly legacy code, and also breaks the reply as fixup_chain_error_packet() enforces a 2-byte wct on any reply where smb_rcls != 0. Found in testing by Andrew Bartlett. Thanks Andrew ! Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Sat Dec 31 08:05:35 CET 2011 on sn-devel-104 (cherry picked from commit e39df67669f61056692736db9c8dc16fbf2c3624) (cherry picked from commit 627f57f0714f257c6082b21447d122935c6e92e2)
* Third part of fix for bug #8679 - recvfile code path using splice() on Linux ↵Jeremy Allison2012-01-231-21/+18
| | | | | | | | | | leaves data in the pipe on short write. Fix default_sys_recvfile() to correctly cope with short writes. Return the amount written. Return -1 and set errno if no data could be written. (cherry picked from commit 5e6263960aaf1a5f9993cb7bb5646d36ff92b9cc) (cherry picked from commit ec9b07e84e806705e22f0cf2eb527fed14efac55)
* Second part of fix for bug #8679 - recvfile code path using splice() on ↵Jeremy Allison2012-01-231-1/+30
| | | | | | | | | Linux leaves data in the pipe on short write. Split out the functionality of drain_socket() into a separate function from default_sys_recvfile(). (cherry picked from commit a5715420e37b98038fe8f2c3028e4c6938400eed) (cherry picked from commit 7924e459b6677ba3500afff4b78f797e1e0ad83d)
* Fix bug #8679 - recvfile code path using splice() on Linux leaves data in ↵Jeremy Allison2012-01-231-3/+2
| | | | | | | | | | | the pipe on short write Bug found and fix suggested by Andrew Bartlett. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Sun Dec 25 07:46:38 CET 2011 on sn-devel-104 (cherry picked from commit eb617374a673bb1189dd9b6bccbf3f1d9fb91010) (cherry picked from commit b3f344b5b52096715eb5670b146f477a67af8245)
* s3-cli: fix bug 563, >8GB tar on BE machinesMasafumi Nakayama2012-01-231-5/+17
| | | | | | | | | | | Borrows on existing patches proposed by Craig Barratt and Brad Ellis. Signed-off-by: David Disseldorp <ddiss@suse.de> Autobuild-User: David Disseldorp <ddiss@samba.org> Autobuild-Date: Tue Jan 3 18:31:28 CET 2012 on sn-devel-104 (cherry picked from commit 909056a2daacd961b40158b86bc117650a897054) (cherry picked from commit ab62ee622358362d4d2b16c7fec9a1f2cf7b8d8d)
* s3-winbind: Fix segfault if we can't map the last user.Andreas Schneider2012-01-231-0/+18
| | | | | | | | | | | This fixes bug #8678. The issue is caused by bug #8608. Autobuild-User: Andreas Schneider <asn@cryptomilk.org> Autobuild-Date: Wed Jan 4 18:30:53 CET 2012 on sn-devel-104 (cherry picked from commit b9d208bdaa9da2a5ae534481865efc881b851b01) (cherry picked from commit 23db6e7cf65bdd3974a4857dda0be6ad7d758b9a)
* s3-winbind: Move finding the domain to it's own function.Andreas Schneider2012-01-231-11/+21
| | | | | | This the first part to fix bug #8678. (cherry picked from commit 5075e565684627dfbd23f715da344b4365351ccb) (cherry picked from commit 2fca06a63d47619f2b6902b1c8601021843c4b95)
* Fix bug #8644 - vfs_acl_xattr and vfs_acl_tdb modules can fail to add ↵Jeremy Allison2012-01-231-1/+1
| | | | | | | | inheritable entries on a directory with no stored ACL. If referring to an fsp sbuf can be left as an uninitialized variable, causing the 'is_directory' variable to be false when it should be true. (cherry picked from commit 16c0d52842386fc2ebf975166b57b888d36796c5)
* s3/doc: document the ignore system acls option of vfs_acl_xattr and vfs_acl_tdbBjörn Jacke2012-01-232-6/+40
| | | | | | | | | | | Autobuild-User: Björn Jacke <bj@sernet.de> Autobuild-Date: Sat Dec 10 15:30:46 CET 2011 on sn-devel-104 (cherry picked from commit f452add2231906742c9fd119371cd4fd81a1bdd6) Fix bug #8652 (vfs_acl man pages miss "ignore system acls" option). Fix bug #8652 (vfs_acl man pages miss "ignore system acls" option). (cherry picked from commit ceeab5c66cef2c5aa7931329a9976c8173f44467)
* s3: Fix bug 8371Volker Lendecke2012-01-231-0/+2
| | | | | | | ndr_set_flag or's in the given flag (ALIGN4). At this point, ndr->flags contains NOALIGN, which will persist. In ndr_push_DATA_BLOB NOALIGN overrides everything else, so that the ALIGN4 is not respected. (cherry picked from commit 6cb605364e83fe0c5562c9b0920408c697e4fc3e)
* s3-winbind: Add an update function for winbind cache.Andreas Schneider2012-01-231-2/+94
| | | | | | | | | | | With 57b3d32 we changed the format for the winbind cache database and the code deleted the database for the upgrade. As this database holds also cached credentials, removing it is not an option. We need to update from version 1 to version 2. Fix bug #8643 (A Samba update to 3.6 deletes the winbind cache with cached credentials). (cherry picked from commit df616e928e08646bbc234af673a496117535c6d8)
* s3: Attempt to fix the vfs_commit moduleVolker Lendecke2012-01-231-1/+1
| | | | | | | | | This bug went in in 2007. I wonder how much this module is actually used.... Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Wed Nov 30 21:46:09 CET 2011 on sn-devel-104 (cherry picked from commit b638abf70a3c9b2815344454946c0931295551be) (cherry picked from commit 33a8e161401b889feca19b2bb9222509cf77c37d)
View Lorry Controller Status