summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* s3:smbd: Out-by-4 error in smbd read reply max_send clampRobert Sprowson2022-06-091-2/+2
| | | | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14443 Signed-off-by: Robert Sprowson <webpages@sprow.co.uk> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Noel Power <noel.power@suse.com> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Jun 8 19:50:08 UTC 2022 on sn-devel-184 (cherry picked from commit 174a76cc27f25120af5a86bee3f26d9afad87d8f) Autobuild-User(v4-16-test): Jule Anger <janger@samba.org> Autobuild-Date(v4-16-test): Thu Jun 9 11:14:52 UTC 2022 on sn-devel-184
* s3:printing: Start samba-bgqd as soon as possibleAndreas Schneider2022-06-091-4/+4
| | | | | | | | | | | | | We need some time to fill the printcap cache. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15081 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit ac16351ff5a0c5b46f461c26516b85e8483bba83) Autobuild-User(v4-16-test): Jule Anger <janger@samba.org> Autobuild-Date(v4-16-test): Thu Jun 9 10:03:29 UTC 2022 on sn-devel-184
* s3:printing: Initialize the printcap cache as soon as the bgqd startsAndreas Schneider2022-06-091-0/+3
| | | | | | | | | | | As soon as the background daemon starts, we need to initialize the printcap cache so that rpcd-spoolssd can serve printers. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15081 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 3b5b80e99603e4c1d4d1080ed45bd75116a9fa8e)
* lib/util/gpfswrap: remove unused gpfswrap_get_winattrs_path()Ralph Boehme2022-06-092-16/+0
| | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=15069 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Christof Schmitt <cs@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri Jun 3 21:53:31 UTC 2022 on sn-devel-184 (cherry picked from commit 3bd753983c8dac33b483affa859984b7e3350d65)
* vfs_gpfs: use handle based gpfswrap_get_winattrs()Ralph Boehme2022-06-091-6/+6
| | | | | | | | | | | | | | | | Fixes detecting offline flag for files in snapshot – no idea if this is actually expected. Replaces path based gpfswrap_get_winattrs_path() with handle based version gpfswrap_get_winattrs(). When dealing with files in snapshots fsp->fsp_name points to the active dataset, which will cause ENOENT failures if files are deleted there any only present in the snapshot. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15069 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Christof Schmitt <cs@samba.org> (cherry picked from commit 8ae672f955bf07bb97f38b7d2f965f14e8315e9e)
* lib/util/gpfswrap: remove unused gpfswrap_getacl()Ralph Boehme2022-06-092-13/+0
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=15069 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Christof Schmitt <cs@samba.org> (cherry picked from commit 9172c5ff6a419e4daef451564650d4a3ce96bfae)
* vfs_gpfs: finally: use gpfswrap_fgetacl() instead of gpfswrap_getacl()Ralph Boehme2022-06-091-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | Replaces path based gpfswrap_getacl() with handle based version gpfswrap_fgetacl(). When dealing with files in snapshots fsp->fsp_name points to the active dataset, which will cause ENOENT failures if files are deleted there any only present in the snapshot: [2022/05/06 11:32:55.233435, 4, pid=12962, effective(1460548, 273710), real(1460548, 0)] calling open_file with flags=0x0 flags2=0x800 mode=0644, access_mask = 0x80, open_access_mask = 0x80 [2022/05/06 11:32:55.233460, 10, pid=12962, effective(1460548, 273710), real(1460548, 0), class=vfs] gpfs_get_nfs4_acl invoked for dir/subdir/file.txt [2022/05/06 11:32:55.233495, 5, pid=12962, effective(1460548, 273710), real(1460548, 0), class=vfs] smbd_gpfs_getacl failed with No such file or directory [2022/05/06 11:32:55.233521, 9, pid=12962, effective(1460548, 273710), real(1460548, 0), class=vfs] gpfs_getacl failed for dir/subdir/file.txt with No such file or directory [2022/05/06 11:32:55.233546, 10, pid=12962, effective(1460548, 273710), real(1460548, 0)] smbd_check_access_rights_fsp: Could not get acl on dir/subdir/file.txt {@GMT-2022.05.04-11.58.53}: NT_STATUS_OBJECT_NAME_NOT_FOUND BUG: https://bugzilla.samba.org/show_bug.cgi?id=15069 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Christof Schmitt <cs@samba.org> (cherry picked from commit a0dc4c9026519c949070dc001e7addad7c7d35ce)
* lib/util/gpfswrap: add gpfswrap_fgetacl()Ralph Boehme2022-06-092-0/+13
| | | | | | | | | | Adds handle based version of gpfswrap_getacl(). BUG: https://bugzilla.samba.org/show_bug.cgi?id=15069 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Christof Schmitt <cs@samba.org> (cherry picked from commit d373ff3c01c2c50cd539b78494c0673974a0f046)
* vfs_gpfs: pass fsp to gpfs_getacl_with_capability()Ralph Boehme2022-06-091-3/+5
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=15069 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Christof Schmitt <cs@samba.org> (cherry picked from commit 1b2c70f4d16e48998c9c8bc9e22ee8eb3c0ad53e)
* vfs_gpfs: pass fsp to vfs_gpfs_getacl()Ralph Boehme2022-06-091-7/+6
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=15069 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Christof Schmitt <cs@samba.org> (cherry picked from commit ac458648aa3f557b7f137f7efa88806f7cb0da71)
* vfs_gpfs: use fsp in gpfsacl_get_posix_acl()Ralph Boehme2022-06-091-2/+2
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=15069 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Christof Schmitt <cs@samba.org> (cherry picked from commit 3764be70319d8e953a6205649fecaed06c93dbc8)
* vfs_gpfs: pass fsp to gpfsacl_get_posix_acl()Ralph Boehme2022-06-091-3/+4
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=15069 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Christof Schmitt <cs@samba.org> (cherry picked from commit c26efe0c23b426c4a1e7073b040da85df6f1ea61)
* vfs_gpfs: pass fsp to gpfs_get_nfs4_acl()Ralph Boehme2022-06-091-3/+5
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=15069 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Christof Schmitt <cs@samba.org> (cherry picked from commit 5f4625a2859bf622ea2034e5bbf63f9959e58b78)
* vfs_gpfs: pass fsp to gpfsacl_emu_chmod()Ralph Boehme2022-06-091-4/+5
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=15069 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Christof Schmitt <cs@samba.org> (cherry picked from commit ad06d806831c80a1169468d18b3e59b239a5ba77)
* vfs_gpfs: indentation and README.Coding fixesRalph Boehme2022-06-091-17/+19
| | | | | | | | | | Best viewed with git show -w. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15069 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Christof Schmitt <cs@samba.org> (cherry picked from commit a0f7ced610013cad145ff14cedcfbb5388d1ea4f)
* s3/client: Restore '-E' handlingNoel Power2022-05-302-1/+5
| | | | | | | | | | | | | | | | | | | | | | Sometimes we really do need to redirect output to stderr e.g. when using the tar command to output the archive to stdout we don't want debug or cmdline status messages straying into stdout. was removed with commit: e4474ac0a540c56548b4d15e38f2e234455e19b6 remove known fail for the test BUG: https://bugzilla.samba.org/show_bug.cgi?id=15075 Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Noel Power <npower@samba.org> Autobuild-Date(master): Tue May 24 10:29:27 UTC 2022 on sn-devel-184 (cherry picked from commit 56e179817123b40c3646476563d345d8f97efff9) Autobuild-User(v4-16-test): Jule Anger <janger@samba.org> Autobuild-Date(v4-16-test): Mon May 30 09:10:47 UTC 2022 on sn-devel-184
* s3/script/tests: Test smbclient -E redirects output to stderrNoel Power2022-05-302-0/+46
| | | | | | | | | | | Add new test to ensure smbclient is writing to stderr (with '-E') Add knownfail for this test (will be removed when issue is fixed in later commit) BUG: https://bugzilla.samba.org/show_bug.cgi?id=15075 Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Andreas Schneider <asn@samba.org> (cherry picked from commit 5b6493043fc90a2bed5aaedad3b4511621d0b9fd)
* s3:libads: Clear previous CLDAP ping flags when reusing the ADS_STRUCTSamuel Cabrero2022-05-301-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before commit 1d066f37b9217a475b6b84a935ad51fbec88fe04, when the LDAP connection wasn't established yet (ads->ldap.ld == NULL), the ads_current_time() function always allocated and initialized a new ADS_STRUCT even when ads->ldap.ss had a good address after having called ads_find_dc(). After that commit, when the ADS_STRUCT is reused and passed to the ads_connect() call, ads_try_connect() may fail depending on the contacted DC because ads->config.flags field can contain the flags returned by the previous CLDAP call. For example, when having 5 DCs: * 192.168.101.31 has PDC FSMO role * 192.168.101.32 * 192.168.101.33 * 192.168.101.34 * 192.168.101.35 $> net ads info -S 192.168.101.35 net_ads_info() ads_startup_nobind() ads_startup_int() ads_init() ads_connect() ads_try_connect(192.168.101.35) check_cldap_reply_required_flags(returned=0xF1FC, required=0x0) ads_current_time() ads_connect() ads_try_connect(192.168.101.35) check_cldap_reply_required_flags(returned=0xF1FC, required=0xF1FC) The check_cldap_reply_required_flags() call fails because ads->config.flags contain the flags returned by the previous CLDAP call, even when the returned and required values match because they have different semantics: if (req_flags & DS_PDC_REQUIRED) RETURN_ON_FALSE(ret_flags & NBT_SERVER_PDC); translates to: if (0xF1FC & 0x80) RETURN_ON_FALSE(0xF1FC & 0x01); which returns false because 192.168.101.35 has no PDC FSMO role. The easiest fix for now is to reset ads->config.flags in ads_current_time() when reusing an ADS_STRUCT before calling ads_connect(), but we should consider storing the required and returned flags in different fields or at least use the same bitmap for them because check_cldap_reply_required_flags() is checking a netr_DsRGetDCName_flags value using the nbt_server_type bitmap. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14674 Signed-off-by: Samuel Cabrero <scabrero@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Mon May 23 19:18:38 UTC 2022 on sn-devel-184 (cherry picked from commit a26f535dedc651afa2a25dd37113ac71787197ff)
* third_party: Update waf to version 2.0.24Andreas Schneider2022-05-307-9/+26
| | | | | | | | | | | | | | This fixes building of python libraries with Python 3.11! BUG: https://bugzilla.samba.org/show_bug.cgi?id=15071 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Mon May 23 09:34:51 UTC 2022 on sn-devel-184 (cherry picked from commit d19dfe1efb2f6cb0dcf0a63b957df584d8ed5945)
* third_party: Update waf to verison 2.0.23Andreas Schneider2022-05-3021-113/+325
| | | | | | | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Mon Feb 21 10:06:27 UTC 2022 on sn-devel-184 (cherry picked from commit fb175576b698f43224dab815fd6c0763a12db2b2)
* third_party:waf: Print the version of waf at the end of the update scriptAndreas Schneider2022-05-301-1/+3
| | | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org> (cherry picked from commit 6b8d30e0aa15fff7e831c0a3e34719e8cdc1ebec)
* srvsvc: Announce [username] in NetShareEnumVolker Lendecke2022-05-202-2/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch has two flaws: First, it does not cover api_RNetShareEnum() for SMB1, and the second one is: To make this elegant, we would have to restructure our share handling. It is really only listing shares for which we have to pull in everything from smb.conf, registry, usershares and potentially printers. What we should do is modify our loadparm handling to only load share definitions on demand and for listing shares handle all the potential sources specially. Add code that walks the registry shares without adding them to our services list and so on. This patch is the quick&dirty way to fix the bug, the alternative would be weeks or more. And hopefully nobody notices the SMB1 problem... Bug: https://bugzilla.samba.org/show_bug.cgi?id=15062 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed May 18 17:42:20 UTC 2022 on sn-devel-184 (cherry picked from commit 04e0e02c6951e327130210e44deb87b9a303cdb3) Autobuild-User(v4-16-test): Jule Anger <janger@samba.org> Autobuild-Date(v4-16-test): Fri May 20 09:10:43 UTC 2022 on sn-devel-184
* srvsvc: Add a central return point to init_srv_share_info_ctr()Volker Lendecke2022-05-201-25/+73
| | | | | | | | | | Soon there will be cleanup work to do. Bug: https://bugzilla.samba.org/show_bug.cgi?id=15062 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 20cbade5b164c0e9eec744bd5a564110923a0c61)
* selftest: Test for bug 15062 -- list "username" in netshareenumVolker Lendecke2022-05-203-0/+29
| | | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=15062 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 3145131809269a33ad07261f94ee6e09e1850365)
* s3: smbd: Allow a durable handle on a leased stat-open.Jeremy Allison2022-05-092-5/+0
| | | | | | | | | | | | | | Remove knownfail. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15042 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> (back-ported from commit fe7daae8c4692b99ff08d4e3e48034d59ddee245) Autobuild-User(v4-16-test): Jule Anger <janger@samba.org> Autobuild-Date(v4-16-test): Mon May 9 08:18:05 UTC 2022 on sn-devel-184
* s4: torture: Add a new test - samba3.smb2.durable-open.stat-open.Jeremy Allison2022-05-093-0/+65
| | | | | | | | | | | | | | | | | | Passes against Windows. Shows that Windows allows a durable handle on a leased open for READ_ATTRUBUTES only (a stat open). Mark as knownfail for now. NB. Not sure why we are testing smb2.durable-open against ad_dc as that provisioning has "smb2 leases = no" which precludes granting durable handles. Not changing for this bug but this should be looked at in future. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15042 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> (cherry picked from commit bb329d4de505d2c01ba45a06311c9dc6d87f8dec)
* VERSION: Bump version up to Samba 4.16.2...Jule Anger2022-05-021-2/+2
| | | | | | and re-enable GIT_SNAPSHOT. Signed-off-by: Jule Anger <janger@samba.org>
* VERSION: Disable GIT_SNAPSHOT for the 4.16.1 release.samba-4.16.1Jule Anger2022-05-021-1/+1
| | | | Signed-off-by: Jule Anger <janger@samba.org>
* WHATSNEW: Add release notes for Samba 4.16.1.Jule Anger2022-05-021-0/+72
| | | | Signed-off-by: Jule Anger <janger@samba.org>
* vfs_gpfs: Ignore pathref fds for gpfs:recalls checkChristof Schmitt2022-05-021-0/+1
| | | | | | | | | | | | | | | | | | | | | | | Setting gpfs:recalls=no should prevent data access to offline files. Since Samba 4.14, the VFS openat function is also called with O_PATH to get a reference to the path. These accesses should not be blocked, otherwise this would prevent offline files from being included in directory listings. Fix this by skipping the check for pathref fds. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15055 Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Thu Apr 28 07:59:47 UTC 2022 on sn-devel-184 (cherry picked from commit 03d0dd2651c9e6552d6c3d9513810e581339ac08) Autobuild-User(v4-16-test): Jule Anger <janger@samba.org> Autobuild-Date(v4-16-test): Mon May 2 08:23:01 UTC 2022 on sn-devel-184
* s4:kdc: strictly have 2 16-bit parts in krbtgt kvnosStefan Metzmacher2022-04-281-8/+43
| | | | | | | | | | | | | | | | Even if the msDS-KeyVersionNumber of the main krbtgt account if larger than 65535, we need to have the 16 upper bits all zero in order to avoid mixing the keys with an RODC. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14951 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit ab0946a75d51b8f4826d98c61c3ad503615009fe) Autobuild-User(v4-16-test): Stefan Metzmacher <metze@samba.org> Autobuild-Date(v4-16-test): Thu Apr 28 15:42:38 UTC 2022 on sn-devel-184
* s3:passdb: Also allow to handle UPNs in lookup_name_smbconf()Andreas Schneider2022-04-281-1/+2
| | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=15054 Signed-off-by: Andreas Schneider <asn@cryptomilk.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 28fc44f2852046d03cada161ed1001d04d9e1554) Autobuild-User(v4-16-test): Jule Anger <janger@samba.org> Autobuild-Date(v4-16-test): Thu Apr 28 09:03:34 UTC 2022 on sn-devel-184
* s3:passdb: Refactor lookup_name_smbconf()Andreas Schneider2022-04-281-3/+4
| | | | | | | | | | This will be changed to support UPNs too in the next patch. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15054 Signed-off-by: Andreas Schneider <asn@cryptomilk.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 2690310743920dfe20ac235c1e3617e0f421eddc)
* s3:passdb: Use already defined pointer in lookup_name_smbconf()Andreas Schneider2022-04-281-7/+5
| | | | | | Signed-off-by: Andreas Schneider <asn@cryptomilk.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit ed8e466854d6d8d6120388716a7b604df7a4db27)
* s3:passdb: Add support to handle UPNs in lookup_name()Andreas Schneider2022-04-281-2/+12
| | | | | | | | | | | | This address an issue if sssd is running and handling nsswitch. If we look up a user with getpwnam("DOMAIN\user") it will return user@REALM in the passwd structure. We need to be able to deal with that. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15054 Signed-off-by: Andreas Schneider <asn@cryptomilk.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 2a03fb91c1120718ada9d4b8421044cb7eae7b83)
* s3:passdb: Remove trailing spaces in lookup_sid.cAndreas Schneider2022-04-281-9/+9
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=15054 Signed-off-by: Andreas Schneider <asn@cryptomilk.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 756cd0eed30322ae6dbd5402ec11441387475884)
* s3:winbind: Remove no longer used domain's private_data pointerSamuel Cabrero2022-04-152-5/+0
| | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=15046 Signed-off-by: Samuel Cabrero <scabrero@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> (cherry picked from commit a6d6ae3cfcd64a85f82ec5b12253ca0e237d95bb) Autobuild-User(v4-16-test): Jule Anger <janger@samba.org> Autobuild-Date(v4-16-test): Fri Apr 15 14:45:44 UTC 2022 on sn-devel-184
* s3:winbind: Do not use domain's private data to store the ADS_STRUCTSamuel Cabrero2022-04-154-9/+12
| | | | | | | | | | | | The ADS_STRUCT is not allocated using talloc and there are many places casting this pointer directly so use a typed pointer. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15046 Signed-off-by: Samuel Cabrero <scabrero@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> (cherry picked from commit 3cb256439e9ceece26c2de82293c43486543e0cb)
* s3:winbind: Simplify open_cached_internal_pipe_conn()Samuel Cabrero2022-04-151-6/+4
| | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=15046 Signed-off-by: Samuel Cabrero <scabrero@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> (cherry picked from commit 91395e660a2b1b69bf74ca0b77aee416e2ac1db3)
* s3:winbind: Do not use domain's private data to store the SAMR pipesSamuel Cabrero2022-04-153-15/+17
| | | | | | | | | | | | | | | | | | | | The domain's private_data pointer is also used to store a ADS_STRUCT, which is not allocated using talloc and there are many places casting this pointer directly. The recently added samba.tests.pam_winbind_setcred was randomly failing and after debugging it the problem was that kerberos authentication was failing because the time_offset passed to kerberos_return_pac() was wrong. This time_offset was retrieved from ads->auth.time_offset, where the ads pointer was directly casted from domain->private_data but private_data was pointing to a winbind_internal_pipes struct. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15046 Signed-off-by: Samuel Cabrero <scabrero@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> (cherry picked from commit e1f29b0970f4cac52a9cd517be6862cf69a1433a)
* s3: smbget: Fix auth_fn, order of //server/share parameters is mixed in prompt.Jeremy Allison2022-04-151-1/+1
| | | | | | | | | | Found by <voetelink@nrg.eu> BUG: https://bugzilla.samba.org/show_bug.cgi?id=14831 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> (cherry picked from commit f1765f91b015d64122e74c01c7c6d0984cc7af87)
* s3:auth: Fix user_in_list() for UNIX groupsPavel Filipenský2022-04-112-6/+7
| | | | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=15041 Signed-off-by: Pavel Filipenský <pfilipen@redhat.com> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Noel Power <npower@samba.org> Autobuild-User(master): Noel Power <npower@samba.org> Autobuild-Date(master): Thu Apr 7 09:49:44 UTC 2022 on sn-devel-184 (cherry picked from commit 6dc463d3e2eb229df1c4f620cfcaf22ac71738d4) Autobuild-User(v4-16-test): Jule Anger <janger@samba.org> Autobuild-Date(v4-16-test): Mon Apr 11 08:51:01 UTC 2022 on sn-devel-184
* s3:tests Test "username map" for UNIX groupsPavel Filipenský2022-04-113-0/+31
| | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=15041 Signed-off-by: Pavel Filipenský <pfilipen@redhat.com> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Noel Power <npower@samba.org> (cherry picked from commit af8747a28bd62937a01fa4648f404bd0b09a44c0)
* selftest: Add to "username.map" mapping for jackthemappergroupPavel Filipenský2022-04-111-0/+2
| | | | | | | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=15041 Only for environment ad_member_idmap_nss. * !jacknompapper = \@jackthemappergroup jackthemaper from group jackthemappergroup is mapped to jacknompapper * !root = jacknomappergroup since there is no '@' or '+' prefix, it is not an UNIX group mapping Signed-off-by: Pavel Filipenský <pfilipen@redhat.com> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Noel Power <npower@samba.org> (cherry picked from commit 0feeb6d58a6d6b1949faa842473053af4562c979)
* selftest: Create groups "jackthemappergroup" and "jacknomappergroup"Pavel Filipenský2022-04-111-0/+6
| | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=15041 Signed-off-by: Pavel Filipenský <pfilipen@redhat.com> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Noel Power <npower@samba.org> (cherry picked from commit 26e4268d6e3bde74520e36f3ca3cc9d979292d1d)
* selftest: Create users "jackthemapper" and "jacknomapper"Pavel Filipenský2022-04-111-1/+11
| | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=15041 Signed-off-by: Pavel Filipenský <pfilipen@redhat.com> Reviewed-by: Noel Power <npower@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 1b0146182224fe01ed70815364656a626038685a)
* vfs_shadow_copy2: implement readdir()Ralph Boehme2022-04-112-1/+91
| | | | | | | | | | | | | RN: shadow_copy2 fails listing snapshotted dirs with shadow:fixinodes BUG: https://bugzilla.samba.org/show_bug.cgi?id=15035 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Mar 31 18:47:42 UTC 2022 on sn-devel-184 (cherry picked from commit 9fa67ba8eeb6249d4b91b894e80eb1985c845314)
* CI: add a test listing a snapshotted directoryRalph Boehme2022-04-113-0/+190
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=15035 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit ba9c5ba8ec54e72d68e3f753a5350afe0fb50a7c)
* CI: avoid smb2.twrp being run by plansmbtorture4testsuite() directlyRalph Boehme2022-04-112-0/+4
| | | | | | | | | | | This should only be run by a blackbox test. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15035 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (backported from commit f734e960eb7ad98808ad8757de51c51d3db86a2b) [slow@samba.org: conflict in source3/selftest/tests.py caused by new test in master not present in 4.16]
* s3: smbd: Preserve the fsp->fsp_name->st buf across a MSG_SMB_FILE_RENAME ↵Jeremy Allison2022-04-112-1/+20
| | | | | | | | | | | | | message. Remove knownfail.d/rename-full-info BUG: https://bugzilla.samba.org/show_bug.cgi?id=15038 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> (Back-ported from commit 06bfac2125da5e4d37a596d1213912f0c698e69e)
View Lorry Controller Status