diff options
author | Joe Guo <joeg@catalyst.net.nz> | 2018-07-30 18:17:02 +1200 |
---|---|---|
committer | Douglas Bagnall <dbagnall@samba.org> | 2018-08-24 07:49:27 +0200 |
commit | 562411bd9587bdd011bd70e25f9763c38a8af401 (patch) | |
tree | c2a3f2753ead19a35df6259cb1be3dd28dda4473 /wintest | |
parent | a9551edaeebdb2e8c209a843bae7088e60946e96 (diff) | |
download | samba-562411bd9587bdd011bd70e25f9763c38a8af401.tar.gz |
PEP8: fix E202: whitespace before ')'
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Diffstat (limited to 'wintest')
-rwxr-xr-x | wintest/test-s3.py | 4 | ||||
-rwxr-xr-x | wintest/test-s4-howto.py | 22 | ||||
-rw-r--r-- | wintest/wintest.py | 2 |
3 files changed, 14 insertions, 14 deletions
diff --git a/wintest/test-s3.py b/wintest/test-s3.py index 3272f277eaa..145aed96cb8 100755 --- a/wintest/test-s3.py +++ b/wintest/test-s3.py @@ -52,7 +52,7 @@ def test_wbinfo(t): casefold=True) t.cmd_contains("bin/wbinfo -u", ["${WIN_DOMAIN}/administrator", - "${WIN_DOMAIN}/krbtgt" ], + "${WIN_DOMAIN}/krbtgt"], casefold=True) t.cmd_contains("bin/wbinfo -g", ["${WIN_DOMAIN}/domain users", @@ -152,7 +152,7 @@ def join_as_member(t, vm): t.setwinvars(vm) t.info("Joining ${WIN_VM} as a member using net ads join") t.port_wait("${WIN_IP}", 389) - t.retry_cmd("host -t SRV _ldap._tcp.${WIN_REALM} ${WIN_IP}", ['has SRV record'] ) + t.retry_cmd("host -t SRV _ldap._tcp.${WIN_REALM} ${WIN_IP}", ['has SRV record']) t.cmd_contains("bin/net ads join -Uadministrator%${WIN_PASS}", ["Joined"]) t.cmd_contains("bin/net ads testjoin", ["Join is OK"]) t.cmd_contains("bin/net ads dns register ${HOSTNAME}.${WIN_REALM} -P", ["Successfully registered hostname with DNS"]) diff --git a/wintest/test-s4-howto.py b/wintest/test-s4-howto.py index e646d5b91c8..694f8c549e0 100755 --- a/wintest/test-s4-howto.py +++ b/wintest/test-s4-howto.py @@ -206,7 +206,7 @@ def test_dcpromo(t, vm): # the first replication will transfer the dnsHostname attribute t.cmd_contains("bin/samba-tool drs replicate ${HOSTNAME}.${LCREALM} ${WIN_HOSTNAME} CN=Configuration,${BASEDN} -k yes", ["was successful"]) - for nc in ['${BASEDN}', 'CN=Configuration,${BASEDN}', 'CN=Schema,CN=Configuration,${BASEDN}' ]: + for nc in ['${BASEDN}', 'CN=Configuration,${BASEDN}', 'CN=Schema,CN=Configuration,${BASEDN}']: t.cmd_contains("bin/samba-tool drs replicate ${HOSTNAME}.${LCREALM} ${WIN_HOSTNAME}.${LCREALM} %s -k yes" % nc, ["was successful"]) t.cmd_contains("bin/samba-tool drs replicate ${WIN_HOSTNAME}.${LCREALM} ${HOSTNAME}.${LCREALM} %s -k yes" % nc, ["was successful"]) @@ -242,7 +242,7 @@ def test_dcpromo(t, vm): "CN=Configuration,${BASEDN}", "Last success", "CN=Configuration,${BASEDN}", - "Last success" ], + "Last success"], ordered=True, regex=True) @@ -369,7 +369,7 @@ def test_dcpromo_rodc(t, vm): child.expect("CN=Configuration,${BASEDN}") child.expect("was successful") - for nc in ['${BASEDN}', 'CN=Configuration,${BASEDN}', 'CN=Schema,CN=Configuration,${BASEDN}' ]: + for nc in ['${BASEDN}', 'CN=Configuration,${BASEDN}', 'CN=Schema,CN=Configuration,${BASEDN}']: t.cmd_contains("bin/samba-tool drs replicate --add-ref ${WIN_HOSTNAME}.${LCREALM} ${HOSTNAME}.${LCREALM} %s" % nc, ["was successful"]) t.cmd_contains("bin/samba-tool drs showrepl ${HOSTNAME}.${LCREALM}", @@ -380,7 +380,7 @@ def test_dcpromo_rodc(t, vm): "CN=Configuration,${BASEDN}", "Last attempt.*was successful", "CN=Configuration,${BASEDN}", - "Last attempt.*was successful" ], + "Last attempt.*was successful"], ordered=True, regex=True) @@ -411,9 +411,9 @@ def join_as_dc(t, vm): t.setwinvars(vm) t.info("Joining ${WIN_VM} as a second DC using samba-tool domain join DC") t.port_wait("${WIN_IP}", 389) - t.retry_cmd("host -t SRV _ldap._tcp.${WIN_REALM} ${WIN_IP}", ['has SRV record'] ) + t.retry_cmd("host -t SRV _ldap._tcp.${WIN_REALM} ${WIN_IP}", ['has SRV record']) - t.retry_cmd("bin/samba-tool drs showrepl ${WIN_HOSTNAME}.${WIN_REALM} -Uadministrator%${WIN_PASS}", ['INBOUND NEIGHBORS'] ) + t.retry_cmd("bin/samba-tool drs showrepl ${WIN_HOSTNAME}.${WIN_REALM} -Uadministrator%${WIN_PASS}", ['INBOUND NEIGHBORS']) t.run_cmd('bin/samba-tool domain join ${WIN_REALM} DC -Uadministrator%${WIN_PASS} -d${DEBUGLEVEL} --option=interfaces=${INTERFACE}') t.run_cmd('bin/samba-tool drs kcc ${WIN_HOSTNAME}.${WIN_REALM} -Uadministrator@${WIN_REALM}%${WIN_PASS}') @@ -432,7 +432,7 @@ def test_join_as_dc(t, vm): t.run_cmd('bin/samba-tool drs kcc ${HOSTNAME}.${WIN_REALM} -Uadministrator@${WIN_REALM}%${WIN_PASS}') t.kinit("administrator@${WIN_REALM}", "${WIN_PASS}") - for nc in ['${WIN_BASEDN}', 'CN=Configuration,${WIN_BASEDN}', 'CN=Schema,CN=Configuration,${WIN_BASEDN}' ]: + for nc in ['${WIN_BASEDN}', 'CN=Configuration,${WIN_BASEDN}', 'CN=Schema,CN=Configuration,${WIN_BASEDN}']: t.cmd_contains("bin/samba-tool drs replicate ${HOSTNAME}.${WIN_REALM} ${WIN_HOSTNAME}.${WIN_REALM} %s -k yes" % nc, ["was successful"]) t.cmd_contains("bin/samba-tool drs replicate ${WIN_HOSTNAME}.${WIN_REALM} ${HOSTNAME}.${WIN_REALM} %s -k yes" % nc, ["was successful"]) @@ -489,8 +489,8 @@ def join_as_rodc(t, vm): t.setwinvars(vm) t.info("Joining ${WIN_VM} as a RODC using samba-tool domain join DC") t.port_wait("${WIN_IP}", 389) - t.retry_cmd("host -t SRV _ldap._tcp.${WIN_REALM} ${WIN_IP}", ['has SRV record'] ) - t.retry_cmd("bin/samba-tool drs showrepl ${WIN_HOSTNAME}.${WIN_REALM} -Uadministrator%${WIN_PASS}", ['INBOUND NEIGHBORS'] ) + t.retry_cmd("host -t SRV _ldap._tcp.${WIN_REALM} ${WIN_IP}", ['has SRV record']) + t.retry_cmd("bin/samba-tool drs showrepl ${WIN_HOSTNAME}.${WIN_REALM} -Uadministrator%${WIN_PASS}", ['INBOUND NEIGHBORS']) t.run_cmd('bin/samba-tool domain join ${WIN_REALM} RODC -Uadministrator%${WIN_PASS} -d${DEBUGLEVEL} --option=interfaces=${INTERFACE}') t.run_cmd('bin/samba-tool drs kcc ${WIN_HOSTNAME}.${WIN_REALM} -Uadministrator@${WIN_REALM}%${WIN_PASS}') @@ -509,7 +509,7 @@ def test_join_as_rodc(t, vm): t.run_cmd('bin/samba-tool drs kcc ${WIN_HOSTNAME}.${WIN_REALM} -Uadministrator@${WIN_REALM}%${WIN_PASS}') t.kinit("administrator@${WIN_REALM}", "${WIN_PASS}") - for nc in ['${WIN_BASEDN}', 'CN=Configuration,${WIN_BASEDN}', 'CN=Schema,CN=Configuration,${WIN_BASEDN}' ]: + for nc in ['${WIN_BASEDN}', 'CN=Configuration,${WIN_BASEDN}', 'CN=Schema,CN=Configuration,${WIN_BASEDN}']: t.cmd_contains("bin/samba-tool drs replicate ${HOSTNAME}.${WIN_REALM} ${WIN_HOSTNAME}.${WIN_REALM} %s -k yes" % nc, ["was successful"]) retries = 10 @@ -534,7 +534,7 @@ def test_join_as_rodc(t, vm): "CN=Configuration,${WIN_BASEDN}", "Last attempt .* was successful", "CN=Configuration,${WIN_BASEDN}", - "Last attempt .* was successful" ], + "Last attempt .* was successful"], ordered=True, regex=True) diff --git a/wintest/wintest.py b/wintest/wintest.py index bd6d6ae4dca..ad177cdb77d 100644 --- a/wintest/wintest.py +++ b/wintest/wintest.py @@ -880,7 +880,7 @@ RebootOnCompletion=No # Give DNS registration a kick child.sendline("ipconfig /registerdns") - self.retry_cmd("host -t SRV _ldap._tcp.${WIN_REALM} ${WIN_IP}", ['has SRV record'], retries=60, delay=5 ) + self.retry_cmd("host -t SRV _ldap._tcp.${WIN_REALM} ${WIN_IP}", ['has SRV record'], retries=60, delay=5) def start_winvm(self, vm): |