summaryrefslogtreecommitdiff
path: root/source4
diff options
context:
space:
mode:
authorDavid Disseldorp <ddiss@samba.org>2012-06-22 18:49:50 +0200
committerKarolin Seeger <kseeger@samba.org>2012-07-24 20:53:18 +0200
commite0e0f30958f9cd4dbc8faba901216869bb6601e5 (patch)
tree2c9c9bd6405ea42cd66096a20ed14841e4bf39c0 /source4
parent32584347e93e5ff219cce4dd8e13bf8b2868072c (diff)
downloadsamba-e0e0f30958f9cd4dbc8faba901216869bb6601e5.tar.gz
s3-torture: Use static printer for smbd spooler test
Diffstat (limited to 'source4')
-rw-r--r--source4/torture/rpc/spoolss.c10
1 files changed, 9 insertions, 1 deletions
diff --git a/source4/torture/rpc/spoolss.c b/source4/torture/rpc/spoolss.c
index a724aeeae16..fd065fc6183 100644
--- a/source4/torture/rpc/spoolss.c
+++ b/source4/torture/rpc/spoolss.c
@@ -54,6 +54,7 @@
#define TORTURE_DRIVER_TIMESTAMPS "torture_driver_timestamps"
#define TORTURE_DRIVER_DELETER "torture_driver_deleter"
#define TORTURE_DRIVER_DELETERIN "torture_driver_deleterin"
+#define TORTURE_PRINTER_STATIC1 "print1"
#define TOP_LEVEL_PRINT_KEY "SOFTWARE\\Microsoft\\Windows NT\\CurrentVersion\\Print"
#define TOP_LEVEL_PRINT_PRINTERS_KEY TOP_LEVEL_PRINT_KEY "\\Printers"
@@ -7747,7 +7748,14 @@ static bool test_print_test_smbd(struct torture_context *tctx,
struct cli_credentials *credentials = cmdline_credentials;
struct smbcli_options options;
TALLOC_CTX *mem_ctx = talloc_new(tctx);
- const char *share = t->info2.printername;
+ /*
+ * Do not test against the dynamically added printers, printing via
+ * smbd means that a different spoolss process may handle the
+ * OpenPrinter request to the one that handled the AddPrinter request.
+ * This currently leads to an ugly race condition where one process
+ * sees the new printer and one doesn't.
+ */
+ const char *share = TORTURE_PRINTER_STATIC1;
torture_comment(tctx, "Testing smbd job spooling\n");
lpcfg_smbcli_options(tctx->lp_ctx, &options);