diff options
| author | Andrew Bartlett <abartlet@samba.org> | 2020-11-23 19:35:37 +1300 |
|---|---|---|
| committer | Karolin Seeger <kseeger@samba.org> | 2021-01-07 10:50:10 +0000 |
| commit | fc15ff8951f791ba53f25b44c105093c1cdb9bac (patch) | |
| tree | 31dc555eb14fd54fa8d1197f2aa3d66c3707278e /source4 | |
| parent | c5159bd6d7678b62461da785a2994f1cf97ca5db (diff) | |
| download | samba-fc15ff8951f791ba53f25b44c105093c1cdb9bac.tar.gz | |
Do not create an empty DB when accessing a sam.ldb
Samba already does this for samba-tool and doing this should make
our errors more sensible, particularly in BIND9 if not provisioned
with the correct --dns-backend=DLZ_BIND9
The old error was like:
named[62954]: samba_dlz: Unable to get basedn for
/var/lib/samba/private/dns/sam.ldb
- NULL Base DN invalid for a base search.
The new error will be like (in this case from the torture test):
Failed to connect to Failed to connect to
ldb:///home/abartlet/samba/st/chgdcpass/bind-dns/dns/sam.ldb:
Unable to open tdb '/home/abartlet/samba/st/chgdcpass/bind-dns/dns/sam.ldb':
No such file or directory: Operations error
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14579
Reviewed-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit d49e96bc45ea5e2d3364242dad36fe9094b7cc42)
Autobuild-User(v4-13-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-13-test): Thu Jan 7 10:50:10 UTC 2021 on sn-devel-184
Diffstat (limited to 'source4')
| -rw-r--r-- | source4/dsdb/samdb/samdb.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/source4/dsdb/samdb/samdb.c b/source4/dsdb/samdb/samdb.c index 10db0c50395..d5890dec03e 100644 --- a/source4/dsdb/samdb/samdb.c +++ b/source4/dsdb/samdb/samdb.c @@ -63,6 +63,9 @@ int samdb_connect_url(TALLOC_CTX *mem_ctx, *ldb_ret = NULL; *errstring = NULL; + /* We create sam.ldb in provision, and never anywhere else */ + flags |= LDB_FLG_DONT_CREATE_DB; + if (remote_address == NULL) { ldb = ldb_wrap_find(url, ev_ctx, lp_ctx, session_info, NULL, flags); |