diff options
| author | Noel Power <noel.power@suse.com> | 2019-05-22 09:47:27 +0000 |
|---|---|---|
| committer | Andreas Schneider <asn@cryptomilk.org> | 2019-06-04 22:13:07 +0000 |
| commit | bcc6b8c2492b87fb4ac6bdb5075a5831d71bade8 (patch) | |
| tree | 53270e4749edc5d4aae0c8c9c74f9be3bf685fc8 /source4 | |
| parent | 2bed937e7fbb551bebfed3c76d7bf4317f72b425 (diff) | |
| download | samba-bcc6b8c2492b87fb4ac6bdb5075a5831d71bade8.tar.gz | |
s4/rpc_server/dnsserver: clang: fix Value stored to 'status' is never read
Fix the following warnings
source4/rpc_server/dnsserver/dcerpc_dnsserver.c:1021: error: uninitvar: Uninitialized variable: answer_integer <--[cppcheck]
source4/rpc_server/dnsserver/dcerpc_dnsserver.c:1723:4: warning: Value stored to 'status' is never read <--[clang]
status = dns_fill_records_array(tmp_ctx, NULL, DNS_TYPE_A,
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
source4/rpc_server/dnsserver/dcerpc_dnsserver.c:1881:4: warning: Value stored to 'status' is never read <--[clang]
status = dns_fill_records_array(tmp_ctx, NULL, DNS_TYPE_A,
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Diffstat (limited to 'source4')
| -rw-r--r-- | source4/rpc_server/dnsserver/dcerpc_dnsserver.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/source4/rpc_server/dnsserver/dcerpc_dnsserver.c b/source4/rpc_server/dnsserver/dcerpc_dnsserver.c index 1bb46a58339..62a74127ecf 100644 --- a/source4/rpc_server/dnsserver/dcerpc_dnsserver.c +++ b/source4/rpc_server/dnsserver/dcerpc_dnsserver.c @@ -1727,6 +1727,10 @@ static WERROR dnsserver_enumerate_root_records(struct dnsserver_state *dsstate, NULL, NULL); talloc_free(rname); talloc_free(res); + if (!W_ERROR_IS_OK(status)) { + talloc_free(tmp_ctx); + return status; + } } } @@ -1885,6 +1889,10 @@ static WERROR dnsserver_enumerate_records(struct dnsserver_state *dsstate, NULL, NULL); talloc_free(rname); talloc_free(res); + if (!W_ERROR_IS_OK(status)) { + talloc_free(tmp_ctx); + return status; + } } } |