diff options
| author | Noel Power <noel.power@suse.com> | 2019-05-22 09:37:40 +0000 |
|---|---|---|
| committer | Andreas Schneider <asn@cryptomilk.org> | 2019-06-04 22:13:07 +0000 |
| commit | 2bed937e7fbb551bebfed3c76d7bf4317f72b425 (patch) | |
| tree | 2ccff840d8ce060bf54aca8e3c5d1263bc953d72 /source4 | |
| parent | 05d0806e71b6c3c31e4457c239bd2a5886187bf4 (diff) | |
| download | samba-2bed937e7fbb551bebfed3c76d7bf4317f72b425.tar.gz | |
s4/rpc_server/dnsserver: cppcheck: Fix Uninitialized variable error.
source4/rpc_server/dnsserver/dcerpc_dnsserver.c:715: error: uninitvar: Uninitialized variable: answer_integer <--[cppcheck]
This error is benign and somewhat false because the code pointed to does
not run (due to a different check) if answer_integer is not actually
initialsed. It is easy to squash it though by just initialising the var.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Diffstat (limited to 'source4')
| -rw-r--r-- | source4/rpc_server/dnsserver/dcerpc_dnsserver.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/source4/rpc_server/dnsserver/dcerpc_dnsserver.c b/source4/rpc_server/dnsserver/dcerpc_dnsserver.c index 841557814a0..1bb46a58339 100644 --- a/source4/rpc_server/dnsserver/dcerpc_dnsserver.c +++ b/source4/rpc_server/dnsserver/dcerpc_dnsserver.c @@ -374,6 +374,7 @@ static WERROR dnsserver_query_server(struct dnsserver_state *dsstate, } is_integer = 0; + answer_integer = 0; if (strcasecmp(operation, "AddressAnswerLimit") == 0) { answer_integer = serverinfo->cAddressAnswerLimit; @@ -834,7 +835,7 @@ static WERROR dnsserver_query_zone(struct dnsserver_state *dsstate, union DNSSRV_RPC_UNION *r) { uint8_t is_integer, is_addresses, is_string; - uint32_t answer_integer; + uint32_t answer_integer = 0; struct IP4_ARRAY *answer_iparray; struct DNS_ADDR_ARRAY *answer_addrarray; char *answer_string; |