summaryrefslogtreecommitdiff
path: root/source4
diff options
context:
space:
mode:
authorNoel Power <noel.power@suse.com>2019-05-24 11:03:09 +0000
committerNoel Power <npower@samba.org>2019-06-11 12:10:17 +0000
commit1c6db152bf1b0de205017dcfae358ba362545de1 (patch)
tree1917b33acd703527436c19274d5bc3b26abb69bb /source4
parent7cc9e3fe24dd476360837c04538345752048e6be (diff)
downloadsamba-1c6db152bf1b0de205017dcfae358ba362545de1.tar.gz
s4/torture/rpc: cppcheck: Fix ctunullpointer error
Fixes source4/torture/rpc/netlogon.c:307: error: ctunullpointer: Null pointer dereference: p <--[cppcheck] Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Gary Lockyer gary@catalyst.net.nz
Diffstat (limited to 'source4')
-rw-r--r--source4/torture/rpc/netlogon.c8
1 files changed, 7 insertions, 1 deletions
diff --git a/source4/torture/rpc/netlogon.c b/source4/torture/rpc/netlogon.c
index 52c443e39f3..94fe4020fa9 100644
--- a/source4/torture/rpc/netlogon.c
+++ b/source4/torture/rpc/netlogon.c
@@ -304,7 +304,13 @@ bool test_SetupCredentials3(struct dcerpc_pipe *p, struct torture_context *tctx,
uint32_t rid;
const char *machine_name;
const char *plain_pass;
- struct dcerpc_binding_handle *b = p->binding_handle;
+ struct dcerpc_binding_handle *b = NULL;
+
+ if (p == NULL) {
+ return false;
+ }
+
+ b = p->binding_handle;
machine_name = cli_credentials_get_workstation(machine_credentials);
torture_assert(tctx, machine_name != NULL, "machine_name");