diff options
| author | Gary Lockyer <gary@catalyst.net.nz> | 2019-07-08 16:14:26 +1200 |
|---|---|---|
| committer | Gary Lockyer <gary@samba.org> | 2019-07-09 03:03:25 +0000 |
| commit | 063809bc9609fa5d47e548445d3af1495285624e (patch) | |
| tree | b741e012e02ca8c40fd53dd41715542d55136e02 /source4 | |
| parent | 59cca4c5d699be80b4ed22b40d8914787415c507 (diff) | |
| download | samba-063809bc9609fa5d47e548445d3af1495285624e.tar.gz | |
dsdb repl_meta_data: Don't print ldif on error
Don't call ldb_ldif_message_redacted_string when linked_attr_modify
fails. When joining a large domain this takes way to much time, in excess of 3
hours for a join on a 200k domain.
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Tim Beale <timbeale@catalyst.net.nz>
Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Tue Jul 9 03:03:25 UTC 2019 on sn-devel-184
Diffstat (limited to 'source4')
| -rw-r--r-- | source4/dsdb/samdb/ldb_modules/repl_meta_data.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c index 9dd354743ff..1d800feb0c1 100644 --- a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c +++ b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c @@ -8459,12 +8459,11 @@ static int replmd_process_la_group(struct ldb_module *module, ret = linked_attr_modify(module, msg, NULL); if (ret != LDB_SUCCESS) { ldb_debug(ldb, LDB_DEBUG_WARNING, - "Failed to apply linked attribute change '%s'\n%s\n", + "Failed to apply linked attribute change " + "Error: '%s' DN: '%s' Attribute: '%s'\n", ldb_errstring(ldb), - ldb_ldif_message_redacted_string(ldb, - tmp_ctx, - LDB_CHANGETYPE_MODIFY, - msg)); + ldb_dn_get_linearized(msg->dn), + attr->lDAPDisplayName); TALLOC_FREE(tmp_ctx); return ret; } |