diff options
| author | Garming Sam <garming@catalyst.net.nz> | 2018-02-14 13:32:24 +1300 |
|---|---|---|
| committer | Garming Sam <garming@samba.org> | 2018-02-15 05:42:03 +0100 |
| commit | 59fa9e7ecf84bd4c2469e9a6835855769c4f6287 (patch) | |
| tree | 78d791d0366da1a2d941a0d4cb521db554dcab04 /source4 | |
| parent | 45d19167d52e42bd2f9369dbe37a233902cc81b0 (diff) | |
| download | samba-59fa9e7ecf84bd4c2469e9a6835855769c4f6287.tar.gz | |
repl_metadata: Avoid silent skipping an object during DRS (due to RODC name collisions)
No error code was being set in this case, and so, we would commit the
HWM and UDV without actually having all the updates.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13269
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Diffstat (limited to 'source4')
| -rw-r--r-- | source4/dsdb/samdb/ldb_modules/repl_meta_data.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c index 7646f942fca..84d898af483 100644 --- a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c +++ b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c @@ -4932,6 +4932,7 @@ static int replmd_op_possible_conflict_callback(struct ldb_request *req, struct "Conflict adding object '%s' from incoming replication as we are read only for the partition. \n" " - We must fail the operation until a master for this partition resolves the conflict", ldb_dn_get_linearized(conflict_dn)); + ret = LDB_ERR_OPERATIONS_ERROR; goto failed; } |