diff options
| author | Andrew Bartlett <abartlet@samba.org> | 2009-11-04 17:42:53 +1100 |
|---|---|---|
| committer | Andrew Bartlett <abartlet@samba.org> | 2009-11-12 16:34:01 +1100 |
| commit | fd5174e88ca1727a91d6dc9bf9bd898ff9087fe8 (patch) | |
| tree | 7f1511fcea311f2ef637ca23dee8699ba00adfb6 /source4/torture | |
| parent | a8769e667514f83a45ee3e825d21a351987d0210 (diff) | |
| download | samba-fd5174e88ca1727a91d6dc9bf9bd898ff9087fe8.tar.gz | |
lib/util Split data_blob_hex_string() into upper and lower
Rather than have a repeat of the bugs we found at the plugfest where
hexidecimal strings must be in upper or lower case in particular
places, ensure that each caller chooses which case they want.
This reverts most of the callers back to upper case, as things were
before tridge's patch. The critical call in the extended DN code is
of course handled in lower case.
Andrew Bartlett
Diffstat (limited to 'source4/torture')
| -rw-r--r-- | source4/torture/ldap/schema.c | 2 | ||||
| -rw-r--r-- | source4/torture/rpc/samsync.c | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/source4/torture/ldap/schema.c b/source4/torture/ldap/schema.c index 7fe171691a6..b0a4892d7a5 100644 --- a/source4/torture/ldap/schema.c +++ b/source4/torture/ldap/schema.c @@ -356,7 +356,7 @@ static bool test_dump_sorted_syntax(struct ldb_context *ldb, struct test_rootDSE if (strcmp(syntaxes[i], a->attributeSyntax_oid) != 0) continue; - om_hex = data_blob_hex_string(ldb, &a->oMObjectClass); + om_hex = data_blob_hex_string_upper(ldb, &a->oMObjectClass); if (!om_hex) { return false; } diff --git a/source4/torture/rpc/samsync.c b/source4/torture/rpc/samsync.c index 52df4eb6b97..19060c69a94 100644 --- a/source4/torture/rpc/samsync.c +++ b/source4/torture/rpc/samsync.c @@ -593,11 +593,11 @@ static bool samsync_handle_user(struct torture_context *tctx, TALLOC_CTX *mem_ct if (nt_hash_p) { DATA_BLOB nt_hash_blob = data_blob_const(nt_hash_p, 16); - DEBUG(100,("ACCOUNT [%s\\%-25s] NTHASH %s\n", samsync_state->domain_name[0], username, data_blob_hex_string(mem_ctx, &nt_hash_blob))); + DEBUG(100,("ACCOUNT [%s\\%-25s] NTHASH %s\n", samsync_state->domain_name[0], username, data_blob_hex_string_upper(mem_ctx, &nt_hash_blob))); } if (lm_hash_p) { DATA_BLOB lm_hash_blob = data_blob_const(lm_hash_p, 16); - DEBUG(100,("ACCOUNT [%s\\%-25s] LMHASH %s\n", samsync_state->domain_name[0], username, data_blob_hex_string(mem_ctx, &lm_hash_blob))); + DEBUG(100,("ACCOUNT [%s\\%-25s] LMHASH %s\n", samsync_state->domain_name[0], username, data_blob_hex_string_upper(mem_ctx, &lm_hash_blob))); } nt_status = test_SamLogon(samsync_state->p_netlogon_wksta, mem_ctx, samsync_state->creds_netlogon_wksta, |